RongtongJin merged PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ro
YxAc commented on PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2124353788
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
DongyuanPan commented on code in PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#discussion_r1609645962
##
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/notify/NotifyManager.java:
##
@@ -73,18 +72,20 @@ public class NotifyManager {
private NettyRemotingCl
YxAc commented on PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2124241589
> Hi @YxAc , please review, thank you.
Pls resolve the comment above, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
YxAc commented on code in PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#discussion_r1609572391
##
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/notify/NotifyManager.java:
##
@@ -73,18 +72,20 @@ public class NotifyManager {
private NettyRemotingClient re
yx9o commented on PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2124220659
Hi @YxAc , please review, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
yx9o commented on PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2124072514
OK, i take care of it as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
YxAc commented on PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2124007685
hi @yx9o , can you cherry pick #265 to fix the compilation error and keep
consistency with the main branch, thx.
--
This is an automated message from the Apache Git Service.
To respond
yx9o commented on PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2109786656
@DongyuanPan , it has been changed, please review, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
DongyuanPan commented on code in PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#discussion_r1599554020
##
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/notify/NotifyManager.java:
##
@@ -73,18 +72,20 @@ public class NotifyManager {
private NettyRemotingCl
DongyuanPan commented on code in PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#discussion_r1598084965
##
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/meta/MetaPersistManagerSample.java:
##
@@ -64,15 +63,14 @@ public class MetaPersistManagerSample implements
yx9o commented on code in PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#discussion_r1598068540
##
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/meta/MetaPersistManagerSample.java:
##
@@ -64,15 +63,14 @@ public class MetaPersistManagerSample implements
MetaP
DongyuanPan commented on code in PR #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276#discussion_r1598039603
##
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/meta/MetaPersistManagerSample.java:
##
@@ -64,15 +63,14 @@ public class MetaPersistManagerSample implements
yx9o opened a new pull request, #276:
URL: https://github.com/apache/rocketmq-mqtt/pull/276
Fix #274 , develop branch startup exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
14 matches
Mail list logo
