acassis commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2813291589
@Fix-Point @xiaoxiang781216 I think it should be tested on real hardware as
well. Normally small changes on core features like this could break the system.
I think it requires test on sen
simbit18 commented on PR #16195:
URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2812994831
I was trying some tests with CMake
with this board there seems to be some problem.
```
D:\nuttx>cmake --build build
ninja: error:
'D:/nuttx/boards/arm/tiva/tm4c123g-la
anchao commented on code in PR #16226:
URL: https://github.com/apache/nuttx/pull/16226#discussion_r2049210554
##
include/nuttx/msgq.h:
##
@@ -0,0 +1,315 @@
+/
+ * include/nuttx/msgq.h
+ *
+ * SPDX-Licens
anchao commented on PR #16226:
URL: https://github.com/apache/nuttx/pull/16226#issuecomment-2813564551
let me mark this PR as a draft first . I want to support the priority queue
and zero-copy in this pull request.
--
This is an automated message from the Apache Git Service.
To respond to
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049169728
##
sched/wqueue/kwork_thread.c:
##
@@ -211,6 +288,17 @@ static int work_thread(int argc, FAR char *argv[])
}
}
+ if (!list_is_empty(&wqueue-
anchao commented on issue #16235:
URL: https://github.com/apache/nuttx/issues/16235#issuecomment-2813386204
What is the opcode after disassemble? Are the instructions after using
xtensa-esp32s3-elf-objdump consistent with those shown in gdb?
--
This is an automated message from the Apache
cederom commented on PR #3062:
URL: https://github.com/apache/nuttx-apps/pull/3062#issuecomment-2813840163
> > Thank you @Laczen very nice feature!! :-)
> > Some trivial code formatting to be fixed
(https://nuttx.apache.org/docs/latest/contributing/coding_style.html).
> > Would it be p
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050007793
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from ca664fd431 Documentation: Update openocd-esp32 command for all
Espressif Socs
add 0715c584b7 arch/xtensa: use
xiaoxiang781216 commented on code in PR #15945:
URL: https://github.com/apache/nuttx/pull/15945#discussion_r2050010584
##
fs/littlefs/lfs_vfs.c:
##
@@ -367,6 +368,15 @@ static int littlefs_open(FAR struct file *filep, FAR const
char *relpath,
relpath = littlefs_convert_pat
TimJTi commented on issue #3055:
URL: https://github.com/apache/nuttx-apps/issues/3055#issuecomment-2813921383
Closed the PR - I'm creating a new tool and now have it passing checkpatch
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Laczen commented on PR #3062:
URL: https://github.com/apache/nuttx-apps/pull/3062#issuecomment-2813782060
> Thank you @Laczen very nice feature!! :-)
>
> Some trivial code formatting to be fixed
(https://nuttx.apache.org/docs/latest/contributing/coding_style.html).
>
> Would it
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049854411
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- st
TimJTi commented on PR #3051:
URL: https://github.com/apache/nuttx-apps/pull/3051#issuecomment-2813920175
OK - this tool creates cpp code and is not suitable for the kernel. Looks
like I'm learning Python after all!
--
This is an automated message from the Apache Git Service.
To respond t
linguini1 commented on issue #16139:
URL: https://github.com/apache/nuttx/issues/16139#issuecomment-2814123294
> Thank you for testing. Can you verify whether it works with different apps?
> How does the serial output look when running "help" or other apps? Because
> for me sometimes os
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new c8cb0913e Publishing web: 16e1777
nuttxpr commented on PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2812005286
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The PR summary is good, clearly explaining the "why" an
yamt commented on code in PR #15945:
URL: https://github.com/apache/nuttx/pull/15945#discussion_r2050105867
##
fs/littlefs/lfs_vfs.c:
##
@@ -367,6 +368,15 @@ static int littlefs_open(FAR struct file *filep, FAR const
char *relpath,
relpath = littlefs_convert_path(relpath);
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050107421
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 6a721b859c boards/xtensa: fix build errors related to data types on
ESP32|S3
add 60111786d6 fs/littlefs: Code
TimJTi closed pull request #3051: tools/bitmap_converter.py: Fix print to allow
use of Python3
URL: https://github.com/apache/nuttx-apps/pull/3051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xiaoxiang781216 merged PR #16022:
URL: https://github.com/apache/nuttx/pull/16022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
fdcavalcanti commented on PR #16022:
URL: https://github.com/apache/nuttx/pull/16022#issuecomment-2814291318
@xiaoxiang781216 all done.
Thanks for the fixes @yamt!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049938581
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqsave(&w
chirping78 commented on issue #16235:
URL: https://github.com/apache/nuttx/issues/16235#issuecomment-2814404279
As a comparison, here is the disassemble output of xt-clang/xt-gdb,
toolchain from cadence, used in a product embedded a hifi4 dsp (which is also
LX7 arch based):
```
(xt-gd
cederom commented on code in PR #3062:
URL: https://github.com/apache/nuttx-apps/pull/3062#discussion_r2049442404
##
examples/elf/Kconfig:
##
@@ -39,7 +39,7 @@ config EXAMPLES_ELF_EXTERN
The file system is assumed to reside on some external media
TimJTi closed issue #3055: [HELP] Updating tools/bitmap_converter.py to work
with Python3
URL: https://github.com/apache/nuttx-apps/issues/3055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
xiaoxiang781216 merged PR #16234:
URL: https://github.com/apache/nuttx/pull/16234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from edaa074e51 include/nuttx/atomic.h: For each ATOMIC func, cast the
parameters to (FAR intXX_t *) of correct size
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049948161
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- struct l
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049949011
##
sched/wqueue/kwork_queue.c:
##
@@ -155,49 +94,48 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
flags = spin_lock_irqsave(&wqueue->lock);
sch
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049951335
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049958705
##
sched/wqueue/kwork_thread.c:
##
@@ -83,11 +83,15 @@
struct hp_wqueue_s g_hpwork =
{
- LIST_INITIAL_VALUE(g_hpwork.q),
- SEM_INITIALIZER(0),
- SEM_INITIALIZE
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049947713
##
include/nuttx/wqueue.h:
##
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
-struct
-{
- struct l
chirping78 commented on issue #16235:
URL: https://github.com/apache/nuttx/issues/16235#issuecomment-2814452848
Here is the 3rd evidence (recall that the 1st is disassemble of esp32 gdb
and objdump, and 2nd is disassemble of cadence toolchain), this is more serious
than first twos.
O
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049939836
##
sched/wqueue/kwork_thread.c:
##
@@ -160,14 +208,19 @@ static int work_thread(int argc, FAR char *argv[])
* so ourselves, and (2) there will be no changes t
chirping78 commented on issue #16235:
URL: https://github.com/apache/nuttx/issues/16235#issuecomment-2814381183
> What is the opcode after disassemble? Are the instructions after using
xtensa-esp32s3-elf-objdump consistent with those shown in gdb?
@anchao updated the main post with `d
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049926527
##
sched/wqueue/kwork_thread.c:
##
@@ -160,14 +208,19 @@ static int work_thread(int argc, FAR char *argv[])
* so ourselves, and (2) there will be no changes to t
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049938678
##
sched/wqueue/kwork_queue.c:
##
@@ -155,51 +94,48 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue,
flags = spin_lock_irqsave(&wqueue->lock);
sch
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049939697
##
sched/wqueue/kwork_thread.c:
##
@@ -211,6 +288,17 @@ static int work_thread(int argc, FAR char *argv[])
}
}
+ if (!list_is_empty(&wque
Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049939572
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
xiaoxiang781216 merged PR #15945:
URL: https://github.com/apache/nuttx/pull/15945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050007021
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqs
xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2050007021
##
sched/wqueue/kwork_cancel.c:
##
@@ -59,38 +59,20 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
*/
flags = spin_lock_irqs
cederom commented on code in PR #3062:
URL: https://github.com/apache/nuttx-apps/pull/3062#discussion_r2049495857
##
examples/elf/Kconfig:
##
@@ -39,7 +39,7 @@ config EXAMPLES_ELF_EXTERN
The file system is assumed to reside on some external media
acassis commented on issue #16159:
URL: https://github.com/apache/nuttx/issues/16159#issuecomment-2814222721
@gustavosousa2208 did you fix the issue?
@davids5 do you remember about this dmapreflight issue? I think you already
posted about it in the mailing list some time ago.
--
T
anchao commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049150464
##
sched/wqueue/kwork_thread.c:
##
@@ -110,6 +118,44 @@ struct lp_wqueue_s g_lpwork =
* Private Functions
***
anchao commented on code in PR #16226:
URL: https://github.com/apache/nuttx/pull/16226#discussion_r2049203623
##
include/nuttx/msgq.h:
##
@@ -0,0 +1,315 @@
+/
+ * include/nuttx/msgq.h
+ *
+ * SPDX-Licens
xiaoxiang781216 commented on PR #16022:
URL: https://github.com/apache/nuttx/pull/16022#issuecomment-2812059426
@fdcavalcanti please rebase your patch again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
xiaoxiang781216 merged PR #16230:
URL: https://github.com/apache/nuttx/pull/16230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 8d89d73bb canutils: use bps units for bit
xiaoxiang781216 merged PR #3061:
URL: https://github.com/apache/nuttx-apps/pull/3061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
xiaoxiang781216 commented on code in PR #3059:
URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2048429377
##
canutils/slcan/slcan.c:
##
@@ -137,8 +137,7 @@ static int caninit(char *candev, int *s, struct
sockaddr_can *addr,
syslog(LOG_ERR, "Error opening
jlaitine opened a new pull request, #16233:
URL: https://github.com/apache/nuttx/pull/16233
## Summary
This fixes useless -Wpointer-sign errors with clang when doing atomic
operations on unsigned datatypes.
Possible alternatives to this:
- the pointer type cast could
lupyuen commented on PR #3057:
URL: https://github.com/apache/nuttx-apps/pull/3057#issuecomment-2812628752
@Donny9 Please close the voting. Thanks!
This Breaking PR compiles with the [NuttX Breaking Changes Handling
Process](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md#113-
lupyuen commented on PR #16198:
URL: https://github.com/apache/nuttx/pull/16198#issuecomment-2812628623
@Donny9 Please close the voting. Thanks!
This Breaking PR compiles with the [NuttX Breaking Changes Handling
Process](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md#113-bre
pussuw commented on code in PR #16226:
URL: https://github.com/apache/nuttx/pull/16226#discussion_r2048637427
##
include/nuttx/msgq.h:
##
@@ -0,0 +1,315 @@
+/
+ * include/nuttx/msgq.h
+ *
+ * SPDX-Licens
pussuw commented on PR #16226:
URL: https://github.com/apache/nuttx/pull/16226#issuecomment-2812403874
I like the idea a lot, I was always wondering how NuttX did not already have
this kernel internal message system (which does not depend on a file system).
Like stated in the summary field,
pussuw commented on code in PR #16226:
URL: https://github.com/apache/nuttx/pull/16226#discussion_r2048647549
##
include/nuttx/msgq.h:
##
@@ -0,0 +1,315 @@
+/
+ * include/nuttx/msgq.h
+ *
+ * SPDX-Licens
nuttxpr commented on PR #16233:
URL: https://github.com/apache/nuttx/pull/16233#issuecomment-2812318102
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the NuttX requirements, al
pussuw commented on code in PR #16226:
URL: https://github.com/apache/nuttx/pull/16226#discussion_r2048639403
##
include/nuttx/msgq.h:
##
@@ -0,0 +1,315 @@
+/
+ * include/nuttx/msgq.h
+ *
+ * SPDX-Licens
tmedicci opened a new pull request, #16234:
URL: https://github.com/apache/nuttx/pull/16234
## Summary
This PR adds new fields to the metadata section used by MCUBoot. The
openocd-esp32 project requires these fields to properly map the flash segments
and enable using SW breakpoints a
nuttxpr commented on PR #16234:
URL: https://github.com/apache/nuttx/pull/16234#issuecomment-2812726464
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the NuttX requirements. T
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 2ff8199d90 documentation: update docs on ADC support for Espressif
devices
add de12b6ae82 esp32-devkitc/wamr_w
jlaitine opened a new pull request, #16232:
URL: https://github.com/apache/nuttx/pull/16232
## Summary
Correct the debugassert line in wireless/ieee802154. Code should not access
semaphore internals directly, but use the defined interface for that.
## Impact
No funct
xiaoxiang781216 merged PR #16232:
URL: https://github.com/apache/nuttx/pull/16232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1658ee4abf wireless/ieee802154: Replace direct
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 1658ee4abf wireless/ieee802154: Replace direct access to semaphore
value with nxsem_get_value
add edaa074e51 i
xiaoxiang781216 merged PR #16233:
URL: https://github.com/apache/nuttx/pull/16233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xuxin930 commented on issue #16221:
URL: https://github.com/apache/nuttx/issues/16221#issuecomment-2812829966
> [@xuxin930](https://github.com/xuxin930)请看一下。
sure @xiaoxiang781216 @acassis @trns1997
I have located the issue, because when neither libcxx nor uclibc++ is
selected, cm
trns1997 commented on issue #16221:
URL: https://github.com/apache/nuttx/issues/16221#issuecomment-2812928928
> > [@xuxin930](https://github.com/xuxin930)请看一下。
>
> sure [@xiaoxiang781216](https://github.com/xiaoxiang781216)
[@acassis](https://github.com/acassis) [@trns1997](https://gi
Laczen opened a new pull request, #3062:
URL: https://github.com/apache/nuttx-apps/pull/3062
Add the possibility to create a `romfs` image for an "external" file system.
The `romfs.img` can directly be written to a configurable `mtdblock` device.
## Summary
The elf loader can a
nuttxpr commented on PR #3062:
URL: https://github.com/apache/nuttx-apps/pull/3062#issuecomment-2812938926
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the NuttX requirements,
73 matches
Mail list logo
