Re: [PR] [BREAKING] system/dd: using system dd to instead nsh dd, avoid duplicate code [nuttx-apps]

2025-04-16 Thread via GitHub
pussuw commented on PR #3057: URL: https://github.com/apache/nuttx-apps/pull/3057#issuecomment-2809387680 This causes a regression when NSH_FILEAPPS=y, as the full path to /bin/dd must be provided. I'm okay with this, since I put /bin into PATH, but others might not. Just something to keep

Re: [PR] examples/camera: Initialize g_nximage semaphore with SEM_INITIALIZER [nuttx-apps]

2025-04-16 Thread via GitHub
pussuw merged PR #3060: URL: https://github.com/apache/nuttx-apps/pull/3060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.ap

(nuttx-apps) branch master updated: examples/camera: Initialize g_nximage semaphore with SEM_INITIALIZER

2025-04-16 Thread pussuw
This is an automated email from the ASF dual-hosted git repository. pussuw pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new ecbd1e964 examples/camera: Initialize g_nxim

Re: [PR] Feature/esp dedicated gpio [nuttx]

2025-04-16 Thread via GitHub
nuttxpr commented on PR #16223: URL: https://github.com/apache/nuttx/pull/16223#issuecomment-2808600905 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description mostly meets the NuttX requirements

(nuttx) branch master updated (a0cc89349f -> 2ff8199d90)

2025-04-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from a0cc89349f boards/xtensa/esp32: Fix the SPI Flash MTD block device number add 99099a1a9d arch/xtensa: ADC supp

Re: [PR] arch/risc-v: Add dedicated GPIO support for esp32[-s2|-s3|-c3|-c6|-h2] [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 commented on PR #16223: URL: https://github.com/apache/nuttx/pull/16223#issuecomment-2811852516 can we add ioctl to expose ioexpender_lowhalf to userspace? which has api to control pin in the group. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] arch/xtensa: fix definition for `_int32_t` and `_uint32_t` [nuttx]

2025-04-16 Thread via GitHub
yamt commented on PR #16022: URL: https://github.com/apache/nuttx/pull/16022#issuecomment-2811970150 > > > Hi @yamt thanks for the update! > > > We still have a compilation issue to `esp32-devkitc:wamr_wasi_debug`, maybe related? > > > > > > see [#16022 (comment)](https://gith

[PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-04-16 Thread via GitHub
Fix-Point opened a new pull request, #16231: URL: https://github.com/apache/nuttx/pull/16231 ## Summary This commit refactors the logic of workqueue processing delayed and periodic work, and changes the timer to be set in `work_thread`. The improvements of this change are as follows:

[PR] boards/xtensa/esp32: Fix the SPI Flash MTD block device number [nuttx]

2025-04-16 Thread via GitHub
tmedicci opened a new pull request, #16229: URL: https://github.com/apache/nuttx/pull/16229 ## Summary * boards/xtensa/esp32: Fix the SPI Flash MTD block device number This PR fixes the SPI flash MTD block device number if OTA's partitions are present. In this case, the OTA par

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046907885 ## canutils/slcan/slcan.c: ## @@ -137,8 +137,7 @@ static int caninit(char *candev, int *s, struct sockaddr_can *addr, syslog(LOG_ERR, "Error opening

(nuttx) branch master updated: arch/arm/stm32h5: GPDMA Hardware files

2025-04-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1f53575192 arch/arm/stm32h5: GPDMA Hardware fi

Re: [PR] arch/arm/stm32h5: GPDMA Hardware files [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 merged PR #16218: URL: https://github.com/apache/nuttx/pull/16218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] CMake Build Support for arch/arm/rp2040 & Raspberry Pi Pico [nuttx]

2025-04-16 Thread via GitHub
simbit18 commented on PR #16212: URL: https://github.com/apache/nuttx/pull/16212#issuecomment-2809564415 @roskuttan Why are your Cmakefiles not aligned with Make.defs? I created a branch for building rp2040 with CMake seems to work. (Ho commentato anche #include rp2040_pico.h in r

Re: [PR] arch/risc-v/espressif: Bump common source version [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 merged PR #16219: URL: https://github.com/apache/nuttx/pull/16219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] arch/arm/src/armv6-m/CMakeLists.txt: fix undefined reference to `up_show_cpuinfo' [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 merged PR #16227: URL: https://github.com/apache/nuttx/pull/16227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (1f53575192 -> 0cec2bd662)

2025-04-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 1f53575192 arch/arm/stm32h5: GPDMA Hardware files add 0cec2bd662 arch/risc-v/espressif: Bump common source vers

(nuttx) branch master updated (0cec2bd662 -> 7af6b8c63d)

2025-04-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 0cec2bd662 arch/risc-v/espressif: Bump common source version add 7af6b8c63d arch/arm/src/armv6-m/CMakeLists.txt

Re: [PR] Add ADC support on ESP32|S2|S3|C3|C6|H2 [nuttx]

2025-04-16 Thread via GitHub
acassis commented on code in PR #16228: URL: https://github.com/apache/nuttx/pull/16228#discussion_r2047110439 ## arch/xtensa/src/common/espressif/esp_adc.c: ## @@ -0,0 +1,844 @@ +/ + * arch/xtensa/src/c

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-04-16 Thread via GitHub
simbit18 commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2047221301 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,239 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cmak

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-04-16 Thread via GitHub
simbit18 commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2047221301 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,239 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cmak

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-04-16 Thread via GitHub
simbit18 commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2047231522 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,239 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cmak

Re: [PR] Add ADC support on ESP32|S2|S3|C3|C6|H2 [nuttx]

2025-04-16 Thread via GitHub
fdcavalcanti commented on code in PR #16228: URL: https://github.com/apache/nuttx/pull/16228#discussion_r2047073557 ## arch/xtensa/src/common/espressif/esp_adc.c: ## @@ -0,0 +1,844 @@ +/ + * arch/xtensa/

Re: [PR] Add ADC support on ESP32|S2|S3|C3|C6|H2 [nuttx]

2025-04-16 Thread via GitHub
fdcavalcanti commented on code in PR #16228: URL: https://github.com/apache/nuttx/pull/16228#discussion_r2047073557 ## arch/xtensa/src/common/espressif/esp_adc.c: ## @@ -0,0 +1,844 @@ +/ + * arch/xtensa/

Re: [PR] net: use bps units for bitrate in SocketCAN interfaces. [nuttx]

2025-04-16 Thread via GitHub
acassis merged PR #16225: URL: https://github.com/apache/nuttx/pull/16225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-04-16 Thread via GitHub
simbit18 commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2047221301 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,239 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cmak

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-04-16 Thread via GitHub
simbit18 commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2047221301 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,239 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cmak

Re: [PR] tools: add a convert tool to help migrate from make to cmake [nuttx]

2025-04-16 Thread via GitHub
simbit18 commented on code in PR #9782: URL: https://github.com/apache/nuttx/pull/9782#discussion_r2047231522 ## tools/nxmake2cmake.py: ## @@ -0,0 +1,239 @@ +#!/usr/bin/env python3 + +# tools/nxmake2cmak

Re: [PR] [BREAKING] boards/defconfig: remove unused config about dd [nuttx]

2025-04-16 Thread via GitHub
Donny9 commented on PR #16198: URL: https://github.com/apache/nuttx/pull/16198#issuecomment-2811678824 > @Donny9: The Special CI Checks for this PR are all successful except for `stm32l0538-disco:nsh`. Please remember to fix `stm32l0538-disco:nsh` and we'll rerun the Special CI Checks thank

Re: [PR] [BREAKING] boards/defconfig: remove unused config about dd [nuttx]

2025-04-16 Thread via GitHub
Donny9 commented on PR #16198: URL: https://github.com/apache/nuttx/pull/16198#issuecomment-2811678711 > @Donny9 feel free to add `CONFIG_DEFAULT_SMALL=y` to stm32l0538-disco/nsh @raiden00pl I found that the reason for the flash overflow issue is the system dd calling the clock_gettim

Re: [PR] [BREAKING] system/dd: using system dd to instead nsh dd, avoid duplicate code [nuttx-apps]

2025-04-16 Thread via GitHub
Donny9 commented on PR #3057: URL: https://github.com/apache/nuttx-apps/pull/3057#issuecomment-2811682623 > @cederom @lupyuen @Donny9 comparing both file with meld I can see they are basically the same code: > > ``` > alan@dev:~/nuttxspace/apps$ meld nshlib/nsh_ddcmd.c system/dd/dd

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: d976c66edfbcb26312ea8a841f4ffa191f53d769

2025-04-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 847622705 Publishing web: 16e1777

Re: [PR] [BREAKING] boards/defconfig: remove unused config about dd [nuttx]

2025-04-16 Thread via GitHub
lupyuen commented on PR #16198: URL: https://github.com/apache/nuttx/pull/16198#issuecomment-2811684284 Cool! The Special CI Checks are still running, we'll finish the checks in about 6 hours. https://gist.github.com/nuttxpr -- This is an automated message from the Apache Git Service.

Re: [PR] boards/xtensa/esp32: Fix the SPI Flash MTD block device number [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 merged PR #16229: URL: https://github.com/apache/nuttx/pull/16229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[PR] esp32-devkitc/wamr_wasi_debug: bump wamr version [nuttx]

2025-04-16 Thread via GitHub
yamt opened a new pull request, #16230: URL: https://github.com/apache/nuttx/pull/16230 ## Summary bump wamr version to contain this change: https://github.com/bytecodealliance/wasm-micro-runtime/pull/4189 for: https://github.com/apache/nuttx/pull/16022 note: this i

Re: [PR] Add ADC support on ESP32|S2|S3|C3|C6|H2 [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 merged PR #16228: URL: https://github.com/apache/nuttx/pull/16228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] sched/wdog: Support for periodic wdog. [nuttx]

2025-04-16 Thread via GitHub
anchao commented on PR #15937: URL: https://github.com/apache/nuttx/pull/15937#issuecomment-2808973151 @Fix-Point @xiaoxiang781216 There are 2 serious problems with `work_queue_period` in this PR: 1. watchdog list in work_s is reused in the callback of `work_queue_period`, whi

[PR] arch/arm/src/stm32h7: unassigned ret variable in SIOCSCANBITRATE. [nuttx]

2025-04-16 Thread via GitHub
csanchezdll opened a new pull request, #16224: URL: https://github.com/apache/nuttx/pull/16224 ## Summary This problem was introduced in https://github.com/apache/nuttx/pull/16199 In that PR, the assignment of "ret" variable was removed so now this variable might be used in uni

[PR] canutils: use bps units for bitrate in SocketCAN interfaces. [nuttx-apps]

2025-04-16 Thread via GitHub
csanchezdll opened a new pull request, #3061: URL: https://github.com/apache/nuttx-apps/pull/3061 ## Summary This matches PR https://github.com/apache/nuttx/pull/16225 in Nuttx where units for SocketCAN bitrate ioctls were changed. ## Impact No user impact. The change

Re: [PR] net: use bps units for bitrate in SocketCAN interfaces. [nuttx]

2025-04-16 Thread via GitHub
nuttxpr commented on PR #16225: URL: https://github.com/apache/nuttx/pull/16225#issuecomment-2808830399 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] nuttx/msgq: add kernel message queue support [nuttx]

2025-04-16 Thread via GitHub
anchao opened a new pull request, #16226: URL: https://github.com/apache/nuttx/pull/16226 ## Summary nuttx/msgq: add kernel message queue support Currently NuttX have 2 message queue implementations: 1. Posix Message Queue (mq_close/mq_getattr/mq_getsetattr/mq_not

Re: [PR] canutils: use bps units for bitrate in SocketCAN interfaces. [nuttx-apps]

2025-04-16 Thread via GitHub
nuttxpr commented on PR #3061: URL: https://github.com/apache/nuttx-apps/pull/3061#issuecomment-2808851044 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the Nutt

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-04-16 Thread via GitHub
jlaitine commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2808681060 Ah. But now the CI is also blocked by an app; created a PR against nuttx-apps: https://github.com/apache/nuttx-apps/pull/3060 -- This is an automated message from the Apache Git Se

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
csanchezdll commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046318579 ## canutils/slcan/slcan.c: ## @@ -137,8 +137,8 @@ static int caninit(char *candev, int *s, struct sockaddr_can *addr, syslog(LOG_ERR, "Error opening CAN

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
csanchezdll commented on PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#issuecomment-2808719093 I fixed the format errors and used checkpatch from the nuttx repo. I found the initialization of ifr = {0} that I had fails because format rules want the braces on separate l

[PR] Feature/esp dedicated gpio [nuttx]

2025-04-16 Thread via GitHub
eren-terzioglu opened a new pull request, #16223: URL: https://github.com/apache/nuttx/pull/16223 ## Summary Add dedicated gpio support to control pins with faster response time and control multiple pins at the same time to applications requires faster response time (.e.g SPI bitbang

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
acassis commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046692911 ## canutils/slcan/slcan.c: ## @@ -137,8 +137,7 @@ static int caninit(char *candev, int *s, struct sockaddr_can *addr, syslog(LOG_ERR, "Error opening CAN sock

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
acassis commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046698164 ## canutils/slcan/slcan.c: ## @@ -316,9 +316,22 @@ int main(int argc, char *argv[]) { /* open CAN interface */

[PR] arch/arm/src/armv6-m/CMakeLists.txt: fix undefined reference to `up_show_cpuinfo' [nuttx]

2025-04-16 Thread via GitHub
simbit18 opened a new pull request, #16227: URL: https://github.com/apache/nuttx/pull/16227 ## Summary Aligned Cmakefile with Make.defs PR #10132 fix D:/nx20250410/tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld.exe: fs/libfs

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
csanchezdll commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046705164 ## canutils/slcan/slcan.c: ## @@ -137,8 +137,7 @@ static int caninit(char *candev, int *s, struct sockaddr_can *addr, syslog(LOG_ERR, "Error opening CAN

Re: [PR] net: use bps units for bitrate in SocketCAN interfaces. [nuttx]

2025-04-16 Thread via GitHub
acassis commented on PR #16225: URL: https://github.com/apache/nuttx/pull/16225#issuecomment-2809265762 Added "breaking change" for compatibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [BREAKING] boards/defconfig: remove unused config about dd [nuttx]

2025-04-16 Thread via GitHub
raiden00pl commented on PR #16198: URL: https://github.com/apache/nuttx/pull/16198#issuecomment-2808799263 @Donny9 feel free to add `CONFIG_DEFAULT_SMALL=y` to stm32l0538-disco/nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] net: use bps units for bitrate in SocketCAN interfaces. [nuttx]

2025-04-16 Thread via GitHub
csanchezdll opened a new pull request, #16225: URL: https://github.com/apache/nuttx/pull/16225 ## Summary This makes units compatible with what Linux uses for SocketCAN bitrate and allows representing usual Single Wire Can (SAE J2411) usual bitrates of 3 and 8 bps. ##

Re: [PR] arch/risc-v/espressif: Bump common source version [nuttx]

2025-04-16 Thread via GitHub
tmedicci commented on PR #16219: URL: https://github.com/apache/nuttx/pull/16219#issuecomment-2809343420 > @tmedicci why add a no-op pr? Sorry. I reverted the commit locally to get the boot log before the patch and that ended-up to this PR. Fixed! -- This is an automated message fr

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
acassis commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046764328 ## canutils/slcan/slcan.c: ## @@ -137,8 +137,7 @@ static int caninit(char *candev, int *s, struct sockaddr_can *addr, syslog(LOG_ERR, "Error opening CAN sock

Re: [PR] Add ADC support on ESP32|S2|S3|C3|C6|H2 [nuttx]

2025-04-16 Thread via GitHub
acassis commented on code in PR #16228: URL: https://github.com/apache/nuttx/pull/16228#discussion_r2046769819 ## arch/xtensa/src/common/espressif/esp_adc.c: ## @@ -0,0 +1,844 @@ +/ + * arch/xtensa/src/c

Re: [PR] ADC support on Espressif devices [nuttx]

2025-04-16 Thread via GitHub
nuttxpr commented on PR #16228: URL: https://github.com/apache/nuttx/pull/16228#issuecomment-2809353486 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR appears to meet the NuttX requirements, althoug

Re: [PR] arch/risc-v: Add dedicated GPIO support for esp32[-s2|-s3|-c3|-c6|-h2] [nuttx]

2025-04-16 Thread via GitHub
acassis commented on PR #16223: URL: https://github.com/apache/nuttx/pull/16223#issuecomment-2809319506 > I'm not sure if expanding `/drivers/ioexpander/gpio.c` this way is a good idea. This driver is designed to support **single GPIO**. The interface for single GPIO is different and mutual

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
acassis commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046756973 ## canutils/slcan/slcan.c: ## @@ -137,8 +137,7 @@ static int caninit(char *candev, int *s, struct sockaddr_can *addr, syslog(LOG_ERR, "Error opening CAN sock

[PR] ADC support on Espressif devices [nuttx]

2025-04-16 Thread via GitHub
fdcavalcanti opened a new pull request, #16228: URL: https://github.com/apache/nuttx/pull/16228 ## Summary - documentation: update docs on ADC support for Espressif devices - boards/risc-v: ADC support on Espressif devices - boards/xtensa: ADC support on Espressif devices

[PR] examples/camera: Initialize g_nximage semaphore with SEM_INITIALIZER [nuttx-apps]

2025-04-16 Thread via GitHub
jlaitine opened a new pull request, #3060: URL: https://github.com/apache/nuttx-apps/pull/3060 Use SEM_INITIALIZER macro instead of direct { 0 } ## Summary Initialize the semaphore using the SEM_INITIALIZER macro ## Impact No impact, but direct assigning 0 conflict

Re: [PR] examples/camera: Initialize g_nximage semaphore with SEM_INITIALIZER [nuttx-apps]

2025-04-16 Thread via GitHub
nuttxpr commented on PR #3060: URL: https://github.com/apache/nuttx-apps/pull/3060#issuecomment-2808682492 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic NuttX require

Re: [PR] sched/wdog: Support for periodic wdog. [nuttx]

2025-04-16 Thread via GitHub
Fix-Point commented on PR #15937: URL: https://github.com/apache/nuttx/pull/15937#issuecomment-2809276203 > @Fix-Point @xiaoxiang781216 > > There are 2 serious problems with `work_queue_period` in this PR: > > 1. watchdog list in work_s is reused in the callback of `work_queue_

Re: [PR] arch/risc-v: Add dedicated GPIO support for esp32[-s2|-s3|-c3|-c6|-h2] [nuttx]

2025-04-16 Thread via GitHub
eren-terzioglu commented on PR #16223: URL: https://github.com/apache/nuttx/pull/16223#issuecomment-2809287865 > I'm not sure if expanding `/drivers/ioexpander/gpio.c` this way is a good idea. This driver is designed to support **single GPIO**. The interface for single GPIO is different and

Re: [PR] arch/risc-v: Add dedicated GPIO support for esp32[-s2|-s3|-c3|-c6|-h2] [nuttx]

2025-04-16 Thread via GitHub
raiden00pl commented on PR #16223: URL: https://github.com/apache/nuttx/pull/16223#issuecomment-2809305448 > Should we implement a new driver which includes just 2 calls? Maybe we can write the driver when we implement parallel io interface for esp devices to make the interface more inclusi

Re: [PR] arch/arm/src/stm32h7: unassigned ret variable in SIOCSCANBITRATE. [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 merged PR #16224: URL: https://github.com/apache/nuttx/pull/16224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] drivers/video/vnc: Replace direct semcount access with nxsem_get_value [nuttx]

2025-04-16 Thread via GitHub
xiaoxiang781216 merged PR #16222: URL: https://github.com/apache/nuttx/pull/16222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: arch/arm/src/stm32h7: unassigned ret variable in SIOCSCANBITRATE.

2025-04-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8f1d670a83 arch/arm/src/stm32h7: unassigned re

(nuttx) branch master updated: drivers/video/vnc: Replace direct semcount access with nxsem_get_value

2025-04-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b5144afd03 drivers/video/vnc: Replace direct s

Re: [PR] nuttx/msgq: add kernel message queue support [nuttx]

2025-04-16 Thread via GitHub
nuttxpr commented on PR #16226: URL: https://github.com/apache/nuttx/pull/16226#issuecomment-2808873313 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does **not** fully meet the NuttX requirements.

Re: [PR] Make slcan brin the interface up/down with the appropiate commands [nuttx-apps]

2025-04-16 Thread via GitHub
acassis commented on code in PR #3059: URL: https://github.com/apache/nuttx-apps/pull/3059#discussion_r2046948817 ## canutils/slcan/slcan.c: ## @@ -137,8 +137,7 @@ static int caninit(char *candev, int *s, struct sockaddr_can *addr, syslog(LOG_ERR, "Error opening CAN sock