Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-05 Thread via GitHub
raiden00pl commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382525781 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: there have

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-05 Thread via GitHub
raiden00pl commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382525781 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: there have

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-05 Thread via GitHub
raiden00pl commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382531694 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: Another op

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-05 Thread via GitHub
raiden00pl commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382531694 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: Another op

[PR] Documentation: migrate some wiki pages [nuttx]

2023-11-05 Thread via GitHub
raiden00pl opened a new pull request, #11129: URL: https://github.com/apache/nuttx/pull/11129 ## Summary - Documentation: migrate "Per-Thread Interrupt Controls" from wiki - Documentation: migrate "Effects of Disabling Interrupts or Pre-Emption on Response Latency" from wiki - Docum

[PR] examples/foc: add support for control loop performance measurements [nuttx-apps]

2023-11-05 Thread via GitHub
raiden00pl opened a new pull request, #2179: URL: https://github.com/apache/nuttx-apps/pull/2179 ## Summary examples/foc: add support for control loop performance measurements ## Impact ## Testing b-g431b-esc1 -- This is an automated message from the Apache Git Serv

Re: [I] iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? [nuttx]

2023-11-05 Thread via GitHub
michi-jung commented on issue #11123: URL: https://github.com/apache/nuttx/issues/11123#issuecomment-1793712275 @wengzhe Thanks! I am going to investigate further then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? [nuttx]

2023-11-05 Thread via GitHub
michi-jung commented on issue #11123: URL: https://github.com/apache/nuttx/issues/11123#issuecomment-1793712719 ``` (gdb) print *(struct iob_s *)0x2000fdec $14 = {io_flink = 0x2000fd1c , io_len = 182 '\266', io_offset = 14 '\016', io_pktlen = 187, io_data = "\006T21\003T111.111\0

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382565207 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: can w

Re: [PR] fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex [nuttx]

2023-11-05 Thread via GitHub
zouboan commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382571179 ## fs/inode/fs_files.c: ## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: It seems like

Re: [PR] Add Settings Utility and Example App [nuttx-apps]

2023-11-05 Thread via GitHub
TimJTi commented on PR #2178: URL: https://github.com/apache/nuttx-apps/pull/2178#issuecomment-1793739477 @xiaoxiang781216 It still fails CI - I HAVE NO IDEA!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? [nuttx]

2023-11-05 Thread via GitHub
michi-jung closed issue #11123: iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? URL: https://github.com/apache/nuttx/issues/11123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] iob_free: io_offset not taken into consideration when adjusting remaining io_pktlen? [nuttx]

2023-11-05 Thread via GitHub
michi-jung commented on issue #11123: URL: https://github.com/apache/nuttx/issues/11123#issuecomment-1793745492 Thanks again for your help, @wengzhe Indeed, I am missing this fix (I am still on NuttX 12.0.0). Meanwhile I cherrry-picked it and it did resolve my problem. -- This is

Re: [PR] examples/foc: add support for control loop performance measurements [nuttx-apps]

2023-11-05 Thread via GitHub
xiaoxiang781216 merged PR #2179: URL: https://github.com/apache/nuttx-apps/pull/2179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: examples/foc: add support for control loop performance measurements

2023-11-05 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 9ba709200 examples/foc: add support for c

Re: [PR] Update serialrx_main.c [nuttx-apps]

2023-11-05 Thread via GitHub
xiaoxiang781216 merged PR #2174: URL: https://github.com/apache/nuttx-apps/pull/2174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: Update serialrx_main.c

2023-11-05 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 0c572e167 Update serialrx_main.c 0c572e16

Re: [PR] Documentation: migrate some wiki pages [nuttx]

2023-11-05 Thread via GitHub
xiaoxiang781216 merged PR #11129: URL: https://github.com/apache/nuttx/pull/11129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (ffc5434a8c -> 2214eecddc)

2023-11-05 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ffc5434a8c sched/Kconfig: RW_SPINLOCK depends on SPINLOCK add 0b17238714 Documentation: migrate "Per-Thread Int

(nuttx) 02/02: net/tcp: Support initial sequence number described in RFC 6528

2023-11-05 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit d1c73b6ed65cfb51dc8b8a8a8dc5854e77638f55 Author: Zhe Weng AuthorDate: Wed Nov 1 11:30:36 2023 +0800 net/tcp: Supp

(nuttx) 01/02: net/tcp: Take out get random process as common function

2023-11-05 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 5096a2c9fdfcd7838a8dc015a3185b3a2b2a4849 Author: Zhe Weng AuthorDate: Wed Nov 1 11:59:51 2023 +0800 net/tcp: Take

Re: [PR] net/tcp: Support initial sequence number described in RFC 6528 [nuttx]

2023-11-05 Thread via GitHub
xiaoxiang781216 merged PR #11126: URL: https://github.com/apache/nuttx/pull/11126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (2214eecddc -> d1c73b6ed6)

2023-11-05 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 2214eecddc Documentation: migrate "Testing TCP/IP Network Stacks" from wiki new 5096a2c9fd net/tcp: Take out g

[PR] sched: Check for zero sleep time and yield CPU [nuttx]

2023-11-05 Thread via GitHub
no1wudi opened a new pull request, #11130: URL: https://github.com/apache/nuttx/pull/11130 ## Summary Check for zero sleep time and yield CPU if necessary ## Impact Minor ## Testing libuv -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] sched: Check for zero sleep time and yield CPU [nuttx]

2023-11-05 Thread via GitHub
no1wudi closed pull request #11130: sched: Check for zero sleep time and yield CPU URL: https://github.com/apache/nuttx/pull/11130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] SystemView example based on nucleo-f446re [nuttx]

2023-11-05 Thread via GitHub
ixnisarg commented on PR #10006: URL: https://github.com/apache/nuttx/pull/10006#issuecomment-1794164310 Any one can share step by step guide to use system view usage on Nuttx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a