[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9159: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9159: URL: https://github.com/apache/nuttx/pull/9159 ## Summary tools/pre-commit should be copied to .git/hooks/pre-commit to take effect. ## Impact new shell script ## Testing CI -- This is an automated mes

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9160: net/can: Remove the unnecessary "ret = OK;" in can_getsockopt

2023-05-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9160: URL: https://github.com/apache/nuttx/pull/9160 ## Summary and remove the extra space in code ## Impact code refactor only ## Testing CI -- This is an automated message from the Apache Git Service. To respo

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9161: net: Remove net_ preifx from net_ipv6_pref2xxx

2023-05-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9161: URL: https://github.com/apache/nuttx/pull/9161 ## Summary follow other utility function convention(e.g. tcp_ipv4_chksum) ## Impact code refactor only ## Testing CI -- This is an automated message from the

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8726: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #8726: URL: https://github.com/apache/nuttx/pull/8726#discussion_r1183335121 ## drivers/modem/alt1250/altcom_hdlr.c: ## @@ -2531,13 +2530,13 @@ static int32_t actpdn_pkt_compose(FAR void **arg, out->iptype = apn->ip_type; out->autht

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8726: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #8726: URL: https://github.com/apache/nuttx/pull/8726#discussion_r1183336492 ## arch/arm/src/phy62xx/uart.h: ## @@ -165,7 +165,12 @@ int hal_uart_set_tx_buf(UART_INDEX_e uart_index, uint8_t *buf, uint16_t size); int hal_uart_get_tx_

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1623: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #1623: URL: https://github.com/apache/nuttx-apps/pull/1623#discussion_r1183361340 ## examples/udgram/udgram_server.c: ## @@ -144,7 +146,7 @@ int main(int argc, FAR char *argv[]) } } else /* if (recvlen > sizeof

[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1623: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #1623: URL: https://github.com/apache/nuttx-apps/pull/1623#issuecomment-1532610531 > @xiaoxiang781216 please add commit messages describing the changes All change is simply replacing the unsafe function with the safe one, which already mention in the me

[GitHub] [nuttx-apps] xiaoxiang781216 closed pull request #897: system: Simplify the line ending option in cle/readline/vi/bas

2023-05-03 Thread via GitHub
xiaoxiang781216 closed pull request #897: system: Simplify the line ending option in cle/readline/vi/bas URL: https://github.com/apache/nuttx-apps/pull/897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nuttx] pkarashchenko commented on pull request #9161: net: Remove net_ preifx from net_ipv6_pref2xxx

2023-05-03 Thread via GitHub
pkarashchenko commented on PR #9161: URL: https://github.com/apache/nuttx/pull/9161#issuecomment-1532719369 I see plenty of `net_ip4addr_conv32`, `net_ipv4addr_copy`, `net_ipv6addr_copy`, etc. Do you plan to change all other places or only here? -- This is an automated message from the

[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1737: nsh: Fix the typo error cmd_swtichboot -> cmd_switchboot

2023-05-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #1737: URL: https://github.com/apache/nuttx-apps/pull/1737 ## Summary ## Impact minor ## Testing CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1736: graphics: Fix nxstyle errors

2023-05-03 Thread via GitHub
xiaoxiang781216 merged PR #1736: URL: https://github.com/apache/nuttx-apps/pull/1736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[nuttx-apps] branch master updated: graphics: Fix nxstyle errors

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 1707be397 graphics: Fix nxstyle errors 17

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9160: net/can: Remove the unnecessary "ret = OK;" in can_getsockopt

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #9160: URL: https://github.com/apache/nuttx/pull/9160#discussion_r1183455492 ## net/can/can_getsockopt.c: ## @@ -172,14 +169,13 @@ int can_getsockopt(FAR struct socket *psock, int level, int option, * to me in this case.

[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1557: Wolfssl code back

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #1557: URL: https://github.com/apache/nuttx-apps/pull/1557#issuecomment-1532728670 @jpbland1 please fix the below nxstyle warning: ``` Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/crypto/wolfssl/user_settings.h:1:1: error: Missing file header com

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8726: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #8726: URL: https://github.com/apache/nuttx/pull/8726#discussion_r1183462717 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -292,13 +292,16 @@ static void tlsr82_flash_print(const char *msg, const uint8_t *buf, { if (i % 16 ==

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9159: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #9159: URL: https://github.com/apache/nuttx/pull/9159#discussion_r1183464617 ## tools/pre-commit: ## @@ -0,0 +1,17 @@ +#!/usr/bin/env bash Review Comment: `/home/runner/work/nuttx/nuttx/nuttx/tools/pre-commit: error: execute permissions

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9159: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #9159: URL: https://github.com/apache/nuttx/pull/9159#discussion_r1183465473 ## tools/pre-commit: ## @@ -0,0 +1,17 @@ +#!/usr/bin/env bash +# tools/pre-commit +# git hook to run check-patch on the output and stop any commits +# that do not p

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9159: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #9159: URL: https://github.com/apache/nuttx/pull/9159#discussion_r1183465473 ## tools/pre-commit: ## @@ -0,0 +1,17 @@ +#!/usr/bin/env bash +# tools/pre-commit +# git hook to run check-patch on the output and stop any commits +# that do not p

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9154: mtd/nand: Return -EUCLEAN when the bit error happen but fixed by ecc

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #9154: URL: https://github.com/apache/nuttx/pull/9154#discussion_r1183467273 ## drivers/mtd/mtd_nand.c: ## @@ -600,7 +624,11 @@ static ssize_t nand_bread(FAR struct mtd_dev_s *dev, off_t startpage, /* Read the next page from NAND */

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9162: net: Simplify the tcp/udp existence check

2023-05-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9162: URL: https://github.com/apache/nuttx/pull/9162 ## Summary Replace defined(CONFIG_NET_TCP) && !defined(CONFIG_NET_TCP_NO_STACK) with NET_TCP_HAVE_STACK Replace defined(CONFIG_NET_UDP) && !defined(CONFIG_NET_UDP_NO_STACK) with NET_UD

[GitHub] [nuttx] jerpelea commented on pull request #9162: net: Simplify the tcp/udp existence check

2023-05-03 Thread via GitHub
jerpelea commented on PR #9162: URL: https://github.com/apache/nuttx/pull/9162#issuecomment-1532801120 please add a commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9160: net/can: Remove the unnecessary "ret = OK;" in can_getsockopt

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #9160: URL: https://github.com/apache/nuttx/pull/9160#discussion_r1183518194 ## net/bluetooth/bluetooth_container.c: ## @@ -144,7 +144,7 @@ FAR struct bluetooth_container_s *bluetooth_container_allocate(void) net_unlock(); c

[GitHub] [nuttx] xiaoxiang781216 closed pull request #4860: libc/gets: Simplify the line ending option

2023-05-03 Thread via GitHub
xiaoxiang781216 closed pull request #4860: libc/gets: Simplify the line ending option URL: https://github.com/apache/nuttx/pull/4860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9159: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #9159: URL: https://github.com/apache/nuttx/pull/9159#discussion_r1183554494 ## tools/pre-commit: ## @@ -0,0 +1,17 @@ +#!/usr/bin/env bash Review Comment: because we can't add .sh suffix to pre-commit since git require the file name m

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9159: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #9159: URL: https://github.com/apache/nuttx/pull/9159#discussion_r1183555130 ## tools/pre-commit: ## @@ -0,0 +1,17 @@ +#!/usr/bin/env bash +# tools/pre-commit +# git hook to run check-patch on the output and stop any commits +# that do not

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9162: net: Simplify the tcp/udp existence check

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #9162: URL: https://github.com/apache/nuttx/pull/9162#issuecomment-1532857800 > please add a commit message Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8726: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #8726: URL: https://github.com/apache/nuttx/pull/8726#discussion_r1183568992 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -292,13 +292,16 @@ static void tlsr82_flash_print(const char *msg, const uint8_t *buf, { if (i % 16

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8726: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #8726: URL: https://github.com/apache/nuttx/pull/8726#discussion_r1183570394 ## arch/arm/src/tlsr82/tlsr82_flash_mtd.c: ## @@ -292,13 +292,16 @@ static void tlsr82_flash_print(const char *msg, const uint8_t *buf, { if (i % 16 ==

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9154: mtd/nand: Return -EUCLEAN when the bit error happen but fixed by ecc

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #9154: URL: https://github.com/apache/nuttx/pull/9154#discussion_r1183571352 ## drivers/mtd/mtd_nand.c: ## @@ -600,7 +624,11 @@ static ssize_t nand_bread(FAR struct mtd_dev_s *dev, off_t startpage, /* Read the next page from NAND *

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9154: mtd/nand: Return -EUCLEAN when the bit error happen but fixed by ecc

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #9154: URL: https://github.com/apache/nuttx/pull/9154#discussion_r1183575541 ## drivers/mtd/mtd_nand.c: ## @@ -110,6 +111,48 @@ static int nand_ioctl(FAR struct mtd_dev_s *dev, int cmd, * Private Functions **

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9154: mtd/nand: Return -EUCLEAN when the bit error happen but fixed by ecc

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #9154: URL: https://github.com/apache/nuttx/pull/9154#discussion_r1183580469 ## drivers/mtd/mtd_nand.c: ## @@ -110,6 +111,48 @@ static int nand_ioctl(FAR struct mtd_dev_s *dev, int cmd, * Private Functions

[GitHub] [nuttx] xiaoxiang781216 closed pull request #6746: sched: Remove KEEP_ALIVE_HACK hack

2023-05-03 Thread via GitHub
xiaoxiang781216 closed pull request #6746: sched: Remove KEEP_ALIVE_HACK hack URL: https://github.com/apache/nuttx/pull/6746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9158: libs/libxx: remove redundant code

2023-05-03 Thread via GitHub
xiaoxiang781216 merged PR #9158: URL: https://github.com/apache/nuttx/pull/9158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (884be2bdb9 -> f1e37a4987)

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 884be2bdb9 assert: Distinguish between assert and exception add f1e37a4987 libs/libxx: remove redundant code N

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9161: net: Remove net_ preifx from net_ipv6_pref2xxx

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #9161: URL: https://github.com/apache/nuttx/pull/9161#issuecomment-1532895159 let's change this patch to draft until I finish the decsision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [nuttx] xiaoxiang781216 closed pull request #8478: compiler/diagnostic: Replace all #warning to #pragma message

2023-05-03 Thread via GitHub
xiaoxiang781216 closed pull request #8478: compiler/diagnostic: Replace all #warning to #pragma message URL: https://github.com/apache/nuttx/pull/8478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9163: sched: Stop the sched timer when possible to save the power in tickless mode

2023-05-03 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9163: URL: https://github.com/apache/nuttx/pull/9163 ## Summary Remove KEEP_ALIVE_HACK to avoid waking up the device periodly. The workaround it's added by: ``` commit 6546fa39c7a292e919d1ea396d67bea8242f2c4b Author: Gregory

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9163: sched: Stop the sched timer when possible to save the power in tickless mode

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #9163: URL: https://github.com/apache/nuttx/pull/9163#issuecomment-1532918176 Since KEEP_ALIVE_HACK impact the device power consumption, it's better to remove this hack. From my understanding, the workaround is unnecessary, @patacongo could you confirm it?

[GitHub] [nuttx] raiden00pl commented on pull request #8952: boards/stm32: add composite device configurations

2023-05-03 Thread via GitHub
raiden00pl commented on PR #8952: URL: https://github.com/apache/nuttx/pull/8952#issuecomment-1532924843 @xiaoxiang781216 conflict fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [nuttx] jerpelea merged pull request #9159: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread via GitHub
jerpelea merged PR #9159: URL: https://github.com/apache/nuttx/pull/9159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[nuttx] branch master updated: tools: add git pre-commit hook based on checkpatch.sh

2023-05-03 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new db84cd2e59 tools: add git pre-commit hook based

[GitHub] [nuttx] jerpelea merged pull request #9160: net/can: Remove the unnecessary "ret = OK;" in can_getsockopt

2023-05-03 Thread via GitHub
jerpelea merged PR #9160: URL: https://github.com/apache/nuttx/pull/9160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[nuttx] branch master updated (db84cd2e59 -> 5de49d2939)

2023-05-03 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from db84cd2e59 tools: add git pre-commit hook based on checkpatch.sh add df246461ec net/can: Remove the unnecessary

[GitHub] [nuttx] zouboan opened a new pull request, #9164: boards/nucleo-f429zi: update CONFIG define to keep up with the CONFIG in arch/stm32

2023-05-03 Thread via GitHub
zouboan opened a new pull request, #9164: URL: https://github.com/apache/nuttx/pull/9164 ## Summary The kconfig item in arch/arm/stm32 is CONFIG_STM32_XXX , but when the config definition was used in nucleo-f429zi it was supposed to be CONFIG_STM32F4_XXX at present, it should be update t

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8952: boards/stm32: add composite device configurations

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #8952: URL: https://github.com/apache/nuttx/pull/8952#discussion_r1183688102 ## boards/arm/stm32f7/nucleo-144/src/stm32_composite.c: ## @@ -0,0 +1,347 @@ +/ + * boar

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1623: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
pkarashchenko commented on code in PR #1623: URL: https://github.com/apache/nuttx-apps/pull/1623#discussion_r1183693741 ## logging/nxscope/nxscope_chan.c: ## @@ -364,7 +364,7 @@ static int nxscope_put_vector(FAR uint8_t *buff, uint8_t type, FAR void *val, DEBUGASSE

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1623: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on code in PR #1623: URL: https://github.com/apache/nuttx-apps/pull/1623#discussion_r1183715324 ## logging/nxscope/nxscope_chan.c: ## @@ -364,7 +364,7 @@ static int nxscope_put_vector(FAR uint8_t *buff, uint8_t type, FAR void *val, DEBUGAS

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9163: sched: Stop the sched timer when possible to save the power in tickless mode

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #9163: URL: https://github.com/apache/nuttx/pull/9163#issuecomment-1533069380 Thanks, I will do more test internally before I get the solid result, let me change this patch to draft. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [nuttx] simbit18 opened a new pull request, #9165: include: Fix nxstyle errors

2023-05-03 Thread via GitHub
simbit18 opened a new pull request, #9165: URL: https://github.com/apache/nuttx/pull/9165 ## Summary error: Long line found ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nuttx] pkarashchenko merged pull request #9162: net: Simplify the tcp/udp existence check

2023-05-03 Thread via GitHub
pkarashchenko merged PR #9162: URL: https://github.com/apache/nuttx/pull/9162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[nuttx] branch master updated (5de49d2939 -> 74e2b75857)

2023-05-03 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5de49d2939 net: Remove the extra space add 74e2b75857 net: Simplify the tcp/udp existence check No new rev

[GitHub] [nuttx] pkarashchenko merged pull request #9154: mtd/nand: Return -EUCLEAN when the bit error happen but fixed by ecc

2023-05-03 Thread via GitHub
pkarashchenko merged PR #9154: URL: https://github.com/apache/nuttx/pull/9154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[nuttx] branch master updated (74e2b75857 -> a514c0a13e)

2023-05-03 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 74e2b75857 net: Simplify the tcp/udp existence check add 3e1ddb3de9 mtd/nand: Return -EUCLEAN when the bit

[nuttx-apps] branch master updated: nsh: Fix the typo error cmd_swtichboot -> cmd_switchboot

2023-05-03 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new bebae28bd nsh: Fix the typo error cmd

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1737: nsh: Fix the typo error cmd_swtichboot -> cmd_switchboot

2023-05-03 Thread via GitHub
pkarashchenko merged PR #1737: URL: https://github.com/apache/nuttx-apps/pull/1737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9156: esp32_esp32s3/wifi: add support to WPA3 on Station Mode

2023-05-03 Thread via GitHub
xiaoxiang781216 merged PR #9156: URL: https://github.com/apache/nuttx/pull/9156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] 02/05: esp32s3/wifi: add support to WPA3 on Station Mode

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 9ede7d4650318d6d8c7af8bb6cac56994b53b17b Author: Tiago Medicci Serrano AuthorDate: Thu Apr 27 11:07:07 2023 -0300

[nuttx] 03/05: esp32/wifi: remove debug features from Wi-Fi-related `defconfig`s

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 6e76229df2e6547c033e5d5d1966cdad50615ded Author: Tiago Medicci Serrano AuthorDate: Thu Apr 27 11:10:40 2023 -0300

[nuttx] 05/05: documentation/esp32_esp32s3: update informations about Wi-Fi

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 24ce51f137702cdcd04a91dab8bbf9df10f35191 Author: Tiago Medicci Serrano AuthorDate: Thu Apr 27 18:04:49 2023 -0300

[nuttx] branch master updated (a514c0a13e -> 24ce51f137)

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from a514c0a13e mtd/nand: Implement isbad and markbad callback new a86a9dc09e esp32s3/wifi: fix Wi-Fi's NVS-like sto

[nuttx] 01/05: esp32s3/wifi: fix Wi-Fi's NVS-like storage long filename error

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit a86a9dc09ecd53796097aaa804dd53a7f9759379 Author: Tiago Medicci Serrano AuthorDate: Thu Apr 27 10:58:38 2023 -0300

[nuttx] 04/05: esp32/wifi: add support to WPA3 on Station Mode

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 28361a295d24553088b33b7a55d12250ee70060b Author: Tiago Medicci Serrano AuthorDate: Thu Apr 27 11:11:56 2023 -0300

[GitHub] [nuttx] tmedicci commented on a diff in pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-03 Thread via GitHub
tmedicci commented on code in PR #9138: URL: https://github.com/apache/nuttx/pull/9138#discussion_r1184077178 ## libs/libc/string/lib_memcmp.c: ## @@ -30,7 +30,9 @@ * Public Functions / -#ifndef CO

[GitHub] [nuttx] tmedicci commented on a diff in pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-03 Thread via GitHub
tmedicci commented on code in PR #9138: URL: https://github.com/apache/nuttx/pull/9138#discussion_r1184077894 ## libs/libc/machine/Kconfig: ## @@ -137,6 +137,54 @@ config LIBC_ARCH_ELF_64BIT default n depends on LIBC_ARCH_ELF +config LIBC_ARCH_PREVENT_KERNEL +

[GitHub] [nuttx] acassis merged pull request #9164: boards/nucleo-f429zi: update CONFIG define to keep up with the CONFIG in arch/stm32

2023-05-03 Thread via GitHub
acassis merged PR #9164: URL: https://github.com/apache/nuttx/pull/9164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated: boards/nucleo-f429zi: update CONFIG name to keep up with the CONFIG in arch/stm32

2023-05-03 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new e7df243a4a boards/nucleo-f429zi: update CONFIG n

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9165: include: Fix nxstyle errors

2023-05-03 Thread via GitHub
xiaoxiang781216 merged PR #9165: URL: https://github.com/apache/nuttx/pull/9165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (e7df243a4a -> b1404f486e)

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from e7df243a4a boards/nucleo-f429zi: update CONFIG name to keep up with the CONFIG in arch/stm32 add b1404f486e in

[GitHub] [nuttx] tmedicci commented on pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-03 Thread via GitHub
tmedicci commented on PR #9138: URL: https://github.com/apache/nuttx/pull/9138#issuecomment-1533498348 > LGTM. @tmedicci This PR could also extend to ESP32, basically the same changes applied to ESP32-S3. You may validate it via a successful `ostest` with `esp32-devkitc:knsh` defconfig.

[GitHub] [nuttx] ldube opened a new pull request, #9166: wireless/bluetooth: Support removable bluetooth modules.

2023-05-03 Thread via GitHub
ldube opened a new pull request, #9166: URL: https://github.com/apache/nuttx/pull/9166 ## Summary This bluetooth stack remains in an inconsistent state when the bluetooth HCI module is removed. This change adds a bt_netdev_unregister function that can be used to clean up after a modu

[GitHub] [nuttx] patacongo commented on pull request #9163: sched: Stop the sched timer when possible to save the power in tickless mode

2023-05-03 Thread via GitHub
patacongo commented on PR #9163: URL: https://github.com/apache/nuttx/pull/9163#issuecomment-1533510456 > Thanks, I will do more test internally before I get the solid result, let me change this patch to draft. Ok. Whenever you are satisfied, I will be happy to merge. The cond

[GitHub] [nuttx] acassis commented on pull request #9103: arch/riscv: Fixed FPU register error

2023-05-03 Thread via GitHub
acassis commented on PR #9103: URL: https://github.com/apache/nuttx/pull/9103#issuecomment-1533513644 @SunJun8 is there some reproducible way to happen these wrong values written to the registers all the time to demonstrate the issue? -- This is an automated message from the Apache Git Se

[GitHub] [nuttx] acassis commented on a diff in pull request #9166: wireless/bluetooth: Support removable bluetooth modules.

2023-05-03 Thread via GitHub
acassis commented on code in PR #9166: URL: https://github.com/apache/nuttx/pull/9166#discussion_r1184111610 ## wireless/bluetooth/bt_hcicore.c: ## @@ -1444,6 +1453,7 @@ static void cmd_queue_init(void) nxsem_init(&g_btdev.ncmd_sem, 0, 1); g_btdev.ncmd = 1; + g_btdev.tx

[GitHub] [nuttx] acassis commented on a diff in pull request #9166: wireless/bluetooth: Support removable bluetooth modules.

2023-05-03 Thread via GitHub
acassis commented on code in PR #9166: URL: https://github.com/apache/nuttx/pull/9166#discussion_r1184113449 ## wireless/bluetooth/bt_hcicore.c: ## @@ -1575,6 +1593,53 @@ int bt_driver_register(FAR struct bt_driver_s *btdev) void bt_driver_unregister(FAR struct bt_driver_s *b

[GitHub] [nuttx] acassis commented on issue #8831: BMP280 sensor is not working with sensortest

2023-05-03 Thread via GitHub
acassis commented on issue #8831: URL: https://github.com/apache/nuttx/issues/8831#issuecomment-1533532361 Hi @Donny9 did you test the sensor with some board config? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [nuttx] tmedicci commented on pull request #9138: libc/string: select arch's libc for kernel/userspace optionally

2023-05-03 Thread via GitHub
tmedicci commented on PR #9138: URL: https://github.com/apache/nuttx/pull/9138#issuecomment-1533535429 > > LGTM. @tmedicci This PR could also extend to ESP32, basically the same changes applied to ESP32-S3. You may validate it via a successful `ostest` with `esp32-devkitc:kn

[GitHub] [nuttx] ldube commented on a diff in pull request #9166: wireless/bluetooth: Support removable bluetooth modules.

2023-05-03 Thread via GitHub
ldube commented on code in PR #9166: URL: https://github.com/apache/nuttx/pull/9166#discussion_r1184152211 ## wireless/bluetooth/bt_hcicore.c: ## @@ -1575,6 +1593,53 @@ int bt_driver_register(FAR struct bt_driver_s *btdev) void bt_driver_unregister(FAR struct bt_driver_s *btd

[GitHub] [nuttx] pkarashchenko commented on pull request #8726: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
pkarashchenko commented on PR #8726: URL: https://github.com/apache/nuttx/pull/8726#issuecomment-1533627373 Please fix compilation issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [nuttx] acassis opened a new pull request, #9167: boards: Fix CONFIG_[START_DATE,START_MONTH] cannot start with 0

2023-05-03 Thread via GitHub
acassis opened a new pull request, #9167: URL: https://github.com/apache/nuttx/pull/9167 ## Summary Run: $ ./tools/refresh.sh --silent --defaults all It will report that CONFIG_START_DATE and/or CONFIG_START_MONTH are using invalid value starting with 0, so 03 should be 3, and s

[GitHub] [nuttx] fdcavalcanti opened a new issue, #9168: Add MPU60X0 device driver to TIVA TM4C bring up sequence

2023-05-03 Thread via GitHub
fdcavalcanti opened a new issue, #9168: URL: https://github.com/apache/nuttx/issues/9168 Hi everyone, I saw that the bring up sequence of the Nucleo-144 already registers the MPU60X0 device driver, if requested. So far, i've edited the bring up file on the TM4C board to bind the MPU

[nuttx-website] branch asf-site updated: Publishing web: 6b97f0b7d9c9541ec77f08b188cf82e4a808a573 docs: b1404f486ed52ed598d699e860f93afa6f1243a0

2023-05-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0a446a11 Publishing web: 6b97f0b7

[GitHub] [nuttx] GooTal commented on issue #8959: Enabling sinfo printing and disabling CONFIG_SYSLOG_TIMESTAMP_REALTIME caused a recursive calling bug?

2023-05-03 Thread via GitHub
GooTal commented on issue #8959: URL: https://github.com/apache/nuttx/issues/8959#issuecomment-1533940563 @anchao Thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [nuttx] GooTal commented on issue #8750: dd: open failed: 6 on rv-virt:nsh64

2023-05-03 Thread via GitHub
GooTal commented on issue #8750: URL: https://github.com/apache/nuttx/issues/8750#issuecomment-1533945887 Wow, Nice work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nuttx] SunJun8 commented on pull request #9103: arch/riscv: Fixed FPU register error

2023-05-03 Thread via GitHub
SunJun8 commented on PR #9103: URL: https://github.com/apache/nuttx/pull/9103#issuecomment-1533963699 > Hi, the current implementation is done as per RISC-V privileged spec. v1.10 table 3.4. and it was done when the FPU save/restore was done only when a context switch actually happened.

[GitHub] [nuttx] SunJun8 commented on pull request #9103: arch/riscv: Fixed FPU register error

2023-05-03 Thread via GitHub
SunJun8 commented on PR #9103: URL: https://github.com/apache/nuttx/pull/9103#issuecomment-1533967828 > @SunJun8 is there some reproducible way to happen these wrong values written to the registers all the time to demonstrate the issue? I attempted to replicate the issue with BL602, a

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9167: boards: Fix CONFIG_[START_DATE,START_MONTH] cannot start with 0

2023-05-03 Thread via GitHub
xiaoxiang781216 merged PR #9167: URL: https://github.com/apache/nuttx/pull/9167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated: boards: Fix CONFIG_[START_DATE,START_MONTH] cannot start with 0

2023-05-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new bac304afc0 boards: Fix CONFIG_[START_DATE,STAR

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9166: wireless/bluetooth: Support removable bluetooth modules.

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #9166: URL: https://github.com/apache/nuttx/pull/9166#issuecomment-1533991618 @ldube does bluetooth stack just support one HCI device? I saw the code destroy the core data structure in bt_netdev_unregister. Can we improve this situation? -- This is an auto

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8726: Replace the unsafe function(strcat, sprintf) with the safe one(strlcat, snprintf)

2023-05-03 Thread via GitHub
xiaoxiang781216 commented on PR #8726: URL: https://github.com/apache/nuttx/pull/8726#issuecomment-1534003170 > Please fix compilation issues Done, the origin code has bug which may make the buffer overflow, it is cached by compiler after we switch sprintf to snprintf. -- This is a

[GitHub] [nuttx] ldube commented on pull request #9166: wireless/bluetooth: Support removable bluetooth modules.

2023-05-03 Thread via GitHub
ldube commented on PR #9166: URL: https://github.com/apache/nuttx/pull/9166#issuecomment-1534006811 > Yes, only one HCI device is supported at the moment. I have thought about fixing this. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [nuttx] zhhyu7 closed pull request #9058: Add some network-related definitions

2023-05-03 Thread via GitHub
zhhyu7 closed pull request #9058: Add some network-related definitions URL: https://github.com/apache/nuttx/pull/9058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9169: ethernet: add ETHERTYPE define

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9169: URL: https://github.com/apache/nuttx/pull/9169 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9170: route: add struct in6_rtmsg definition

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9170: URL: https://github.com/apache/nuttx/pull/9170 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9171: if_arp: add arphdr definition

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9171: URL: https://github.com/apache/nuttx/pull/9171 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9172: if_ether: add ether_arp definition

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9172: URL: https://github.com/apache/nuttx/pull/9172 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9173: udp: add udphdr definition

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9173: URL: https://github.com/apache/nuttx/pull/9173 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9174: icmp6: add icmp6-related definition

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9174: URL: https://github.com/apache/nuttx/pull/9174 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9175: netlink: convert lltype to device type

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9175: URL: https://github.com/apache/nuttx/pull/9175 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9176: syslog: add syslog option definition

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9176: URL: https://github.com/apache/nuttx/pull/9176 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

[GitHub] [nuttx] zhhyu7 opened a new pull request, #9177: if: add net device type

2023-05-03 Thread via GitHub
zhhyu7 opened a new pull request, #9177: URL: https://github.com/apache/nuttx/pull/9177 ## Summary We will integrate network management tools in future projects. In the process of porting the tools, we encounter some situations where the structure is not defined, or the returned data typ

  1   2   >