[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8371: Change sec2tick macros to round up

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8371: URL: https://github.com/apache/nuttx/pull/8371#discussion_r1091580504 ## include/nuttx/clock.h: ## @@ -145,41 +145,49 @@ * preferred for that reason (at the risk of overflow) */ -#define TICK_PER_HOUR (USEC_PER_HOUR /

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #6242: rv-virt:knsh64

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #6242: URL: https://github.com/apache/nuttx/pull/6242#issuecomment-1409945018 There is a draft PR to enable ostest for kernel mode: https://github.com/apache/nuttx-apps/pull/1500. @GooTal you can try and refine it. -- This is an automated message from the

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8372: arch:xtena: modify timer interrupt level large to XCHAL_IRQ_LEVEL level

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #8372: URL: https://github.com/apache/nuttx/pull/8372#issuecomment-1409947738 @gustavonihei could you verify this patch? Our device require this patch to boot. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8361: net/devif: check the net device before use

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8361: URL: https://github.com/apache/nuttx/pull/8361#discussion_r1091589847 ## net/devif/devif_send.c: ## @@ -68,47 +69,50 @@ void devif_send(FAR struct net_driver_s *dev, FAR const void *buf, int len, unsigned int offse

[GitHub] [nuttx] anchao commented on a diff in pull request #8361: net/devif: check the net device before use

2023-01-31 Thread via GitHub
anchao commented on code in PR #8361: URL: https://github.com/apache/nuttx/pull/8361#discussion_r1091591820 ## net/devif/devif_send.c: ## @@ -68,47 +69,50 @@ void devif_send(FAR struct net_driver_s *dev, FAR const void *buf, int len, unsigned int offset) { -#i

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1515: Makefile: adjust compilation flags order

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #1515: URL: https://github.com/apache/nuttx-apps/pull/1515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[nuttx-apps] branch master updated: Makefile: adjust compilation flags order

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 0e823eadc Makefile: adjust compilation fl

[GitHub] [nuttx] zyfeier commented on pull request #8175: sched/semaphore: increase sem count when holder task exit

2023-01-31 Thread via GitHub
zyfeier commented on PR #8175: URL: https://github.com/apache/nuttx/pull/8175#issuecomment-1409969819 > Meanwhile I will try to run the test you provided on my end @pkarashchenko can you repeat the question with the test case? -- This is an automated message from the Apache Git Ser

[GitHub] [nuttx] GUIDINGLI merged pull request #8308: tools/unix.mk: Pass APPDIR to arch's Makefile

2023-01-31 Thread via GitHub
GUIDINGLI merged PR #8308: URL: https://github.com/apache/nuttx/pull/8308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

[nuttx] branch master updated (55679aec5f -> c3ddb1507b)

2023-01-31 Thread ligd
This is an automated email from the ASF dual-hosted git repository. ligd pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 55679aec5f drivers/camera: Support the private data for imgsensor and imgdata add c3ddb1507b tools/unix.mk: Pass AP

[GitHub] [nuttx-apps] masayuki2009 opened a new pull request, #1518: testing: ostest: Show errno in message queue test

2023-01-31 Thread via GitHub
masayuki2009 opened a new pull request, #1518: URL: https://github.com/apache/nuttx-apps/pull/1518 ## Summary - This commit shows errno in message queue test ## Impact - None ## Testing - Tested with esp32-devkitc:smp on QEMU-7.1 -- This is an automat

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8373: vfs: Suppoprt F_DUPFD_CLOEXEC

2023-01-31 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8373: URL: https://github.com/apache/nuttx/pull/8373 ## Summary https://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html ## Impact new F_DUPFD_CLOEXEC ## Testing internal test -- This is an automate

[GitHub] [nuttx] jlaitine commented on a diff in pull request #8371: Change sec2tick macros to round up

2023-01-31 Thread via GitHub
jlaitine commented on code in PR #8371: URL: https://github.com/apache/nuttx/pull/8371#discussion_r1091664006 ## include/nuttx/clock.h: ## @@ -145,41 +145,49 @@ * preferred for that reason (at the risk of overflow) */ -#define TICK_PER_HOUR (USEC_PER_HOUR / USEC_PE

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8371: Change sec2tick macros to round up

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8371: URL: https://github.com/apache/nuttx/pull/8371#discussion_r1091685095 ## include/nuttx/clock.h: ## @@ -145,41 +145,49 @@ * preferred for that reason (at the risk of overflow) */ -#define TICK_PER_HOUR (USEC_PER_HOUR /

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8347: tools: compile with full file path

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #8347: URL: https://github.com/apache/nuttx/pull/8347#issuecomment-1410069856 Need update ELFCOMPILE in apps too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8347: tools: compile with full file path

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #8347: URL: https://github.com/apache/nuttx/pull/8347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (c3ddb1507b -> 9c6c9fb0cd)

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c3ddb1507b tools/unix.mk: Pass APPDIR to arch's Makefile add 9c6c9fb0cd tools/Config.mk: compile with full file

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8347: tools: compile with full file path

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8347: URL: https://github.com/apache/nuttx/pull/8347#discussion_r1091719602 ## tools/Config.mk: ## @@ -364,7 +364,7 @@ endef define ASSEMBLE @echo "AS: $1" - $(Q) $(CCACHE) $(CC) -c $(AFLAGS) $1 $($(strip $1)_AFLAGS) -o $

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8374: sched: Remove the unused TCB_FLAG_SCHED_OTHER

2023-01-31 Thread via GitHub
xiaoxiang781216 opened a new pull request, #8374: URL: https://github.com/apache/nuttx/pull/8374 ## Summary after https://github.com/apache/nuttx/pull/8330 ## Impact No, remove the dead code ## Testing Internal review -- This is an automated message from

[GitHub] [nuttx-apps] wengzhe opened a new pull request, #1519: ifconfig: Support `ifconfig interface` and update arg limit

2023-01-31 Thread via GitHub
wengzhe opened a new pull request, #1519: URL: https://github.com/apache/nuttx-apps/pull/1519 ## Summary From comment in cmd_ifconfig, it seems that we support `ifconfig [interface]`, but actually not considering the interface param now. After this commit, we only print the information o

[GitHub] [nuttx] TimJTi commented on issue #8325: RNDIS/CDC-ECM/CDC-NCM

2023-01-31 Thread via GitHub
TimJTi commented on issue #8325: URL: https://github.com/apache/nuttx/issues/8325#issuecomment-1410112036 @masayuki2009 Perfect! That's exactly what I believe to be going on, based on lots of evidence on other processors an RTOS' I will try and implement similar fix and create a PR.

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8361: net/devif: check the net device before use

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #8361: URL: https://github.com/apache/nuttx/pull/8361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated: net/devif: check the net device before use

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7fce145b30 net/devif: check the net device bef

[GitHub] [nuttx] pussuw commented on pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-01-31 Thread via GitHub
pussuw commented on PR #8355: URL: https://github.com/apache/nuttx/pull/8355#issuecomment-1410142518 Build error seems to be something with the CI env: unzip: cannot find zipfile directory in one of v8.3.3.zip or v8.3.3.zip.zip, and cannot find v8.3.3.zip.ZIP, period. -- Thi

[GitHub] [nuttx] pussuw commented on pull request #8355: arch/addrenv: Refactor address environment handling, by moving tg_addrenv out of the group structure

2023-01-31 Thread via GitHub
pussuw commented on PR #8355: URL: https://github.com/apache/nuttx/pull/8355#issuecomment-1410142995 Also, the CI output is full of this: drivers/mmcsd/Kconfig:32:warning: 'MMCSD_IOCSUPPORT': number is invalid drivers/mmcsd/Kconfig:32:warning: 'MMCSD_IOCSUPPORT': number is invalid d

[GitHub] [nuttx] pussuw opened a new pull request, #8375: drivers/mmcsd: Fix kconfig error regarding MMCSD_IOCSUPPORT

2023-01-31 Thread via GitHub
pussuw opened a new pull request, #8375: URL: https://github.com/apache/nuttx/pull/8375 ## Summary Something I noticed in CI: drivers/mmcsd/Kconfig:32:warning: 'MMCSD_IOCSUPPORT': number is invalid ## Impact Fix CI ## Testing CI pass without the error message -- This is a

[GitHub] [nuttx] pussuw commented on pull request #8375: drivers/mmcsd: Fix kconfig error regarding MMCSD_IOCSUPPORT

2023-01-31 Thread via GitHub
pussuw commented on PR #8375: URL: https://github.com/apache/nuttx/pull/8375#issuecomment-1410148479 I assume this was supposed to be a boolean ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [nuttx] masayuki2009 commented on pull request #8361: net/devif: check the net device before use

2023-01-31 Thread via GitHub
masayuki2009 commented on PR #8361: URL: https://github.com/apache/nuttx/pull/8361#issuecomment-1410201734 @anchao I noticed that the renew command with lm3s6965-ek:discover on QEMU-7.1 does not work with this PR. ``` nsh> uname -a NuttX 10.4.0 7fce145b30 Jan 31 2023 20

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8375: drivers/mmcsd: Fix kconfig error regarding MMCSD_IOCSUPPORT

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #8375: URL: https://github.com/apache/nuttx/pull/8375#issuecomment-1410207616 Yes, thanks for fix the warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #4320: fs: Add model field to geometry and mtd_geometry_s

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #4320: URL: https://github.com/apache/nuttx/pull/4320#issuecomment-1410215140 ping @gustavonihei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [nuttx] gustavonihei commented on pull request #4320: fs: Add model field to geometry and mtd_geometry_s

2023-01-31 Thread via GitHub
gustavonihei commented on PR #4320: URL: https://github.com/apache/nuttx/pull/4320#issuecomment-1410239375 > @gustavonihei I finally get the time to improve the patch as your suggestion, please take a look. Sorry for the delay, I didn't notice the first ping. So in this PR we'll be

[GitHub] [nuttx] anchao commented on pull request #8361: net/devif: check the net device before use

2023-01-31 Thread via GitHub
anchao commented on PR #8361: URL: https://github.com/apache/nuttx/pull/8361#issuecomment-1410239540 > @anchao > > I noticed that the renew command with lm3s6965-ek:discover on QEMU-7.1 does not work with this PR. Could you please share the qemu command line? -- This is

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #4320: fs: Add model field to geometry and mtd_geometry_s

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #4320: URL: https://github.com/apache/nuttx/pull/4320#issuecomment-1410251461 > > @gustavonihei I finally get the time to improve the patch as your suggestion, please take a look. > > Sorry for the delay, I didn't notice the first ping. So in this PR we

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #4320: fs: Add model field to geometry and mtd_geometry_s

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #4320: URL: https://github.com/apache/nuttx/pull/4320#issuecomment-1410257948 @gustavonihei here is the issue: https://github.com/apache/nuttx/issues/8376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [nuttx] xiaoxiang781216 opened a new issue, #8376: Report more info through mtd_geometry_s and geometry

2023-01-31 Thread via GitHub
xiaoxiang781216 opened a new issue, #8376: URL: https://github.com/apache/nuttx/issues/8376 https://github.com/apache/nuttx/pull/4320 add model info to mtd_geometry_s and geometry, the next step is: 1. Move erase state to mtd_geometry_s and remove MTDIOC_ERASESTATE 2. Add more usef

[GitHub] [nuttx] gustavonihei commented on pull request #4320: fs: Add model field to geometry and mtd_geometry_s

2023-01-31 Thread via GitHub
gustavonihei commented on PR #4320: URL: https://github.com/apache/nuttx/pull/4320#issuecomment-1410259163 > > Is the remaining of the planning from [#4320 (comment)](https://github.com/apache/nuttx/pull/4320#issuecomment-896795388) going to implemented soon? > > move erase state to

[GitHub] [nuttx] masayuki2009 commented on pull request #8361: net/devif: check the net device before use

2023-01-31 Thread via GitHub
masayuki2009 commented on PR #8361: URL: https://github.com/apache/nuttx/pull/8361#issuecomment-1410260377 @anchao >Could you please share the qemu command line? ``` /home/ishikawa/opensource/QEMU/qemu-7.1/build/arm-softmmu/qemu-system-arm -net nic,model=stellaris -net use

[GitHub] [nuttx] qiaohaijiao opened a new pull request, #8377: sim/sim_alsa.c: support streaming data when offload playback.

2023-01-31 Thread via GitHub
qiaohaijiao opened a new pull request, #8377: URL: https://github.com/apache/nuttx/pull/8377 Audio offload playback, change data organization from fragmented to streaming. Signed-off-by: qiaohaijiao1 ## Summary Audio offload playback, change data organization from fragmente

[GitHub] [nuttx] anchao opened a new pull request, #8378: tools/makefile: silent all compile output

2023-01-31 Thread via GitHub
anchao opened a new pull request, #8378: URL: https://github.com/apache/nuttx/pull/8378 Signed-off-by: chao an ## Summary tools/makefile: silent all compile output In order to make compilation warnings and errors easier to be found out, this commit will disable the

[GitHub] [nuttx-apps] qiaohaijiao opened a new pull request, #1520: nxplayer: enqueue streaming data to audio driver.

2023-01-31 Thread via GitHub
qiaohaijiao opened a new pull request, #1520: URL: https://github.com/apache/nuttx-apps/pull/1520 nxplayer: enqueue streaming data to audio driver. Signed-off-by: qiaohaijiao1 ## Summary add support streaming data instead of framed. ## Impact N/A ## Testing

[GitHub] [nuttx] fjpanag opened a new pull request, #8379: checkpatch: Added encoding check with cvt2utf

2023-01-31 Thread via GitHub
fjpanag opened a new pull request, #8379: URL: https://github.com/apache/nuttx/pull/8379 ## Summary Added check for non-UTF characters in `checkpatch.sh`. The check is accomplished by using [cvt2utf](https://github.com/x1angli/cvt2utf). All cached files are converted and t

[GitHub] [nuttx] jerpelea merged pull request #8375: drivers/mmcsd: Fix kconfig error regarding MMCSD_IOCSUPPORT

2023-01-31 Thread via GitHub
jerpelea merged PR #8375: URL: https://github.com/apache/nuttx/pull/8375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[nuttx] branch master updated: drivers/mmcsd: Fix kconfig error regarding MMCSD_IOCSUPPORT

2023-01-31 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new da83836da7 drivers/mmcsd: Fix kconfig error reg

[GitHub] [nuttx] anchao opened a new pull request, #8380: net/devif: correct the judgment condition in devif_send()

2023-01-31 Thread via GitHub
anchao opened a new pull request, #8380: URL: https://github.com/apache/nuttx/pull/8380 ## Summary net/devif: correct the judgment condition in devif_send() Regression by: ``` | commit 7fce145b3043e7ee13c72286674d51e9888935c3 | Author: chao an | Date: Mon Jan

[GitHub] [nuttx] anchao commented on pull request #8361: net/devif: check the net device before use

2023-01-31 Thread via GitHub
anchao commented on PR #8361: URL: https://github.com/apache/nuttx/pull/8361#issuecomment-1410303196 > @anchao > > > Could you please share the qemu command line? > > ``` > /home/ishikawa/opensource/QEMU/qemu-7.1/build/arm-softmmu/qemu-system-arm -net nic,model=stellaris -ne

[GitHub] [nuttx] no1wudi opened a new pull request, #8381: tools: Make zig available for arm/riscv/sim

2023-01-31 Thread via GitHub
no1wudi opened a new pull request, #8381: URL: https://github.com/apache/nuttx/pull/8381 ## Summary Add essential compile flags to make zig available out of box. ## Impact Zig only ## Testing Local machine -- This is an automated message from the Apache Git Service. To r

[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1521: Application.mk: Provide a default ZIGELFFLAGS if not defined

2023-01-31 Thread via GitHub
no1wudi opened a new pull request, #1521: URL: https://github.com/apache/nuttx-apps/pull/1521 ## Summary Avoid add ZIGELFFLAGS to each board level Make.defs by default value. ## Impact Zig only ## Testing Local machine -- This is an automated message from the

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8381: tools: Make zig available for arm/riscv/sim

2023-01-31 Thread via GitHub
pkarashchenko commented on code in PR #8381: URL: https://github.com/apache/nuttx/pull/8381#discussion_r1091954930 ## arch/arm/src/common/Toolchain.defs: ## @@ -229,6 +229,10 @@ else endif endif +# Zig compiler + +ZIG = zig Review Comment: ```suggestion ZIG := zig

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8377: sim/sim_alsa.c: support streaming data when offload playback.

2023-01-31 Thread via GitHub
pkarashchenko commented on code in PR #8377: URL: https://github.com/apache/nuttx/pull/8377#discussion_r1091963707 ## arch/sim/src/sim/posix/sim_offload.h: ## @@ -0,0 +1,77 @@ +/ + * arch/sim/src/sim/pos

[GitHub] [nuttx] fjpanag commented on issue #8017: Create a Software Qualification Testing for Release new versions

2023-01-31 Thread via GitHub
fjpanag commented on issue #8017: URL: https://github.com/apache/nuttx/issues/8017#issuecomment-1410399666 Some thoughts on enhancing testing of NuttX: # Expect When we want to test the external interfaces of the system (e.g. console, protocols etc), we are making heavy use of `exp

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1518: testing: ostest: Show errno in message queue test

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #1518: URL: https://github.com/apache/nuttx-apps/pull/1518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[nuttx-apps] branch master updated: testing: ostest: Show errno in message queue test

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new bb8b5493e testing: ostest: Show errno in

[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1519: ifconfig: Support `ifconfig interface` and update arg limit

2023-01-31 Thread via GitHub
pkarashchenko commented on code in PR #1519: URL: https://github.com/apache/nuttx-apps/pull/1519#discussion_r1091992027 ## nshlib/nsh_command.c: ## @@ -244,9 +244,10 @@ static const struct cmdmap_s g_cmdmap[] = #ifdef CONFIG_NET # ifndef CONFIG_NSH_DISABLE_IFCONFIG - { "ifc

[GitHub] [nuttx] pkarashchenko merged pull request #8374: sched: Remove the unused TCB_FLAG_SCHED_OTHER

2023-01-31 Thread via GitHub
pkarashchenko merged PR #8374: URL: https://github.com/apache/nuttx/pull/8374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[nuttx] branch master updated: sched: Remove the unused TCB_FLAG_SCHED_OTHER

2023-01-31 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3904fd775a sched: Remove the unused TCB_FL

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8373: vfs: Suppoprt F_DUPFD_CLOEXEC

2023-01-31 Thread via GitHub
pkarashchenko commented on code in PR #8373: URL: https://github.com/apache/nuttx/pull/8373#discussion_r1091996301 ## fs/vfs/fs_fcntl.c: ## @@ -71,7 +71,13 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap) { /* Does not set the errno var

[GitHub] [nuttx-apps] wengzhe commented on a diff in pull request #1519: ifconfig: Support `ifconfig interface` and update arg limit

2023-01-31 Thread via GitHub
wengzhe commented on code in PR #1519: URL: https://github.com/apache/nuttx-apps/pull/1519#discussion_r1092001099 ## nshlib/nsh_command.c: ## @@ -244,9 +244,10 @@ static const struct cmdmap_s g_cmdmap[] = #ifdef CONFIG_NET # ifndef CONFIG_NSH_DISABLE_IFCONFIG - { "ifconfig"

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8373: vfs: Suppoprt F_DUPFD_CLOEXEC

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8373: URL: https://github.com/apache/nuttx/pull/8373#discussion_r1092004856 ## fs/vfs/fs_fcntl.c: ## @@ -71,7 +71,13 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap) { /* Does not set the errno v

[nuttx-apps] branch master updated: nxplayer: enqueue streaming data to audio driver.

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 20fb7e189 nxplayer: enqueue streaming dat

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1520: nxplayer: enqueue streaming data to audio driver.

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #1520: URL: https://github.com/apache/nuttx-apps/pull/1520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [nuttx] lucasssvaz opened a new pull request, #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels

2023-01-31 Thread via GitHub
lucasssvaz opened a new pull request, #8382: URL: https://github.com/apache/nuttx/pull/8382 ## Summary This PR aims to fix a potential problem with the execution of 2nd level RTC IRQ handlers. Some drivers might need to re-check the RTC status register. This patch propagates the c

[GitHub] [nuttx] TimJTi commented on issue #8325: RNDIS/CDC-ECM/CDC-NCM

2023-01-31 Thread via GitHub
TimJTi commented on issue #8325: URL: https://github.com/apache/nuttx/issues/8325#issuecomment-1410481976 Think I have to give up. This is beyond me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8371: Change sec2tick macros to round up

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #8371: URL: https://github.com/apache/nuttx/pull/8371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] 02/03: Revert "arch/arm/src/stm32f7/stm32_i2c.c: Round up stm32_i2c_toticks return value"

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 05eb8541d18454c7732bd8240bddee5ef2e6d2ca Author: Jukka Laitinen AuthorDate: Mon Jan 30 12:15:03 2023 +0400 Revert

[nuttx] 03/03: arch/arm/src/lc823450/lc823450_i2c.c: Remove extra rounding after MSEC2TIC change to round up

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 4f957f8031e96dfb69be864187a0f3bb45217f30 Author: Jukka Laitinen AuthorDate: Tue Jan 31 10:28:18 2023 +0400 arch/a

[nuttx] branch master updated (3904fd775a -> 4f957f8031)

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 3904fd775a sched: Remove the unused TCB_FLAG_SCHED_OTHER new 4dd8187afe include/nuttx/clock.h: Change ?SEC2TICK

[GitHub] [nuttx] xiaoxiang781216 closed issue #8346: Regression in many places due to change of nxsem_timedwait_uninterruptible with nxsem_tickwait_uninterruptible

2023-01-31 Thread via GitHub
xiaoxiang781216 closed issue #8346: Regression in many places due to change of nxsem_timedwait_uninterruptible with nxsem_tickwait_uninterruptible URL: https://github.com/apache/nuttx/issues/8346 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[nuttx] 01/03: include/nuttx/clock.h: Change ?SEC2TICK macros to round up and fix nxstyle errors

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 4dd8187afee4dcd92a7af00dc91f7e6515941b9a Author: Jukka Laitinen AuthorDate: Mon Jan 30 12:13:16 2023 +0400 includ

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8380: net/devif: correct the judgment condition in devif_send()

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #8380: URL: https://github.com/apache/nuttx/pull/8380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (4f957f8031 -> 30aa0ee700)

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4f957f8031 arch/arm/src/lc823450/lc823450_i2c.c: Remove extra rounding after MSEC2TIC change to round up add 3

[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels

2023-01-31 Thread via GitHub
gustavonihei commented on code in PR #8382: URL: https://github.com/apache/nuttx/pull/8382#discussion_r1092034976 ## arch/xtensa/src/esp32/esp32_rtc_gpio.c: ## @@ -127,8 +128,9 @@ static inline bool is_valid_rtc_gpio(uint32_t rtcio_num)

[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels

2023-01-31 Thread via GitHub
lucasssvaz commented on code in PR #8382: URL: https://github.com/apache/nuttx/pull/8382#discussion_r1092039179 ## arch/xtensa/src/esp32/esp32_rtc_gpio.c: ## @@ -127,8 +128,9 @@ static inline bool is_valid_rtc_gpio(uint32_t rtcio_num) **

[GitHub] [nuttx] gustavonihei merged pull request #4320: fs: Add model field to geometry and mtd_geometry_s

2023-01-31 Thread via GitHub
gustavonihei merged PR #4320: URL: https://github.com/apache/nuttx/pull/4320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

[nuttx] branch master updated: fs: Add model field to geometry and mtd_geometry_s

2023-01-31 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9f027208d4 fs: Add model field to geometry

[GitHub] [nuttx] gustavonihei commented on issue #8376: Report more info through mtd_geometry_s and geometry

2023-01-31 Thread via GitHub
gustavonihei commented on issue #8376: URL: https://github.com/apache/nuttx/issues/8376#issuecomment-1410501612 > 1. Move erase state to mtd_geometry_s and remove MTDIOC_ERASESTATE Please, note that the NuttX port of MCUboot makes use of the MTDIOC_ERASESTATE: https://github.com/m

[GitHub] [nuttx] masayuki2009 opened a new pull request, #8383: fs: mqueue: Fix file_mq_open() for SMP

2023-01-31 Thread via GitHub
masayuki2009 opened a new pull request, #8383: URL: https://github.com/apache/nuttx/pull/8383 ## Summary - I noticed that sometimes mqueue_test failed with rv-virt:smp. - This commit fixes this issue. ## Impact - SMP only ## Testing - Tested with ostest o

[GitHub] [nuttx] Gary-Hobson commented on pull request #7572: tools: Fix various error in Windows native build

2023-01-31 Thread via GitHub
Gary-Hobson commented on PR #7572: URL: https://github.com/apache/nuttx/pull/7572#issuecomment-1410578628 @zouboan In the ubuntu environment, there are two separators for some information compiled and output using Make V=1 Is it necessary? Is there a way to remove ```sh arm

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8379: checkpatch: Added encoding check with cvt2utf

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #8379: URL: https://github.com/apache/nuttx/pull/8379#issuecomment-1410607155 Hit the same error: https://github.com/apache/nuttx/pull/8247. So, it isn't related to Ubuntu version. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8379: checkpatch: Added encoding check with cvt2utf

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on PR #8379: URL: https://github.com/apache/nuttx/pull/8379#issuecomment-1410618357 @Bhindhiya and anjana-tel do you know why docker fail to generate the renesas toolchain: ``` Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c cd renesas-

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8383: fs: mqueue: Fix file_mq_open() for SMP

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8383: URL: https://github.com/apache/nuttx/pull/8383#discussion_r1092122101 ## fs/mqueue/mq_open.c: ## @@ -211,10 +214,15 @@ static int file_mq_vopen(FAR struct file *mq, FAR const char *mq_name, /* Make sure that the check for the ex

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8381: tools: Make zig available for arm/riscv/sim

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8381: URL: https://github.com/apache/nuttx/pull/8381#discussion_r1092129405 ## arch/arm/src/common/Toolchain.defs: ## @@ -258,6 +262,20 @@ else LDFLAGS += -nostdlib endif +ifeq ($(CONFIG_ARM_THUMB),y) + ZARCH := thumb +else + ZARC

[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8384: Makefile: fix redundant delimiters when using make V=1

2023-01-31 Thread via GitHub
Gary-Hobson opened a new pull request, #8384: URL: https://github.com/apache/nuttx/pull/8384 ## Summary When using make V=1, the obj file will print two separators in the libc and mm directories Use the [ realpath function](https://www.gnu.org/software/make/manual/html_node/File-Name-

[nuttx] branch master updated (9f027208d4 -> f07885541c)

2023-01-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9f027208d4 fs: Add model field to geometry and mtd_geometry_s add f07885541c arch/xtensa/esp32: Propagate RTC I

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #8382: URL: https://github.com/apache/nuttx/pull/8382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] acassis commented on pull request #8384: Makefile: fix redundant delimiters when using make V=1

2023-01-31 Thread via GitHub
acassis commented on PR #8384: URL: https://github.com/apache/nuttx/pull/8384#issuecomment-1410781165 @Gary-Hobson seems there are other places that need to be fixed too, after applying this patch I can see it: ``` arm-none-eabi-gcc -c -Wstrict-prototypes -Os -fno-strict-aliasing -fom

[GitHub] [nuttx] Gary-Hobson commented on pull request #8384: Makefile: fix redundant delimiters when using make V=1

2023-01-31 Thread via GitHub
Gary-Hobson commented on PR #8384: URL: https://github.com/apache/nuttx/pull/8384#issuecomment-1410824575 > @Gary-Hobson seems there are other places that need to be fixed too, after applying this patch I can see it: > > ``` > arm-none-eabi-gcc -c -Wstrict-prototypes -Os -fno-stric

[GitHub] [nuttx] acassis commented on pull request #8384: Makefile: fix redundant delimiters when using make V=1

2023-01-31 Thread via GitHub
acassis commented on PR #8384: URL: https://github.com/apache/nuttx/pull/8384#issuecomment-1410854097 Thank you @Gary-Hobson ! I missed that PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [nuttx] acassis merged pull request #8384: Makefile: fix redundant delimiters when using make V=1

2023-01-31 Thread via GitHub
acassis merged PR #8384: URL: https://github.com/apache/nuttx/pull/8384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated: Makefile: fix redundant delimiters when using make V=1

2023-01-31 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 64d39a8b7b Makefile: fix redundant delimiters wh

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8384: Makefile: fix redundant delimiters when using make V=1

2023-01-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #8384: URL: https://github.com/apache/nuttx/pull/8384#discussion_r1092414447 ## mm/Makefile: ## @@ -52,18 +52,18 @@ all: $(BIN) .PHONY: context depend clean distclean $(AOBJS): $(BINDIR)$(DELIM)$(DELIM)%$(OBJEXT): %.S - $(call AS

[nuttx-apps] branch master updated: netutils/cjson: fix unpackage error when local gerrit does not exist

2023-01-31 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new f4e29f376 netutils/cjson: fix unpacka

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1517: netutils/cjson: fix unpackage error when local gerrit does not exist

2023-01-31 Thread via GitHub
pkarashchenko merged PR #1517: URL: https://github.com/apache/nuttx-apps/pull/1517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[GitHub] [nuttx] g2gps commented on a diff in pull request #8368: litex: Add GPIO driver.

2023-01-31 Thread via GitHub
g2gps commented on code in PR #8368: URL: https://github.com/apache/nuttx/pull/8368#discussion_r1092534840 ## arch/risc-v/src/litex/litex_gpio.c: ## @@ -0,0 +1,357 @@ +/ + * arch/risc-v/src/litex/litex_g

[GitHub] [nuttx] masayuki2009 commented on a diff in pull request #8383: fs: mqueue: Fix file_mq_open() for SMP

2023-01-31 Thread via GitHub
masayuki2009 commented on code in PR #8383: URL: https://github.com/apache/nuttx/pull/8383#discussion_r1092547460 ## fs/mqueue/mq_open.c: ## @@ -211,10 +214,15 @@ static int file_mq_vopen(FAR struct file *mq, FAR const char *mq_name, /* Make sure that the check for the exist

[GitHub] [nuttx] hartmannathan opened a new pull request, #8385: libc/termios: Fix comment in cfmakeraw docstring.

2023-01-31 Thread via GitHub
hartmannathan opened a new pull request, #8385: URL: https://github.com/apache/nuttx/pull/8385 ## Summary Fix a copy-paste error in a comment. ## Impact Documentation correctness. No functional change. ## Testing nxstyle -- This is an automated messag

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 64d39a8b7b4288c44f13b1ac5cb0878ad541fab5

2023-01-31 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c5fea648 Publishing web: b50f5ca4

[GitHub] [nuttx] hartmannathan opened a new pull request, #8386: Kconfig: Improve help text related to *_SERIALBRK_BSDCOMPAT

2023-01-31 Thread via GitHub
hartmannathan opened a new pull request, #8386: URL: https://github.com/apache/nuttx/pull/8386 ## Summary In Kconfig, improve the help text of the GD32F4_SERIALBRK_BSDCOMPAT, STM32_SERIALBRK_BSDCOMPAT, STM32F7_SERIALBRK_BSDCOMPAT, STM32H7_SERIALBRK_BSDCOMPAT, STM32L4_SERIALBRK_BSDCOM

[GitHub] [nuttx] qiaohaijiao commented on a diff in pull request #8377: sim/sim_alsa.c: support streaming data when offload playback.

2023-01-31 Thread via GitHub
qiaohaijiao commented on code in PR #8377: URL: https://github.com/apache/nuttx/pull/8377#discussion_r1092646304 ## arch/sim/src/sim/posix/sim_offload.h: ## @@ -0,0 +1,77 @@ +/ + * arch/sim/src/sim/posix

[GitHub] [nuttx] no1wudi commented on a diff in pull request #8381: tools: Make zig available for arm/riscv/sim

2023-01-31 Thread via GitHub
no1wudi commented on code in PR #8381: URL: https://github.com/apache/nuttx/pull/8381#discussion_r1092655456 ## arch/arm/src/common/Toolchain.defs: ## @@ -258,6 +262,20 @@ else LDFLAGS += -nostdlib endif +ifeq ($(CONFIG_ARM_THUMB),y) + ZARCH := thumb +else + ZARCH := arm

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8385: libc/termios: Fix comment in cfmakeraw docstring.

2023-01-31 Thread via GitHub
xiaoxiang781216 merged PR #8385: URL: https://github.com/apache/nuttx/pull/8385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

  1   2   >