[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

masayuki2009 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1010081631 ## arch/arm/src/cxd56xx/cxd56_spi.c: ## @@ -179,15 +178,19 @@ static const struct spi_ops_s g_spi4ops = static struct cxd56_spidev_s g_spi4dev = { .sp

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

masayuki2009 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1010159691 ## arch/arm/src/sama5/sam_twi.c: ## @@ -1248,15 +1268,6 @@ struct i2c_master_s *sam_i2cbus_initialize(int bus) goto errout_with_lock; } - /*

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

masayuki2009 commented on PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#issuecomment-1298184771 Hmm, it's too hard because the first commit is too big and has several changes other than the global muetx/sem initialization. -- This is an automated message from

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7496: nucleo-h743zi2: refresh the pysim defconfig to fix CI problem

xiaoxiang781216 commented on PR #7496: URL: https://github.com/apache/incubator-nuttx/pull/7496#issuecomment-1298195727 let merge this to unblock the ci. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7496: nucleo-h743zi2: refresh the pysim defconfig to fix CI problem

xiaoxiang781216 merged PR #7496: URL: https://github.com/apache/incubator-nuttx/pull/7496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: nucleo-h743zi2: refresh the pysim defconfig to fix CI problem

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5611d89015 nucleo-h743zi2: refresh t

[GitHub] [incubator-nuttx] CV-Bowen commented on pull request #7495: mm_heap: add debug assert to check the alignment problem

CV-Bowen commented on PR #7495: URL: https://github.com/apache/incubator-nuttx/pull/7495#issuecomment-1298206495 Rebase to retrigger the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-nuttx-apps] CV-Bowen commented on pull request #1393: mm_main: delete realloc boundary test

CV-Bowen commented on PR #1393: URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#issuecomment-1298208726 Rebased to retrigger the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request, #1394: alarm: using timegm instead of mktime beacuse rtc is gmt time

Donny9 opened a new pull request, #1394: URL: https://github.com/apache/incubator-nuttx-apps/pull/1394 ## Summary alarm: using timegm instead of mktime beacuse rtc is gmt time Signed-off-by: dongjiuzhu1 ## Impact correct for command: alarm -r ## Testing loc

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7497: arm/backtrace_sp: fix build warning

xiaoxiang781216 commented on PR #7497: URL: https://github.com/apache/incubator-nuttx/pull/7497#issuecomment-1298243640 @SPRESENSE please rebase the code, the ci broken is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] SPRESENSE commented on pull request #7497: arm/backtrace_sp: fix build warning

SPRESENSE commented on PR #7497: URL: https://github.com/apache/incubator-nuttx/pull/7497#issuecomment-1298277824 @xiaoxiang781216 rebase done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #7436: arm: Added breakpoint in stack overflow trap.

fjpanag commented on code in PR #7436: URL: https://github.com/apache/incubator-nuttx/pull/7436#discussion_r1010273631 ## arch/arm/src/armv8-m/arm_stackcheck.c: ## @@ -69,6 +69,12 @@ void __stack_overflow_trap(void) uint32_t regval; + regval = getreg32(NVIC_DHCSR); + if

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #7436: arm: Added breakpoint in stack overflow trap.

fjpanag commented on code in PR #7436: URL: https://github.com/apache/incubator-nuttx/pull/7436#discussion_r1010274210 ## arch/arm/src/armv7-m/arm_stackcheck.c: ## @@ -69,6 +69,12 @@ void __stack_overflow_trap(void) uint32_t regval; + regval = getreg32(NVIC_DHCSR); Revi

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7491: Fix the warning found by https://github.com/apache/incubator-nuttx/pull/7391

pkarashchenko commented on code in PR #7491: URL: https://github.com/apache/incubator-nuttx/pull/7491#discussion_r1010303768 ## include/nuttx/usb/usb.h: ## @@ -65,10 +65,10 @@ #define MSBYTE(u16) ((u16) >> 8) /* Get MS byte from uint16_t */ #de

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1393: mm_main: delete realloc boundary test

xiaoxiang781216 merged PR #1393: URL: https://github.com/apache/incubator-nuttx-apps/pull/1393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated: mm_main: delete realloc boundary test

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new fe28ed052 mm_main: delete reall

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1393: mm_main: delete realloc boundary test

xiaoxiang781216 commented on PR #1393: URL: https://github.com/apache/incubator-nuttx-apps/pull/1393#issuecomment-1298374408 related patch: https://github.com/apache/incubator-nuttx/pull/7495 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7495: mm_heap: add debug assert to check the alignment problem

xiaoxiang781216 merged PR #7495: URL: https://github.com/apache/incubator-nuttx/pull/7495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: mm_heap: add debug assert to check the alignment problem

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new fccda0c08b mm_heap: add debug assert

[GitHub] [incubator-nuttx] Gary-Hobson commented on pull request #7425: Optimize noteram speed, copy all data at once

Gary-Hobson commented on PR #7425: URL: https://github.com/apache/incubator-nuttx/pull/7425#issuecomment-1298387095 This commit needs to be revised and will be resubmitted later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] Gary-Hobson closed pull request #7425: Optimize noteram speed, copy all data at once

Gary-Hobson closed pull request #7425: Optimize noteram speed, copy all data at once URL: https://github.com/apache/incubator-nuttx/pull/7425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-nuttx] jerpelea merged pull request #7497: arm/backtrace_sp: fix build warning

jerpelea merged PR #7497: URL: https://github.com/apache/incubator-nuttx/pull/7497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[incubator-nuttx] branch master updated: arm/backtrace_sp: fix build warning

This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3379fc96fc arm/backtrace_sp: fix buil

[GitHub] [incubator-nuttx] acassis commented on issue #7331: Is it possible to enable nsh over composite usb configuration using RP2040?

acassis commented on issue #7331: URL: https://github.com/apache/incubator-nuttx/issues/7331#issuecomment-1298486658 Hi @abdallah-ali-abdallah do you know if rp2040 has OpenOCD support? My suggestion is to use GDB+OpenOCD to debug it. I suspect there is some semaphore or equivalent thing i

[incubator-nuttx] branch master updated: arm: Added breakpoint in stack overflow trap.

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 189aa0292f arm: Added breakpoint in

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7436: arm: Added breakpoint in stack overflow trap.

xiaoxiang781216 merged PR #7436: URL: https://github.com/apache/incubator-nuttx/pull/7436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7491: Fix the warning found by https://github.com/apache/incubator-nuttx/pull/7391

xiaoxiang781216 commented on code in PR #7491: URL: https://github.com/apache/incubator-nuttx/pull/7491#discussion_r1010451252 ## include/nuttx/usb/usb.h: ## @@ -65,10 +65,10 @@ #define MSBYTE(u16) ((u16) >> 8) /* Get MS byte from uint16_t */ #

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7494: arch_timer: adjust timer/arch_timer to support tick

xiaoxiang781216 merged PR #7494: URL: https://github.com/apache/incubator-nuttx/pull/7494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: arch_timer: adjust timer/arch_timer to support tick

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new b118083c35 arch_timer: adjust timer/

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7493: clock: adjust clock function to support tick

xiaoxiang781216 merged PR #7493: URL: https://github.com/apache/incubator-nuttx/pull/7493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: clock: adjust clock function to support tick

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8512ca74b1 clock: adjust clock funct

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7476: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__ if __INT32_TYPE__ is defined

xiaoxiang781216 commented on PR #7476: URL: https://github.com/apache/incubator-nuttx/pull/7476#issuecomment-1298546684 @pkarashchenko do you have more suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1394: alarm: using timegm instead of mktime beacuse rtc is gmt time

xiaoxiang781216 merged PR #1394: URL: https://github.com/apache/incubator-nuttx-apps/pull/1394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated: alarm: using timegm instead of mktime beacuse rtc is gmt time

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 6e3c4aab7 alarm: using timegm i

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7476: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__ if __INT32_TYPE__ is defined

pkarashchenko commented on PR #7476: URL: https://github.com/apache/incubator-nuttx/pull/7476#issuecomment-1298558135 I'm fine. Just waiting @yamt to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7476: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__ if __INT32_TYPE__ is defined

xiaoxiang781216 commented on PR #7476: URL: https://github.com/apache/incubator-nuttx/pull/7476#issuecomment-1298594461 @yamt do you have more concern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] yamt commented on a diff in pull request #7476: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__ if __INT32_TYPE__ is defined

yamt commented on code in PR #7476: URL: https://github.com/apache/incubator-nuttx/pull/7476#discussion_r1010535210 ## arch/arm/include/inttypes.h: ## @@ -29,91 +29,142 @@ * Pre-processor Prototypes

[GitHub] [incubator-nuttx] FASTSHIFT commented on pull request #7268: boards: adapt LVGL v8 defconfig

FASTSHIFT commented on PR #7268: URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1298714538 @tmedicci @gustavonihei Is there anything else we need to modify? Can we start merging this PR :) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7076: Remove duplicate calls and optimize compilation speed

Gary-Hobson commented on code in PR #7076: URL: https://github.com/apache/incubator-nuttx/pull/7076#discussion_r1010609083 ## drivers/segger/Make.defs: ## @@ -27,11 +27,11 @@ ifeq ($(CONFIG_SEGGER_RTT),y) CFLAGS += -Wno-shadow -Wno-array-bounds ifneq ($(CONFIG_SEGGER_RTT

[GitHub] [incubator-nuttx] tmedicci commented on pull request #7268: boards: adapt LVGL v8 defconfig

tmedicci commented on PR #7268: URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1298767920 > @tmedicci @gustavonihei Is there anything else we need to modify? Can we start merging this PR :) It isn't a block from my side, but I still see a warning regarding the

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7491: Fix the warning found by https://github.com/apache/incubator-nuttx/pull/7391

pkarashchenko merged PR #7491: URL: https://github.com/apache/incubator-nuttx/pull/7491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] 07/07: Fix usbhost/usbhost_hidmouse.c:1693:13: error: unused function 'usbhost_putle16'

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 463be02921cdbeb4ea4448cdde03223fd9386e52 Author: Xiang Xiao AuthorDate: Mon Oct 31 22:37:48 2022 +0800

[incubator-nuttx] 06/07: Fix lpc17_40_serial.c:705:24: error: unused function 'lpc17_40_uartcclkdiv'

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4578df5cbba4273fe13449180247cba0d5f845dc Author: Xiang Xiao AuthorDate: Mon Oct 31 22:36:28 2022 +0800

[incubator-nuttx] 04/07: Fix error: format specifies type 'unsigned short' but the argument has type 'int'

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 3b060bad34f443a9e0bda8695fc4e3af7f67d47a Author: Xiang Xiao AuthorDate: Mon Oct 31 22:29:19 2022 +0800

[incubator-nuttx] branch master updated (8512ca74b1 -> 463be02921)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 8512ca74b1 clock: adjust clock function to support tick new ae9ff3bc67 Fix lpc176x_clockconfig.c:

[incubator-nuttx] 02/07: Fix lpc17_40_serial.c:814:20: error: unused function 'lpc17_40_uart0config'

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 09997c65469b15f53165ef306e2308a20d75ac18 Author: Xiang Xiao AuthorDate: Mon Oct 31 22:17:52 2022 +0800

[incubator-nuttx] 05/07: Fix lpc17_40_serial.c:510:20: error: unused function 'up_restoreuartint'

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7daacec1fa41523a0fb6a7f5b74ed547aad20d67 Author: Xiang Xiao AuthorDate: Mon Oct 31 22:30:48 2022 +0800

[incubator-nuttx] 01/07: Fix lpc176x_clockconfig.c:213:16: error: variable 'regval' set but not used

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit ae9ff3bc67c31c424854f0ba3235c36a3859f35f Author: Xiang Xiao AuthorDate: Mon Oct 31 22:16:11 2022 +0800

[incubator-nuttx] 03/07: Fix lpc17_40_sdcard.c:614:24: error: unused function 'lpc17_40_getpwrctrl'

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 5948dc8c8f1342707640c827cbf33274b10e97cf Author: Xiang Xiao AuthorDate: Mon Oct 31 22:20:34 2022 +0800

[GitHub] [incubator-nuttx] Gary-Hobson commented on a diff in pull request #7076: Remove duplicate calls and optimize compilation speed

Gary-Hobson commented on code in PR #7076: URL: https://github.com/apache/incubator-nuttx/pull/7076#discussion_r1010625337 ## tools/Config.mk: ## @@ -555,26 +555,34 @@ endef # ARCHxxx means the predefined setting(either toolchain, arch, or system specific) -ARCHDEFINES +=

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7498: binfmt: elf_addrenv_free select addrenv before up_addrenv_destroy

xiaoxiang781216 opened a new pull request, #7498: URL: https://github.com/apache/incubator-nuttx/pull/7498 ## Summary to avoid up_addrenv_destroy delete the current task page table this patch fix the below panic due to elf contain the unresolved symbol: ``` qemu-system-arm -s -S -se

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7499: libc/spawn: Always build lib_psa_[get|set]stacksize.c

xiaoxiang781216 opened a new pull request, #7499: URL: https://github.com/apache/incubator-nuttx/pull/7499 ## Summary instead of lib_psa_[get|set]stackaddr.c since the later doesn't exist in kernel mode regression by: ``` commit b9b032af722d9812790b379590c1da154a8be748 Author: Xi

[GitHub] [incubator-nuttx] abdallah-ali-abdallah commented on issue #7331: Is it possible to enable nsh over composite usb configuration using RP2040?

abdallah-ali-abdallah commented on issue #7331: URL: https://github.com/apache/incubator-nuttx/issues/7331#issuecomment-1298868681 > @abdallah-ali-abdallah I have a suggestion: keep CONFIG_NSH_USBCONSOLE enabled and don't define the CONFIG_NSH_USBCONDEV, it should put use /dev/console as U

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request, #7500: xtensa/esp32s3: Move linker scripts to folder common to all boards

gustavonihei opened a new pull request, #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500 ## Summary This PR intends to reduce the repetition of Linker-related files among boards based on **ESP32-S3** by moving the generic ones to a common folder. ## Impact

[GitHub] [incubator-nuttx] tmedicci opened a new pull request, #7501: esp32/i2s: use internal buffer to handle multiple audio formats

tmedicci opened a new pull request, #7501: URL: https://github.com/apache/incubator-nuttx/pull/7501 ## Summary 1. Creates an internal buffer handled by the ESP32's I2S driver to be able to make the necessary manipulations to correctly fit the characteristics of the I2S's FIFO (byte a

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7476: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__ if __INT32_TYPE__ is defined

pkarashchenko merged PR #7476: URL: https://github.com/apache/incubator-nuttx/pull/7476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 93895c42a7 arch/arm: Typedef _[u

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7476: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__ if __INT32_TYPE__ is defined

pkarashchenko commented on PR #7476: URL: https://github.com/apache/incubator-nuttx/pull/7476#issuecomment-1298972418 Let's merge PR. @xiaoxiang781216 please add some link for reference or short explanation into the code as a comment to improve readability -- This is an automated message

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7502: arch/arm: Document the clever trick of PRI?32 macros

xiaoxiang781216 opened a new pull request, #7502: URL: https://github.com/apache/incubator-nuttx/pull/7502 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7476: arch/arm: Typedef _[u]int32_t to __[U]INT32_TYPE__ if __INT32_TYPE__ is defined

xiaoxiang781216 commented on PR #7476: URL: https://github.com/apache/incubator-nuttx/pull/7476#issuecomment-1298984050 > Let's merge PR. @xiaoxiang781216 please add some link for reference or short explanation into the code as a comment to improve readability @pkarashchenko it's here

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7500: xtensa/esp32s3: Move linker scripts to folder common to all boards

xiaoxiang781216 commented on code in PR #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500#discussion_r1010805492 ## boards/xtensa/esp32s3/esp32s3-devkit/src/Make.defs: ## @@ -49,13 +49,12 @@ ifeq ($(CONFIG_LCD_ST7735),y) CSRCS += esp32s3_st7735.c endif -SCRIPTI

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7499: libc/spawn: Always build lib_psa_[get|set]stacksize.c

pkarashchenko commented on PR #7499: URL: https://github.com/apache/incubator-nuttx/pull/7499#issuecomment-1299070924 Isn't sabre-6quad/netknsh built by CI? I mean how it happened that this issue was not catched by CI? -- This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7499: libc/spawn: Always build lib_psa_[get|set]stacksize.c

pkarashchenko merged PR #7499: URL: https://github.com/apache/incubator-nuttx/pull/7499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated: libc/spawn: Always build lib_psa_[get|set]stacksize.c

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9e72fe9fab libc/spawn: Always bu

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request, #7503: arch: Fix linking of multiple preprocessed linker script files

gustavonihei opened a new pull request, #7503: URL: https://github.com/apache/incubator-nuttx/pull/7503 ## Summary This PR intends to fix the preprocessing of multiple linker script files introduced in #7208. Only the last item from the ARCHSCRIPT list was being suffixed with ".tmp",

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7500: xtensa/esp32s3: Move linker scripts to folder common to all boards

gustavonihei commented on code in PR #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500#discussion_r1010875984 ## boards/xtensa/esp32s3/esp32s3-devkit/src/Make.defs: ## @@ -49,13 +49,12 @@ ifeq ($(CONFIG_LCD_ST7735),y) CSRCS += esp32s3_st7735.c endif -SCRIPTIN =

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7500: xtensa/esp32s3: Move linker scripts to folder common to all boards

pkarashchenko commented on code in PR #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500#discussion_r1010939798 ## boards/xtensa/esp32s3/esp32s3-eye/scripts/Make.defs: ## @@ -23,13 +23,26 @@ include $(TOPDIR)/tools/Config.mk include $(TOPDIR)/tools/esp32s3/Config.m

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7501: esp32/i2s: use internal buffer to handle multiple audio formats

pkarashchenko commented on code in PR #7501: URL: https://github.com/apache/incubator-nuttx/pull/7501#discussion_r1010940988 ## arch/xtensa/src/esp32/esp32_i2s.c: ## @@ -711,27 +736,114 @@ static int i2s_txdma_setup(struct esp32_i2s_s *priv, /* Get the transfer information,

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #7500: xtensa/esp32s3: Move linker scripts to folder common to all boards

gustavonihei commented on code in PR #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500#discussion_r1010942005 ## boards/xtensa/esp32s3/esp32s3-eye/scripts/Make.defs: ## @@ -23,13 +23,26 @@ include $(TOPDIR)/tools/Config.mk include $(TOPDIR)/tools/esp32s3/Config.mk

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7500: xtensa/esp32s3: Move linker scripts to folder common to all boards

pkarashchenko commented on code in PR #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500#discussion_r1010947723 ## boards/xtensa/esp32s3/esp32s3-eye/scripts/Make.defs: ## @@ -23,13 +23,26 @@ include $(TOPDIR)/tools/Config.mk include $(TOPDIR)/tools/esp32s3/Config.m

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7502: arch/arm: Document the clever trick of PRI?32 macros

pkarashchenko merged PR #7502: URL: https://github.com/apache/incubator-nuttx/pull/7502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7500: xtensa/esp32s3: Move linker scripts to folder common to all boards

pkarashchenko commented on code in PR #7500: URL: https://github.com/apache/incubator-nuttx/pull/7500#discussion_r1010948385 ## boards/xtensa/esp32s3/esp32s3-eye/scripts/Make.defs: ## @@ -23,13 +23,26 @@ include $(TOPDIR)/tools/Config.mk include $(TOPDIR)/tools/esp32s3/Config.m

[incubator-nuttx] branch master updated: arch/arm: Document the clever trick of PRI?32 macros

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 12926ee864 arch/arm: Document th

[GitHub] [incubator-nuttx] acassis opened a new pull request, #7504: Doc: Add how to configure network MTU size

acassis opened a new pull request, #7504: URL: https://github.com/apache/incubator-nuttx/pull/7504 ## Summary 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 ## Impact Users will know how to setup network MTU on NuttX ## Testing N/A -- This is an automated message from the Apac

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7504: Doc: Add how to configure network MTU size

xiaoxiang781216 merged PR #7504: URL: https://github.com/apache/incubator-nuttx/pull/7504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: Doc: Add how to configure network MTU size

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new fd8647d3dd Doc: Add how to configure

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7503: arch: Fix linking of multiple preprocessed linker script files

xiaoxiang781216 merged PR #7503: URL: https://github.com/apache/incubator-nuttx/pull/7503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: arch: Fix linking of multiple preprocessed linker script files

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new f5c77933cb arch: Fix linking of mult

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1362: netutils: Support telnetd in the kernel mode

xiaoxiang781216 commented on PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#issuecomment-1299473233 @masayuki2009 sorry for later reply, the change work with sabre-6quad/netknsh now. Please reverify again. Note: please ensure your nuttx git contain https://githu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011099572 ## arch/arm/src/cxd56xx/cxd56_hostif.c: ## @@ -379,8 +382,6 @@ static int hif_initialize(struct hostif_buff_s *buffer) DEBUGASSERT(buffer); - me

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011101420 ## arch/arm/src/cxd56xx/cxd56_spi.c: ## @@ -871,7 +886,7 @@ static void spi_exchange(struct spi_dev_s *dev, const void *txbuffer, size_t dmath = 0;

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011105975 ## arch/arm/src/cxd56xx/cxd56_spi.c: ## @@ -77,7 +77,6 @@ struct cxd56_spidev_s uint8_t port;/* Port number */ int i

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r107069 ## arch/arm/src/kinetis/kinetis_edma.c: ## @@ -721,18 +707,12 @@ void weak_function arm_dma_initialize(void) /* Initialize data structures */ -

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r108793 ## arch/arm/src/kinetis/kinetis_usbhshost.c: ## @@ -5406,10 +5400,6 @@ struct usbhost_connection_s *kinetis_ehci_initialize(int controller) usbhos

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r109132 ## arch/arm/src/kinetis/kinetis_usbhshost.c: ## @@ -5295,7 +5290,6 @@ struct usbhost_connection_s *kinetis_ehci_initialize(int controller) * to poi

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011121996 ## arch/arm/src/lpc17xx_40xx/lpc17_40_usbhost.c: ## @@ -3826,11 +3825,9 @@ struct usbhost_connection_s *lpc17_40_usbhost_initialize(int controller)

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011122056 ## arch/arm/src/lpc31xx/lpc31_ehci.c: ## @@ -5279,7 +5279,6 @@ struct usbhost_connection_s *lpc31_ehci_initialize(int controller) * first port is

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011122178 ## arch/arm/src/lpc43xx/lpc43_ehci.c: ## @@ -5087,7 +5087,6 @@ struct usbhost_connection_s *lpc43_ehci_initialize(int controller) * first port is

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011122367 ## arch/arm/src/lpc54xx/lpc54_usb0_ohci.c: ## @@ -3904,11 +3903,9 @@ struct usbhost_connection_s *lpc54_usbhost_initialize(int controller) LPC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011122542 ## arch/arm/src/lpc43xx/lpc43_ehci.c: ## @@ -5240,10 +5238,6 @@ struct usbhost_connection_s *lpc43_ehci_initialize(int controller) up_enable_irq(LPC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011122729 ## arch/arm/src/nrf52/nrf52_radio.c: ## @@ -1149,22 +1151,11 @@ nrf52_radio_initialize(int intf, struct nrf52_radio_board_s *board) } }

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011124101 ## arch/arm/src/nrf52/nrf52_rng.c: ## @@ -124,13 +128,6 @@ static int nrf52_rng_initialize(void) first_flag = false; - _info("Initializing RNG\n

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011125332 ## arch/arm/src/s32k1xx/s32k1xx_edma.c: ## @@ -706,18 +692,12 @@ void weak_function arm_dma_initialize(void) /* Initialize data structures */ -

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011127817 ## arch/arm/src/s32k3xx/s32k3xx_edma.c: ## @@ -459,7 +445,7 @@ static struct s32k3xx_edmatcd_s *s32k3xx_tcd_alloc(void) */ flags = enter_critic

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011128126 ## arch/arm/src/s32k3xx/s32k3xx_edma.c: ## @@ -916,18 +902,12 @@ void weak_function arm_dma_initialize(void) /* Initialize data structures */ -

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011142297 ## arch/arm/src/sam34/sam_twi.c: ## @@ -187,14 +187,6 @@ static void twi_hw_initialize(struct twi_dev_s *priv, unsigned int pid, * Private Data ***

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011144704 ## arch/arm/src/sam34/sam_twi.c: ## @@ -917,12 +934,7 @@ struct i2c_master_s *sam_i2cbus_initialize(int bus) #ifdef CONFIG_SAM34_TWIM1 if (bus == 1)

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011146474 ## arch/arm/src/sama5/sam_adc.c: ## @@ -497,11 +497,20 @@ static const struct adc_ops_s g_adcops = /* ADC internal state */ -static struct sam_adc_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011147988 ## arch/arm/src/sama5/sam_adc.c: ## @@ -2041,17 +2050,9 @@ struct adc_dev_s *sam_adc_initialize(void) /* Initialize the public ADC device data st

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

xiaoxiang781216 commented on code in PR #7472: URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011149329 ## arch/arm/src/sama5/sam_can.c: ## @@ -287,8 +287,17 @@ static const struct sam_config_s g_can0const = }, }; -static struct sam_can_s g_can0priv;

  1   2   >