[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
xiaoxiang781216 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960287712 ## fs/procfs/fs_procfsmeminfo.c: ## @@ -578,6 +578,11 @@ static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf) void procfs_register_

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
masayuki2009 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960288984 ## fs/procfs/fs_procfsmeminfo.c: ## @@ -578,6 +578,11 @@ static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf) void procfs_register_mem

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6956: net/tcp: use independent work to free the conn instance

2022-09-01 Thread GitBox
xiaoxiang781216 commented on PR #6956: URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1233839252 @fjpanag do you have any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6977: sim: add usrsocktest config to detect the regression issue

2022-09-01 Thread GitBox
masayuki2009 commented on PR #6977: URL: https://github.com/apache/incubator-nuttx/pull/6977#issuecomment-1233920234 @anchao Please rebase this PR to the latest master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-09-01 Thread GitBox
XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r960360686 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2484 @@ +/ + * drivers/mtd/mtd_con

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-09-01 Thread GitBox
XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r960366396 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2484 @@ +/ + * drivers/mtd/mtd_con

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-09-01 Thread GitBox
XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r960372923 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2484 @@ +/ + * drivers/mtd/mtd_con

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-09-01 Thread GitBox
XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r960379975 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2484 @@ +/ + * drivers/mtd/mtd_con

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-09-01 Thread GitBox
XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r960401262 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2484 @@ +/ + * drivers/mtd/mtd_con

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
xiaoxiang781216 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960436028 ## fs/procfs/fs_procfsmeminfo.c: ## @@ -578,6 +578,11 @@ static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf) void procfs_register_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
xiaoxiang781216 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960436630 ## mm/umm_heap/umm_initialize.c: ## @@ -81,7 +81,11 @@ void umm_initialize(FAR void *heap_start, size_t heap_size) { +#ifdef CONFIG_BUILD_KERNEL Rev

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
xiaoxiang781216 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960436630 ## mm/umm_heap/umm_initialize.c: ## @@ -81,7 +81,11 @@ void umm_initialize(FAR void *heap_start, size_t heap_size) { +#ifdef CONFIG_BUILD_KERNEL Rev

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
masayuki2009 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960450614 ## mm/umm_heap/umm_initialize.c: ## @@ -81,7 +81,11 @@ void umm_initialize(FAR void *heap_start, size_t heap_size) { +#ifdef CONFIG_BUILD_KERNEL Review

[GitHub] [incubator-nuttx] fjpanag commented on pull request #6956: net/tcp: use independent work to free the conn instance

2022-09-01 Thread GitBox
fjpanag commented on PR #6956: URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1234043050 @xiaoxiang781216 Sorry I need more time. I haven't finished with the tests yet. I also have one device that has crashed again, but I haven't got it in my hands yet (its on

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6983: compiler.h: Rename inline_function to always_inline_function

2022-09-01 Thread GitBox
xiaoxiang781216 opened a new pull request, #6983: URL: https://github.com/apache/incubator-nuttx/pull/6983 ## Summary reserve inline_function macro for inline keyword ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-09-01 Thread GitBox
XinStellaris commented on code in PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r960469471 ## drivers/mtd/mtd_config_fs.c: ## @@ -0,0 +1,2484 @@ +/ + * drivers/mtd/mtd_con

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
xiaoxiang781216 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960478907 ## mm/umm_heap/umm_initialize.c: ## @@ -81,7 +81,11 @@ void umm_initialize(FAR void *heap_start, size_t heap_size) { +#ifdef CONFIG_BUILD_KERNEL Rev

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
xiaoxiang781216 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960478907 ## mm/umm_heap/umm_initialize.c: ## @@ -81,7 +81,11 @@ void umm_initialize(FAR void *heap_start, size_t heap_size) { +#ifdef CONFIG_BUILD_KERNEL Rev

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
masayuki2009 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960508701 ## fs/procfs/fs_procfsmeminfo.c: ## @@ -578,6 +578,11 @@ static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf) void procfs_register_mem

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
masayuki2009 commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r960511132 ## fs/procfs/fs_procfsmeminfo.c: ## @@ -578,6 +578,11 @@ static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf) void procfs_register_mem

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
hartmannathan commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r960597990 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ +

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
pkarashchenko commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r960780379 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ +

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
pkarashchenko commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r960783420 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ +

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
hartmannathan commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r960785424 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ +

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
hartmannathan commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r960789456 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ +

[GitHub] [incubator-nuttx] rajvindervirk opened a new pull request, #6984: stm32h7\stm32_fdcan_sock: fix the FDCAN_LOOPBACK config macros

2022-09-01 Thread GitBox
rajvindervirk opened a new pull request, #6984: URL: https://github.com/apache/incubator-nuttx/pull/6984 ## Summary The names of the macros STM32H7_FDCAN_LOOPBACK and STM32H7_FDCAN_LOOPBACK_INTERNAL do not match with the corresponding macro names in KConfig. As a result, when these macr

[GitHub] [incubator-nuttx] acassis commented on issue #6938: Nuttx not installing correctly on the Particle Photon.

2022-09-01 Thread GitBox
acassis commented on issue #6938: URL: https://github.com/apache/incubator-nuttx/issues/6938#issuecomment-1234791865 Hi @greg5678 sorry I only saw your issue today. Did you search to know what the yellow blinking means? Last time I tested Particle Photon was with NuttX 8.x, I need to tes

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
pkarashchenko merged PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx] branch master updated (63cd44e5e1 -> fb0cb6f270)

2022-09-01 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 63cd44e5e1 net/usrsock: forward FIONBIO to socket level new 27985fa639 fs: procfs: Skip to regist

[incubator-nuttx] 01/02: fs: procfs: Skip to register for meminfo if the name is NULL

2022-09-01 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 27985fa639d8c1d4babe981d3c44e99a27efabb3 Author: Masayuki Ishikawa AuthorDate: Thu Sep 1 09:47:30 2022 +

[incubator-nuttx] 02/02: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit fb0cb6f270ee746739dacc46381192c2bfc998f9 Author: Masayuki Ishikawa AuthorDate: Thu Sep 1 15:44:02 2022 +

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6979: mm: umm_heap: Do not register Umem if CONFIG_BUILD_KERNEL=y

2022-09-01 Thread GitBox
pkarashchenko commented on code in PR #6979: URL: https://github.com/apache/incubator-nuttx/pull/6979#discussion_r961115879 ## fs/procfs/fs_procfsmeminfo.c: ## @@ -578,6 +578,11 @@ static int meminfo_stat(FAR const char *relpath, FAR struct stat *buf) void procfs_register_me

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6976: fs: Run the default action of FIONBIO/FIOCLEX/FIONCLEX in success path

2022-09-01 Thread GitBox
pkarashchenko commented on code in PR #6976: URL: https://github.com/apache/incubator-nuttx/pull/6976#discussion_r961117930 ## fs/vfs/fs_ioctl.c: ## @@ -67,53 +67,52 @@ int file_vioctl(FAR struct file *filep, int req, va_list ap) ret = inode->u.i_ops->ioctl(filep, req, ar

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
pkarashchenko commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r961118937 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ +

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6978: net: Align the prototype of sock_intf_s::si_ioctl with file_operations::ioctl

2022-09-01 Thread GitBox
pkarashchenko commented on PR #6978: URL: https://github.com/apache/incubator-nuttx/pull/6978#issuecomment-1234817468 Please rebase and fix build issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] greg5678 commented on issue #6938: Nuttx not installing correctly on the Particle Photon.

2022-09-01 Thread GitBox
greg5678 commented on issue #6938: URL: https://github.com/apache/incubator-nuttx/issues/6938#issuecomment-1234827316 Yes, so it blinking yellow means it's in DFU mode. I made a couple of posts about it on Particle's forum, and they recommend I downgrade it to 0.5.5, but that didn't help.

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6977: sim: add usrsocktest config to detect the regression issue

2022-09-01 Thread GitBox
masayuki2009 merged PR #6977: URL: https://github.com/apache/incubator-nuttx/pull/6977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-nuttx] branch master updated: sim: add usrsocktest config to detect the regression issue

2022-09-01 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 42d553c6d4 sim: add usrsocktest confi

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 42d553c6d4add365d458cc85f7f614443a1b3eb3

2022-09-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new c23335c Publishing web

[GitHub] [incubator-nuttx] zyfeier commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
zyfeier commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r961221199 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ + tm

[GitHub] [incubator-nuttx] nealef commented on issue #6941: Wrong calculations by pow()

2022-09-01 Thread GitBox
nealef commented on issue #6941: URL: https://github.com/apache/incubator-nuttx/issues/6941#issuecomment-1234974722 Just to add to the libm discussion and motivations for libmCS: https://github.com/apache/incubator-nuttx/issues/6767 -- This is an automated message from the Apache Git Ser

[GitHub] [incubator-nuttx] shn1233 commented on pull request #4367: riscv/backtrace: add up_backtrace support

2022-09-01 Thread GitBox
shn1233 commented on PR #4367: URL: https://github.com/apache/incubator-nuttx/pull/4367#issuecomment-1234987748 **-Does riscv only support the backtrace function after opening the macro ARCH_HAVE_BACKTRACE?** When I only enable SCHED_BACKTRACE, enter the function sched_backtrace->_U

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4367: riscv/backtrace: add up_backtrace support

2022-09-01 Thread GitBox
xiaoxiang781216 commented on PR #4367: URL: https://github.com/apache/incubator-nuttx/pull/4367#issuecomment-1235002818 we just run frame base backtrace before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6984: stm32h7\stm32_fdcan_sock: fix the FDCAN_LOOPBACK config macros

2022-09-01 Thread GitBox
xiaoxiang781216 merged PR #6984: URL: https://github.com/apache/incubator-nuttx/pull/6984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: stm32h7\stm32_fdcan_sock: fix the FDCAN_LOOPBACK config macros

2022-09-01 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 27fbca771f stm32h7\stm32_fdcan_sock:

[GitHub] [incubator-nuttx] no1wudi opened a new issue, #6985: Shift out of bounds on ESP32-C3

2022-09-01 Thread GitBox
no1wudi opened a new issue, #6985: URL: https://github.com/apache/incubator-nuttx/issues/6985 Enable CONFIG_MM_UBSAN and disable CONFIG_MM_UBSAN_TRAP_ON_ERROR in esp32c3-devkit:nsh, and then we get: ``` ubsan_prologue: ==

[GitHub] [incubator-nuttx] no1wudi commented on issue #6985: Shift out of bounds on ESP32-C3

2022-09-01 Thread GitBox
no1wudi commented on issue #6985: URL: https://github.com/apache/incubator-nuttx/issues/6985#issuecomment-1235010563 @gustavonihei Could you take a look for it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6966: nuttx/queue: Change some queue function to macro

2022-09-01 Thread GitBox
xiaoxiang781216 commented on code in PR #6966: URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r961257526 ## include/queue.h: ## @@ -67,6 +67,223 @@ } \ while (0) +#define sq_addfirst(p, q) \ + do \ +{ \ + FAR sq_entry_t *tmp_node = p; \ +

[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6986: UBSan: Allow custom the sanitizer in Kconfig

2022-09-01 Thread GitBox
no1wudi opened a new pull request, #6986: URL: https://github.com/apache/incubator-nuttx/pull/6986 ## Summary New option only ## Impact None ## Testing CI and custom board -- This is an automated message from the Apache Git Service. To respond to the message, please log