xiaoxiang781216 opened a new pull request, #6958:
URL: https://github.com/apache/incubator-nuttx/pull/6958
## Summary
it inappropriate to apply volatile to the task list:
1.The code access task list is already protected by critical section
2.The queue is complex struct, it isn't enou
XinStellaris commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r958081982
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2652 @@
+/
+ * drivers/mtd/mtd_con
xiaoxiang781216 commented on PR #6926:
URL: https://github.com/apache/incubator-nuttx/pull/6926#issuecomment-1231258712
> In general looks good, but the main difference inline from define is that
inlining is done based on compiler decision and with define we have inlining
unconditionally.
pkarashchenko commented on PR #6958:
URL: https://github.com/apache/incubator-nuttx/pull/6958#issuecomment-1231268050
@xiaoxiang781216 the PR description states about "protection by volatile",
but volatile just ensures that structure members are always fetched from
memory. But in general I
pkarashchenko commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1231271094
I see that we are going back and forth with removing and adding cls work
@anchao do you recall why it was removed last time?
--
This is an automated message from the Apac
pkarashchenko merged PR #6862:
URL: https://github.com/apache/incubator-nuttx/pull/6862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from f93964ad3c riscv: Dump trap val in exception handler
add 1b04bfae20 sched: Remove the unnecessary
pkarashchenko commented on code in PR #6955:
URL: https://github.com/apache/incubator-nuttx/pull/6955#discussion_r958120808
##
boards/risc-v/esp32c3/esp32c3-devkit-rust-1/src/Makefile:
##
@@ -41,6 +41,18 @@ ifeq ($(CONFIG_BOARDCTL_IOCTL),y)
CSRCS += esp32c3_ioctl.c
endif
+if
anchao commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1231279901
> I see that we are going back and forth with removing and adding cls work
@anchao do you recall why it was removed last time?
The resource consumption of network has increa
xiaoxiang781216 commented on PR #6958:
URL: https://github.com/apache/incubator-nuttx/pull/6958#issuecomment-1231282191
> @xiaoxiang781216 the PR description states about "protection by volatile",
but volatile just ensures that structure members are always fetched from
memory. But in genera
no1wudi opened a new pull request, #6959:
URL: https://github.com/apache/incubator-nuttx/pull/6959
## Summary
* Add a new attribute nosanitize_undefined
* Fix wrong report by design:
```
ubsan_prologue:
=
xiaoxiang781216 commented on code in PR #6959:
URL: https://github.com/apache/incubator-nuttx/pull/6959#discussion_r958178275
##
libs/libc/symtab/symtab_allsyms.c:
##
@@ -43,6 +43,7 @@ extern const int g_nallsyms;
*
***
fjpanag commented on PR #6947:
URL: https://github.com/apache/incubator-nuttx/pull/6947#issuecomment-1231382769
I did lot's of testing on this, both manually and stress tests. I tested
various error conditions.
No crashes anymore.
I noticed that `tcp_close_eventhandler()` is not
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1231385176
@anchao I will be glad to test this, but it will take me some time. Maybe
till the evening or tomorrow morning.
Please wait for my results, I will comment here.
--
This i
fjpanag opened a new issue, #6960:
URL: https://github.com/apache/incubator-nuttx/issues/6960
A while back I studied the implementation of `CONFIG_NET_ALLOC_CONNS`, and I
saw some things that seemed strange to me.
I would like to discuss my thoughts, being motivated by #6956.
I
XinStellaris commented on code in PR #1288:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1288#discussion_r958241651
##
testing/mtd_config_fs/mtd_config_fs_test_main.c:
##
@@ -0,0 +1,2040 @@
+/**
fjpanag commented on issue #6960:
URL:
https://github.com/apache/incubator-nuttx/issues/6960#issuecomment-1231415692
Personally I think I would prefer us to ditch the `CONFIG_NET_ALLOC_CONNS`
option completely.
Always have a poll of statically allocated structs, for example using
op
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1231416441
@anchao FYI see issue #6960.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
ethanlcz commented on PR #6949:
URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1231488064
> @ethanlcz I tried this PR with spresense:wifi_smp but it does not work.
>
> ```
> NuttShell (NSH)
> nsh> uname -a
> NuttX 0.0.0 6bb1c0902d Aug 30 2022 14:01:59 a
xiaoxiang781216 commented on issue #6960:
URL:
https://github.com/apache/incubator-nuttx/issues/6960#issuecomment-1231489177
If you like allocate/free every time when the pool is exhausted and don't
care about the fragmentation. We can simply do this special action by checking
`CONFIG_NET_
fjpanag commented on PR #6954:
URL: https://github.com/apache/incubator-nuttx/pull/6954#issuecomment-1231496014
@hartmannathan I had a look, and it seems perfect.
I did try all the test strings on `strtof()` and `strtold()` and they all
succeeded.
--
This is an automated message fr
fjpanag commented on issue #6960:
URL:
https://github.com/apache/incubator-nuttx/issues/6960#issuecomment-1231500115
> If you like allocate/free every time when the pool is exhausted and don't
care about the fragmentation. We can simply do this special action by checking
`CONFIG_NET_ALLOC_
hartmannathan commented on PR #6954:
URL: https://github.com/apache/incubator-nuttx/pull/6954#issuecomment-1231527162
> @hartmannathan I had a look, and it seems perfect.
>
>
>
> I did try all the test strings on `strtof()` and `strtold()` and they all
succeeded.
@fjpan
xiaoxiang781216 commented on issue #6960:
URL:
https://github.com/apache/incubator-nuttx/issues/6960#issuecomment-1231539487
I mean you can kmm_free directly in case of `ONFIG_NET_ALLOC_CONNS == 1` not
to the pool.
--
This is an automated message from the Apache Git Service.
To respond t
xiaoxiang781216 merged PR #6959:
URL: https://github.com/apache/incubator-nuttx/pull/6959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 28872ca3edbc5237917e8c25a172fc80edf14b64
Author: Huang Qi
AuthorDate: Tue Aug 30 08:23:13 2022 +
li
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 1b04bfae20 sched: Remove the unnecessary weak_function
new 7e316d0ba9 compiler.h: Add a new attribute
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7e316d0ba9c7f9fcd17fcb41b87ad9dbc3c7ca3b
Author: Huang Qi
AuthorDate: Tue Aug 30 08:15:58 2022 +
co
xiaoxiang781216 merged PR #6947:
URL: https://github.com/apache/incubator-nuttx/pull/6947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new bf6cbbca5d net/tcp: fix devif callba
fjpanag opened a new pull request, #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961
## Summary
Various prints produced compiler warnings, because of wrong specifiers used,
or wrong types.
This PR fixes these warnings.
## Impact
Code builds without war
xiaoxiang781216 commented on code in PR #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961#discussion_r958373615
##
mm/kasan/kasan.c:
##
@@ -101,7 +101,8 @@ static void kasan_report(FAR const void *addr, size_t size,
bool is_write)
if (++recursion == 1)
{
fjpanag commented on code in PR #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961#discussion_r958375925
##
mm/kasan/kasan.c:
##
@@ -101,7 +101,8 @@ static void kasan_report(FAR const void *addr, size_t size,
bool is_write)
if (++recursion == 1)
{
_a
masayuki2009 opened a new pull request, #6962:
URL: https://github.com/apache/incubator-nuttx/pull/6962
## Summary
- This PR contains the following 2 commits.
- commit1: arch: risc-v: Assign dedicated virtual addresses for text and
heap
- Current RISC-V/NuttX implementatio
xiaoxiang781216 merged PR #6962:
URL: https://github.com/apache/incubator-nuttx/pull/6962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0ba9d8e9f5cef9e325a90035158fd7fefb3c8875
Author: Masayuki Ishikawa
AuthorDate: Tue Aug 30 21:05:55 2022 +090
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e2f0f431d96f16085d253c53cad585632af3e5bf
Author: Masayuki Ishikawa
AuthorDate: Tue Aug 30 20:54:16 2022 +090
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from bf6cbbca5d net/tcp: fix devif callback list corruption on tcp_close()
new e2f0f431d9 arch: risc-v: As
xiaoxiang781216 merged PR #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 484bdc54d3 Fixed warnings in various
gustavonihei commented on code in PR #6955:
URL: https://github.com/apache/incubator-nuttx/pull/6955#discussion_r958599597
##
boards/risc-v/esp32c3/esp32c3-devkit-rust-1/src/esp32c3_apa102.c:
##
@@ -0,0 +1,109 @@
+/
xiaoxiang781216 commented on PR #6958:
URL: https://github.com/apache/incubator-nuttx/pull/6958#issuecomment-1232002748
> But if the generated code is the same then why do we need the change ;)
avoid the cast to remove volatile which will be in the next PR.
--
This is an automated m
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232045297
I had one case were one thread stuck indefinitely within a `connect()` call.
During the incident, all other tasks could be seen idling. It was not a
dead-lock.
I am no
acassis commented on code in PR #6955:
URL: https://github.com/apache/incubator-nuttx/pull/6955#discussion_r958834870
##
boards/risc-v/esp32c3/esp32c3-devkit-rust-1/src/Makefile:
##
@@ -41,6 +41,18 @@ ifeq ($(CONFIG_BOARDCTL_IOCTL),y)
CSRCS += esp32c3_ioctl.c
endif
+ifeq ($(
xiaoxiang781216 commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232071598
Does your netdev still work in this case? it look like psock_tcp_connect
can't receive any important event inside psock_connect_eventhandler.
--
This is an automated mes
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232084111
> Does your netdev still work in this case? it look like psock_tcp_connect
can't receive any important event inside psock_connect_eventhandler.
Yes, during the incident anot
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232086596
I also removed and re-plugged the Ethernet during this. This has as a result
a pair of calls to ifdown/ifup. The rest of the system behaved correctly, while
this thread remained s
xiaoxiang781216 commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232091028
In this case, do you receive NETDEV_DOWN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232097455
In my case `CONFIG_NETDOWN_NOTIFIER` is disabled.
I don't know if it is related, but `tcp_close_eventhandler()` is still not
called every time a socket is closed. Only some
xiaoxiang781216 commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232108316
> In my case `CONFIG_NETDOWN_NOTIFIER` is disabled.
>
> I don't know if it is related, but `tcp_close_eventhandler()` is still not
called every time a socket is clos
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232114674
> If you don't close the socket by self, and unplug the netdev without
CONFIG_NETDOWN_NOTIFIER, nobody can notify you. Does the problem disappear
without this patch?
The so
xiaoxiang781216 commented on PR #6958:
URL: https://github.com/apache/incubator-nuttx/pull/6958#issuecomment-1232149929
@pkarashchenko I add a new patch remove the unnecessary cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232200183
I managed to cause the issue with the stuck thread again. Here is how I did
it.
My setup has as follows:
```mermaid
graph LR
A[Device] -->|Ethernet A| B
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232236729
Repeating the experiment multiple times I got a failed assertion @
`tcp/tcp_conn.c`, line 770.
Worker A:
 were added to refs/heads/asf-site by this push:
new e0fae8a Publishing web
xiaoxiang781216 merged PR #6963:
URL: https://github.com/apache/incubator-nuttx/pull/6963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new b7063427c8 arch: risc-v: Fix up_chec
xiaoxiang781216 merged PR #6955:
URL: https://github.com/apache/incubator-nuttx/pull/6955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from b7063427c8 arch: risc-v: Fix up_check_tcbstack() for
CONFIG_ARCH_ADDRENV=y
add 4744810bfd esp32c3/bo
yamt opened a new pull request, #6964:
URL: https://github.com/apache/incubator-nuttx/pull/6964
## Summary
* Update WAMR version
* Enable CONFIG_INTERPRETERS_WAMR_DEBUG_INTERP
(TCP related config changes in this commit are for this)
* Enable CONFIG_MM_DUMP_ON_FAILURE
XinStellaris commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r959076767
##
boards/risc-v/esp32c3/esp32c3-devkit/configs/nvcfgdata/defconfig:
##
@@ -0,0 +1,50 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You
XinStellaris commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r959077188
##
boards/risc-v/esp32c3/esp32c3-devkit/configs/nvcfgdata/defconfig:
##
@@ -0,0 +1,50 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You
anjiahao1 opened a new pull request, #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965
Signed-off-by: anjiahao
## Summary
[pull5070](https://github.com/apache/incubator-nuttx/pull/5070)
this is step 2，then change sem defult behavior
## Impact
schedule
## T
anchao commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1232422666
> Repeating the experiment multiple times I got a failed assertion @
`tcp/tcp_conn.c`, line 770.
@fjpanag ,
Thanks a lot for your detailed analysis! From the callstack
xiaoxiang781216 merged PR #6964:
URL: https://github.com/apache/incubator-nuttx/pull/6964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new d252b0b430 esp32-devkitc/wamr_wasi_d
anjiahao1 commented on PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1232431554
this error can't fix
--
This is an automated message from t
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch releases/11.0
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
at 53800a8657 sim: Fix the /etc/passwd after TEA algo fixing
No new revisions were added by this upda
ethanlcz commented on PR #6949:
URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1232438122
> > @ethanlcz I tried this PR with spresense:wifi_smp but it does not work.
> > ```
> > NuttShell (NSH)
> > nsh> uname -a
> > NuttX 0.0.0 6bb1c0902d Aug 30 2022 14:01:
masayuki2009 commented on PR #6949:
URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1232447185
@ethanlcz
Can you try to add `CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10C=y` to
defconfig?
If it still does not work, try
`CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_
ethanlcz commented on PR #6949:
URL: https://github.com/apache/incubator-nuttx/pull/6949#issuecomment-1232474661
> gs2200m
Thanks Masayuki !
It works after set "CONFIG_WIFI_BOARD_IS110B_HARDWARE_VERSION_10C=y".
--
This is an automated message from the Apache Git Service.
To r
zyfeier opened a new pull request, #6966:
URL: https://github.com/apache/incubator-nuttx/pull/6966
## Summary
Modify queue function to macro for performance.
## Impact
before:
```
text data bss dec hex filename
109708 224 2
79 matches
Mail list logo
