[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1286: industry/foc foc_ident: improve flux linkage identification method

2022-08-20 Thread GitBox
xiaoxiang781216 commented on code in PR #1286: URL: https://github.com/apache/incubator-nuttx-apps/pull/1286#discussion_r950660191 ## include/industry/foc/float/foc_ident.h: ## @@ -48,6 +48,10 @@ struct foc_routine_ident_cb_f32_s FAR void *priv_speed; + /* Private data

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6885: Make the full image instrumentation configurable

2022-08-20 Thread GitBox
xiaoxiang781216 opened a new pull request, #6885: URL: https://github.com/apache/incubator-nuttx/pull/6885 ## Summary since it isn't possible to instrument the full image due to the size or speed limitation. - mm/kasan: Add MM_KASAN_ALL option - arch: Add ARCH_COVERAGE_ALL o

[GitHub] [incubator-nuttx] standby24x7 opened a new pull request, #6886: rp2040: Add missing comma in rp2040_i2c_slave.c

2022-08-20 Thread GitBox
standby24x7 opened a new pull request, #6886: URL: https://github.com/apache/incubator-nuttx/pull/6886 This patch fixes missing comma, found by cppcheck. rp2040_i2c_slave.c:259:0: error: failed to expand 'modbits_reg32', Wrong number of parameters for macro 'modbits_reg32'.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6881: debug: Introduce portion of UBSan for arm/risc-v

2022-08-20 Thread GitBox
xiaoxiang781216 commented on code in PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#discussion_r950661893 ## mm/Kconfig: ## @@ -191,6 +191,49 @@ config MM_KASAN bugs in native code. After turn on this option, Please add -fsanit

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6886: rp2040: Add missing comma in rp2040_i2c_slave.c

2022-08-20 Thread GitBox
xiaoxiang781216 commented on PR #6886: URL: https://github.com/apache/incubator-nuttx/pull/6886#issuecomment-1221251337 @standby24x7 is it possible to integrate cppcheck(or even https://github.com/Ericsson/codechecker) to CI system so we can catch the problem before merging? -- This is a

[GitHub] [incubator-nuttx-apps] zouboan closed pull request #1286: industry/foc foc_ident: improve flux linkage identification method

2022-08-20 Thread GitBox
zouboan closed pull request #1286: industry/foc foc_ident: improve flux linkage identification method URL: https://github.com/apache/incubator-nuttx-apps/pull/1286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx-apps] zouboan opened a new pull request, #1287: industry/foc foc_ident: improve flux linkage identification method

2022-08-20 Thread GitBox
zouboan opened a new pull request, #1287: URL: https://github.com/apache/incubator-nuttx-apps/pull/1287 ## Summary 1. change flux linkage identification from V/F openloop to I/F openloop to solve the problem of some motors fail to start on V/F openloop; 2. reset FOC ident routine state

[GitHub] [incubator-nuttx-apps] zouboan commented on pull request #1286: industry/foc foc_ident: improve flux linkage identification method

2022-08-20 Thread GitBox
zouboan commented on PR #1286: URL: https://github.com/apache/incubator-nuttx-apps/pull/1286#issuecomment-1221257288 @xiaoxiang781216 sorry, my local branch is not synchronized with the master branch , and the rebase info becomes a mess and various errors, so i'm close this PR, and start a

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6886: rp2040: Add missing comma in rp2040_i2c_slave.c

2022-08-20 Thread GitBox
xiaoxiang781216 merged PR #6886: URL: https://github.com/apache/incubator-nuttx/pull/6886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: rp2040: Add missing comma in rp2040_i2c_slave.c

2022-08-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new bd584332a4 rp2040: Add missing comma

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6884: arch/ceva: Add missing comma

2022-08-20 Thread GitBox
xiaoxiang781216 merged PR #6884: URL: https://github.com/apache/incubator-nuttx/pull/6884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: arch/ceva: Add missing comma

2022-08-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 49c50d3bf4 arch/ceva: Add missing co

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1286: industry/foc foc_ident: improve flux linkage identification method

2022-08-20 Thread GitBox
xiaoxiang781216 commented on PR #1286: URL: https://github.com/apache/incubator-nuttx-apps/pull/1286#issuecomment-1221260669 Sure no problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1287: industry/foc foc_ident: improve flux linkage identification method

2022-08-20 Thread GitBox
pkarashchenko commented on code in PR #1287: URL: https://github.com/apache/incubator-nuttx-apps/pull/1287#discussion_r950692495 ## industry/foc/float/foc_ident.c: ## @@ -650,12 +653,23 @@ int foc_routine_ident_run_f32(FAR foc_routine_f32_t *r, break; } -

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 49c50d3bf4c987697e6e95886332cd0cb4a17e39

2022-08-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 1bd14df Publishing web

[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6881: debug: Introduce portion of UBSan for arm/risc-v

2022-08-20 Thread GitBox
no1wudi commented on code in PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#discussion_r950792510 ## mm/Kconfig: ## @@ -191,6 +191,49 @@ config MM_KASAN bugs in native code. After turn on this option, Please add -fsanitize=kern

[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6881: debug: Introduce portion of UBSan for arm/risc-v

2022-08-20 Thread GitBox
no1wudi commented on code in PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#discussion_r950793545 ## mm/ubsan/ubsan.c: ## @@ -0,0 +1,302 @@ +/ + * mm/ubsan/ubsan.c + * + * Licensed to

[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6881: debug: Introduce portion of UBSan for arm/risc-v

2022-08-20 Thread GitBox
no1wudi commented on code in PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#discussion_r950793625 ## mm/ubsan/ubsan.c: ## @@ -0,0 +1,302 @@ +/ + * mm/ubsan/ubsan.c + * + * Licensed to