xiaoxiang781216 merged PR #6523:
URL: https://github.com/apache/incubator-nuttx/pull/6523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new c3b84b9b3b wireless/bcm43xxx: remove
xiaoxiang781216 commented on PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#issuecomment-1166448088
please rebase the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pkarashchenko merged PR #6522:
URL: https://github.com/apache/incubator-nuttx/pull/6522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new c6c0baa233 Added configuration f
normanr commented on PR #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1166455202
fyi: I tried to use this code (adding a `dhcpc` daemon based on the `ntpc`
daemon), but it has a couple of nasty bugs:
- it doesn't renew dhcp leases, but rather does full r
anchao commented on PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#issuecomment-1166455686
> please rebase the code
Done, please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
xiaoxiang781216 commented on PR #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1166462314
> fyi: I tried to use this code (adding a `dhcpc` daemon based on the `ntpc`
daemon), but it has a couple of nasty bugs:
>
> * it doesn't renew dhcp leases, but
xiaoxiang781216 commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906782823
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##
@@ -376,8 +374,10 @@ int bcmf_sdpcm_sendframe(FAR struct bcmf_dev_s *priv)
DEBUGPANIC();
anchao commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906792385
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##
@@ -317,7 +316,7 @@ int bcmf_sdpcm_readframe(FAR struct bcmf_dev_s *priv)
DEBUGPANIC();
anchao commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906792447
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##
@@ -1065,14 +1063,20 @@ struct bcmf_sdio_frame *bcmf_sdio_allocate_frame(FAR
struct bcmf_dev_s *priv,
pkarashchenko commented on PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#issuecomment-1166487810
@qinwei2004 you can fix only critical items like `assert(1)` and `psci_fn`
and other style issues can be fixed in the next PR
--
This is an automated message from the Apac
anchao commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906793379
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c:
##
@@ -1077,17 +1078,12 @@ struct bcmf_sdio_frame *bcmf_sdio_allocate_frame(FAR
struct bcmf_dev_s *priv,
yunkya2 commented on issue #6507:
URL:
https://github.com/apache/incubator-nuttx/issues/6507#issuecomment-1166495177
Hi, @acassis
The mass storage error seems not related to the issue.
I found that the change 9140693 is the root cause. By reverting this change,
I confirmed raspberryp
pkarashchenko commented on issue #6483:
URL:
https://github.com/apache/incubator-nuttx/issues/6483#issuecomment-1166500483
Unfortunately no. I've been working with SAMe70 based board that does not
have USB interface
--
This is an automated message from the Apache Git Service.
To respond
xiaoxiang781216 commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906802762
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##
@@ -317,7 +316,7 @@ int bcmf_sdpcm_readframe(FAR struct bcmf_dev_s *priv)
DEBUGPANIC
zouboan opened a new pull request, #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525
## Summary
1. add lower half support of capture for stm32_capture, because there's no
external interface for device driver in stm32_capture.c;
2. add support of pwm input capture driver i
xiaoxiang781216 commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906813067
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##
@@ -141,102 +141,75 @@ int bcmf_sdpcm_readframe(FAR struct bcmf_dev_s *priv)
uint16_t len;
yunkya2 opened a new pull request, #6526:
URL: https://github.com/apache/incubator-nuttx/pull/6526
## Summary
In #6465, the new member `struct lcd_dev_s *dev` is added to `struct
lcd_planeinfo_s`.
The member must be initialized in getplaneinfo method. But ST7789, ST7768
and skeleton L
yunkya2 commented on issue #6507:
URL:
https://github.com/apache/incubator-nuttx/issues/6507#issuecomment-1166543562
I found the problem and fixed in #6526.
Now I confirmed `raspberrypi-pico:displaypack` works fine.
I think waveshare-lcd-1.14 also works because it has same LCD controll
anchao commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906824994
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##
@@ -141,102 +141,75 @@ int bcmf_sdpcm_readframe(FAR struct bcmf_dev_s *priv)
uint16_t len;
uint16_t
anchao commented on code in PR #6524:
URL: https://github.com/apache/incubator-nuttx/pull/6524#discussion_r906825532
##
drivers/wireless/ieee80211/bcm43xxx/bcmf_sdpcm.c:
##
@@ -141,102 +141,75 @@ int bcmf_sdpcm_readframe(FAR struct bcmf_dev_s *priv)
uint16_t len;
uint16_t
pkarashchenko commented on issue #6310:
URL:
https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1166561982
I've been thinking about this issue on the background and I think I know how
to solve it by keeping code efficiency. Will try to work on this next week and
come with s
xiaoxiang781216 commented on code in PR #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525#discussion_r906840369
##
drivers/timers/capture.c:
##
@@ -0,0 +1,377 @@
+/
+ * drivers/timers/captu
pkarashchenko commented on PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#issuecomment-1166622070
Seems that the rebase is done in a wrong way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
pkarashchenko closed issue #6507: raspiberrypi-pico reporting Mass Storage
error after nuttx.uf2 was flashed
URL: https://github.com/apache/incubator-nuttx/issues/6507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
pkarashchenko merged PR #6526:
URL: https://github.com/apache/incubator-nuttx/pull/6526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f3dbc7bc63 drivers/lcd: getplane
normanr commented on PR #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1166643120
> > * you can't start `dhcpc_request_async` from `netinit_net_bringup`, and
later call `dhcpc_close` from nsh:
> > * the socket isn't closed properly, not sure why (it wor
acassis commented on PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#issuecomment-1166643950
> Seems that the rebase is done in a wrong way.
What issue did you see? @adamkaliszan did you follow the documentation:
https://nuttx.apache.org/docs/latest/contributing/mak
normanr commented on code in PR #6154:
URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r906870581
##
net/tcp/tcp_conn.c:
##
@@ -49,6 +49,7 @@
#include
#include
#include
+#include
Review Comment:
Yea, I was just surprised that kernel code was callin
normanr commented on code in PR #4335:
URL: https://github.com/apache/incubator-nuttx/pull/4335#discussion_r906875320
##
arch/risc-v/src/bl602/bl602_netdev.c:
##
@@ -2120,10 +2122,12 @@ void bl602_net_event(int evt, int val)
case CODE_WIFI_ON_DISCONNECT:
do
acassis commented on issue #6507:
URL:
https://github.com/apache/incubator-nuttx/issues/6507#issuecomment-1166658870
Thank you very much @yunkya2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hartmannathan opened a new pull request, #6527:
URL: https://github.com/apache/incubator-nuttx/pull/6527
## Summary
Minor fixes in comments and Kconfig help text.
## Impact
Improves readability.
## Testing
No functional changes.
--
This is an automated me
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 65d4513 Publishing web
zouboan commented on code in PR #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525#discussion_r906900591
##
drivers/timers/capture.c:
##
@@ -0,0 +1,377 @@
+/
+ * drivers/timers/capture.c
+ *
zouboan commented on code in PR #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525#discussion_r906900591
##
drivers/timers/capture.c:
##
@@ -0,0 +1,377 @@
+/
+ * drivers/timers/capture.c
+ *
qinwei2004 commented on code in PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r906924373
##
arch/arm64/src/qemu/qemu_serial.c:
##
@@ -0,0 +1,856 @@
+/***
+ * arch/arm64/src/qe
curuvar opened a new pull request, #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528
## Summary
Added Board definition files for Adafruit KB2040 and Adafruit Feather RP2040.
Added NeoPixel driver that supports the upper-half/lower-half model for
RP2040.
This wa
curuvar opened a new pull request, #1211:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1211
## Summary
Example app using the neopixel driver that displays a rainbow pattern.
## Impact
Should not impact other apps.
## Testing
Tested app with singl
xiaoxiang781216 merged PR #6527:
URL: https://github.com/apache/incubator-nuttx/pull/6527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6057960331 Fix mistakes in comments
xiaoxiang781216 commented on code in PR #6525:
URL: https://github.com/apache/incubator-nuttx/pull/6525#discussion_r906943916
##
drivers/timers/capture.c:
##
@@ -0,0 +1,377 @@
+/
+ * drivers/timers/captu
xiaoxiang781216 commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r906946953
##
examples/neopixel/neopixel_main.c:
##
@@ -38,6 +38,196 @@
#include
+/*
xiaoxiang781216 commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1166806885
@nimish why close this PR? will you create a new one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
btashton commented on PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#issuecomment-1166819669
Seems like we should combine the two drivers, even if that means making some
changes to the existing one. neopixel is just a marketing name for the same
chip.
I wrote the
curuvar commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r906961866
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,106 @@
+/
+ * apps/examples
qinwei2004 commented on PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#issuecomment-1166838087
> @qinwei2004 you can fix only critical items like `assert(1)` and `psci_fn`
and other style issues can be fixed in the next PR
Please check again
--
This is an automa
curuvar commented on PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#issuecomment-1166844133
I agree that it would be better to use the more generic name. I didn't try
to work with the existing ws2812 as it is so closely wedded to SPI and I cannot
use SPI to drive the o
nimish commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1166848264
bizarre. no idea why this closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
SunJun8 commented on code in PR #4335:
URL: https://github.com/apache/incubator-nuttx/pull/4335#discussion_r907016676
##
arch/risc-v/src/bl602/bl602_netdev.c:
##
@@ -2120,10 +2122,12 @@ void bl602_net_event(int evt, int val)
case CODE_WIFI_ON_DISCONNECT:
do
xiaoxiang781216 commented on code in PR #1211:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1211#discussion_r907024774
##
examples/neopixel/neopixel_main.c:
##
@@ -0,0 +1,106 @@
+/
+ * apps/
xiaoxiang781216 commented on PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#issuecomment-1166943491
@nimish the change looks good now, but a minor style issue need be addressed
before merging:
https://github.com/apache/incubator-nuttx/runs/7067463510?check_suite_focus
53 matches
Mail list logo
