[GitHub] [incubator-nuttx] zouboan opened a new pull request, #6412: Fft 2

2022-06-12 Thread GitBox
zouboan opened a new pull request, #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6409: mm: Add mm_uninitialize to release the resource

2022-06-12 Thread GitBox
xiaoxiang781216 commented on PR #6409: URL: https://github.com/apache/incubator-nuttx/pull/6409#issuecomment-1153125278 @pkarashchenko could you merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6409: mm: Add mm_uninitialize to release the resource

2022-06-12 Thread GitBox
masayuki2009 merged PR #6409: URL: https://github.com/apache/incubator-nuttx/pull/6409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-nuttx] branch master updated: mm: Add mm_uninitialize to release the resource

2022-06-12 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 53c6789bef mm: Add mm_uninitialize to

[GitHub] [incubator-nuttx] mlyszczek opened a new pull request, #6413: Stm32wl5 exti

2022-06-12 Thread GitBox
mlyszczek opened a new pull request, #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413 ## Summary These patches add - support for GPIO EXTI for stm32wl5 chip. - support for buttons in nucleo board. - Please, also read commit message for each commit for explanatio

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
xiaoxiang781216 commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895178463 ## include/nuttx/sensors/as5048a.h: ## @@ -0,0 +1,146 @@ +/ + * include/nuttx

[GitHub] [incubator-nuttx] zouboan commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
zouboan commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895184729 ## drivers/sensors/as5048a.c: ## @@ -0,0 +1,632 @@ +/ + * drivers/sensors/as5048a.c +

[GitHub] [incubator-nuttx] zouboan commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
zouboan commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895184834 ## include/nuttx/sensors/as5048a.h: ## @@ -0,0 +1,146 @@ +/ + * include/nuttx/sensors

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6413: stm32wl5: add gpio exti support

2022-06-12 Thread GitBox
pkarashchenko commented on code in PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895217928 ## arch/arm/src/stm32wl5/hardware/stm32wl5_exti.h: ## @@ -103,4 +108,84 @@ #define EXTI2_RADIOBSY (1 << 14) /* EXTI line 45: Radio busy wakeup */ #d

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6320: use rmutex inside of all repeated implementation

2022-06-12 Thread GitBox
pkarashchenko commented on code in PR #6320: URL: https://github.com/apache/incubator-nuttx/pull/6320#discussion_r895219754 ## drivers/syslog/syslog_device.c: ## @@ -123,63 +120,6 @@ static const uint8_t g_syscrlf[2] = * Private Functions

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6414: mutex: Revert part of the changes introduced by cea7953a5623bd48ce1188ce7db9017f92dc0504

2022-06-12 Thread GitBox
pkarashchenko opened a new pull request, #6414: URL: https://github.com/apache/incubator-nuttx/pull/6414 ## Summary Revert part of the changes introduced by cea7953a5623bd48ce1188ce7db9017f92dc0504 dues to deadlock in syslog and introduction of cancellation points in kernel for FLAT mode

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6320: use rmutex inside of all repeated implementation

2022-06-12 Thread GitBox
pkarashchenko commented on code in PR #6320: URL: https://github.com/apache/incubator-nuttx/pull/6320#discussion_r895222450 ## drivers/syslog/syslog_device.c: ## @@ -123,63 +120,6 @@ static const uint8_t g_syscrlf[2] = * Private Functions

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
pkarashchenko commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895222657 ## drivers/sensors/as5048a.c: ## @@ -0,0 +1,632 @@ +/ + * drivers/sensors/as504

[GitHub] [incubator-nuttx] mlyszczek commented on pull request #6413: stm32wl5: add gpio exti support

2022-06-12 Thread GitBox
mlyszczek commented on PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#issuecomment-1153271192 Thanks for the review Petro, and your keen eye:) All issues should be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-nuttx-website] branch asf-site updated: Publishing web: 42e9e27963415ec1359277228669d6b9c71c48d1 docs: 53c6789bef5951525acc81464e9d97d2436717ee

2022-06-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new b601420 Publishing web

[GitHub] [incubator-nuttx] zouboan commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
zouboan commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895258486 ## include/nuttx/sensors/as5048a.h: ## @@ -0,0 +1,146 @@ +/ + * include/nuttx/sensors

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request, #6415: arch: k210: Add a workaround for clock stabilization

2022-06-12 Thread GitBox
masayuki2009 opened a new pull request, #6415: URL: https://github.com/apache/incubator-nuttx/pull/6415 ## Summary - I noticed that sometimes uart shows nothing on the maix-bit board. - This commit adds a workaround to avoid such the issue ## Impact - k210 only

[GitHub] [incubator-nuttx] zouboan commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
zouboan commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895262207 ## drivers/sensors/as5048a.c: ## @@ -0,0 +1,632 @@ +/ + * drivers/sensors/as5048a.c +

[GitHub] [incubator-nuttx] normanr opened a new pull request, #6416: Fix `CONFIG_ALLSYMS` for arm, risc-v and xtensa after #5496

2022-06-12 Thread GitBox
normanr opened a new pull request, #6416: URL: https://github.com/apache/incubator-nuttx/pull/6416 ## Summary As described at https://github.com/apache/incubator-nuttx/pull/5496#issuecomment-1094459216, the cleanup broke `CONFIG_ALLSYMS` for arm, risc-v and xtensa by including the linke

[GitHub] [incubator-nuttx] normanr commented on pull request #5750: net/udp: clear the connection structure after free

2022-06-12 Thread GitBox
normanr commented on PR #5750: URL: https://github.com/apache/incubator-nuttx/pull/5750#issuecomment-1153394170 How did you discover this? Has it been like this ~forever, or was it broken more recently? (I'm wondering if it needs to be cherrypicked into 10.3.0) -- This is an automated mes

[GitHub] [incubator-nuttx] normanr commented on pull request #5750: net/udp: clear the connection structure after free

2022-06-12 Thread GitBox
normanr commented on PR #5750: URL: https://github.com/apache/incubator-nuttx/pull/5750#issuecomment-1153396887 Also `TCP` calls memset in `tcp_alloc`, instead of `tcp_free`, so it pays twice to zero the memory if `NET_ALLOC_CONNS` is enabled, so it might be nice to make `TCP` and `UDP` do

[incubator-nuttx] branch master updated: Fix `CONFIG_ALLSYMS` for arm, risc-v and xtensa after #5496

2022-06-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new e6376c72d7 Fix `CONFIG_ALLSYMS` for

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6416: Fix `CONFIG_ALLSYMS` for arm, risc-v and xtensa after #5496

2022-06-12 Thread GitBox
xiaoxiang781216 merged PR #6416: URL: https://github.com/apache/incubator-nuttx/pull/6416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6415: arch: k210: Add a workaround for clock stabilization

2022-06-12 Thread GitBox
xiaoxiang781216 merged PR #6415: URL: https://github.com/apache/incubator-nuttx/pull/6415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: arch: k210: Add a workaround for clock stabilization

2022-06-12 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new a0ff6f9fa6 arch: k210: Add a workaro

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5750: net/udp: clear the connection structure after free

2022-06-12 Thread GitBox
xiaoxiang781216 commented on PR #5750: URL: https://github.com/apache/incubator-nuttx/pull/5750#issuecomment-1153434010 > Also `TCP` calls memset in `tcp_alloc`, instead of `tcp_free`, so it pays twice to zero the memory if `NET_ALLOC_CONNS` is enabled, so it might be nice to make `TCP` and

[GitHub] [incubator-nuttx-apps] normanr commented on pull request #824: boot/mcuboot: Add support for MCUboot bootloader

2022-06-12 Thread GitBox
normanr commented on PR #824: URL: https://github.com/apache/incubator-nuttx-apps/pull/824#issuecomment-1153468545 How is the image hash verification supposed to work? The hash to verify the download against is compiled into the agent example, so how can "the hash for firmware v2" be known

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6413: stm32wl5: add gpio exti support

2022-06-12 Thread GitBox
pkarashchenko commented on code in PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895328006 ## arch/arm/src/stm32wl5/stm32wl5_exti_gpio.c: ## @@ -121,9 +253,60 @@ static int stm32wl5_exti0_15_isr(int irq, void *context, FAR void *arg) int stm32w

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
pkarashchenko commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895330017 ## drivers/sensors/as5048a.c: ## @@ -0,0 +1,632 @@ +/ + * drivers/sensors/as504

[GitHub] [incubator-nuttx-apps] adamkaliszan commented on a diff in pull request #1193: serialblaster bugfix

2022-06-12 Thread GitBox
adamkaliszan commented on code in PR #1193: URL: https://github.com/apache/incubator-nuttx-apps/pull/1193#discussion_r895334882 ## examples/serialblaster/serialblaster_main.c: ## @@ -84,25 +85,25 @@ int main(int argc, FAR char *argv[]) fd = open(devpath, O_RDWR); if (fd <

[GitHub] [incubator-nuttx-apps] adamkaliszan commented on a diff in pull request #1193: serialblaster bugfix

2022-06-12 Thread GitBox
adamkaliszan commented on code in PR #1193: URL: https://github.com/apache/incubator-nuttx-apps/pull/1193#discussion_r895335109 ## examples/serialblaster/serialblaster_main.c: ## @@ -59,7 +59,7 @@ int main(int argc, FAR char *argv[]) int ret; int fd; FAR char *devpath;

[GitHub] [incubator-nuttx-apps] jlaitine commented on pull request #1194: nshlib/nsh_envcmd.c: Change cmd_unset to only unset existing env vari…

2022-06-12 Thread GitBox
jlaitine commented on PR #1194: URL: https://github.com/apache/incubator-nuttx-apps/pull/1194#issuecomment-1153485498 Closing in favor of better solution from @xiaoxiang781216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx-apps] jlaitine closed pull request #1194: nshlib/nsh_envcmd.c: Change cmd_unset to only unset existing env vari…

2022-06-12 Thread GitBox
jlaitine closed pull request #1194: nshlib/nsh_envcmd.c: Change cmd_unset to only unset existing env vari… URL: https://github.com/apache/incubator-nuttx-apps/pull/1194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] jlaitine commented on a diff in pull request #6025: Add vm map

2022-06-12 Thread GitBox
jlaitine commented on code in PR #6025: URL: https://github.com/apache/incubator-nuttx/pull/6025#discussion_r895342388 ## mm/shm/shm_initialize.c: ## @@ -69,20 +69,20 @@ struct shm_info_s g_shminfo = int shm_group_initialize(FAR struct task_group_s *group) { - DEBUGASSERT(g

[GitHub] [incubator-nuttx] jlaitine commented on pull request #6025: Add vm map

2022-06-12 Thread GitBox
jlaitine commented on PR #6025: URL: https://github.com/apache/incubator-nuttx/pull/6025#issuecomment-1153495140 Shall I just close this PR? I don't think that there is interest in this, nor for the shmfs, so no point keeping this hanging around? -- This is an automated message from t

[GitHub] [incubator-nuttx] jlaitine commented on pull request #6025: Add vm map

2022-06-12 Thread GitBox
jlaitine commented on PR #6025: URL: https://github.com/apache/incubator-nuttx/pull/6025#issuecomment-1153496289 Closing, as 1) the review is already a mess and I can't comprehend any more what to do with this 2) this has been stale for a long time, and apparently there is no interest

[GitHub] [incubator-nuttx] jlaitine closed pull request #6025: Add vm map

2022-06-12 Thread GitBox
jlaitine closed pull request #6025: Add vm map URL: https://github.com/apache/incubator-nuttx/pull/6025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] adamkaliszan opened a new pull request, #6417: Ssd1680 bsp esp32

2022-06-12 Thread GitBox
adamkaliszan opened a new pull request, #6417: URL: https://github.com/apache/incubator-nuttx/pull/6417 ## Summary BSP for Lilygo T5v2 board (e-paper display with SD card reader). ## Impact None ## Testing Yes, on Lilygo T5v2 board. -- This is an automated message from t

[GitHub] [incubator-nuttx] adamkaliszan closed pull request #6417: Ssd1680 bsp esp32

2022-06-12 Thread GitBox
adamkaliszan closed pull request #6417: Ssd1680 bsp esp32 URL: https://github.com/apache/incubator-nuttx/pull/6417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [incubator-nuttx] adamkaliszan opened a new pull request, #6418: Eps32 Lilygo t5v2 BSP

2022-06-12 Thread GitBox
adamkaliszan opened a new pull request, #6418: URL: https://github.com/apache/incubator-nuttx/pull/6418 ## Summary BSP for Lilygo T5v2 board (e-paper display with SD card reader). ## Impact None ## Testing Yes, on Lilygo T5v2 board. -- This is an automated message from t

[GitHub] [incubator-nuttx] normanr commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

2022-06-12 Thread GitBox
normanr commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r895359172 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: Isn't this a userspace library? Shouldn't kernel code

[GitHub] [incubator-nuttx] zouboan commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder

2022-06-12 Thread GitBox
zouboan commented on code in PR #6412: URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895360361 ## drivers/sensors/as5048a.c: ## @@ -0,0 +1,632 @@ +/ + * drivers/sensors/as5048a.c +

[GitHub] [incubator-nuttx] XinStellaris commented on a diff in pull request #6154: net/tcp:make initial tcp port more random

2022-06-12 Thread GitBox
XinStellaris commented on code in PR #6154: URL: https://github.com/apache/incubator-nuttx/pull/6154#discussion_r895374200 ## net/tcp/tcp_conn.c: ## @@ -49,6 +49,7 @@ #include #include #include +#include Review Comment: I had tested arc4random_buf, it generated the e

[GitHub] [incubator-nuttx] mlyszczek commented on a diff in pull request #6413: stm32wl5: add gpio exti support

2022-06-12 Thread GitBox
mlyszczek commented on code in PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895377305 ## arch/arm/src/stm32wl5/stm32wl5_exti_gpio.c: ## @@ -121,9 +253,60 @@ static int stm32wl5_exti0_15_isr(int irq, void *context, FAR void *arg) int stm32wl5_g

[GitHub] [incubator-nuttx] mlyszczek commented on a diff in pull request #6413: stm32wl5: add gpio exti support

2022-06-12 Thread GitBox
mlyszczek commented on code in PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895377305 ## arch/arm/src/stm32wl5/stm32wl5_exti_gpio.c: ## @@ -121,9 +253,60 @@ static int stm32wl5_exti0_15_isr(int irq, void *context, FAR void *arg) int stm32wl5_g

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6413: stm32wl5: add gpio exti support

2022-06-12 Thread GitBox
pkarashchenko commented on code in PR #6413: URL: https://github.com/apache/incubator-nuttx/pull/6413#discussion_r895379389 ## arch/arm/src/stm32wl5/stm32wl5_exti_gpio.c: ## @@ -121,9 +253,60 @@ static int stm32wl5_exti0_15_isr(int irq, void *context, FAR void *arg) int stm32w