pussuw opened a new pull request, #6250:
URL: https://github.com/apache/incubator-nuttx/pull/6250
Same treatment as task_delete, this is not usable in kernel build
either.
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Se
pkarashchenko commented on PR #6232:
URL: https://github.com/apache/incubator-nuttx/pull/6232#issuecomment-1124620521
If there is an exception for units (`Hz`) then probably we can add exception
for other units like (`bps`, `us`, `ms`, `ns`). But that will mean that we will
add exception fo
pkarashchenko commented on code in PR #6240:
URL: https://github.com/apache/incubator-nuttx/pull/6240#discussion_r871031558
##
libs/libc/machine/arm/aeabi_atexit.c:
##
@@ -0,0 +1,56 @@
+/
+ * libs/libc/m
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124631587
@pussuw Sorry for a dummy question, but can we have a single `lib_exit.c`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pussuw commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124633220
> @pussuw Sorry for a dummy question, but can we have a single `lib_exit.c`?
Yes, that is the target. This change just renames lib_Exit.c to lib__Exit.c,
no extra file is add
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124640022
I was thinking that we can rename `lib_exit.c` in this PR, but as you have
more context I assume that not. I'm fine with temporary rename
--
This is an automated message f
xiaoxiang781216 opened a new pull request, #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251
## Summary
- Change up_mdelay with >= 10ms with nxsig_usleep
- Change up_mdelay with < 10ms with up_udelay
## Impact
Minor
## Testing
Pass CI
--
Thi
masayuki2009 commented on PR #6242:
URL: https://github.com/apache/incubator-nuttx/pull/6242#issuecomment-1124659433
```
curl: (28) Failed to connect to www.phyplusinc.com port 80: Connection timed
out
cp: cannot stat 'libphy62xxble.a': No such file or directory
make[1]: *** [chip/M
Ouss4 commented on PR #6222:
URL: https://github.com/apache/incubator-nuttx/pull/6222#issuecomment-1124704317
@xiaoxiang781216 @zhuyanlinzyl how about the `xtensa_cpstate_s` struct we
still have in `xtensa_coproc.h`. There is no use for it now. I think we can
just `#if 0` it with a commen
pussuw commented on PR #6250:
URL: https://github.com/apache/incubator-nuttx/pull/6250#issuecomment-1124704654
curl: (28) Failed to connect to www.phyplusinc.com port 80: Connection
timed out
cp: cannot stat 'libphy62xxble.a': No such file or directory
make[1]: *** [chip/Make.defs:82:
pussuw opened a new pull request, #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252
Implement a generic access rights modification procedure instead
of the procedures that only do one thing (enable/disable write)
to one section (text).
## Summary
Follow up to htt
xiaoxiang781216 commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871142508
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/***
pussuw commented on code in PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r871195697
##
include/sys/atexit.h:
##
@@ -0,0 +1,81 @@
+/
+ * include/sys/atexit.h
Review Comme
xiaoxiang781216 commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124810754
> I was thinking that we can rename `lib_exit.c` in this PR, but as you have
more context I assume that not. I'm fine with temporary rename
Spec define two api(_exit
zhuyanlinzyl commented on PR #6222:
URL: https://github.com/apache/incubator-nuttx/pull/6222#issuecomment-1124823186
ok, I can removew struct `xtensa_cpstate_s`. How about void
xtensa_coproc_enable(struct xtensa_cpstate_s *cpstate, int cpset) function ?
modify to void xtensa_coproc_enable(i
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124840623
> > I was thinking that we can rename `lib_exit.c` in this PR, but as you
have more context I assume that not. I'm fine with temporary rename
>
> Spec define two api(_
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124842724
Anyway let's follow a plan and do things step by step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
pussuw commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124843504
> > > I was thinking that we can rename `lib_exit.c` in this PR, but as you
have more context I assume that not. I'm fine with temporary rename
> >
> >
> > Spec define tw
pkarashchenko commented on code in PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871235822
##
arch/arm/src/c5471/c5471_ethernet.c:
##
@@ -1892,7 +1892,7 @@ static int c5471_ifup(struct net_driver_s *dev)
putreg32((getreg32(EIM_CTRL) | EIM_CT
pkarashchenko commented on code in PR #6226:
URL: https://github.com/apache/incubator-nuttx/pull/6226#discussion_r871238116
##
sched/semaphore/sem_tickwait.c:
##
@@ -165,19 +145,24 @@ int nxsem_tickwait(FAR sem_t *sem, clock_t start,
uint32_t delay)
*
**
pkarashchenko commented on code in PR #6226:
URL: https://github.com/apache/incubator-nuttx/pull/6226#discussion_r871240017
##
sched/semaphore/sem_tickwait.c:
##
@@ -165,19 +145,24 @@ int nxsem_tickwait(FAR sem_t *sem, clock_t start,
uint32_t delay)
*
**
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124851845
I just was trying to say that `lib_exit.c` vs `lib_Exit.c` only matters on
case insensitive file systems, so was thinking that we can rename to lower case
and extend it will
pussuw commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124856359
> I just was trying to say that `lib_exit.c` vs `lib_Exit.c` only matters on
case insensitive file systems, so was thinking that we can rename to lower case
and extend it will addi
pkarashchenko merged PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fb1c1bfe6c libc: Rename lib_Exit
Ouss4 commented on PR #6222:
URL: https://github.com/apache/incubator-nuttx/pull/6222#issuecomment-1124880206
> ok, I can remove struct `xtensa_cpstate_s`. How about void
xtensa_coproc_enable(struct xtensa_cpstate_s *cpstate, int cpset) function ?
modify to void xtensa_coproc_enable(int cps
Ouss4 commented on PR #6222:
URL: https://github.com/apache/incubator-nuttx/pull/6222#issuecomment-1124887380
@zhuyanlinzyl @xiaoxiang781216 A bit unrelated, but one thing regarding lazy
context switching is this issue:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/
CV-Bowen opened a new pull request, #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253
## Summary
Compile error when enable CONFIG_CRYPTO_AES
In file included from drivers_initialize.c:25:0:
/home/wangbowen/project/community/wbw_nuttx/nuttx/include/nuttx/crypto/cryp
pkarashchenko commented on PR #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253#issuecomment-1124900356
Maybe better to switch keysize to size_t?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
masayuki2009 commented on PR #6250:
URL: https://github.com/apache/incubator-nuttx/pull/6250#issuecomment-1124926573
@pussuw
I've just restarted the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
davids5 commented on PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#issuecomment-1124948904
Were all the up_ delays changes scrutinized see it interrupts were off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiaoxiang781216 commented on PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#issuecomment-1124963056
> Were all the up_ delays changes scrutinized see it interrupts were off?
Yes, we need review carefully, but the replacement is only for the sleep >=
10ms, I don't b
CV-Bowen commented on PR #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253#issuecomment-1124973896
> Maybe better to switch keysize to size_t?
Done， i am not sure your meaning, do you mean switch type of keysize to
size_t ob basis of this PR? If yes, done.
--
This is
xiaoxiang781216 commented on code in PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871426739
##
arch/arm/src/c5471/c5471_ethernet.c:
##
@@ -1892,7 +1892,7 @@ static int c5471_ifup(struct net_driver_s *dev)
putreg32((getreg32(EIM_CTRL) | EIM_
xiaoxiang781216 merged PR #6250:
URL: https://github.com/apache/incubator-nuttx/pull/6250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from fb1c1bfe6c libc: Rename lib_Exit lib__Exit
add 5bcd1dbb64 sched: Remove task_restart in case of CONFI
xiaoxiang781216 commented on code in PR #6240:
URL: https://github.com/apache/incubator-nuttx/pull/6240#discussion_r871430239
##
libs/libc/machine/arm/aeabi_atexit.c:
##
@@ -0,0 +1,56 @@
+/
+ * libs/libc
pkarashchenko commented on code in PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871430681
##
arch/arm/src/c5471/c5471_ethernet.c:
##
@@ -1892,7 +1892,7 @@ static int c5471_ifup(struct net_driver_s *dev)
putreg32((getreg32(EIM_CTRL) | EIM_CT
pkarashchenko commented on code in PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871430681
##
arch/arm/src/c5471/c5471_ethernet.c:
##
@@ -1892,7 +1892,7 @@ static int c5471_ifup(struct net_driver_s *dev)
putreg32((getreg32(EIM_CTRL) | EIM_CT
pkarashchenko commented on code in PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871430681
##
arch/arm/src/c5471/c5471_ethernet.c:
##
@@ -1892,7 +1892,7 @@ static int c5471_ifup(struct net_driver_s *dev)
putreg32((getreg32(EIM_CTRL) | EIM_CT
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 072c28fe8e Revert "tools/mkallsyms.s
xiaoxiang781216 commented on code in PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871448752
##
arch/arm/src/c5471/c5471_ethernet.c:
##
@@ -1892,7 +1892,7 @@ static int c5471_ifup(struct net_driver_s *dev)
putreg32((getreg32(EIM_CTRL) | EIM_
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 072c28fe8e Revert "tools/mkallsyms.sh: Disable the mismatch warning of
builtin declaration"
add 47e8
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 47e85b68fe arch/addrenv: Change text write enable/disable to generic
mprot
add 568621fbcf crypto: fi
xiaoxiang781216 merged PR #6247:
URL: https://github.com/apache/incubator-nuttx/pull/6247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
pkarashchenko commented on PR #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253#issuecomment-1125073594
> > Maybe better to switch keysize to size_t?
>
> Done， i am not sure your meaning, do you mean switch type of keysize to
size_t on basis of this PR? If yes, done.
xiaoxiang781216 commented on PR #6249:
URL: https://github.com/apache/incubator-nuttx/pull/6249#issuecomment-1125074412
It's good to see that NuttX based device outside of Xiaomi start to use
OpenAMP to talk with Linux or another NuttX.
--
This is an automated message from the Apache Git
xiaoxiang781216 merged PR #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 merged PR #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
CV-Bowen commented on PR #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253#issuecomment-1125091991
> > > Maybe better to switch keysize to size_t?
> >
> >
> > Done， i am not sure your meaning, do you mean switch type of keysize to
size_t on basis of this PR? If yes,
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 77e36d1acc risc-v/mpfs: introduce IH
pkarashchenko commented on PR #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253#issuecomment-1125105777
I definitely know that stdint.h can be include in assembly. I will check
maybe sys/types.h is better
--
This is an automated message from the Apache Git Service.
To respon
xiaoxiang781216 merged PR #6249:
URL: https://github.com/apache/incubator-nuttx/pull/6249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit dc9103a72d3c1aa3d5f5b658b1187523e58999fd
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 14:05:21 2022 +
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 8e6081abe03d0497bc432d836fc1a0bbcf1968ac
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 14:02:33 2022 +
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit adf7ceedf4aed2017079175636a03314d6be636e
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 14:00:48 2022 +
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 4b383b397d5f5398d392ea84e2c6388b0bf09289
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 14:06:31 2022 +
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit b7f57a1952a1016049db78d8f0cce5ab53d798c8
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 14:03:56 2022 +
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
from 725fe76b9 trace: format the usage output
new 5ee2e6348 Use -fno-builtin for SYMTABOBJ
new 6
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 5ee2e6348f0b0cb9b57d449410e7e75d47bc81b1
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 12:24:16 2022 +
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 6a25898568acd19be4670bdddf1561b2def4c607
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 12:31:21 2022 +
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 59fc69c453de1ffc26017b69571fe3f52d9163f7
Author: YAMAMOTO Takashi
AuthorDate: Wed Apr 6 14:07:51 2022 +
xiaoxiang781216 merged PR #1124:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
xiaoxiang781216 opened a new pull request, #6254:
URL: https://github.com/apache/incubator-nuttx/pull/6254
## Summary
since libboard.a isn't copied in the action of export_startup
## Impact
No
## Testing
Pass CI
--
This is an automated message from the Apache Git
xiaoxiang781216 opened a new pull request, #6255:
URL: https://github.com/apache/incubator-nuttx/pull/6255
## Summary
riscv doesn't have thumb mode like arm
## Impact
Shouldn't
## Testing
--
This is an automated message from the Apache Git Service.
To respond to
pussuw commented on PR #6255:
URL: https://github.com/apache/incubator-nuttx/pull/6255#issuecomment-1125280011
Not necessarily required but there are other places with EPC &= ~1 in the
file, can you please remove those also ? One example is SYS_pthread_start, many
others as well.
--
This
xiaoxiang781216 commented on PR #6222:
URL: https://github.com/apache/incubator-nuttx/pull/6222#issuecomment-1125297087
> @zhuyanlinzyl @xiaoxiang781216 A bit unrelated, but one thing regarding
lazy context switching is this issue:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32
xiaoxiang781216 commented on PR #6255:
URL: https://github.com/apache/incubator-nuttx/pull/6255#issuecomment-1125302397
> Not necessarily required but there are other places with EPC &= ~1 in the
file, can you please remove those also ? One example is SYS_pthread_start, many
others as well.
xiaoxiang781216 commented on issue #6219:
URL:
https://github.com/apache/incubator-nuttx/issues/6219#issuecomment-1125307177
Does the new toolchain on your search path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xiaoxiang781216 opened a new pull request, #6256:
URL: https://github.com/apache/incubator-nuttx/pull/6256
## Summary
- boards/nrf52: Remove ARCHCCVERSION/ARCHCCMAJOR which isn't used
- boards/nrf52: Remove toolchain macro which is already defined in
Toolchain.defs
- boards/rv3
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit dc2a01e75a89ea0e90dbc37aebbc7822f1d846e9
Author: Masayuki Ishikawa
AuthorDate: Mon May 9 11:02:46 2022 +0900
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 3193aa3c97ed26e5cb9c5638c070282643531ad2
Author: Masayuki Ishikawa
AuthorDate: Mon May 9 11:00:56 2022 +0900
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 77e36d1acc risc-v/mpfs: introduce IHC driver
new 3193aa3c97 arch: risc-v: Add MMU support for qemu-rv
kassane commented on issue #6219:
URL:
https://github.com/apache/incubator-nuttx/issues/6219#issuecomment-1125387769
Right, the example of this is zcc and zcxx worked even though they generated
a flags error. Only zig build did not return any information in the output.
I will review the
pkarashchenko commented on code in PR #6251:
URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871781647
##
arch/arm/src/lpc43xx/lpc43_cgu.c:
##
@@ -654,7 +654,7 @@ void lpc43_clockconfig(void)
/* Delay around 10 milliseconds */
- up_mdelay(XTAL_DELAY)
xiaoxiang781216 merged PR #6242:
URL: https://github.com/apache/incubator-nuttx/pull/6242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 23200471df arch/riscv: Remove &
pkarashchenko commented on code in PR #6222:
URL: https://github.com/apache/incubator-nuttx/pull/6222#discussion_r871785422
##
arch/xtensa/src/common/xtensa_coproc.S:
##
@@ -112,77 +113,87 @@ _xtensa_coproc_savestate:
/* Move the address of the thread state save area t
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1ba316b5c7 arch: Remove board/li
pkarashchenko merged PR #6255:
URL: https://github.com/apache/incubator-nuttx/pull/6255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
pkarashchenko merged PR #6254:
URL: https://github.com/apache/incubator-nuttx/pull/6254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
pkarashchenko opened a new pull request, #6257:
URL: https://github.com/apache/incubator-nuttx/pull/6257
## Summary
It is better to include `sys/types.h` since header does not contain types
from `stdint.h` and `sys/types.h` is `__ASSEMBLY__` friendly.
## Impact
None
## T
pkarashchenko commented on PR #6253:
URL: https://github.com/apache/incubator-nuttx/pull/6253#issuecomment-1125421961
@CV-Bowen please check https://github.com/apache/incubator-nuttx/pull/6257
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pkarashchenko commented on code in PR #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252#discussion_r871810439
##
include/nuttx/arch.h:
##
@@ -1186,41 +1186,25 @@ int up_addrenv_detach(FAR struct task_group_s *group,
FAR struct tcb_s *tcb);
#endif
/
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f7f8a21486 libs: Move aeabi_atex
pussuw commented on code in PR #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252#discussion_r871815417
##
include/nuttx/arch.h:
##
@@ -1186,41 +1186,25 @@ int up_addrenv_detach(FAR struct task_group_s *group,
FAR struct tcb_s *tcb);
#endif
/***
pkarashchenko commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871816120
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/*
pkarashchenko commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871818554
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/*
pussuw commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871823170
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/
pkarashchenko commented on code in PR #6246:
URL: https://github.com/apache/incubator-nuttx/pull/6246#discussion_r871820610
##
drivers/mmcsd/sdio.c:
##
@@ -115,6 +124,10 @@ int sdio_sendcmdpoll(FAR struct sdio_dev_s *dev, uint32_t
cmd, uint32_t arg)
return ret;
}
+/**
pkarashchenko merged PR #6240:
URL: https://github.com/apache/incubator-nuttx/pull/6240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
gustavonihei opened a new pull request, #6258:
URL: https://github.com/apache/incubator-nuttx/pull/6258
## Summary
This PR intends to provide a fix to the `sys_call5` and `sys_call6`
functions, where the argument `parm4` is mistakenly passed instead of the
remaining arguments.
##
pkarashchenko commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871839614
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/*
pussuw commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871841569
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/
pkarashchenko commented on code in PR #6241:
URL: https://github.com/apache/incubator-nuttx/pull/6241#discussion_r871841567
##
libs/libc/machine/risc-v/common/arch_elf.c:
##
@@ -399,6 +400,29 @@ int up_relocateadd(FAR const Elf_Rela *rel, FAR const
Elf_Sym *sym,
}
pussuw commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871841569
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/
pkarashchenko commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871842266
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/*
pkarashchenko commented on PR #6232:
URL: https://github.com/apache/incubator-nuttx/pull/6232#issuecomment-1125466527
We already have things like
```
# define SX127X_CMN_PARAMP_PARAMP_250us (4 <<
SX127X_CMN_PARAMP_PARAMP_SHIFT)
```
and
```
# define SX127X_CMN_PLL_BW_75kH
pkarashchenko commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871856950
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/*
pussuw commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871858319
##
arch/risc-v/src/common/crt0.c:
##
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
);
}
+/
1 - 100 of 129 matches
Mail list logo
