pkarashchenko merged PR #6184:
URL: https://github.com/apache/incubator-nuttx/pull/6184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new bbdbca00c1 libc/assert: let CONF
pkarashchenko merged PR #6205:
URL: https://github.com/apache/incubator-nuttx/pull/6205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fdef3a7b92 binfmt/libelf: Fix fu
masayuki2009 commented on PR #5896:
URL: https://github.com/apache/incubator-nuttx/pull/5896#issuecomment-1117028795
>@masayuki2009 should we merge this PR without waiting fix the cache issue?
The cache issue was resolved by
https://github.com/apache/incubator-nuttx/pull/6107
--
masayuki2009 commented on PR #5896:
URL: https://github.com/apache/incubator-nuttx/pull/5896#issuecomment-1117033118
@jerpelea
Could you backport this PR to the 10.3 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
masayuki2009 commented on PR #6107:
URL: https://github.com/apache/incubator-nuttx/pull/6107#issuecomment-1117045253
@jerpelea
Please backport this PR to the 10.3 branch as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
jerpelea opened a new pull request, #6206:
URL: https://github.com/apache/incubator-nuttx/pull/6206
## Summary
patches added:
https://github.com/apache/incubator-nuttx/pull/6107
https://github.com/apache/incubator-nuttx/pull/5896
## Impact
NuttX 10.3 RELEASE
## Testi
takayoshi-k commented on PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#issuecomment-1117120335
@pkarashchenko
I modified them. Please check them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
masayuki2009 merged PR #6206:
URL: https://github.com/apache/incubator-nuttx/pull/6206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch releases/10.3
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 2e3c217d10 libc/string:add LICENSE info
new 6ad2e7f5de arm/cortex-[a|r]: IRQ Switch return shou
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch releases/10.3
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit ec8fa7d2bfd649d8848448243744e30c96467ff2
Author: zhuyanlin
AuthorDate: Tue Apr 19 20:55:32 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch releases/10.3
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 6ad2e7f5def7650682f9416e75ed52da133bd814
Author: chao.an
AuthorDate: Tue Mar 29 00:36:22 2022 +0800
pussuw commented on code in PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r864681160
##
sched/task/exit.c:
##
@@ -53,24 +53,24 @@
void _exit(int status)
{
- up_exit(status);
+ up_exit(status & 0xff);
}
/**
pussuw commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1117248426
I cannot produce the build error locally:
Configuration/Tool: qemu-intel64/nsh
---
Ouss4 commented on issue #6172:
URL:
https://github.com/apache/incubator-nuttx/issues/6172#issuecomment-1117346153
Since the FPU state is stored in the interrupt stack frame, isn't the issue
more generic with lazy context switching?
--
This is an automated message from the Apache Git Ser
Ouss4 commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1117407107
@pussuw there seem to be some warnings:
```
stdlib/lib_cxa_atexit.c:83:13: error: '__cxa_callback' defined but not used
[-Werror=unused-function]
```
CI turns war
pussuw commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1117420539
> @pussuw there seem to be some warnings:
>
> ```
> stdlib/lib_cxa_atexit.c:83:13: error: '__cxa_callback' defined but not
used [-Werror=unused-function]
> ```
>
Ouss4 commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1117432648
> The other build error which I listed above is way beyond my understanding.
The make recipe works locally for the targets that fail in CI.
It could be a parallel make issue a
pkarashchenko merged PR #1160:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 385603666 system: Add gcov
pkarashchenko commented on PR #6200:
URL: https://github.com/apache/incubator-nuttx/pull/6200#issuecomment-1117451681
@xiaoxiang781216 please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
xiaoxiang781216 commented on PR #6200:
URL: https://github.com/apache/incubator-nuttx/pull/6200#issuecomment-1117527283
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pkarashchenko commented on PR #6025:
URL: https://github.com/apache/incubator-nuttx/pull/6025#issuecomment-1117530313
I will start a review tomorrow. Quite a complex change and I was too busy
current and last weeks to make a proper analysis.
--
This is an automated message from the Apache
Ouss4 opened a new pull request, #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207
## Summary
This reverts commit 05ff19d17bed7ff8a9ac8d38ae7ad81cf84ee70d because now we
are having a bunch of `make: arm-nuttx-eabi-gcc: Command not found` for some
configs.
I'v
JacobCrabill commented on PR #6057:
URL: https://github.com/apache/incubator-nuttx/pull/6057#issuecomment-1117534853
Ok, one lest bench test for the Tx completion changes and this should be
good for review.
--
This is an automated message from the Apache Git Service.
To respond to the mes
Ouss4 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117536261
@xiaoxiang781216 the comment says:
> Don't skip configure and distclean to improve the test coverage
I'm not sure how does this improve test coverage. Can you please explai
Ouss4 commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1117544274
@pussuw Apparently we have a name collision with
https://github.com/apache/incubator-nuttx/blob/master/libs/libc/stdlib/lib_Exit.c
and your newly created file `lib_exit.c`. I won't
xiaoxiang781216 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117564061
> @xiaoxiang781216 the comment says:
>
> > Don't skip configure and distclean to improve the test coverage
>
> I'm not sure how does this improve test coverage
pussuw commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1117570558
> @pussuw Apparently we have a name collision with
https://github.com/apache/incubator-nuttx/blob/master/libs/libc/stdlib/lib_Exit.c
and your newly created file `lib_exit.c`. I won
xiaoxiang781216 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117609268
From the ci log, it look like that make try to invoke arm-nuttx-eabi-gcc in
preconfig and distclean phase, but it shouldn't.
--
This is an automated message from the Apa
Ouss4 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1117610441
> > @xiaoxiang781216 the comment says:
> > > Don't skip configure and distclean to improve the test coverage
> >
> >
> > I'm not sure how does this improve test coverage
xiaoxiang781216 opened a new pull request, #6208:
URL: https://github.com/apache/incubator-nuttx/pull/6208
## Summary
- arm/common: Skip compile arm_[m|u]delay.c if CONFIG_[ALARM|TIMER]_ARCH is
true
- arch/arm: Remove arm_etherstub.c
## Impact
Minor, code refactor
xiaoxiang781216 commented on PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#issuecomment-1117676027
@okayserh please use `git rebase' instead 'git merge' next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
okayserh commented on code in PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#discussion_r865153394
##
drivers/audio/wm8994.c:
##
@@ -373,16 +450,9 @@ static void wm8994_writereg(FAR struct wm8994_dev_s *priv,
uint16_t regaddr,
*
*/
-static void wm8994_
JacobCrabill commented on PR #6057:
URL: https://github.com/apache/incubator-nuttx/pull/6057#issuecomment-1117688149
@xiaoxiang781216 do you want me to do a rebase on top of `master`, or just
squash the last few commits but leave the base the same?
--
This is an automated message from the
okayserh commented on PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#issuecomment-1117692848
Ok, next time I'll directly do the rebase without a prior merge. Still
following the steps in
https://nuttx.apache.org/docs/latest/contributing/making-changes.html#submitting-
xiaoxiang781216 commented on PR #6057:
URL: https://github.com/apache/incubator-nuttx/pull/6057#issuecomment-1117707678
> @xiaoxiang781216 do you want me to do a rebase on top of `master`, or just
squash the last few commits but leave the base the same?
either is fine.
--
This is a
pkarashchenko commented on code in PR #6186:
URL: https://github.com/apache/incubator-nuttx/pull/6186#discussion_r865187718
##
drivers/audio/wm8994.c:
##
@@ -373,16 +450,9 @@ static void wm8994_writereg(FAR struct wm8994_dev_s *priv,
uint16_t regaddr,
*
*/
-static void wm
pussuw commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1117956401
Should have looked more carefully into the syscall table and syscall.csv:
`SYSCALL_LOOKUP(exit, 1)`
and
`"exit","stdlib.h","","noreturn","int"`
This means the pro
pkarashchenko commented on code in PR #6208:
URL: https://github.com/apache/incubator-nuttx/pull/6208#discussion_r865410862
##
arch/arm/src/common/Make.defs:
##
@@ -23,12 +23,18 @@
CMN_CSRCS += arm_allocateheap.c arm_assert.c arm_blocktask.c
CMN_CSRCS += arm_createstack.c arm_
pkarashchenko commented on code in PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#discussion_r865413317
##
audioutils/.gitignore:
##
@@ -0,0 +1 @@
+/Kconfig
Review Comment:
why gitignore is needed?
--
This is an automated message from the Apache
takayoshi-k commented on code in PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#discussion_r865452826
##
audioutils/.gitignore:
##
@@ -0,0 +1 @@
+/Kconfig
Review Comment:
It is because of nuttx build system.
The build system makes Kconfig automat
takayoshi-k commented on code in PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#discussion_r865452826
##
audioutils/.gitignore:
##
@@ -0,0 +1 @@
+/Kconfig
Review Comment:
It is because of nuttx build system.
The build system makes Kconfig automat
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 1e620f1 Publishing web
CV-Bowen opened a new pull request, #6209:
URL: https://github.com/apache/incubator-nuttx/pull/6209
## Summary
Telink toolchain is special and not added to the CI yet.
## Impact
Telink boards CI.
## Testing
CI.
--
This is an automated message from the Apache Git
xiaoxiang781216 commented on code in PR #6208:
URL: https://github.com/apache/incubator-nuttx/pull/6208#discussion_r865530154
##
arch/arm/src/common/Make.defs:
##
@@ -23,12 +23,18 @@
CMN_CSRCS += arm_allocateheap.c arm_assert.c arm_blocktask.c
CMN_CSRCS += arm_createstack.c ar
xiaoxiang781216 commented on code in PR #6209:
URL: https://github.com/apache/incubator-nuttx/pull/6209#discussion_r865532928
##
tools/ci/testlist/arm-13.dat:
##
@@ -9,3 +9,5 @@
-launchxl-tms57004:nsh
-lm3s6965-ek:qemu-nxflat
-tms570ls31x-usb-kit:nsh
+-tlsr8278adk80d:ostest
+
CV-Bowen commented on code in PR #6209:
URL: https://github.com/apache/incubator-nuttx/pull/6209#discussion_r865534057
##
tools/ci/testlist/arm-13.dat:
##
@@ -9,3 +9,5 @@
-launchxl-tms57004:nsh
-lm3s6965-ek:qemu-nxflat
-tms570ls31x-usb-kit:nsh
+-tlsr8278adk80d:ostest
+-tlsr82
CV-Bowen commented on PR #6179:
URL: https://github.com/apache/incubator-nuttx/pull/6179#issuecomment-1118134931
CI failed, because mixed case identifier found in arch/arm/src/phy62xx/* and
boards/arm/stm32l4/nucleo-l476rg/*, it seems unrelated to this pr.
--
This is an automated message
xiaoxiang781216 commented on PR #6209:
URL: https://github.com/apache/incubator-nuttx/pull/6209#issuecomment-1118175796
Close, let's track by https://github.com/apache/incubator-nuttx/pull/6179
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message
xiaoxiang781216 closed pull request #6209: ci/arm-13.dat: do not check board
tlsr8278adk80d
URL: https://github.com/apache/incubator-nuttx/pull/6209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
pkarashchenko commented on code in PR #6208:
URL: https://github.com/apache/incubator-nuttx/pull/6208#discussion_r865556885
##
arch/arm/src/common/Make.defs:
##
@@ -23,12 +23,18 @@
CMN_CSRCS += arm_allocateheap.c arm_assert.c arm_blocktask.c
CMN_CSRCS += arm_createstack.c arm_
pkarashchenko commented on code in PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#discussion_r865557574
##
audioutils/.gitignore:
##
@@ -0,0 +1 @@
+/Kconfig
Review Comment:
Ok, so this is for autogenerated Kconfig. That's fine.
--
This is an aut
pkarashchenko commented on code in PR #1158:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1158#discussion_r865584992
##
examples/mml_parser/mml_parser_main.c:
##
@@ -0,0 +1,197 @@
+/
+ * app
pkarashchenko commented on code in PR #6200:
URL: https://github.com/apache/incubator-nuttx/pull/6200#discussion_r865588496
##
libs/libc/misc/lib_impure.c:
##
@@ -0,0 +1,71 @@
+/
+ * libs/libc/misc/lib_i
xiaoxiang781216 commented on PR #6207:
URL: https://github.com/apache/incubator-nuttx/pull/6207#issuecomment-1118219574
> > > @xiaoxiang781216 the comment says:
> > > > Don't skip configure and distclean to improve the test coverage
> > >
> > >
> > > I'm not sure how does this i
pkarashchenko commented on code in PR #6179:
URL: https://github.com/apache/incubator-nuttx/pull/6179#discussion_r865591251
##
arch/arm/src/tlsr82/Make.defs:
##
@@ -0,0 +1,87 @@
+
+# arch/tc32/src/tlsr82
xiaoxiang781216 commented on code in PR #6200:
URL: https://github.com/apache/incubator-nuttx/pull/6200#discussion_r865600022
##
libs/libc/misc/lib_impure.c:
##
@@ -0,0 +1,71 @@
+/
+ * libs/libc/misc/lib
pussuw commented on PR #6197:
URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1118233193
I noticed one oddity with nxtask_exit() -> nxtask_terminate() and its call
to nxtask_exithook(). The call to nxtask_exithook() will fail every time if the
task itself is asking to
xiaoxiang781216 commented on code in PR #6179:
URL: https://github.com/apache/incubator-nuttx/pull/6179#discussion_r865603512
##
arch/arm/src/tlsr82/Make.defs:
##
@@ -0,0 +1,87 @@
+
+# arch/tc32/src/tlsr
61 matches
Mail list logo
