[GitHub] [incubator-nuttx] no1wudi commented on pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

2022-03-23 Thread GitBox
no1wudi commented on pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#issuecomment-1075995482 @masayuki2009 It seems the CPU1~CPU7 don't works, and I see: ``` qemu-system-riscv64: clint: invalid write: 0004 ``` I've never see this error on qemu 6.2

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5828: Show assigned cpu in dump task and other fix for qemu rv

2022-03-23 Thread GitBox
no1wudi opened a new pull request #5828: URL: https://github.com/apache/incubator-nuttx/pull/5828 ## Summary Show assigned cpu in dump task, before this PR: ``` [CPU0] riscv_showtasks:PIDPRI USED STACK FILLEDCOMMAND [CPU0] riscv_showtasks:

[GitHub] [incubator-nuttx] pussuw opened a new pull request #5829: RISC-V: Add/fix implementation for arch_elf.c

2022-03-23 Thread GitBox
pussuw opened a new pull request #5829: URL: https://github.com/apache/incubator-nuttx/pull/5829 The jump instruction relocation had an assert that tests for jumps with an offset of 0. This makes it so that a while(1); statement causes an assert because the jump instruction points to t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5828: Show assigned cpu in dump task and other fix for qemu rv

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5828: URL: https://github.com/apache/incubator-nuttx/pull/5828#discussion_r832952564 ## File path: arch/risc-v/src/qemu-rv/qemu_rv_irq_dispatch.c ## @@ -117,6 +117,34 @@ void *riscv_dispatch_irq(uintptr_t vector, uintptr_t

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5830: risc-v/qemu-rv: Restore FPU context after context switch

2022-03-23 Thread GitBox
no1wudi opened a new pull request #5830: URL: https://github.com/apache/incubator-nuttx/pull/5830 ## Summary Add missing FPU register context restore logic. ## Impact qemu-rv ## Testing rv-virt:smp/smp64 with QEMU 6.2 -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5828: Show assigned cpu in dump task

2022-03-23 Thread GitBox
xiaoxiang781216 commented on pull request #5828: URL: https://github.com/apache/incubator-nuttx/pull/5828#issuecomment-1076056638 BTW how about ps from nsh? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5828: Show assigned cpu in dump task

2022-03-23 Thread GitBox
no1wudi commented on pull request #5828: URL: https://github.com/apache/incubator-nuttx/pull/5828#issuecomment-1076058553 > BTW how about ps from nsh? output from ps: ``` NuttShell (NSH) NuttX-10.2.0 nsh> ps PID GROUP CPU PRI POLICY TYPENPX STATEEVENT SIGMA

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5828: Show assigned cpu in dump task

2022-03-23 Thread GitBox
xiaoxiang781216 commented on pull request #5828: URL: https://github.com/apache/incubator-nuttx/pull/5828#issuecomment-1076071227 Perfect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5829: RISC-V: Add/fix implementation for arch_elf.c

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5829: URL: https://github.com/apache/incubator-nuttx/pull/5829#discussion_r832979072 ## File path: libs/libc/machine/risc-v/common/arch_elf.c ## @@ -343,7 +343,7 @@ int up_relocateadd(FAR const Elf_Rela *rel, FAR const Elf

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5826: tools/jlink: Change the type of pid from uint16_t to uint32_t

2022-03-23 Thread GitBox
pkarashchenko commented on pull request #5826: URL: https://github.com/apache/incubator-nuttx/pull/5826#issuecomment-1076095260 Maybe we can introduce a flag that may be passed to host build system and select the size of `pid_t` on a target system? By default it will be 32-bit. Something l

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5829: RISC-V: Add/fix implementation for arch_elf.c

2022-03-23 Thread GitBox
pkarashchenko commented on a change in pull request #5829: URL: https://github.com/apache/incubator-nuttx/pull/5829#discussion_r833004623 ## File path: libs/libc/machine/risc-v/common/arch_elf.c ## @@ -343,7 +343,7 @@ int up_relocateadd(FAR const Elf_Rela *rel, FAR const Elf_S

[incubator-nuttx] branch master updated: Fix rpmsgfs/rpmsgfs_client.c:774:3: warning: 'strcpy' writing 1 or more bytes into a region of size 0 overflows the destination

2022-03-23 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4d8c926 Fix rpmsgfs/rpmsgfs_cli

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5823: Fix rpmsgfs/rpmsgfs_client.c:774:3: warning: 'strcpy' writing 1 or more bytes into a region of size 0 overflows the destination

2022-03-23 Thread GitBox
pkarashchenko merged pull request #5823: URL: https://github.com/apache/incubator-nuttx/pull/5823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

2022-03-23 Thread GitBox
masayuki2009 commented on pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#issuecomment-1076112239 >I've never see this error on qemu 6.2 and above, could you try again with latest qemu ? @no1wudi The error disappeared but it seems that SMP still d

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5826: tools/jlink: Change the type of pid from uint16_t to uint32_t

2022-03-23 Thread GitBox
xiaoxiang781216 commented on pull request #5826: URL: https://github.com/apache/incubator-nuttx/pull/5826#issuecomment-1076112586 I would like to postpone the change until it really happen to avoid the unnecessary complex in the current implementation. -- This is an automated message fro

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
pkarashchenko commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833007801 ## File path: arch/xtensa/src/esp32s2/rom/esp32s2_spiflash.h ## @@ -0,0 +1,1020 @@ +/***

[incubator-nuttx] branch master updated: tools/jlink: Change the type of pid from uint16_t to uint32_t

2022-03-23 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3259b7d tools/jlink: Change the

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5826: tools/jlink: Change the type of pid from uint16_t to uint32_t

2022-03-23 Thread GitBox
pkarashchenko merged pull request #5826: URL: https://github.com/apache/incubator-nuttx/pull/5826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1086: Fix warning after removing -fno-builtin

2022-03-23 Thread GitBox
pkarashchenko merged pull request #1086: URL: https://github.com/apache/incubator-nuttx-apps/pull/1086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[incubator-nuttx-apps] branch master updated: system: Fix nx[looper|player|recorder] warning

2022-03-23 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new d364d7a system: Fix nx[loo

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

2022-03-23 Thread GitBox
no1wudi commented on pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#issuecomment-1076123831 > > I've never see this error on qemu 6.2 and above, could you try again with latest qemu ? > > @no1wudi > > The error disappeared but it seems that SMP st

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

2022-03-23 Thread GitBox
no1wudi edited a comment on pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#issuecomment-1076123831 > > I've never see this error on qemu 6.2 and above, could you try again with latest qemu ? > > @no1wudi > > The error disappeared but it seems that

[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

2022-03-23 Thread GitBox
no1wudi edited a comment on pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#issuecomment-1076123831 > > I've never see this error on qemu 6.2 and above, could you try again with latest qemu ? > > @no1wudi > > The error disappeared but it seems that

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5529: risc-v/qemu-rv: Supports SMP up to 8 cores and other minor changes

2022-03-23 Thread GitBox
masayuki2009 commented on pull request #5529: URL: https://github.com/apache/incubator-nuttx/pull/5529#issuecomment-1076133061 >Please add -smp 8 to command line, you can specify the core number by this option, by default only one core will be used. Thanks, it works now. -- Th

[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5761: arch/arm: Remove the code copy register from xcpt to stack

2022-03-23 Thread GitBox
no1wudi commented on a change in pull request #5761: URL: https://github.com/apache/incubator-nuttx/pull/5761#discussion_r833042333 ## File path: arch/arm/src/armv7-a/arm_schedulesigaction.c ## @@ -326,13 +329,14 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_deliver_t s

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5761: arch/arm: Remove the code copy register from xcpt to stack

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5761: URL: https://github.com/apache/incubator-nuttx/pull/5761#discussion_r833050660 ## File path: arch/arm/src/armv7-a/arm_schedulesigaction.c ## @@ -326,13 +329,14 @@ void up_schedule_sigaction(struct tcb_s *tcb, sig_del

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5829: RISC-V: Add/fix implementation for arch_elf.c

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5829: URL: https://github.com/apache/incubator-nuttx/pull/5829#discussion_r833053995 ## File path: libs/libc/machine/risc-v/common/arch_elf.c ## @@ -343,7 +343,7 @@ int up_relocateadd(FAR const Elf_Rela *rel, FAR const Elf_Sym *sym

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5829: RISC-V: Add/fix implementation for arch_elf.c

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5829: URL: https://github.com/apache/incubator-nuttx/pull/5829#discussion_r833059131 ## File path: libs/libc/machine/risc-v/common/arch_elf.c ## @@ -343,7 +343,7 @@ int up_relocateadd(FAR const Elf_Rela *rel, FAR const Elf

[GitHub] [incubator-nuttx] no1wudi commented on pull request #5731: arch/risc-v: Improve speed of context switch

2022-03-23 Thread GitBox
no1wudi commented on pull request #5731: URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1076166983 @masayuki2009 Could you try this PR again ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] jlaitine commented on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
jlaitine commented on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076169805 I think @pussuw has addressed all the comments so far. This looks good to me, can you @xiaoxiang781216 re-check? -- This is an automated message from the Apache Git

[incubator-nuttx] branch master updated: RISC-V: Add/fix implementation for arch_elf.c

2022-03-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9288ed8 RISC-V: Add/fix implementat

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5829: RISC-V: Add/fix implementation for arch_elf.c

2022-03-23 Thread GitBox
xiaoxiang781216 merged pull request #5829: URL: https://github.com/apache/incubator-nuttx/pull/5829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5761: arch/arm: Remove the code copy register from xcpt to stack

2022-03-23 Thread GitBox
masayuki2009 commented on pull request #5761: URL: https://github.com/apache/incubator-nuttx/pull/5761#issuecomment-1076182554 >I have fix this crash, please rebase this PR and try again! @anchao I confirmed that the latest PR fixed all of the issues. -- This is an automate

[incubator-nuttx] 03/03: arm/schedulesigaction: update the SP to signal context top

2022-03-23 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7b736063004bf65445afaad26e9b9acee01daaba Author: chao.an AuthorDate: Wed Mar 23 13:13:03 2022 +0800 arm/

[incubator-nuttx] 01/03: arch/arm: Remove the code copy register from xcpt to stack

2022-03-23 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 9ae0dcd4a231424f4968947988cb2865ef90681b Author: Xiang Xiao AuthorDate: Thu Mar 17 02:38:03 2022 +0800 a

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #5761: arch/arm: Remove the code copy register from xcpt to stack

2022-03-23 Thread GitBox
masayuki2009 merged pull request #5761: URL: https://github.com/apache/incubator-nuttx/pull/5761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[incubator-nuttx] 02/03: arm/vfork: update the SP to stack top

2022-03-23 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a770ff20174c4d8fdcf60f8147f768d65a367292 Author: chao.an AuthorDate: Fri Mar 18 21:54:01 2022 +0800 arm/

[incubator-nuttx] branch master updated (9288ed8 -> 7b73606)

2022-03-23 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9288ed8 RISC-V: Add/fix implementation for arch_elf.c new 9ae0dcd arch/arm: Remove the code copy re

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
xiaoxiang781216 commented on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076196870 > I think @pussuw has addressed all the comments so far. This looks good to me, can you @xiaoxiang781216 re-check? Yes, I will take a look again. But sinc

[GitHub] [incubator-nuttx] no1wudi removed a comment on pull request #5731: arch/risc-v: Improve speed of context switch

2022-03-23 Thread GitBox
no1wudi removed a comment on pull request #5731: URL: https://github.com/apache/incubator-nuttx/pull/5731#issuecomment-1076166983 @masayuki2009 Could you try this PR again ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] pussuw commented on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw commented on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076206289 > > I think @pussuw has addressed all the comments so far. This looks good to me, can you @xiaoxiang781216 re-check? > > Yes, I will take a look again. But since t

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5734: arm/armv7-a/r: set the default CPU mode to System

2022-03-23 Thread GitBox
masayuki2009 commented on pull request #5734: URL: https://github.com/apache/incubator-nuttx/pull/5734#issuecomment-1076223466 @xiaoxiang781216 @anchao Did you test this PR with your Cortex-A-based boards? I noticed that this PR does not work with the sabre-6quad dev board (QEMU

[GitHub] [incubator-nuttx] pussuw opened a new pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw opened a new pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831 ## Summary Adds support for a separate kernel stack, needed by CONFIG_BUILD_KERNEL=y ## Impact No impact to existing code ## Testing Tested with icicle:knsh (CONFIG_BUILD_KERNEL=y)

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5830: risc-v/qemu-rv: Restore FPU context after context switch

2022-03-23 Thread GitBox
xiaoxiang781216 merged pull request #5830: URL: https://github.com/apache/incubator-nuttx/pull/5830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated (7b73606 -> f09ea31)

2022-03-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7b73606 arm/schedulesigaction: update the SP to signal context top add f09ea31 risc-v/qemu-rv: Res

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
xiaoxiang781216 commented on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076299011 > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > S-mode can trap ecall from user

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076299011 > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > S-mode can trap ecall fr

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833193039 ## File path: arch/risc-v/src/common/riscv_swint.c ## @@ -440,6 +472,22 @@ int riscv_swint(int irq, void *context, void *arg) r

[GitHub] [incubator-nuttx] pussuw commented on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw commented on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076317489 > > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > > > > > S-mode can trap ecall from

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833196261 ## File path: arch/risc-v/include/irq.h ## @@ -517,6 +517,32 @@ struct xcptcontext uint8_t nsyscalls; struct xcpt_syscall_s syscall[

[GitHub] [incubator-nuttx] pussuw edited a comment on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw edited a comment on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076317489 > > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > > > > > S-mode can trap eca

[GitHub] [incubator-nuttx] pussuw edited a comment on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw edited a comment on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076317489 > > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > > > > > S-mode can trap eca

[GitHub] [incubator-nuttx] pussuw edited a comment on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw edited a comment on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076317489 > > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > > > > > S-mode can trap eca

[GitHub] [incubator-nuttx] pussuw edited a comment on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw edited a comment on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076317489 > > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > > > > > S-mode can trap eca

[GitHub] [incubator-nuttx] pussuw edited a comment on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw edited a comment on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076317489 > > > S-mode can hook ECALL to self, @pussuw could you explain more why we need handle differently in S-mode and M-mode? > > > > > > S-mode can trap eca

[GitHub] [incubator-nuttx] pussuw commented on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw commented on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076325061 Maybe to add some implicit information that is missing. The S-mode implementation is a requirement for CONFIG_BUILD_KERNEL=y, which requires MMU mappings for the user- a

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833213075 ## File path: arch/xtensa/src/esp32s2/Kconfig ## @@ -287,8 +287,6 @@ config ESP32S2_SPI3 config ESP32S2_SPIRAM bool "SPI RAM Support

[GitHub] [incubator-nuttx] pussuw edited a comment on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

2022-03-23 Thread GitBox
pussuw edited a comment on pull request #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1076325061 Maybe to add some implicit information that is missing. The S-mode implementation is a requirement for CONFIG_BUILD_KERNEL=y, which requires MMU mappings for the

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833215001 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.h ## @@ -0,0 +1,150 @@ +/

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833216597 ## File path: arch/risc-v/include/irq.h ## @@ -517,6 +517,32 @@ struct xcptcontext uint8_t nsyscalls; struct xcpt_syscall_s syscall[CONFIG_SY

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833217330 ## File path: arch/risc-v/src/common/addrenv.h ## @@ -0,0 +1,50 @@ +/ +

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833217520 ## File path: arch/risc-v/src/common/riscv_addrenv_kstack.c ## @@ -0,0 +1,109 @@ +/

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833218044 ## File path: arch/risc-v/src/common/riscv_addrenv_kstack.c ## @@ -0,0 +1,109 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833220376 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833221480 ## File path: arch/risc-v/src/common/riscv_swint.c ## @@ -440,6 +472,22 @@ int riscv_swint(int irq, void *context, void *arg) regs[REG_I

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833222532 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.h ## @@ -0,0 +1,206 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833223209 ## File path: arch/xtensa/src/esp32s2/esp32s2_start.c ## @@ -209,6 +210,22 @@ void IRAM_ATTR __esp32s2_start(void) showprogress('A');

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833224754 ## File path: arch/xtensa/src/esp32s2/Kconfig ## @@ -683,6 +681,14 @@ endmenu # SPI Flash configuration menu "SPI RAM Config" Review commen

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833224894 ## File path: arch/xtensa/src/esp32s2/Kconfig ## @@ -738,50 +749,6 @@ config ESP32S2_SPIRAM_IGNORE_NOTFOUND panic. If this is

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833226952 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833227465 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
acassis commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833229430 ## File path: arch/xtensa/src/esp32s2/rom/esp32s2_opi_flash.h ## @@ -0,0 +1,367 @@ +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833230607 ## File path: arch/risc-v/src/common/riscv_swint.c ## @@ -440,6 +472,22 @@ int riscv_swint(int irq, void *context, void *arg) r

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833232130 ## File path: arch/xtensa/src/esp32s2/Kconfig ## @@ -718,6 +724,11 @@ config ESP32S2_SPIRAM_SPEED_80M endchoice # ESP32S2_SPIRAM_SPEED +

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833233659 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833236049 ## File path: arch/risc-v/src/common/riscv_swint.c ## @@ -415,6 +429,24 @@ int riscv_swint(int irq, void *context, void *arg) regs[REG_A

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
pussuw commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833237211 ## File path: arch/risc-v/src/common/riscv_swint.c ## @@ -440,6 +472,22 @@ int riscv_swint(int irq, void *context, void *arg) regs[REG_I

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
acassis commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833241061 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833241902 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833243039 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833245470 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833246081 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833247209 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833249342 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.h ## @@ -0,0 +1,150 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833250362 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833254530 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833255175 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r832747839 ## File path: arch/xtensa/src/esp32s2/esp32s2_spiram.c ## @@ -0,0 +1,450 @@ +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833255505 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833255899 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833256820 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833257625 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833259224 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833259224 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833260540 ## File path: arch/xtensa/src/esp32s2/esp32s2_psram.c ## @@ -0,0 +1,729 @@ +/

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5828: Show assigned cpu in dump task

2022-03-23 Thread GitBox
xiaoxiang781216 merged pull request #5828: URL: https://github.com/apache/incubator-nuttx/pull/5828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated: arch: Show assigned cpu in dump task

2022-03-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9cffc10 arch: Show assigned cpu in

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5831: RISC-V: Add kernel stack

2022-03-23 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5831: URL: https://github.com/apache/incubator-nuttx/pull/5831#discussion_r833325176 ## File path: arch/risc-v/src/common/riscv_swint.c ## @@ -440,6 +472,22 @@ int riscv_swint(int irq, void *context, void *arg) r

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833366981 ## File path: arch/xtensa/src/esp32s2/rom/esp32s2_opi_flash.h ## @@ -0,0 +1,367 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5827: Add SPIRAM to ESP32-S2

2022-03-23 Thread GitBox
gustavonihei commented on a change in pull request #5827: URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833376241 ## File path: arch/xtensa/src/esp32s2/Kconfig ## @@ -683,6 +681,14 @@ endmenu # SPI Flash configuration menu "SPI RAM Config" Review commen

  1   2   >