[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #944: Add a system tool to get/set hostname

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #944: URL: https://github.com/apache/incubator-nuttx-apps/pull/944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #945: examples/mqttc: Fix handling of getaddrinfo errors

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #945: URL: https://github.com/apache/incubator-nuttx-apps/pull/945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[incubator-nuttx-apps] branch master updated: examples/mqttc: Fix handling of getaddrinfo errors

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new ec93611 examples/mqttc: Fix ha

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #943: Update PWM example to handle extra channels

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #943: URL: https://github.com/apache/incubator-nuttx-apps/pull/943#issuecomment-1002477872 @normanr some style issue need fixed: https://github.com/apache/incubator-nuttx-apps/runs/4657076135?check_suite_focus=true -- This is an automated mes

[GitHub] [incubator-nuttx] anchao opened a new pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
anchao opened a new pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104 ## Summary net/udp: rename NET_UDP_CONNS to NET_UDP_CONNS_PER_BLOCK net/tcp: rename NET_TCP_CONNS to NET_TCP_CONNS_PER_BLOCK net/udp: allocate udp connect dynamically net/tcp: all

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5102: net/tcp(unbuffered): removed excessive overwrites of conn->sndseq

2021-12-29 Thread GitBox
a-lunev commented on a change in pull request #5102: URL: https://github.com/apache/incubator-nuttx/pull/5102#discussion_r776245169 ## File path: net/tcp/tcp_input.c ## @@ -737,12 +736,14 @@ static void tcp_input(FAR struct net_driver_s *dev, uint8_t domain, }

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5105: arch/arm: Fix rebase error in arm_backtrace_thumb.c

2021-12-29 Thread GitBox
xiaoxiang781216 opened a new pull request #5105: URL: https://github.com/apache/incubator-nuttx/pull/5105 ## Summary ## Impact sim backtrace ## Testing test locally -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-nuttx-apps] normanr commented on issue #633: mutliple PROGNAME not working correctly

2021-12-29 Thread GitBox
normanr commented on issue #633: URL: https://github.com/apache/incubator-nuttx-apps/issues/633#issuecomment-1002524090 Instead of finding the index of the string, you could zip the two lists together (https://riptutorial.com/makefile/example/23643/zipping-lists), and then eval a template

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5106: arch/risc-v: Refine riscv_testset.S

2021-12-29 Thread GitBox
no1wudi opened a new pull request #5106: URL: https://github.com/apache/incubator-nuttx/pull/5106 ## Summary riscv_testset.S depends on riscv A (atomic) extension, in this patch: * Move riscv_testset.S to common * Enable testset support by ARCH_RV_ISA_A selected * Add riscv_tests

[GitHub] [incubator-nuttx-apps] normanr commented on pull request #943: Update PWM example to handle extra channels

2021-12-29 Thread GitBox
normanr commented on pull request #943: URL: https://github.com/apache/incubator-nuttx-apps/pull/943#issuecomment-1002540625 > @normanr some style issue need fixed: https://github.com/apache/incubator-nuttx-apps/runs/4657076135?check_suite_focus=true Fixed. I'd been working to 78 ch

[incubator-nuttx] 04/07: arch/renesas: Undefine macro B0 to avoid the confliction

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 228442ee239092df667d22f602b7057f9dcc73cb Author: Xiang Xiao AuthorDate: Sat Dec 18 01:18:34 2021 +0800

[incubator-nuttx] branch master updated (901361b -> a698100)

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 901361b arch/risc-v: Move more files to common new a010cb1 serial: Make SIGINT and SIGTSTP work

[incubator-nuttx] 01/07: serial: Make SIGINT and SIGTSTP work even without CONFIG_SERIAL_TERMIOS

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a010cb1af1d1e49e6e4ae15f724de96a50bdeeb5 Author: Xiang Xiao AuthorDate: Fri Dec 17 22:03:10 2021 +0800

[incubator-nuttx] 02/07: serial: Move tcdrain implementation from drivers/serial to libc

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 86684105f9e6a603b5230c6c49f3232cc045c639 Author: Xiang Xiao AuthorDate: Fri Dec 17 22:02:43 2021 +0800

[GitHub] [incubator-nuttx] gustavonihei merged pull request #5017: libc: Enable terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread GitBox
gustavonihei merged pull request #5017: URL: https://github.com/apache/incubator-nuttx/pull/5017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[incubator-nuttx] 06/07: sched: Remove the condition guard from getppid prototype

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 965f7641fd2c3911f64619c34e0705684e0b5fa6 Author: Xiang Xiao AuthorDate: Fri Dec 17 02:57:31 2021 +0800

[incubator-nuttx] 03/07: Fix termios/lib_cfspeed.c:78:5: error: large integer implicitly truncated to unsigned type

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 077a28eff6930350f7037d271b69711a20217db4 Author: Xiang Xiao AuthorDate: Fri Dec 17 17:19:43 2021 +0800

[incubator-nuttx] 07/07: sched: Remove the condition guard from environ macro

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit a698100de320ae0e68548b9b1deb90431482db96 Author: Xiang Xiao AuthorDate: Sun Dec 19 17:24:25 2021 +0800

[incubator-nuttx] 05/07: libc: Implement terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread gustavonihei
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 4262b09cbf08a6721515531263f28fbd21e547d5 Author: Xiang Xiao AuthorDate: Fri Dec 17 02:58:49 2021 +0800

[GitHub] [incubator-nuttx] normanr opened a new pull request #5107: Ensure that sethostname null terminates the hostname correctly

2021-12-29 Thread GitBox
normanr opened a new pull request #5107: URL: https://github.com/apache/incubator-nuttx/pull/5107 ## Summary commit e1c306f2dd3b8f4f304a77a908e965c05fb3eab2 added sethostname. The null terminator should be added after the new hostname (and only at the very end if the new hostname is the

[incubator-nuttx] branch master updated: net/tcp(unbuffered): removed excessive overwrites of conn->sndseq (conn->sndseq was updated in multiple places that was unreasonable and complicated).

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2b60468 net/tcp(unbuffered): remove

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5102: net/tcp(unbuffered): removed excessive overwrites of conn->sndseq

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #5102: URL: https://github.com/apache/incubator-nuttx/pull/5102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5107: Ensure that sethostname null terminates the hostname correctly

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5107: URL: https://github.com/apache/incubator-nuttx/pull/5107#discussion_r776292787 ## File path: libs/libc/unistd/lib_sethostname.c ## @@ -116,8 +116,8 @@ int sethostname(FAR const char *name, size_t size) */ fla

[GitHub] [incubator-nuttx] normanr commented on pull request #5017: libc: Enable terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread GitBox
normanr commented on pull request #5017: URL: https://github.com/apache/incubator-nuttx/pull/5017#issuecomment-1002561641 fyi, I get the following with `CONFIG_SERIAL_TERMIOS` disabled (fine without): ``` make[1]: Entering directory '/home/normanr/src/nuttx/nuttx/drivers' CC: seri

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5107: Ensure that sethostname null terminates the hostname correctly

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5107: URL: https://github.com/apache/incubator-nuttx/pull/5107#issuecomment-1002561785 Let's squash the patch into one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: arch/risc-v: Refine riscv_testset.S

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c15195b arch/risc-v: Refine riscv_t

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5106: arch/risc-v: Refine riscv_testset.S

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #5106: URL: https://github.com/apache/incubator-nuttx/pull/5106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5017: libc: Enable terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5017: URL: https://github.com/apache/incubator-nuttx/pull/5017#issuecomment-1002563451 > fyi, I get the following with `CONFIG_SERIAL_TERMIOS` disabled (fine without): > > ``` > make[1]: Entering directory '/home/normanr/src/nuttx/nuttx/d

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4989: sched: fix bug in the function nxsched_resume_scheduler

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #4989: URL: https://github.com/apache/incubator-nuttx/pull/4989#issuecomment-1002568372 @zhaoxiu-zeng could you split the unrelated patch to the different PR? So people can get the summary info from title and review the change more smooth. -- Thi

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #633: mutliple PROGNAME not working correctly

2021-12-29 Thread GitBox
xiaoxiang781216 commented on issue #633: URL: https://github.com/apache/incubator-nuttx-apps/issues/633#issuecomment-1002569712 Yes, this is the right approach to fix this problem I discussed internally with @anchao . -- This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #943: Update PWM example to handle extra channels

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #943: URL: https://github.com/apache/incubator-nuttx-apps/pull/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[incubator-nuttx-apps] branch master updated (ec93611 -> 2e773bc)

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from ec93611 examples/mqttc: Fix handling of getaddrinfo errors add 75c1e43 increase number of sup

[GitHub] [incubator-nuttx] anchao commented on pull request #5105: arch/arm: Fix rebase error in arm_backtrace_thumb.c

2021-12-29 Thread GitBox
anchao commented on pull request #5105: URL: https://github.com/apache/incubator-nuttx/pull/5105#issuecomment-1002576007 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [incubator-nuttx] anchao merged pull request #5105: arch/arm: Fix rebase error in arm_backtrace_thumb.c

2021-12-29 Thread GitBox
anchao merged pull request #5105: URL: https://github.com/apache/incubator-nuttx/pull/5105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[incubator-nuttx] branch master updated (c15195b -> b92c90e)

2021-12-29 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c15195b arch/risc-v: Refine riscv_testset.S add b92c90e arch/arm: Fix rebase error in arm_backtrace_t

[incubator-nuttx-apps] branch master updated: Fix link error due to missing libapps.a in KERNEL build

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new d1bcd29 Fix link error due to

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #946: Fix link error due to missing libapps.a in KERNEL build

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #946: URL: https://github.com/apache/incubator-nuttx-apps/pull/946#issuecomment-1002580701 > I'm not 100% sure this is the correct way to fix the ELFLD linkage. I tried to follow the git history and the modifications made to the build system but I

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #946: Fix link error due to missing libapps.a in KERNEL build

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #946: URL: https://github.com/apache/incubator-nuttx-apps/pull/946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] DS-LK opened a new pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
DS-LK opened a new pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108 Signed-off-by: zhouliang3 Change-Id: I1fdc3c6752613226900460ccafb0a2271ae0d954 ## Summary strncpy does not end with'\0', stack overflow may occur during use. ## Impact After st

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776311207 ## File path: net/tcp/tcp_conn.c ## @@ -110,15 +108,12 @@ static FAR struct tcp_conn_s * tcp_listener(uint8_t domain, FAR const union i

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108#issuecomment-1002588087 Let's ignore the false style warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108#issuecomment-1002588087 @DS-LK let's fix the style warning: ``` Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/fs/smartfs/smartfs_procfs.c:607:10: error: M

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
davids5 commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776320437 ## File path: include/nuttx/net/netconfig.h ## @@ -456,11 +456,11 @@ * connection requires approximately 30 bytes of memory. */ -#ifndef CON

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108#issuecomment-1002588087 @DS-LK let's fix the style warning: ``` Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/fs/smartfs/smartfs_procfs.c:607:10: error: M

[GitHub] [incubator-nuttx] jlaitine opened a new pull request #5109: risc-v/mpfs: Add MSSIO GPIO pinmap configuration

2021-12-29 Thread GitBox
jlaitine opened a new pull request #5109: URL: https://github.com/apache/incubator-nuttx/pull/5109 Add a pinmap header for mpfs to be able to configure MSSIO GPIOs This also adds Kconfigs for some different chip/package types of the PolarFire SOC Signed-off-by: Jukka Laitinen

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5107: Ensure that sethostname null terminates the hostname correctly

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5107: URL: https://github.com/apache/incubator-nuttx/pull/5107#discussion_r776322475 ## File path: libs/libc/unistd/lib_sethostname.c ## @@ -116,8 +116,8 @@ int sethostname(FAR const char *name, size_t size) */ fla

[GitHub] [incubator-nuttx] anchao opened a new pull request #5110: net/devif: allocate devif callback dynamically

2021-12-29 Thread GitBox
anchao opened a new pull request #5110: URL: https://github.com/apache/incubator-nuttx/pull/5110 ## Summary devif: allocate devif callback dynamically net/devif: rename NET_NACTIVESOCKETS to NET_NACTIVESOCKETS_PER_BLOCK ## Impact netdev interface callback allocate

[GitHub] [incubator-nuttx] DS-LK commented on pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
DS-LK commented on pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108#issuecomment-1002597031 > @DS-LK let's fix the style warning: > > ``` > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/fs/smartfs/smartfs_procfs.c:607:10: error: Multip

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
anchao commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776329530 ## File path: net/tcp/tcp_conn.c ## @@ -110,15 +108,12 @@ static FAR struct tcp_conn_s * tcp_listener(uint8_t domain, FAR const union ip_addr_u

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
anchao commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776330878 ## File path: net/tcp/tcp_conn.c ## @@ -61,6 +61,8 @@ #include #include +#include Review comment: Done ## File path: net/tc

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
anchao commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776330976 ## File path: include/nuttx/net/netconfig.h ## @@ -456,11 +456,11 @@ * connection requires approximately 30 bytes of memory. */ -#ifndef CONF

[GitHub] [incubator-nuttx] normanr commented on pull request #5017: libc: Enable terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread GitBox
normanr commented on pull request #5017: URL: https://github.com/apache/incubator-nuttx/pull/5017#issuecomment-1002600790 I think I started with `bl602evb:gpio`, but I wanted to enable `TTY_SIGINT` and `SIG_DEFAULT` so had `SERIAL_TERMIOS` enabled, then when I saw this commit I tried with

[GitHub] [incubator-nuttx] anchao closed pull request #5086: arch/arm: add classification of cortex-a/m/r

2021-12-29 Thread GitBox
anchao closed pull request #5086: URL: https://github.com/apache/incubator-nuttx/pull/5086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
davids5 commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776336621 ## File path: net/tcp/tcp_conn.c ## @@ -538,22 +570,10 @@ static inline int tcp_ipv6_bind(FAR struct tcp_conn_s *conn, void tcp_initialize(voi

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
anchao commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776337610 ## File path: net/tcp/tcp_conn.c ## @@ -538,22 +570,10 @@ static inline int tcp_ipv6_bind(FAR struct tcp_conn_s *conn, void tcp_initialize(void

[GitHub] [incubator-nuttx] jlaitine opened a new pull request #5111: boards/m100pfsevp: Decrease DDR lane temination values to 40 ohm and …

2021-12-29 Thread GitBox
jlaitine opened a new pull request #5111: URL: https://github.com/apache/incubator-nuttx/pull/5111 …increase BCLKSCLK_OFFSET This fixes problems with DDR training sequence on aries m100pfs board - Set LIBERO_SETTING_RPC_ODT_* to 6, which matches 40 ohm. Originally it was 1

[GitHub] [incubator-nuttx] normanr commented on pull request #5099: arch/sim: Implement up_backtrace

2021-12-29 Thread GitBox
normanr commented on pull request #5099: URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002606551 very nice, are there plans to support this for risc-v too? It looks like it's only missing the `CMN_CSRCS` condition in the `Make.defs` files. -- This is an automated

[GitHub] [incubator-nuttx] normanr commented on a change in pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
normanr commented on a change in pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108#discussion_r776340258 ## File path: fs/binfs/fs_binfs.c ## @@ -326,7 +326,7 @@ static int binfs_readdir(struct inode *mountpt, struct fs_dirent_s *dir) finfo(

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5099: arch/sim: Implement up_backtrace

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5099: URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002609532 risc-v is already supported by @anchao , you just need add up_backtrace.c into CMN_CSRS and turn on the option. -- This is an automated message from the Apach

[GitHub] [incubator-nuttx] normanr commented on a change in pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
normanr commented on a change in pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108#discussion_r776342120 ## File path: fs/binfs/fs_binfs.c ## @@ -326,7 +326,7 @@ static int binfs_readdir(struct inode *mountpt, struct fs_dirent_s *dir) finfo(

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5017: libc: Enable terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5017: URL: https://github.com/apache/incubator-nuttx/pull/5017#issuecomment-1002610812 Some patch doesn't upstream yet, @liguiding is preparing them, so wait for a moment. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx] a-lunev opened a new pull request #5112: bcm43xxx: supported ARM CR4 core and bcm43455 chip in particular

2021-12-29 Thread GitBox
a-lunev opened a new pull request #5112: URL: https://github.com/apache/incubator-nuttx/pull/5112 ## Summary Supported ARM CR4 core in bcm43xxx driver and bcm43455 chip in particular. ## Impact bcm43xxx driver ## Testing -- This is an automated message from the

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5017: libc: Enable terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5017: URL: https://github.com/apache/incubator-nuttx/pull/5017#issuecomment-1002610812 Some patch doesn't upstream yet, @liguiding is preparing them, so wait a moment. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-nuttx] normanr commented on a change in pull request #5107: Ensure that sethostname null terminates the hostname correctly

2021-12-29 Thread GitBox
normanr commented on a change in pull request #5107: URL: https://github.com/apache/incubator-nuttx/pull/5107#discussion_r77636 ## File path: libs/libc/unistd/lib_sethostname.c ## @@ -116,8 +116,8 @@ int sethostname(FAR const char *name, size_t size) */ flags = ent

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5099: arch/sim: Implement up_backtrace

2021-12-29 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5099: URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002609532 risc-v is already supported by @anchao , you just need add up_backtrace.c into CMN_CSRS and turn on the option: https://github.com/apache/incubator-nuttx

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5112: bcm43xxx: supported ARM CR4 core and bcm43455 chip in particular

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5112: URL: https://github.com/apache/incubator-nuttx/pull/5112#issuecomment-1002619200 @a-lunev could you share some performance and stability data about bcm43xxx? We are very interested in the quality of this driver. -- This is an automated mes

[GitHub] [incubator-nuttx] normanr commented on pull request #5099: arch/sim: Implement up_backtrace

2021-12-29 Thread GitBox
normanr commented on pull request #5099: URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002621229 I'm not sure if bl602 has enough space for `ALLSYMS`, but I managed to get backtrace working by adding ``` ifeq ($(CONFIG_SCHED_BACKTRACE),y) CMN_CSRCS += riscv

[GitHub] [incubator-nuttx] normanr commented on pull request #5099: arch/sim: Implement up_backtrace

2021-12-29 Thread GitBox
normanr commented on pull request #5099: URL: https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-1002624146 It works great, and with only 15% overhead! (480K --> 550K) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5110: net/devif: allocate devif callback dynamically

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5110: URL: https://github.com/apache/incubator-nuttx/pull/5110#discussion_r776363168 ## File path: net/devif/devif_callback.c ## @@ -262,7 +276,7 @@ FAR struct devif_callback_s * /* Check the head of the free list */

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5110: net/devif: allocate devif callback dynamically

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5110: URL: https://github.com/apache/incubator-nuttx/pull/5110#discussion_r776363282 ## File path: net/devif/devif_callback.c ## @@ -35,14 +35,15 @@ #include #include +#include Review comment: move before lin

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5110: net/devif: allocate devif callback dynamically

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5110: URL: https://github.com/apache/incubator-nuttx/pull/5110#discussion_r776363965 ## File path: net/socket/Kconfig ## @@ -5,13 +5,12 @@ menu "Socket Support" -config NET_NACTIVESOCKETS - int "Max socket operat

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5110: net/devif: allocate devif callback dynamically

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5110: URL: https://github.com/apache/incubator-nuttx/pull/5110#discussion_r776364093 ## File path: net/socket/Kconfig ## @@ -5,13 +5,12 @@ menu "Socket Support" -config NET_NACTIVESOCKETS - int "Max socket operat

[GitHub] [incubator-nuttx] normanr opened a new pull request #5113: Add backtrace to risc-v common sources

2021-12-29 Thread GitBox
normanr opened a new pull request #5113: URL: https://github.com/apache/incubator-nuttx/pull/5113 ## Summary Improvements from https://github.com/apache/incubator-nuttx/pull/5057 require the code to be linked in (https://github.com/apache/incubator-nuttx/pull/5099#issuecomment-100260953

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #5114: serial: add CONFIG_TTY_LAUNCH support

2021-12-29 Thread GitBox
GUIDINGLI opened a new pull request #5114: URL: https://github.com/apache/incubator-nuttx/pull/5114 ## Summary serial: add CONFIG_TTY_LAUNCH support this allow user start new program from tty - **TTY_LAUNCH** this depends on ``CONFIG_TTY_LAUNCH``, this feature

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776365570 ## File path: net/tcp/Kconfig ## @@ -50,11 +50,11 @@ config NET_TCPURGDATA compiled in. Urgent data (out-of-band data) is

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5017: libc: Enable terminal api regardless of CONFIG_SERIAL_TERMIOS setting

2021-12-29 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5017: URL: https://github.com/apache/incubator-nuttx/pull/5017#issuecomment-1002610812 Some patch doesn't upstream yet, @GUIDINGLI is preparing them, so wait a moment. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-nuttx] a-lunev commented on pull request #5112: bcm43xxx: supported ARM CR4 core and bcm43455 chip in particular

2021-12-29 Thread GitBox
a-lunev commented on pull request #5112: URL: https://github.com/apache/incubator-nuttx/pull/5112#issuecomment-1002637498 > @a-lunev could you share some performance and stability data about bcm43xxx? We are very interested in the quality of this driver. I have tested the performance

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5104: net/tcp/udp: allocate tcp/udp connect dynamically

2021-12-29 Thread GitBox
davids5 commented on a change in pull request #5104: URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776371181 ## File path: net/tcp/Kconfig ## @@ -50,11 +50,11 @@ config NET_TCPURGDATA compiled in. Urgent data (out-of-band data) is a rarely

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5114: serial: add CONFIG_TTY_LAUNCH support

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5114: URL: https://github.com/apache/incubator-nuttx/pull/5114#issuecomment-1002640191 @acassis to save the ram on the resource limited system, we let nsh exist after finish the initialization. This patch bring nsh back in emerging case. -- This

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5114: serial: add CONFIG_TTY_LAUNCH support

2021-12-29 Thread GitBox
xiaoxiang781216 edited a comment on pull request #5114: URL: https://github.com/apache/incubator-nuttx/pull/5114#issuecomment-1002640191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5108: Change fs strncpy to strlcpy to avoid losing'\0'

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5108: URL: https://github.com/apache/incubator-nuttx/pull/5108#discussion_r776374151 ## File path: fs/binfs/fs_binfs.c ## @@ -326,7 +326,7 @@ static int binfs_readdir(struct inode *mountpt, struct fs_dirent_s *dir)

[incubator-nuttx] branch master updated: boards/m100pfsevp: Decrease DDR lane temination values to 40 ohm and increase BCLKSCLK_OFFSET

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new fc41bb7 boards/m100pfsevp: Decrease

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5111: boards/m100pfsevp: Decrease DDR lane temination values to 40 ohm and …

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #5111: URL: https://github.com/apache/incubator-nuttx/pull/5111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5115: arch/risc-v: Refine syscall interface

2021-12-29 Thread GitBox
no1wudi opened a new pull request #5115: URL: https://github.com/apache/incubator-nuttx/pull/5115 ## Summary ## Impact Refactor only. ## Testing CI and rv32-virt:ostest -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-nuttx] AlanRosenthal opened a new pull request #5116: Remove .clean_context

2021-12-29 Thread GitBox
AlanRosenthal opened a new pull request #5116: URL: https://github.com/apache/incubator-nuttx/pull/5116 ## Summary These changes are from this PR: https://github.com/apache/incubator-nuttx/pull/5069 However I felt they were better as a stand only change. ## Impact The `.clea

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5115: arch/risc-v: Refine syscall interface

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5115: URL: https://github.com/apache/incubator-nuttx/pull/5115#discussion_r776401369 ## File path: arch/risc-v/include/common/syscall.h ## @@ -1,5 +1,5 @@ /**

[GitHub] [incubator-nuttx] jlaitine commented on pull request #5109: risc-v/mpfs: Add MSSIO GPIO pinmap configuration

2021-12-29 Thread GitBox
jlaitine commented on pull request #5109: URL: https://github.com/apache/incubator-nuttx/pull/5109#issuecomment-1002672983 Synced mpfs/opensbi defconfig as well to make checks pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5115: arch/risc-v: Refine syscall interface

2021-12-29 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5115: URL: https://github.com/apache/incubator-nuttx/pull/5115#discussion_r776404189 ## File path: arch/risc-v/src/rv32m1/Make.defs ## @@ -23,7 +23,7 @@ HEAD_ASRC = rv32m1_vectors.S # Specify our general Assembly files

[GitHub] [incubator-nuttx] igordrago commented on pull request #2916: arm/rp2040: Raspberry Pi Pico SMP support

2021-12-29 Thread GitBox
igordrago commented on pull request #2916: URL: https://github.com/apache/incubator-nuttx/pull/2916#issuecomment-1002676336 ![image](https://user-images.githubusercontent.com/62919816/147683366-fa08dc80-9880-4eac-9508-97dfca7f62ee.png) Yes I just did, the env variable is set -- Th

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5116: Remove .clean_context

2021-12-29 Thread GitBox
Ouss4 commented on pull request #5116: URL: https://github.com/apache/incubator-nuttx/pull/5116#issuecomment-1002678398 We don't need the same for `menuconfig` and other such targets? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5112: bcm43xxx: supported ARM CR4 core and bcm43455 chip in particular

2021-12-29 Thread GitBox
xiaoxiang781216 commented on pull request #5112: URL: https://github.com/apache/incubator-nuttx/pull/5112#issuecomment-1002695292 BTW, how much frequency do your host MCU run on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[incubator-nuttx] branch master updated: Ensure that sethostname null terminates the hostname correctly

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new df956b0 Ensure that sethostname nul

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5107: Ensure that sethostname null terminates the hostname correctly

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #5107: URL: https://github.com/apache/incubator-nuttx/pull/5107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated: Add backtrace to risc-v common sources

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 091322b Add backtrace to risc-v com

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5113: Add backtrace to risc-v common sources

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #5113: URL: https://github.com/apache/incubator-nuttx/pull/5113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated: bcm43xxx: supported ARM CR4 core and bcm43455 chip in particular

2021-12-29 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 76bb5f5 bcm43xxx: supported ARM CR4

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5112: bcm43xxx: supported ARM CR4 core and bcm43455 chip in particular

2021-12-29 Thread GitBox
xiaoxiang781216 merged pull request #5112: URL: https://github.com/apache/incubator-nuttx/pull/5112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5117: xtensa/esp32: Add support for enabling hardware Flash Encryption on boot

2021-12-29 Thread GitBox
gustavonihei opened a new pull request #5117: URL: https://github.com/apache/incubator-nuttx/pull/5117 ## Summary This PR intends to add support for encrypting the contents of the SPI Flash on boot using the MCUboot bootloader. **Flash encryption** is intended for encrypting the c

[GitHub] [incubator-nuttx] igordrago commented on pull request #2916: arm/rp2040: Raspberry Pi Pico SMP support

2021-12-29 Thread GitBox
igordrago commented on pull request #2916: URL: https://github.com/apache/incubator-nuttx/pull/2916#issuecomment-1002706965 I used sudo make instead of make, which caused the issue. Now worked. Tks for the help! -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-nuttx] a-lunev commented on pull request #5112: bcm43xxx: supported ARM CR4 core and bcm43455 chip in particular

2021-12-29 Thread GitBox
a-lunev commented on pull request #5112: URL: https://github.com/apache/incubator-nuttx/pull/5112#issuecomment-1002717244 > BTW, how much frequency do your host MCU run on? I tested at 120 MHz, 200 MHz and 400 MHz (ARM CM3/CM7). The higher host MCU frequency, the higher the driver pe

  1   2   >