GUIDINGLI commented on a change in pull request #4759:
URL: https://github.com/apache/incubator-nuttx/pull/4759#discussion_r743436110
##
File path: sched/irq/irq_dispatch.c
##
@@ -184,6 +185,14 @@ void irq_dispatch(int irq, FAR void *context)
sched_note_irqhandler(irq, vecto
GUIDINGLI commented on pull request #4782:
URL: https://github.com/apache/incubator-nuttx/pull/4782#issuecomment-961683498
NOT alloc memory, just get the mm lock to check corruption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
yunkya2 opened a new pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786
## Summary
Support I2C bus reset for RP2040 to recover from bus stuck conditions.
(Related discussion: https://github.com/apache/incubator-nuttx/issues/4746)
## Impact
RP2040 onl
yunkya2 commented on issue #4746:
URL:
https://github.com/apache/incubator-nuttx/issues/4746#issuecomment-961686869
I have incorporated the bus recovery sequence like another I2C_RESET
implementation and issued MR #4786.
The code sequence seems to be working as expected, but I cannot co
xiewenxiang opened a new pull request #4787:
URL: https://github.com/apache/incubator-nuttx/pull/4787
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yunkya2 edited a comment on issue #4746:
URL:
https://github.com/apache/incubator-nuttx/issues/4746#issuecomment-961686869
I have incorporated the bus recovery sequence like another I2C_RESET
implementation and issued PR #4786.
The code sequence seems to be working as expected, but I ca
xiaoxiang781216 commented on pull request #4758:
URL: https://github.com/apache/incubator-nuttx/pull/4758#issuecomment-961711006
@GUIDINGLI is it too rigid to always select DEV_SIMPLE_ADDRENV which make
it's impossible to implement the more advanced addrenv.
--
This is an automated messa
xiaoxiang781216 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743474380
##
File path: arch/arm/Kconfig
##
@@ -232,6 +232,7 @@ config ARCH_CHIP_RP2040
select ARCH_HAVE_MULTICPU
select ARCH_HAVE_T
Ouss4 commented on pull request #4782:
URL: https://github.com/apache/incubator-nuttx/pull/4782#issuecomment-961748337
This will actually make the `free` part succeed, and we will be freeing
memory if we successfully get the lock on the first try. `malloc` in the other
hand only `DEBUGVERI
eenurkka opened a new pull request #4788:
URL: https://github.com/apache/incubator-nuttx/pull/4788
cppcheck reports the following:
arch/risc-v/src/mpfs/mpfs_emmcsd.c:2375:22: error: Uninitialized variable:
waitbits [uninitvar]
while (!(status & (waitbits | MPFS_EMMCSD_SRS12_EINT
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f8832f7 mpfs: emmcsd: fix uniniti
Ouss4 merged pull request #4788:
URL: https://github.com/apache/incubator-nuttx/pull/4788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
davids5 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743592637
##
File path: arch/arm/src/rp2040/rp2040_i2c.c
##
@@ -639,7 +642,158 @@ static int rp2040_i2c_transfer(FAR struct i2c_master_s
*dev,
#ifdef CONF
davids5 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743592637
##
File path: arch/arm/src/rp2040/rp2040_i2c.c
##
@@ -639,7 +642,158 @@ static int rp2040_i2c_transfer(FAR struct i2c_master_s
*dev,
#ifdef CONF
yunkya2 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743631676
##
File path: arch/arm/src/rp2040/rp2040_i2c.c
##
@@ -639,7 +642,158 @@ static int rp2040_i2c_transfer(FAR struct i2c_master_s
*dev,
#ifdef CONF
davids5 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743634081
##
File path: arch/arm/src/rp2040/rp2040_i2c.c
##
@@ -639,7 +642,158 @@ static int rp2040_i2c_transfer(FAR struct i2c_master_s
*dev,
#ifdef CONF
GUIDINGLI closed pull request #4758:
URL: https://github.com/apache/incubator-nuttx/pull/4758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: comm
acassis commented on pull request #4787:
URL: https://github.com/apache/incubator-nuttx/pull/4787#issuecomment-962085494
Hi @xiewenxiang it is returning an error:
```
riscv64-unknown-elf-ld:
/github/workspace/sources/nuttx/staging/libarch.a(esp32c3_ble_adapter.o): in
function `read_m
acassis commented on pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#issuecomment-961302209
Great work @btashton and @gustavonihei !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiaoxiang781216 commented on pull request #4758:
URL: https://github.com/apache/incubator-nuttx/pull/4758#issuecomment-961711006
@GUIDINGLI is it too rigid to always select DEV_SIMPLE_ADDRENV which make
it's impossible to implement the more advanced addrenv.
--
This is an automated messa
xiaoxiang781216 merged pull request #4784:
URL: https://github.com/apache/incubator-nuttx/pull/4784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
acassis commented on pull request #4787:
URL: https://github.com/apache/incubator-nuttx/pull/4787#issuecomment-962085494
Hi @xiewenxiang it is returning an error:
```
riscv64-unknown-elf-ld:
/github/workspace/sources/nuttx/staging/libarch.a(esp32c3_ble_adapter.o): in
function `read_m
xiaoxiang781216 commented on pull request #4774:
URL: https://github.com/apache/incubator-nuttx/pull/4774#issuecomment-961311106
@jarivanewijk is it ready to remove the draft from PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
patacongo commented on pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779#issuecomment-961464799
The only issue with moving these functions into libc is that it modifies the
OS interface definition and violates the portable POSIX interface.
We normally keep
xiaoxiang781216 merged pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 merged pull request #4760:
URL: https://github.com/apache/incubator-nuttx/pull/4760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 merged pull request #875:
URL: https://github.com/apache/incubator-nuttx-apps/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
xiaoxiang781216 merged pull request #880:
URL: https://github.com/apache/incubator-nuttx-apps/pull/880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
gustavonihei commented on pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#issuecomment-961289548
Created https://github.com/apache/incubator-nuttx-apps/issues/877 for
addressing the remaining task.
--
This is an automated message from the Apache Git Servi
Ouss4 commented on pull request #4782:
URL: https://github.com/apache/incubator-nuttx/pull/4782#issuecomment-961748337
This will actually make the `free` part succeed, and we will be freeing
memory if we successfully get the lock on the first try. `malloc` in the other
hand only `DEBUGVERI
xiaoxiang781216 merged pull request #879:
URL: https://github.com/apache/incubator-nuttx-apps/pull/879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
davids5 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743592637
##
File path: arch/arm/src/rp2040/rp2040_i2c.c
##
@@ -639,7 +642,158 @@ static int rp2040_i2c_transfer(FAR struct i2c_master_s
*dev,
#ifdef CONF
xiaoxiang781216 merged pull request #4785:
URL: https://github.com/apache/incubator-nuttx/pull/4785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on issue #877:
URL:
https://github.com/apache/incubator-nuttx-apps/issues/877#issuecomment-961320765
Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jarivanewijk commented on pull request #4774:
URL: https://github.com/apache/incubator-nuttx/pull/4774#issuecomment-961338049
@xiaoxiang781216, not yet, sorry. I need to find some time to finish this,
but that might not be until the end of next week.
I still want to have a look at so
GUIDINGLI commented on a change in pull request #4759:
URL: https://github.com/apache/incubator-nuttx/pull/4759#discussion_r743436110
##
File path: sched/irq/irq_dispatch.c
##
@@ -184,6 +185,14 @@ void irq_dispatch(int irq, FAR void *context)
sched_note_irqhandler(irq, vecto
xiaoxiang781216 merged pull request #4660:
URL: https://github.com/apache/incubator-nuttx/pull/4660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
jlaitine commented on pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779#issuecomment-961629697
> The only issue with moving these functions into libc is that it modifies
the OS interface definition and violates the portable POSIX interface.
>
> We normally
GUIDINGLI closed pull request #4758:
URL: https://github.com/apache/incubator-nuttx/pull/4758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: comm
yunkya2 edited a comment on issue #4746:
URL:
https://github.com/apache/incubator-nuttx/issues/4746#issuecomment-961686869
I have incorporated the bus recovery sequence like another I2C_RESET
implementation and issued PR #4786.
The code sequence seems to be working as expected, but I ca
yunkya2 commented on issue #4746:
URL:
https://github.com/apache/incubator-nuttx/issues/4746#issuecomment-961686869
I have incorporated the bus recovery sequence like another I2C_RESET
implementation and issued MR #4786.
The code sequence seems to be working as expected, but I cannot co
xiaoxiang781216 merged pull request #876:
URL: https://github.com/apache/incubator-nuttx-apps/pull/876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
patacongo edited a comment on pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779#issuecomment-961464799
The only issue with moving these functions into libc is that it modifies the
OS interface definition and violates the portable POSIX interface.
We normall
acassis merged pull request #566:
URL: https://github.com/apache/incubator-nuttx-apps/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: com
xiaoxiang781216 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743474380
##
File path: arch/arm/Kconfig
##
@@ -232,6 +232,7 @@ config ARCH_CHIP_RP2040
select ARCH_HAVE_MULTICPU
select ARCH_HAVE_T
xiaoxiang781216 commented on pull request #875:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/875#issuecomment-961323775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cocoacrumbs commented on pull request #875:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/875#issuecomment-961255347
Hi,
My understanding is that the reported "Mixed case identifier found" errors
can't be avoided for now since the source code for BAS has only been partly
Ouss4 commented on a change in pull request #4759:
URL: https://github.com/apache/incubator-nuttx/pull/4759#discussion_r743124566
##
File path: sched/irq/irq_dispatch.c
##
@@ -184,6 +185,14 @@ void irq_dispatch(int irq, FAR void *context)
sched_note_irqhandler(irq, vector, f
GUIDINGLI commented on pull request #4782:
URL: https://github.com/apache/incubator-nuttx/pull/4782#issuecomment-961683498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Ouss4 merged pull request #4788:
URL: https://github.com/apache/incubator-nuttx/pull/4788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-un
yunkya2 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743631676
##
File path: arch/arm/src/rp2040/rp2040_i2c.c
##
@@ -639,7 +642,158 @@ static int rp2040_i2c_transfer(FAR struct i2c_master_s
*dev,
#ifdef CONF
acassis commented on pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#issuecomment-961302209
Great work @btashton and @gustavonihei !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiaoxiang781216 commented on pull request #4758:
URL: https://github.com/apache/incubator-nuttx/pull/4758#issuecomment-961711006
@GUIDINGLI is it too rigid to always select DEV_SIMPLE_ADDRENV which make
it's impossible to implement the more advanced addrenv.
--
This is an automated messa
xiaoxiang781216 merged pull request #4784:
URL: https://github.com/apache/incubator-nuttx/pull/4784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
acassis commented on pull request #4787:
URL: https://github.com/apache/incubator-nuttx/pull/4787#issuecomment-962085494
Hi @xiewenxiang it is returning an error:
```
riscv64-unknown-elf-ld:
/github/workspace/sources/nuttx/staging/libarch.a(esp32c3_ble_adapter.o): in
function `read_m
xiaoxiang781216 commented on pull request #4774:
URL: https://github.com/apache/incubator-nuttx/pull/4774#issuecomment-961311106
@jarivanewijk is it ready to remove the draft from PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
patacongo commented on pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779#issuecomment-961464799
The only issue with moving these functions into libc is that it modifies the
OS interface definition and violates the portable POSIX interface.
We normally keep
xiaoxiang781216 merged pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 merged pull request #4760:
URL: https://github.com/apache/incubator-nuttx/pull/4760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 merged pull request #875:
URL: https://github.com/apache/incubator-nuttx-apps/pull/875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
xiaoxiang781216 merged pull request #880:
URL: https://github.com/apache/incubator-nuttx-apps/pull/880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
gustavonihei commented on pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#issuecomment-961289548
Created https://github.com/apache/incubator-nuttx-apps/issues/877 for
addressing the remaining task.
--
This is an automated message from the Apache Git Servi
Ouss4 commented on pull request #4782:
URL: https://github.com/apache/incubator-nuttx/pull/4782#issuecomment-961748337
This will actually make the `free` part succeed, and we will be freeing
memory if we successfully get the lock on the first try. `malloc` in the other
hand only `DEBUGVERI
xiaoxiang781216 merged pull request #879:
URL: https://github.com/apache/incubator-nuttx-apps/pull/879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
davids5 commented on a change in pull request #4786:
URL: https://github.com/apache/incubator-nuttx/pull/4786#discussion_r743592637
##
File path: arch/arm/src/rp2040/rp2040_i2c.c
##
@@ -639,7 +642,158 @@ static int rp2040_i2c_transfer(FAR struct i2c_master_s
*dev,
#ifdef CONF
xiaoxiang781216 merged pull request #4785:
URL: https://github.com/apache/incubator-nuttx/pull/4785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on issue #877:
URL:
https://github.com/apache/incubator-nuttx-apps/issues/877#issuecomment-961320765
Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jarivanewijk commented on pull request #4774:
URL: https://github.com/apache/incubator-nuttx/pull/4774#issuecomment-961338049
@xiaoxiang781216, not yet, sorry. I need to find some time to finish this,
but that might not be until the end of next week.
I still want to have a look at so
GUIDINGLI commented on a change in pull request #4759:
URL: https://github.com/apache/incubator-nuttx/pull/4759#discussion_r743436110
##
File path: sched/irq/irq_dispatch.c
##
@@ -184,6 +185,14 @@ void irq_dispatch(int irq, FAR void *context)
sched_note_irqhandler(irq, vecto
xiaoxiang781216 merged pull request #4660:
URL: https://github.com/apache/incubator-nuttx/pull/4660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
jlaitine commented on pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779#issuecomment-961629697
> The only issue with moving these functions into libc is that it modifies
the OS interface definition and violates the portable POSIX interface.
>
> We normally
yunkya2 edited a comment on issue #4746:
URL:
https://github.com/apache/incubator-nuttx/issues/4746#issuecomment-961686869
I have incorporated the bus recovery sequence like another I2C_RESET
implementation and issued PR #4786.
The code sequence seems to be working as expected, but I ca
GUIDINGLI closed pull request #4758:
URL: https://github.com/apache/incubator-nuttx/pull/4758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: comm
yunkya2 commented on issue #4746:
URL:
https://github.com/apache/incubator-nuttx/issues/4746#issuecomment-961686869
I have incorporated the bus recovery sequence like another I2C_RESET
implementation and issued MR #4786.
The code sequence seems to be working as expected, but I cannot co
xiaoxiang781216 merged pull request #876:
URL: https://github.com/apache/incubator-nuttx-apps/pull/876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
patacongo edited a comment on pull request #4779:
URL: https://github.com/apache/incubator-nuttx/pull/4779#issuecomment-961464799
The only issue with moving these functions into libc is that it modifies the
OS interface definition and violates the portable POSIX interface.
We normall
acassis merged pull request #566:
URL: https://github.com/apache/incubator-nuttx-apps/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: com
xiaoxiang781216 merged pull request #878:
URL: https://github.com/apache/incubator-nuttx-apps/pull/878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
davids5 opened a new pull request #4789:
URL: https://github.com/apache/incubator-nuttx/pull/4789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: co
79 matches
Mail list logo
