[GitHub] [incubator-nuttx-apps] GUIDINGLI opened a new pull request #801: Update Application.mk

2021-07-06 Thread GitBox
GUIDINGLI opened a new pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801 ## Summary Update Application.mk 1. Generate c source code dependence with c compiler and flags, It's wrong to invoke the c++ compiler with c++ flags 2. Fix https://github

[GitHub] [incubator-nuttx-apps] GUIDINGLI commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

2021-07-06 Thread GitBox
GUIDINGLI commented on pull request #800: URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874513110 Here is the fix: https://github.com/apache/incubator-nuttx-apps/pull/801 so we don't need revert. -- This is an automated message from the Apache Git Se

[GitHub] [incubator-nuttx] cwespressif opened a new pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
cwespressif opened a new pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077 ## Summary Add romfs configuration. ## Impact ## Testing - Tested with ESP32C3-Devkit `./tools/configure esp32c3-devkit:romfs` -- This is an automated m

[GitHub] [incubator-nuttx] anchao commented on pull request #4070: net/tcp: add window scale support

2021-07-06 Thread GitBox
anchao commented on pull request #4070: URL: https://github.com/apache/incubator-nuttx/pull/4070#issuecomment-874520270 @yamt I upload a new commit. When the window scale is enabled, the received buffer is easily over 64K. I modified the related data type to uint32_t to avoid the T

[GitHub] [incubator-nuttx] buyuer opened a new pull request #4078: Add include header file to rpmsg.h.

2021-07-06 Thread GitBox
buyuer opened a new pull request #4078: URL: https://github.com/apache/incubator-nuttx/pull/4078 When use netpacket/rpmsg.h,the compiler prompt that sa_family_t is not defined. Signed-off-by: buyuer -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx] buyuer closed pull request #4078: Add include header file to rpmsg.h.

2021-07-06 Thread GitBox
buyuer closed pull request #4078: URL: https://github.com/apache/incubator-nuttx/pull/4078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3114: usrsock/recv: guarantee all data is received before close

2021-07-06 Thread GitBox
masayuki2009 commented on pull request #3114: URL: https://github.com/apache/incubator-nuttx/pull/3114#issuecomment-874551078 > @masayuki2009 could you try the new change work with your hardware? @anchao @xiaoxiang781216 Sure but could you rebase the branch to the latest master?

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #4072: lpc17xx: Added WDT driver.

2021-07-06 Thread GitBox
fjpanag commented on a change in pull request #4072: URL: https://github.com/apache/incubator-nuttx/pull/4072#discussion_r664339115 ## File path: arch/arm/src/lpc17xx_40xx/hardware/lpc17_40_wdt.h ## @@ -89,6 +89,8 @@ /* Watchdog feed sequence register */ +#define WDT_FEED

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #801: Update Application.mk

2021-07-06 Thread GitBox
xiaoxiang781216 commented on pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134 > i still want this reverted unless a convincing use case for this unusual setup is provided. There are projects which have source files only different

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #4072: lpc17xx: Added WDT driver.

2021-07-06 Thread GitBox
fjpanag commented on a change in pull request #4072: URL: https://github.com/apache/incubator-nuttx/pull/4072#discussion_r664341175 ## File path: arch/arm/src/lpc17xx_40xx/lpc17_40_wdt.c ## @@ -0,0 +1,358 @@ +/

[GitHub] [incubator-nuttx] fjpanag commented on pull request #3760: Fix calculation of free clusters at mounting a fat partition

2021-07-06 Thread GitBox
fjpanag commented on pull request #3760: URL: https://github.com/apache/incubator-nuttx/pull/3760#issuecomment-874565220 Anyone knows how other systems handle this? What does a Linux system do? I mean, does it just depend on superior hardware, or is there any alternative? --

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #801: Update Application.mk

2021-07-06 Thread GitBox
xiaoxiang781216 edited a comment on pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134 > i still want this reverted unless a convincing use case for this unusual setup is provided. There are projects which have source files only di

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4079: fs/procfs: layout the output of meminfo correctly

2021-07-06 Thread GitBox
xiaoxiang781216 opened a new pull request #4079: URL: https://github.com/apache/incubator-nuttx/pull/4079 ## Summary Fix the wrong output like this: ``` nsh> free total used freelargest nused nfree Umem: 27197442495033 152752

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #4070: net/tcp: add window scale support

2021-07-06 Thread GitBox
yamt commented on a change in pull request #4070: URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664377240 ## File path: net/tcp/tcp_send.c ## @@ -372,6 +384,13 @@ static void tcp_sendcommon(FAR struct net_driver_s *dev, /* Update the Receiver Win

[GitHub] [incubator-nuttx] anchao opened a new pull request #4080: net/socket: add SO_SNDBUF support

2021-07-06 Thread GitBox
anchao opened a new pull request #4080: URL: https://github.com/apache/incubator-nuttx/pull/4080 ## Summary net/socket: add SO_SNDBUF support net/wrbuffer: add tcp/udp_wrbuffer_inqueue_size() interface Reference here: https://www.freebsd.org/cgi/man.cgi?query=setsockopt&s

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4070: net/tcp: add window scale support

2021-07-06 Thread GitBox
anchao commented on a change in pull request #4070: URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664403991 ## File path: net/sixlowpan/sixlowpan_tcpsend.c ## @@ -258,7 +258,12 @@ static int sixlowpan_tcp_header(FAR struct tcp_conn_s *conn, /* Upd

[GitHub] [incubator-nuttx] fjpanag opened a new pull request #4081: lpc17_40: fixed compiler warnings.

2021-07-06 Thread GitBox
fjpanag opened a new pull request #4081: URL: https://github.com/apache/incubator-nuttx/pull/4081 ## Summary Fixed a couple of compiler warnings in LPC17xx/LPC40xx RTC driver. 1. In `up_rtc_initialize()` variable `ret` was not always used, causing a warning. Now it is returned

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #801: Update Application.mk

2021-07-06 Thread GitBox
yamt commented on pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874640632 > > i still want this reverted unless a convincing use case for this unusual setup is provided. > > There are projects which have source files only different with

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4078: Add include header file to rpmsg.h.

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4078: URL: https://github.com/apache/incubator-nuttx/pull/4078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated (b901f22 -> 0f77a30)

2021-07-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b901f22 net/socket: add SO_RCVBUF support add 0f77a30 Add include header file to rpmsg.h. No new

[incubator-nuttx] branch master updated (0f77a30 -> 97b8e90)

2021-07-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0f77a30 Add include header file to rpmsg.h. add 97b8e90 boards/esp32c3: Add romfs configuration

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
saramonteiro commented on a change in pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077#discussion_r664436947 ## File path: boards/risc-v/esp32c3/esp32c3-devkit/src/README.txt ## @@ -0,0 +1,120 @@ +README +== + + Overview + + This dire

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
saramonteiro commented on a change in pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077#discussion_r664437831 ## File path: boards/risc-v/esp32c3/esp32c3-devkit/src/README.txt ## @@ -0,0 +1,120 @@ +README +== + + Overview + + This dire

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
saramonteiro commented on a change in pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077#discussion_r664438584 ## File path: boards/risc-v/esp32c3/esp32c3-devkit/src/README.txt ## @@ -0,0 +1,120 @@ +README +== + + Overview + + This dire

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
saramonteiro commented on a change in pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077#discussion_r66764 ## File path: boards/risc-v/esp32c3/esp32c3-devkit/src/README.txt ## @@ -0,0 +1,120 @@ +README +== + + Overview + + This dire

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #4070: net/tcp: add window scale support

2021-07-06 Thread GitBox
yamt commented on a change in pull request #4070: URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r663806067 ## File path: net/tcp/tcp_send.c ## @@ -365,6 +365,13 @@ static void tcp_sendcommon(FAR struct net_driver_s *dev, uint32_t rcvseq = tcp_getseq

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk

2021-07-06 Thread GitBox
masayuki2009 commented on pull request #4055: URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-873883916 > > @xiaoxiang781216 > > BTW, can you add sabre-6quad:knsh to test CONFIG_BUILD_KERNEL with QEMU? > > But, sabre-6quad doesn't have any config enable CONFIG

[GitHub] [incubator-nuttx-apps] gustavonihei commented on pull request #695: webclient: Implement non-blocking I/O

2021-07-06 Thread GitBox
gustavonihei commented on pull request #695: URL: https://github.com/apache/incubator-nuttx-apps/pull/695#issuecomment-874099283 > @gustavonihei is the nullification thing the only thing you are unhappy with this PR? Yes. Regarding the styling issues, I am fine with doing it in a

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #4069: net/socket: add SO_RCVBUF support

2021-07-06 Thread GitBox
yamt commented on a change in pull request #4069: URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r663800441 ## File path: net/udp/udp_callback.c ## @@ -83,6 +83,14 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev, FAR void *src_addr; u

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4055: mm: Move the real implementation of mm_sbrk to sbrk

2021-07-06 Thread GitBox
xiaoxiang781216 commented on pull request #4055: URL: https://github.com/apache/incubator-nuttx/pull/4055#issuecomment-874036195 No, we use dual Cortex-A7 in FLAT mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #3926: net/inet: add support of FIONREAD

2021-07-06 Thread GitBox
anchao commented on a change in pull request #3926: URL: https://github.com/apache/incubator-nuttx/pull/3926#discussion_r663736701 ## File path: net/tcp/tcp_ioctl.c ## @@ -0,0 +1,74 @@ +/ + * net/tcp/tc

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4066: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
acassis commented on a change in pull request #4066: URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r663908926 ## File path: arch/arm/src/rtl8720c/amebaZ.c ## @@ -0,0 +1,62 @@ +/ +

[GitHub] [incubator-nuttx] anchao commented on pull request #3926: net/inet: add support of FIONREAD

2021-07-06 Thread GitBox
anchao commented on pull request #3926: URL: https://github.com/apache/incubator-nuttx/pull/3926#issuecomment-873929357 @yamt san, please review again,thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4070: net/tcp: add window scale support

2021-07-06 Thread GitBox
anchao commented on a change in pull request #4070: URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r663992243 ## File path: net/tcp/Kconfig ## @@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK missing segment, without wai

[GitHub] [incubator-nuttx] acassis commented on pull request #4067: nuttx: Initialize chmod\fchmod\chown\fchown\lchown

2021-07-06 Thread GitBox
acassis commented on pull request #4067: URL: https://github.com/apache/incubator-nuttx/pull/4067#issuecomment-874100510 Hi @DS-LK it is a good idea to put a comment when open and close a PR, this way we could understand what is going on. Thank you! -- This is an automated message from t

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4069: net/socket: add SO_RCVBUF support

2021-07-06 Thread GitBox
anchao commented on a change in pull request #4069: URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r663811404 ## File path: net/udp/udp_callback.c ## @@ -83,6 +83,14 @@ static uint16_t udp_datahandler(FAR struct net_driver_s *dev, FAR void *src_addr;

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4067: nuttx: Initialize chmod\fchmod\chown\fchown\lchown

2021-07-06 Thread GitBox
xiaoxiang781216 commented on pull request #4067: URL: https://github.com/apache/incubator-nuttx/pull/4067#issuecomment-874162931 The new PR will provide after finish the internal review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx-apps] gustavonihei edited a comment on pull request #695: webclient: Implement non-blocking I/O

2021-07-06 Thread GitBox
gustavonihei edited a comment on pull request #695: URL: https://github.com/apache/incubator-nuttx-apps/pull/695#issuecomment-874099283 > @gustavonihei is the nullification thing the only thing you are unhappy with this PR? Yes. Regarding the styling issues, I am fine with addres

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3926: net/inet: add support of FIONREAD

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #3926: URL: https://github.com/apache/incubator-nuttx/pull/3926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[incubator-nuttx] branch master updated (97b8e90 -> 9976635)

2021-07-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 97b8e90 boards/esp32c3: Add romfs configuration add 9976635 lpc17_40: fixed compiler warnings. No

[GitHub] [incubator-nuttx-apps] GUIDINGLI commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

2021-07-06 Thread GitBox
GUIDINGLI commented on pull request #800: URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874513110 Here is the fix: https://github.com/apache/incubator-nuttx-apps/pull/801 so we don't need revert. -- This is an automated message from the Apache Git Se

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3114: usrsock/recv: guarantee all data is received before close

2021-07-06 Thread GitBox
masayuki2009 commented on pull request #3114: URL: https://github.com/apache/incubator-nuttx/pull/3114#issuecomment-874551078 > @masayuki2009 could you try the new change work with your hardware? @anchao @xiaoxiang781216 Sure but could you rebase the branch to the latest master?

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3114: usrsock/recv: guarantee all data is received before close

2021-07-06 Thread GitBox
xiaoxiang781216 commented on pull request #3114: URL: https://github.com/apache/incubator-nuttx/pull/3114#issuecomment-874510299 @masayuki2009 could you try the new change work with your hardware? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-nuttx] fjpanag commented on pull request #3760: Fix calculation of free clusters at mounting a fat partition

2021-07-06 Thread GitBox
fjpanag commented on pull request #3760: URL: https://github.com/apache/incubator-nuttx/pull/3760#issuecomment-874565220 Anyone knows how other systems handle this? What does a Linux system do? I mean, does it just depend on superior hardware, or is there any alternative? --

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4074: Documentation: Fix typos

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4074: URL: https://github.com/apache/incubator-nuttx/pull/4074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] yamt commented on pull request #3900: Revert "Make: use gcc as LD"

2021-07-06 Thread GitBox
yamt commented on pull request #3900: URL: https://github.com/apache/incubator-nuttx/pull/3900#issuecomment-874443249 > I am fine with either approach, but could you incorporate your LTO demo into mainline? Otherwise, the same change may be created again for LTO. maybe i will try.

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #4072: lpc17xx: Added WDT driver.

2021-07-06 Thread GitBox
fjpanag commented on a change in pull request #4072: URL: https://github.com/apache/incubator-nuttx/pull/4072#discussion_r664339115 ## File path: arch/arm/src/lpc17xx_40xx/hardware/lpc17_40_wdt.h ## @@ -89,6 +89,8 @@ /* Watchdog feed sequence register */ +#define WDT_FEED

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4071: net/local: add AF_[UNIX|LOCAL] socketpair support

2021-07-06 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4071: URL: https://github.com/apache/incubator-nuttx/pull/4071#discussion_r664276081 ## File path: net/local/local_sockif.c ## @@ -728,6 +731,106 @@ static int local_ioctl(FAR struct socket *psock, int cmd, return ret;

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
saramonteiro commented on a change in pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077#discussion_r664436947 ## File path: boards/risc-v/esp32c3/esp32c3-devkit/src/README.txt ## @@ -0,0 +1,120 @@ +README +== + + Overview + + This dire

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4069: net/socket: add SO_RCVBUF support

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4069: URL: https://github.com/apache/incubator-nuttx/pull/4069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] anchao commented on pull request #4070: net/tcp: add window scale support

2021-07-06 Thread GitBox
anchao commented on pull request #4070: URL: https://github.com/apache/incubator-nuttx/pull/4070#issuecomment-874520270 @yamt I upload a new commit. When the window scale is enabled, the received buffer is easily over 64K. I modified the related data type to uint32_t to avoid the T

[GitHub] [incubator-nuttx] DS-LK commented on pull request #4067: nuttx: Initialize chmod\fchmod\chown\fchown\lchown

2021-07-06 Thread GitBox
DS-LK commented on pull request #4067: URL: https://github.com/apache/incubator-nuttx/pull/4067#issuecomment-874397208 Sorry, I made a mistake in operation. This PR was submitted for review before, and then closed. I wanted to withdraw that first, but I did not expect to open it again. I w

[GitHub] [incubator-nuttx] YuuichiNakamura commented on pull request #3979: note: Move up_schednote.c to drivers/note folder

2021-07-06 Thread GitBox
YuuichiNakamura commented on pull request #3979: URL: https://github.com/apache/incubator-nuttx/pull/3979#issuecomment-874390374 Thanks for the notification. I have confirmed that my instrumentation code works well. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #801: Update Application.mk

2021-07-06 Thread GitBox
yamt commented on pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874640632 > > i still want this reverted unless a convincing use case for this unusual setup is provided. > > There are projects which have source files only different with

[GitHub] [incubator-nuttx] anchao commented on pull request #4069: net/socket: add SO_RCVBUF support

2021-07-06 Thread GitBox
anchao commented on pull request #4069: URL: https://github.com/apache/incubator-nuttx/pull/4069#issuecomment-87998 > you should update tcp_maxrcvwin too. Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-nuttx] buyuer closed pull request #4078: Add include header file to rpmsg.h.

2021-07-06 Thread GitBox
buyuer closed pull request #4078: URL: https://github.com/apache/incubator-nuttx/pull/4078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4072: lpc17xx: Added WDT driver.

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4072: URL: https://github.com/apache/incubator-nuttx/pull/4072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4075: risc-v/esp32c3: Add board_ioctl and board_uniqueid

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4075: URL: https://github.com/apache/incubator-nuttx/pull/4075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4073: xtensa/esp32: Fix uart 2 issue.

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4073: URL: https://github.com/apache/incubator-nuttx/pull/4073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4069: net/socket: add SO_RCVBUF support

2021-07-06 Thread GitBox
xiaoxiang781216 commented on a change in pull request #4069: URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r664252652 ## File path: net/Kconfig ## @@ -117,6 +117,12 @@ config NET_GUARDSIZE packet size will be chopped down to the size indica

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #4064: binfmt: Replace all nx_ API with file_ API

2021-07-06 Thread GitBox
masayuki2009 merged pull request #4064: URL: https://github.com/apache/incubator-nuttx/pull/4064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-nuttx] jerry-tang-realsil commented on pull request #4066: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
jerry-tang-realsil commented on pull request #4066: URL: https://github.com/apache/incubator-nuttx/pull/4066#issuecomment-874406368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #801: Update Application.mk

2021-07-06 Thread GitBox
xiaoxiang781216 edited a comment on pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134 > i still want this reverted unless a convincing use case for this unusual setup is provided. There are projects which have source files only di

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4077: boards/esp32c3: Add romfs configuration

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4077: URL: https://github.com/apache/incubator-nuttx/pull/4077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] jerry-tang-realsil commented on a change in pull request #4066: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
jerry-tang-realsil commented on a change in pull request #4066: URL: https://github.com/apache/incubator-nuttx/pull/4066#discussion_r664187880 ## File path: arch/arm/src/rtl8720c/Make.defs ## @@ -0,0 +1,91 @@ +

[GitHub] [incubator-nuttx] Virus-V commented on a change in pull request #4069: net/socket: add SO_RCVBUF support

2021-07-06 Thread GitBox
Virus-V commented on a change in pull request #4069: URL: https://github.com/apache/incubator-nuttx/pull/4069#discussion_r664247917 ## File path: net/socket/setsockopt.c ## @@ -131,9 +131,71 @@ static int psock_socketlevel_option(FAR struct socket *psock, int option,

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

2021-07-06 Thread GitBox
yamt commented on pull request #800: URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874454975 @GUIDINGLI @xiaoxiang781216 how do you think? my colleagues are suffering from this Make.dep breakage. and IMO the change itself seems rather controversial. it's

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4072: lpc17xx: Added WDT driver.

2021-07-06 Thread GitBox
acassis commented on a change in pull request #4072: URL: https://github.com/apache/incubator-nuttx/pull/4072#discussion_r664032202 ## File path: arch/arm/src/lpc17xx_40xx/hardware/lpc17_40_wdt.h ## @@ -89,6 +89,8 @@ /* Watchdog feed sequence register */ +#define WDT_FEED

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4070: net/tcp: add window scale support

2021-07-06 Thread GitBox
acassis commented on a change in pull request #4070: URL: https://github.com/apache/incubator-nuttx/pull/4070#discussion_r664091493 ## File path: net/tcp/Kconfig ## @@ -106,6 +106,27 @@ config NET_TCP_FAST_RETRANSMIT_WATERMARK missing segment, without wa

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4078: Add include header file to rpmsg.h.

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4078: URL: https://github.com/apache/incubator-nuttx/pull/4078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4074: Documentation: Fix typos

2021-07-06 Thread GitBox
hartmannathan commented on pull request #4074: URL: https://github.com/apache/incubator-nuttx/pull/4074#issuecomment-874334987 I have additional fixes for comments in the source files in [1], but I'm waiting on PR #4035 since they could introduce unnecessary conflicts. [1] https://gi

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #801: Update Application.mk

2021-07-06 Thread GitBox
xiaoxiang781216 commented on pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801#issuecomment-874562134 > i still want this reverted unless a convincing use case for this unusual setup is provided. There are projects which have source files only different

[GitHub] [incubator-nuttx] jerry-tang-realsil closed pull request #4066: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
jerry-tang-realsil closed pull request #4066: URL: https://github.com/apache/incubator-nuttx/pull/4066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4035: work_queue: schedule the work queue using the timer mechanism

2021-07-06 Thread GitBox
hartmannathan commented on pull request #4035: URL: https://github.com/apache/incubator-nuttx/pull/4035#issuecomment-874330013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [incubator-nuttx] jerry-tang-realsil commented on pull request #4076: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
jerry-tang-realsil commented on pull request #4076: URL: https://github.com/apache/incubator-nuttx/pull/4076#issuecomment-874685918 I’m sorry but I don’t understand what the approval should be. Could you please show me what the approval is? Is there any example? 发件人: Alan Carvalho

[GitHub] [incubator-nuttx] jerry-tang-realsil edited a comment on pull request #4076: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
jerry-tang-realsil edited a comment on pull request #4076: URL: https://github.com/apache/incubator-nuttx/pull/4076#issuecomment-874685918 I’m sorry but I don’t understand what the approval should be. Could you please show me what the approval is? Is there any example? -- This is a

[GitHub] [incubator-nuttx] acassis commented on pull request #4076: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
acassis commented on pull request #4076: URL: https://github.com/apache/incubator-nuttx/pull/4076#issuecomment-874683612 This code derive from GPL code, see PR #4066. *Please* get the approval (SGA) from Realtek, otherwise we cannot include it on NuttX. -- This is an automated message fr

[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #4082: boards/esp32c3: Support mounting SPI Flash MTD to littleFS

2021-07-06 Thread GitBox
donghengqaz opened a new pull request #4082: URL: https://github.com/apache/incubator-nuttx/pull/4082 ## Summary ESP32-C3 Devikit board supports mounting SPI Flash MTD to littleFS. ## Impact ## Testing -- This is an automated message from the Apache Git Servic

[GitHub] [incubator-nuttx] acassis commented on pull request #4066: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
acassis commented on pull request #4066: URL: https://github.com/apache/incubator-nuttx/pull/4066#issuecomment-874681638 You cannot submit this code if it derives from a GPL code. Even if you send again removing the GPL header we already know it came from a GPL code. We need approve from R

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4081: lpc17_40: fixed compiler warnings.

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #4081: URL: https://github.com/apache/incubator-nuttx/pull/4081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-nuttx] davids5 commented on pull request #4064: binfmt: Replace all nx_ API with file_ API

2021-07-06 Thread GitBox
davids5 commented on pull request #4064: URL: https://github.com/apache/incubator-nuttx/pull/4064#issuecomment-874682323 @xiaoxiang781216 I am confused by this PR. If binfmt is a kernel component isn't it supposed to use the nx_ versions to avoid changing error no and not be

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4064: binfmt: Replace all nx_ API with file_ API

2021-07-06 Thread GitBox
xiaoxiang781216 commented on pull request #4064: URL: https://github.com/apache/incubator-nuttx/pull/4064#issuecomment-874697130 Even nx_xxx API should be avoided inside kernel, if there are file_xxx or psock_xxx variant, since nx_xxx API still depends on per-task file table. BTW, this pat

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4064: binfmt: Replace all nx_ API with file_ API

2021-07-06 Thread GitBox
xiaoxiang781216 edited a comment on pull request #4064: URL: https://github.com/apache/incubator-nuttx/pull/4064#issuecomment-874697130 Even nx_xxx API should be avoided inside kernel, if there are file_xxx or psock_xxx variant, since nx_xxx API still depends on per-task file table. BTW, t

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4064: binfmt: Replace all nx_ API with file_ API

2021-07-06 Thread GitBox
xiaoxiang781216 edited a comment on pull request #4064: URL: https://github.com/apache/incubator-nuttx/pull/4064#issuecomment-874697130 Even nx_xxx API should be avoided inside kernel, if there are file_xxx or psock_xxx variant, since nx_xxx API still depends on per-task file table. BTW, t

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

2021-07-06 Thread GitBox
xiaoxiang781216 closed pull request #800: URL: https://github.com/apache/incubator-nuttx-apps/pull/800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #800: Revert "apps/Application.mk: support compile same prefix file in one folder"

2021-07-06 Thread GitBox
xiaoxiang781216 commented on pull request #800: URL: https://github.com/apache/incubator-nuttx-apps/pull/800#issuecomment-874699443 After the discussion in #801, let's close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-nuttx-apps] branch master updated (931a873 -> b831e11)

2021-07-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 931a873 examples/configdata: Fix some printf format warnings new 9b7fe15 Generate c source co

[incubator-nuttx-apps] 01/02: Generate c source code dependence with c compiler and flags

2021-07-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 9b7fe15bfbe80ce77187fc16c960839e8db10c64 Author: Xiang Xiao AuthorDate: Tue Jul 6 14:03:57 2021 +0800

[incubator-nuttx-apps] 02/02: Application.mk: correct depends file generated

2021-07-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit b831e1192e45dac65c6a20427114c741a31adfdf Author: ligd AuthorDate: Tue Jul 6 14:49:46 2021 +0800 Ap

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #801: Update Application.mk

2021-07-06 Thread GitBox
xiaoxiang781216 merged pull request #801: URL: https://github.com/apache/incubator-nuttx-apps/pull/801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-nuttx] davids5 commented on pull request #4076: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
davids5 commented on pull request #4076: URL: https://github.com/apache/incubator-nuttx/pull/4076#issuecomment-874722161 @jerry-tang-realsil Please see https://www.apache.org/licenses/contributor-agreements.html once Realtek submits a CCLA: Corporate Contributor License Agreem

[GitHub] [incubator-nuttx] davids5 merged pull request #4079: fs/procfs: layout the output of meminfo correctly

2021-07-06 Thread GitBox
davids5 merged pull request #4079: URL: https://github.com/apache/incubator-nuttx/pull/4079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[incubator-nuttx] branch master updated: fs/procfs: layout the output of meminfo correctly

2021-07-06 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new d5c1979 fs/procfs: layout the output

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4071: net/local: add AF_[UNIX|LOCAL] socketpair support

2021-07-06 Thread GitBox
anchao commented on a change in pull request #4071: URL: https://github.com/apache/incubator-nuttx/pull/4071#discussion_r664539949 ## File path: net/inet/inet_sockif.c ## @@ -1328,6 +1342,147 @@ static int inet_ioctl(FAR struct socket *psock, int cmd, return -EINVAL; } +/

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4071: net/local: add AF_[UNIX|LOCAL] socketpair support

2021-07-06 Thread GitBox
anchao commented on a change in pull request #4071: URL: https://github.com/apache/incubator-nuttx/pull/4071#discussion_r664540152 ## File path: net/local/local_sockif.c ## @@ -728,6 +731,106 @@ static int local_ioctl(FAR struct socket *psock, int cmd, return ret; } +/***

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4082: boards/esp32c3: Support mounting SPI Flash MTD to littleFS

2021-07-06 Thread GitBox
gustavonihei commented on a change in pull request #4082: URL: https://github.com/apache/incubator-nuttx/pull/4082#discussion_r664540535 ## File path: boards/risc-v/esp32c3/esp32c3-devkit/Kconfig ## @@ -65,6 +65,11 @@ choice endchoice +config ESP32C3_SPIFLASH_FS_MOUNT_PTR

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #4071: net/local: add AF_[UNIX|LOCAL] socketpair support

2021-07-06 Thread GitBox
anchao commented on a change in pull request #4071: URL: https://github.com/apache/incubator-nuttx/pull/4071#discussion_r664541919 ## File path: net/local/local_sockif.c ## @@ -728,6 +731,106 @@ static int local_ioctl(FAR struct socket *psock, int cmd, return ret; } +/***

[GitHub] [incubator-nuttx] anchao commented on pull request #3114: usrsock/recv: guarantee all data is received before close

2021-07-06 Thread GitBox
anchao commented on pull request #3114: URL: https://github.com/apache/incubator-nuttx/pull/3114#issuecomment-874751217 > > @masayuki2009 could you try the new change work with your hardware? > > @anchao @xiaoxiang781216 > Sure but could you rebase the branch to the latest master?

[GitHub] [incubator-nuttx] acassis commented on pull request #4066: AmebaZ2: Add soc src code

2021-07-06 Thread GitBox
acassis commented on pull request #4066: URL: https://github.com/apache/incubator-nuttx/pull/4066#issuecomment-874769741 @justinmclean and @patacongo how we can fix this case? A Realtek employee is submitting a code from Realtek that was released previously as GPL. I think the safe way sho

  1   2   >