[GitHub] [incubator-nuttx] diegoherranz opened a new pull request #2490: drivers/leds/ws2812: make frequency selection more flexible

2020-12-07 Thread GitBox
diegoherranz opened a new pull request #2490: URL: https://github.com/apache/incubator-nuttx/pull/2490 ## Summary Previously only 4 MHz and 8 MHz were allowed. Given the tolerance allowed in the WS2812 timing spec, frequency ranges round those two can be used too which is useful for boa

[GitHub] [incubator-nuttx] fjpanag commented on pull request #2477: STM32 FLASH latency is calculated based on Vin.

2020-12-07 Thread GitBox
fjpanag commented on pull request #2477: URL: https://github.com/apache/incubator-nuttx/pull/2477#issuecomment-739867452 I did the changes as discussed. Can you please have a look? This is an automated message from the

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2491: drivers/power/bq2425x.c: fix build error with baterr()

2020-12-07 Thread GitBox
juniskane opened a new pull request #2491: URL: https://github.com/apache/incubator-nuttx/pull/2491 ## Summary Trivial build error uncovered by recent syslog format string warnings work ## Impact ## Testing --

[GitHub] [incubator-nuttx] juniskane commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
juniskane commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739913380 I'm opposed to this as the new flags don't do anything, they are just cruft copied over from Linux. NuttX is a new OS, it does not have to copy every non-standar

[GitHub] [incubator-nuttx] davids5 commented on pull request #2477: STM32 FLASH latency is calculated based on Vin.

2020-12-07 Thread GitBox
davids5 commented on pull request #2477: URL: https://github.com/apache/incubator-nuttx/pull/2477#issuecomment-739915544 > I did the changes as discussed. > > Can you please have a look? What about using mV 3300 instead of the the Float value? What are the style issues?

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2489: [Performance]net/tcp: send the ACK in time after obtain ahead buffer from iobs

2020-12-07 Thread GitBox
patacongo commented on a change in pull request #2489: URL: https://github.com/apache/incubator-nuttx/pull/2489#discussion_r537499841 ## File path: net/tcp/tcp_recvfrom.c ## @@ -636,14 +683,18 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR void *buf,

[GitHub] [incubator-nuttx] fjpanag commented on pull request #2477: STM32 FLASH latency is calculated based on Vin.

2020-12-07 Thread GitBox
fjpanag commented on pull request #2477: URL: https://github.com/apache/incubator-nuttx/pull/2477#issuecomment-739921688 > What are the style issues? Sorry, I was not careful enough. Fixed, pushing in a moment. > What about using mV 3300 instead of the the Float value? I

[GitHub] [incubator-nuttx] davids5 commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
davids5 commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739922119 This is another hack to facilitate using third party Linix code that is not really supported. Is this what we as a group? I would suggest that if you add the interfac

[GitHub] [incubator-nuttx] juniskane commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
juniskane commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739924292 David, getrandom() itself is not a hack, as it adds feature that is not possible to implement with POSIX alone. The reasons why use getrandom() instead of open("/dev/u

[GitHub] [incubator-nuttx] juniskane commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
juniskane commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739926875 I think there is a real problem with getrandom(), not caused by this PR but introduced by Issue 619 https://github.com/apache/incubator-nuttx/issues/619 There is

[GitHub] [incubator-nuttx] patacongo commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
patacongo commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739928330 Recently, it seems that the objectives of the OS have shifted. Historically, for a dozen years, the objective has been to be a Unix-work alike and to conform strictly

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #2489: [Performance]net/tcp: send the ACK in time after obtain ahead buffer from iobs

2020-12-07 Thread GitBox
anchao commented on a change in pull request #2489: URL: https://github.com/apache/incubator-nuttx/pull/2489#discussion_r537529677 ## File path: net/tcp/tcp_recvfrom.c ## @@ -384,7 +384,7 @@ static inline void tcp_sender(FAR struct net_driver_s *dev, * *

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #2489: [Performance]net/tcp: send the ACK in time after obtain ahead buffer from iobs

2020-12-07 Thread GitBox
anchao commented on a change in pull request #2489: URL: https://github.com/apache/incubator-nuttx/pull/2489#discussion_r537529831 ## File path: net/tcp/tcp_recvfrom.c ## @@ -636,14 +683,18 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR void *buf,

[GitHub] [incubator-nuttx] jerpelea merged pull request #2491: drivers/power/bq2425x.c: fix build error with baterr()

2020-12-07 Thread GitBox
jerpelea merged pull request #2491: URL: https://github.com/apache/incubator-nuttx/pull/2491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
xiaoxiang781216 commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739950396 > I'm opposed to this as the new flags don't do anything, they are just cruft copied over from Linux. > > NuttX is a new OS, it does not have to copy every

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739950396 > I'm opposed to this as the new flags don't do anything, they are just cruft copied over from Linux. > > NuttX is a new OS, it does not have to cop

[incubator-nuttx] branch master updated (979a5b7 -> b2110fc)

2020-12-07 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 979a5b7 stm32: convert all STM32G47X specific code to generic STM32G4 series code. add b2110fc dri

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
xiaoxiang781216 commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739960360 > Recently, it seems that the objectives of the OS have shifted. Historically, for a dozen years, the objective has been to be a Unix-work alike and to conform s

[GitHub] [incubator-nuttx] juniskane commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
juniskane commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739961321 > getrandom has the same prototype in both FreeBSD and Linux: > https://www.freebsd.org/cgi/man.cgi?query=getrandom&sektion=2&manpath=freebsd-release-ports > http

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-739960360 > Recently, it seems that the objectives of the OS have shifted. Historically, for a dozen years, the objective has been to be a Unix-work alike and to co

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2488: libs/libc: correct the getrandom(2) prototype

2020-12-07 Thread GitBox
xiaoxiang781216 commented on pull request #2488: URL: https://github.com/apache/incubator-nuttx/pull/2488#issuecomment-740054518 > > getrandom has the same prototype in both FreeBSD and Linux: > > https://www.freebsd.org/cgi/man.cgi?query=getrandom&sektion=2&manpath=freebsd-release-ports

[GitHub] [incubator-nuttx] v01d opened a new pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
v01d opened a new pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492 ## Summary Make an array const (not only an array of const elements) so that it is placed on flash and reduces memory requirements. ## Impact Reduces memory use ## Test

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2493: arch/stm32: Fix nxstyle errors (and one typo)

2020-12-07 Thread GitBox
hartmannathan opened a new pull request #2493: URL: https://github.com/apache/incubator-nuttx/pull/2493 ## Summary Fix nxstyle errors in: - arch/arm/src/stm32/stm32_dma2d.h - arch/arm/src/stm32/stm32_fmc.h - arch/arm/src/stm32/stm32_freerun.h - arch/arm/src/stm32/s

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2493: arch/stm32: Fix nxstyle errors (and one typo)

2020-12-07 Thread GitBox
Ouss4 merged pull request #2493: URL: https://github.com/apache/incubator-nuttx/pull/2493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-nuttx] branch master updated (b2110fc -> c162069)

2020-12-07 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b2110fc drivers/power/bq2425x.c: fix build error with baterr() add c162069 arch/stm32: Fix nxsty

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
hartmannathan commented on pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740197055 Is this usage consistent with C89? This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-nuttx] v01d commented on pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
v01d commented on pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740197740 I don't understand the question This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
hartmannathan commented on pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740202019 I think the architecture-independent portions of NuttX need to conform to C89. I was asking if C89 supports the use of 'const' in this way. --

[GitHub] [incubator-nuttx] hartmannathan edited a comment on pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
hartmannathan edited a comment on pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740202019 I think the architecture-independent portions of NuttX need to conform to C89. I was asking if C89 supports the use of 'const' in this way. Meanwhile I look

[GitHub] [incubator-nuttx] v01d commented on pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
v01d commented on pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740202877 I think this is part of basic language. Wouldn't expect it to be only part of a specific standard. This is

[GitHub] [incubator-nuttx] hartmannathan merged pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
hartmannathan merged pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2492: procfs: make array const to reduce memory use

2020-12-07 Thread GitBox
hartmannathan commented on pull request #2492: URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740203159 Yes, it's fine. I approved it. Thanks This is an automated message from the Apache Git Service. To

[incubator-nuttx] branch master updated (c162069 -> 8a9f995)

2020-12-07 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c162069 arch/stm32: Fix nxstyle errors (and one typo) add 8a9f995 procfs: make array const to

[incubator-nuttx-website] branch asf-site updated: Publishing web: 0c0103c8517f13270f961e2289dd0f3df1c6c5da docs: 8a9f995d40542555c5e94bdba881191421e17fbf

2020-12-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 10d544d Publishing web

[incubator-nuttx] branch master updated (8a9f995 -> 3edb3a4)

2020-12-07 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8a9f995 procfs: make array const to reduce memory use add 441180b drivers/leds/ws2812: make frequen

[GitHub] [incubator-nuttx] btashton merged pull request #2490: drivers/leds/ws2812: make frequency selection more flexible

2020-12-07 Thread GitBox
btashton merged pull request #2490: URL: https://github.com/apache/incubator-nuttx/pull/2490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2494: Fix SMP

2020-12-07 Thread GitBox
masayuki2009 opened a new pull request #2494: URL: https://github.com/apache/incubator-nuttx/pull/2494 ## Summary - This PR consists of the following 4 commits to fix SMP - commit 1: sched: irq: Change irq_waitlock() from private to public - commit 2: arch, sched: Fix global IRQ