[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2142: Add task name record for task trace

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2142: URL: https://github.com/apache/incubator-nuttx/pull/2142#discussion_r513220247 ## File path: drivers/note/noteram_driver.c ## @@ -63,6 +64,26 @@ struct noteram_info_s uint8_t ni_buffer[CONFIG_DRIVER_NOTERAM_BUFSIZE

[GitHub] [incubator-nuttx-testing] btashton commented on pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
btashton commented on pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#issuecomment-717746440 > I also just kicked off #73 It had failed for an unrelated issue so I want to see if that ipv6 target works and we can just fix that here as well. Confirmed

[GitHub] [incubator-nuttx] btashton merged pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

2020-10-28 Thread GitBox
btashton merged pull request #2128: URL: https://github.com/apache/incubator-nuttx/pull/2128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx] branch master updated (079737d -> 7901ad6)

2020-10-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 079737d libs/libc/signal/sig_pause.c: Fix a comment add 7901ad6 tools/testbuild.sh: Support regular

[GitHub] [incubator-nuttx-testing] btashton commented on pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS

2020-10-28 Thread GitBox
btashton commented on pull request #72: URL: https://github.com/apache/incubator-nuttx-testing/pull/72#issuecomment-717750397 Merged OS side, just restarted the build. This is an automated message from the Apache Git Service

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2131: libxx: Use Kconfig "choice" to specify an implemenetation

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2131: URL: https://github.com/apache/incubator-nuttx/pull/2131#discussion_r513225345 ## File path: libs/libxx/Kconfig ## @@ -22,6 +22,34 @@ config HAVE_CXX if HAVE_CXX +choice + prompt "C++ Library" + defau

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2131: libxx: Use Kconfig "choice" to specify an implemenetation

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2131: URL: https://github.com/apache/incubator-nuttx/pull/2131#discussion_r513225345 ## File path: libs/libxx/Kconfig ## @@ -22,6 +22,34 @@ config HAVE_CXX if HAVE_CXX +choice + prompt "C++ Library" + defau

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2063: Fix libcxx for sim/macOS

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#discussion_r513225864 ## File path: boards/sim/sim/sim/configs/libcxxtest/defconfig ## @@ -0,0 +1,107 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2063: Fix libcxx for sim/macOS

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#discussion_r513227978 ## File path: arch/sim/src/sim/up_macho_init.c ## @@ -0,0 +1,100 @@ +/

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2063: Fix libcxx for sim/macOS

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#discussion_r513227978 ## File path: arch/sim/src/sim/up_macho_init.c ## @@ -0,0 +1,100 @@ +/

[GitHub] [incubator-nuttx-apps] rurtle commented on pull request #443: Changes for nuttx issue 1883

2020-10-28 Thread GitBox
rurtle commented on pull request #443: URL: https://github.com/apache/incubator-nuttx-apps/pull/443#issuecomment-717755280 Looks like I messed up. I made changes to my local branch and then performed fetch which resulted in merge conflict. Afterwards, I tried doing `git rebase` and that m

[GitHub] [incubator-nuttx-apps] rurtle closed pull request #443: Changes for nuttx issue 1883

2020-10-28 Thread GitBox
rurtle closed pull request #443: URL: https://github.com/apache/incubator-nuttx-apps/pull/443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx-apps] rurtle commented on pull request #443: Changes for nuttx issue 1883

2020-10-28 Thread GitBox
rurtle commented on pull request #443: URL: https://github.com/apache/incubator-nuttx-apps/pull/443#issuecomment-717755585 Creating a fresh pull request instead. This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
xiaoxiang781216 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717756806 @masayuki2009 I don't have the device with USB support:(, @juniskane could you help retest the change? -

[GitHub] [incubator-nuttx] btashton opened a new issue #2144: cxd56: mkspk tool should be built when CONFIG_CXD56_BINARY is enabled

2020-10-28 Thread GitBox
btashton opened a new issue #2144: URL: https://github.com/apache/incubator-nuttx/issues/2144 Right now there is a manual step build the `mkspk` tool which means we do not actually test this functionality in CI. This is an a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2114: Make CONFIG_HAVE_CXX14 an explicit config

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2114: URL: https://github.com/apache/incubator-nuttx/pull/2114#discussion_r513236475 ## File path: libs/libxx/Kconfig ## @@ -22,7 +22,7 @@ config HAVE_CXX config HAVE_CXX14 bool "C++14 support" - default n

[GitHub] [incubator-nuttx] jerpelea commented on issue #2144: cxd56: mkspk tool should be built when CONFIG_CXD56_BINARY is enabled

2020-10-28 Thread GitBox
jerpelea commented on issue #2144: URL: https://github.com/apache/incubator-nuttx/issues/2144#issuecomment-717766892 on it This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-nuttx-apps] juniskane commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
juniskane commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717768288 nshlib/nsh_altconsole.c calls non-existent flush(), typo for fflush(). Other than this, change works for me. Tested with proprietary board. I'm using slightl

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
xiaoxiang781216 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-71756 > nshlib/nsh_altconsole.c calls non-existent flush(), typo for fflush(). > > Other than this, change works for me. Tested with proprietary board. I'm u

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2115: Store artifacts durring build

2020-10-28 Thread GitBox
Ouss4 commented on a change in pull request #2115: URL: https://github.com/apache/incubator-nuttx/pull/2115#discussion_r513257617 ## File path: Makefile ## @@ -45,3 +45,7 @@ else include tools/Makefile.unix endif endif + +.PHONY: execname +execname: + @echo $(BIN) Rev

[GitHub] [incubator-nuttx-testing] jerpelea merged pull request #72: testlist/sim.dat: Skip 32bit sim build only for macOS

2020-10-28 Thread GitBox
jerpelea merged pull request #72: URL: https://github.com/apache/incubator-nuttx-testing/pull/72 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-nuttx-testing] branch master updated: testlist/sim.dat: Skip 32bit/X11 sim build for macOS

2020-10-28 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git The following commit(s) were added to refs/heads/master by this push: new 21bed31 testlist/sim.dat: Sk

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2115: Store artifacts durring build

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2115: URL: https://github.com/apache/incubator-nuttx/pull/2115#discussion_r513262830 ## File path: tools/Makefile.win ## @@ -392,17 +392,22 @@ ifeq ($(CONFIG_BUILD_2PASS),y) $(Q) $(MAKE) -C $(CONFIG_PASS1_BUILDIR) L

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
masayuki2009 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717783143 > > nshlib/nsh_altconsole.c calls non-existent flush(), typo for fflush(). > > Other than this, change works for me. Tested with proprietary board. I'm using

[GitHub] [incubator-nuttx] jerpelea commented on issue #2144: cxd56: mkspk tool should be built when CONFIG_CXD56_BINARY is enabled

2020-10-28 Thread GitBox
jerpelea commented on issue #2144: URL: https://github.com/apache/incubator-nuttx/issues/2144#issuecomment-717787179 https://github.com/apache/incubator-nuttx/pull/2145 This is an automated message from the Apache Git Servic

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #2145: tools: cxd56: mkspk: automate mkspk build

2020-10-28 Thread GitBox
jerpelea opened a new pull request #2145: URL: https://github.com/apache/incubator-nuttx/pull/2145 ## Summary the mkspk tool will automaticaly be built if CONFIG_CXD56_BINARY is set. ## Impact CXD56 board (Sony Spresense) ## Testing Test: nuttx.spk was succesfull

[GitHub] [incubator-nuttx-apps] spiriou opened a new pull request #445: Android Debug Bridge daemon

2020-10-28 Thread GitBox
spiriou opened a new pull request #445: URL: https://github.com/apache/incubator-nuttx-apps/pull/445 ## Summary add Android Debug Bridge daemon for NuttX. https://developer.android.com/studio/command-line/adb ## Impact None. Disabled by default. ## Testing

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
xiaoxiang781216 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717797831 Done, both rebase to the latest master. This is an automated message from the Apache Git Ser

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 merged pull request #73: Add ipv6 to Renesas precheck

2020-10-28 Thread GitBox
xiaoxiang781216 merged pull request #73: URL: https://github.com/apache/incubator-nuttx-testing/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-testing] branch master updated: Add ipv6 to Renesas precheck

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git The following commit(s) were added to refs/heads/master by this push: new 2331238 Add ipv6 to Renesas

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
masayuki2009 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717807067 > Done, both rebase to the latest master. @xiaoxiang781216 I think you pushed the commit to https://github.com/xiaoxiang781216/incubator-nuttx-apps/tr

[GitHub] [incubator-nuttx] jerpelea commented on pull request #2145: tools: cxd56: mkspk: automate mkspk build

2020-10-28 Thread GitBox
jerpelea commented on pull request #2145: URL: https://github.com/apache/incubator-nuttx/pull/2145#issuecomment-717813258 @xiaoxiang781216 done This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
masayuki2009 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717815230 > > Done, both rebase to the latest master. > > @xiaoxiang781216 > I think you pushed the commit to https://github.com/xiaoxiang781216/incubator-nuttx-

[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
masayuki2009 edited a comment on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717815230 > > Done, both rebase to the latest master. > > @xiaoxiang781216 > I think you pushed the commit to https://github.com/xiaoxiang781216/incubator

[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
masayuki2009 edited a comment on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717815230 > > Done, both rebase to the latest master. > > @xiaoxiang781216 > I think you pushed the commit to https://github.com/xiaoxiang781216/incubator

[GitHub] [incubator-nuttx-testing] Ouss4 commented on pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
Ouss4 commented on pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#issuecomment-717828535 Shouldn't you then delete the avr-mips-riscv-x86-xtensa.dat and renesas.dat files? (Is the name avr-mips-riscv-x86-xtensa-renesas.dat too long :-P ) In anoth

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2145: tools: cxd56: mkspk: automate mkspk build

2020-10-28 Thread GitBox
Ouss4 commented on pull request #2145: URL: https://github.com/apache/incubator-nuttx/pull/2145#issuecomment-717833378 @jerpelea That should be done in tools/Makefile.host ```diff --- a/tools/Makefile.host +++ b/tools/Makefile.host @@ -261,6 +261,7 @@ ifneq ($(CONFIG_WINDOWS_NATI

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
xiaoxiang781216 commented on pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#issuecomment-717838337 Yes, but after I change build.yaml to use the new file This is an automated message from th

[GitHub] [incubator-nuttx-apps] rurtle opened a new pull request #446: Fix for nuttx issue 1883

2020-10-28 Thread GitBox
rurtle opened a new pull request #446: URL: https://github.com/apache/incubator-nuttx-apps/pull/446 ## Summary Fix for nuttx [issue # 1883](https://github.com/apache/incubator-nuttx/issues/1883). When proc file-system is not mounted, running ifconfig should give output as "ifconfig:

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 edited a comment on pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
xiaoxiang781216 edited a comment on pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#issuecomment-717838337 Yes, but after I change other git's build.yaml to use the new file. This is an autom

[GitHub] [incubator-nuttx] jerpelea commented on pull request #2145: tools: cxd56: mkspk: automate mkspk build

2020-10-28 Thread GitBox
jerpelea commented on pull request #2145: URL: https://github.com/apache/incubator-nuttx/pull/2145#issuecomment-717840300 @Ouss4 updated This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-nuttx] jerpelea commented on pull request #2130: sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system.

2020-10-28 Thread GitBox
jerpelea commented on pull request #2130: URL: https://github.com/apache/incubator-nuttx/pull/2130#issuecomment-717843976 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] Ouss4 closed issue #2144: cxd56: mkspk tool should be built when CONFIG_CXD56_BINARY is enabled

2020-10-28 Thread GitBox
Ouss4 closed issue #2144: URL: https://github.com/apache/incubator-nuttx/issues/2144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[incubator-nuttx] branch master updated: tools: cxd56: mkspk: automate mkspk build

2020-10-28 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new bc8ea75 tools: cxd56: mkspk: auto

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2145: tools: cxd56: mkspk: automate mkspk build

2020-10-28 Thread GitBox
Ouss4 merged pull request #2145: URL: https://github.com/apache/incubator-nuttx/pull/2145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 edited a comment on pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
xiaoxiang781216 edited a comment on pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#issuecomment-717838337 Yes, but after I change other git's build.yml to use the new file. This is an automa

[incubator-nuttx-apps] branch fclose updated (c5822bc -> f0a0b03)

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch fclose in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. discard c5822bc Remove all fclose with stdin, stdout and stderr add 9f9fed3 ipcfg_binary: Fix compile

[GitHub] [incubator-nuttx] acassis commented on pull request #2138: xtensa/esp32: Add Partition and OTA device

2020-10-28 Thread GitBox
acassis commented on pull request #2138: URL: https://github.com/apache/incubator-nuttx/pull/2138#issuecomment-717885380 LGTM? This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] TA1DB commented on issue #1643: stm32f746g-disco:lvgl, fb, nxdemo, nxterm "arm_hardfault: PANIC!!! Hard fault:"

2020-10-28 Thread GitBox
TA1DB commented on issue #1643: URL: https://github.com/apache/incubator-nuttx/issues/1643#issuecomment-717901382 > Hi Murat, don't worry, my board should arrive this week and by the weekend I will try to help you. BTW, if you get a F429I-Disco you can play with LVGL without these issues,

[GitHub] [incubator-nuttx] TA1DB edited a comment on issue #1643: stm32f746g-disco:lvgl, fb, nxdemo, nxterm "arm_hardfault: PANIC!!! Hard fault:"

2020-10-28 Thread GitBox
TA1DB edited a comment on issue #1643: URL: https://github.com/apache/incubator-nuttx/issues/1643#issuecomment-717901382 > Hi Murat, don't worry, my board should arrive this week and by the weekend I will try to help you. BTW, if you get a F429I-Disco you can play with LVGL without these

[GitHub] [incubator-nuttx] TA1DB edited a comment on issue #1643: stm32f746g-disco:lvgl, fb, nxdemo, nxterm "arm_hardfault: PANIC!!! Hard fault:"

2020-10-28 Thread GitBox
TA1DB edited a comment on issue #1643: URL: https://github.com/apache/incubator-nuttx/issues/1643#issuecomment-717901382 > Hi Murat, don't worry, my board should arrive this week and by the weekend I will try to help you. BTW, if you get a F429I-Disco you can play with LVGL without these

[GitHub] [incubator-nuttx-apps] rurtle opened a new pull request #447: Fixed coding std violations in nsh_fsutils.h

2020-10-28 Thread GitBox
rurtle opened a new pull request #447: URL: https://github.com/apache/incubator-nuttx-apps/pull/447 ## Summary Fixed for Nuttx coding standards violations in nsh_fsutils.h as reported in [pull request # 446](https://github.com/apache/incubator-nuttx-apps/pull/446) and [here](https:

[incubator-nuttx-testing] branch merge created (now 0b49874)

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch merge in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git. at 0b49874 testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat This branc

[incubator-nuttx-testing] 01/01: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch merge in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git commit 0b4987406dff880b73332a281a9c54f11a2b0e96 Author: Xiang Xiao AuthorDate: Wed Oct 28 14:15:57 2020 +080

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #446: Fix for nuttx issue 1883

2020-10-28 Thread GitBox
xiaoxiang781216 merged pull request #446: URL: https://github.com/apache/incubator-nuttx-apps/pull/446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated (0781dbf -> 0d74608)

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 0781dbf usrsock_rpmsg: fix can't wake ppoll when no ACTION add 23ec80f Addressed review comme

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #446: Fix for nuttx issue 1883

2020-10-28 Thread GitBox
xiaoxiang781216 commented on pull request #446: URL: https://github.com/apache/incubator-nuttx-apps/pull/446#issuecomment-717914857 LGTM. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #1883: ifconfig: If procfs not mounted, say so in the error message

2020-10-28 Thread GitBox
xiaoxiang781216 closed issue #1883: URL: https://github.com/apache/incubator-nuttx/issues/1883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
xiaoxiang781216 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717923752 Very strange, what's value in other FILE's field? This is an automated message from the Apac

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #425: Remove all fclose with stdin, stdout and stderr

2020-10-28 Thread GitBox
davids5 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717927282 @xiaoxiang781216 would you please set this a `draft` until it is sorted out?. You can test on the board I left with you, it has a usb. -

[incubator-nuttx-apps] branch master updated: Fixed coding std violations in nsh_fsutils.h

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 76e58d9 Fixed coding std viola

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #447: Fixed coding std violations in nsh_fsutils.h

2020-10-28 Thread GitBox
xiaoxiang781216 merged pull request #447: URL: https://github.com/apache/incubator-nuttx-apps/pull/447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] YuuichiNakamura commented on a change in pull request #2142: Add task name record for task trace

2020-10-28 Thread GitBox
YuuichiNakamura commented on a change in pull request #2142: URL: https://github.com/apache/incubator-nuttx/pull/2142#discussion_r513455014 ## File path: sched/sched/sched_note.c ## @@ -405,6 +405,10 @@ void sched_note_start(FAR struct tcb_s *tcb) strncpy(note.nsa_name, tcb-

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2131: libxx: Use Kconfig "choice" to specify an implemenetation

2020-10-28 Thread GitBox
v01d commented on a change in pull request #2131: URL: https://github.com/apache/incubator-nuttx/pull/2131#discussion_r513494553 ## File path: libs/libxx/Kconfig ## @@ -22,6 +22,34 @@ config HAVE_CXX if HAVE_CXX +choice + prompt "C++ Library" + default NUTTXCXX

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2146: drivers/pipes: nx_pipe syscall takes three params, also use nx_close …

2020-10-28 Thread GitBox
juniskane opened a new pull request #2146: URL: https://github.com/apache/incubator-nuttx/pull/2146 ## Summary - Fix SYSCALL_LOOKUP for nx_pipe syscall - Use nx_close() instead of close() to avoid setting errno and cancellation point - Update some misleading comments ##

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2146: drivers/pipes: nx_pipe syscall takes three params, also use nx_close …

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2146: URL: https://github.com/apache/incubator-nuttx/pull/2146#discussion_r513518572 ## File path: include/sys/syscall_lookup.h ## @@ -255,7 +255,7 @@ SYSCALL_LOOKUP(telldir,1) #endif #if defined(CON

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2147: Use nx_close() inside OS

2020-10-28 Thread GitBox
juniskane opened a new pull request #2147: URL: https://github.com/apache/incubator-nuttx/pull/2147 ## Summary Use nx_close() instead of close() inside OS to avoid setting errno and having a cancellation point. ## Impact ## Testing

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2115: Store artifacts durring build

2020-10-28 Thread GitBox
btashton commented on a change in pull request #2115: URL: https://github.com/apache/incubator-nuttx/pull/2115#discussion_r513522024 ## File path: tools/Makefile.win ## @@ -392,17 +392,22 @@ ifeq ($(CONFIG_BUILD_2PASS),y) $(Q) $(MAKE) -C $(CONFIG_PASS1_BUILDIR) LINKLIBS

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2142: Add task name record for task trace

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2142: URL: https://github.com/apache/incubator-nuttx/pull/2142#discussion_r513573129 ## File path: sched/sched/sched_note.c ## @@ -405,6 +405,10 @@ void sched_note_start(FAR struct tcb_s *tcb) strncpy(note.nsa_name, tcb-

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2146: drivers/pipes: nx_pipe syscall takes three params, also use nx_close …

2020-10-28 Thread GitBox
xiaoxiang781216 merged pull request #2146: URL: https://github.com/apache/incubator-nuttx/pull/2146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] 02/02: sched: use nx_close instead of close

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8c464b0e7a35bf6ae94fcecdccc31dd31af9cd29 Author: Juha Niskanen AuthorDate: Wed Oct 28 17:02:56 2020 +0200

[incubator-nuttx] branch master updated: drivers/pipes: nx_pipe syscall takes three params, also use nx_close on error path

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1115452 drivers/pipes: nx_pipe sysc

[incubator-nuttx] branch master updated (1115452 -> 8c464b0)

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 1115452 drivers/pipes: nx_pipe syscall takes three params, also use nx_close on error path new 157

[incubator-nuttx] 01/02: fs/inode/fs_fileopen.c: use nx_close instead of close

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 1577726f05d7a49c95295d807cc73a0207dc176a Author: Juha Niskanen AuthorDate: Wed Oct 28 17:02:35 2020 +0200

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2147: Use nx_close() inside OS

2020-10-28 Thread GitBox
xiaoxiang781216 merged pull request #2147: URL: https://github.com/apache/incubator-nuttx/pull/2147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #445: Android Debug Bridge daemon

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #445: URL: https://github.com/apache/incubator-nuttx-apps/pull/445#discussion_r513422291 ## File path: system/adb/Kconfig ## @@ -0,0 +1,147 @@ +# +# For a description of the syntax of this configuration file, +# see the fil

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2115: Store artifacts durring build

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2115: URL: https://github.com/apache/incubator-nuttx/pull/2115#discussion_r513591543 ## File path: Makefile ## @@ -45,3 +45,7 @@ else include tools/Makefile.unix endif endif + +.PHONY: execname +execname: + @echo $

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2131: libxx: Use Kconfig "choice" to specify an implemenetation

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2131: URL: https://github.com/apache/incubator-nuttx/pull/2131#discussion_r513594032 ## File path: libs/libxx/Kconfig ## @@ -22,6 +22,34 @@ config HAVE_CXX if HAVE_CXX +choice + prompt "C++ Library" + defau

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2115: Store artifacts durring build

2020-10-28 Thread GitBox
btashton commented on a change in pull request #2115: URL: https://github.com/apache/incubator-nuttx/pull/2115#discussion_r513608885 ## File path: Makefile ## @@ -45,3 +45,7 @@ else include tools/Makefile.unix endif endif + +.PHONY: execname +execname: + @echo $(BIN)

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
btashton commented on a change in pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#discussion_r513611274 ## File path: testlist/other.dat ## @@ -0,0 +1,28 @@ +# We do not have a toolchain for avr32 outside of Microchip login wall. +# The work wa

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
btashton commented on a change in pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#discussion_r513612954 ## File path: testlist/other.dat ## @@ -0,0 +1,28 @@ +# We do not have a toolchain for avr32 outside of Microchip login wall. +# The work wa

[GitHub] [incubator-nuttx] btashton commented on pull request #2130: sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system.

2020-10-28 Thread GitBox
btashton commented on pull request #2130: URL: https://github.com/apache/incubator-nuttx/pull/2130#issuecomment-718078824 This is only failing because it needs to be fast-forwarded. The restriction is already in place and tested in the testing repo. Other old PRs will likely need to

[GitHub] [incubator-nuttx] btashton closed issue #2094: sim:rpserver segfault

2020-10-28 Thread GitBox
btashton closed issue #2094: URL: https://github.com/apache/incubator-nuttx/issues/2094 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] btashton merged pull request #2130: sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system.

2020-10-28 Thread GitBox
btashton merged pull request #2130: URL: https://github.com/apache/incubator-nuttx/pull/2130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] v01d merged pull request #2131: libxx: Use Kconfig "choice" to specify an implemenetation

2020-10-28 Thread GitBox
v01d merged pull request #2131: URL: https://github.com/apache/incubator-nuttx/pull/2131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2131: libxx: Use Kconfig "choice" to specify an implemenetation

2020-10-28 Thread GitBox
v01d commented on a change in pull request #2131: URL: https://github.com/apache/incubator-nuttx/pull/2131#discussion_r513618606 ## File path: libs/libxx/Kconfig ## @@ -22,6 +22,34 @@ config HAVE_CXX if HAVE_CXX +choice + prompt "C++ Library" + default NUTTXCXX

[incubator-nuttx] branch master updated (8c464b0 -> c9dd19f)

2020-10-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8c464b0 sched: use nx_close instead of close add c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SI

[incubator-nuttx] branch master updated (c9dd19f -> ff3fa80)

2020-10-28 Thread protobits
This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system. add ff3fa80 libxx: Use

[incubator-nuttx] branch master updated (c9dd19f -> ff3fa80)

2020-10-28 Thread protobits
This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system. add ff3fa80 libxx: Use

[incubator-nuttx] branch master updated (8c464b0 -> c9dd19f)

2020-10-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8c464b0 sched: use nx_close instead of close add c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SI

[incubator-nuttx] branch master updated (8c464b0 -> c9dd19f)

2020-10-28 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8c464b0 sched: use nx_close instead of close add c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SI

[incubator-nuttx] branch master updated (c9dd19f -> ff3fa80)

2020-10-28 Thread protobits
This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system. add ff3fa80 libxx: Use

[GitHub] [incubator-nuttx] v01d opened a new pull request #2148: nrf52_wdt: split into low-level API and watchdog driver lower-half

2020-10-28 Thread GitBox
v01d opened a new pull request #2148: URL: https://github.com/apache/incubator-nuttx/pull/2148 ## Summary This separation allows to interact with the watchdog from OS code, for example initiating the watchdog very early on boot. Moreover, these changes make the lower-half driver

[incubator-nuttx] branch master updated (c9dd19f -> ff3fa80)

2020-10-28 Thread protobits
This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system. add ff3fa80 libxx: Use

[incubator-nuttx] branch master updated (c9dd19f -> ff3fa80)

2020-10-28 Thread protobits
This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c9dd19f sim:rpproxy/rpserver: force use 'CONFIG_SIM_M32' for 64bit system. add ff3fa80 libxx: Use

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #1804: Assertion failed at file:mqueue/mq_sndinternal.c line: 420

2020-10-28 Thread GitBox
xiaoxiang781216 closed issue #1804: URL: https://github.com/apache/incubator-nuttx/issues/1804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1585: sched/task: do not migrate the task state to INVALID

2020-10-28 Thread GitBox
xiaoxiang781216 merged pull request #1585: URL: https://github.com/apache/incubator-nuttx/pull/1585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: sched/task: do not migrate the task state to INVALID

2020-10-28 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new d0bde11 sched/task: do not migrate

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#discussion_r513672709 ## File path: testlist/other.dat ## @@ -0,0 +1,28 @@ +# We do not have a toolchain for avr32 outside of Microchip login wall. +# The

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 commented on a change in pull request #74: testlist: Merge avr-mips-riscv-x86-xtensa.dat and renesas.dat into other.dat

2020-10-28 Thread GitBox
xiaoxiang781216 commented on a change in pull request #74: URL: https://github.com/apache/incubator-nuttx-testing/pull/74#discussion_r513673582 ## File path: testlist/other.dat ## @@ -0,0 +1,28 @@ +# We do not have a toolchain for avr32 outside of Microchip login wall. +# The

  1   2   >