[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1956: Update spresense configs

2020-10-09 Thread GitBox
masayuki2009 commented on pull request #1956: URL: https://github.com/apache/incubator-nuttx/pull/1956#issuecomment-706020961 @jerpelea This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #421: Add task trace support

2020-10-09 Thread GitBox
xiaoxiang781216 commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r502255318 ## File path: nshlib/nsh_command.c ## @@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] = { "time", cmd_time, 2,

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

2020-10-09 Thread GitBox
Ouss4 commented on a change in pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502261719 ## File path: arch/xtensa/src/esp32/esp32_wlan.c ## @@ -0,0 +1,1589 @@ +/***

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

2020-10-09 Thread GitBox
Ouss4 commented on a change in pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502262236 ## File path: arch/xtensa/src/esp32/esp32_wlan.c ## @@ -0,0 +1,1589 @@ +/***

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1957: arch/xtensa: Fix some alignments and typos in assembly code.

2020-10-09 Thread GitBox
Ouss4 opened a new pull request #1957: URL: https://github.com/apache/incubator-nuttx/pull/1957 ## Summary Trivial alignments and typos. ## Impact N/A ## Testing N/A This is an automated message from th

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1958: xtensa/esp32: When PSRAM is enabled allow drivers and tasks to allocate memory from a separate internal memory

2020-10-09 Thread GitBox
Ouss4 opened a new pull request #1958: URL: https://github.com/apache/incubator-nuttx/pull/1958 ## Summary When external RAM and external FLASH are used together we have to make sure that: - For drivers, in case of a DMA transfer, the buffer is DMA capable, i.e. doesn't originate

[GitHub] [incubator-nuttx] v01d commented on pull request #1955: Add note filters documentation

2020-10-09 Thread GitBox
v01d commented on pull request #1955: URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-706174559 The docs look fine, albeit there should also be some explanation inside the first section of *what* the note driver does. Keep in mind that not everyone (as me) is aware of

[GitHub] [incubator-nuttx] v01d commented on issue #1952: Documentation: sphinx-build not found

2020-10-09 Thread GitBox
v01d commented on issue #1952: URL: https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-706176105 Did you manage to solve this? If not, maybe paste the exact sequence of commands and output here. I feel that we're missing something or maybe there's something that is not f

[GitHub] [incubator-nuttx] btashton commented on issue #1952: Documentation: sphinx-build not found

2020-10-09 Thread GitBox
btashton commented on issue #1952: URL: https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705759996 Did you do `pipenv shell` or use `pipenv run` to run the make command? This is an automated message from th

[GitHub] [incubator-nuttx] v01d commented on issue #1952: Documentation: sphinx-build not found

2020-10-09 Thread GitBox
v01d commented on issue #1952: URL: https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705589272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] ghn-certi commented on a change in pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

2020-10-09 Thread GitBox
ghn-certi commented on a change in pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r501658341 ## File path: arch/xtensa/src/esp32/esp32_wlan.c ## @@ -0,0 +1,1589 @@ +/***

[GitHub] [incubator-nuttx] v01d commented on pull request #1955: Add note filters documentation

2020-10-09 Thread GitBox
v01d commented on pull request #1955: URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-706174559 The docs look fine, albeit there should also be some explanation inside the first section of *what* the note driver does. Keep in mind that not everyone (as me) is aware of

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1950: Fix spresense smp

2020-10-09 Thread GitBox
masayuki2009 commented on pull request #1950: URL: https://github.com/apache/incubator-nuttx/pull/1950#issuecomment-705340388 @jerpelea This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on pull request #421: Add task trace support

2020-10-09 Thread GitBox
YuuichiNakamura commented on pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#issuecomment-705383757 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1922: sched: nxtask_start should call entry point directly for kernel thread

2020-10-09 Thread GitBox
masayuki2009 commented on pull request #1922: URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705377635 @xiaoxiang781216 Thaks for your detailed explanation. @jerpelea I think it looks good to me but do you have any other comments. -

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #422: wireless: gs2200m: Fix recvfrom_reques() in gs2200m_main.c

2020-10-09 Thread GitBox
masayuki2009 commented on pull request #422: URL: https://github.com/apache/incubator-nuttx-apps/pull/422#issuecomment-705929872 @jerpelea This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-nuttx-apps] ttnie closed pull request #410: Add LTP support

2020-10-09 Thread GitBox
ttnie closed pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] saramonteiro commented on issue #1952: Documentation: sphinx-build not found

2020-10-09 Thread GitBox
saramonteiro commented on issue #1952: URL: https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705703354 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-nuttx-apps] jerpelea merged pull request #422: wireless: gs2200m: Fix recvfrom_reques() in gs2200m_main.c

2020-10-09 Thread GitBox
jerpelea merged pull request #422: URL: https://github.com/apache/incubator-nuttx-apps/pull/422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-nuttx] jerpelea merged pull request #1922: sched: nxtask_start should call entry point directly for kernel thread

2020-10-09 Thread GitBox
jerpelea merged pull request #1922: URL: https://github.com/apache/incubator-nuttx/pull/1922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx-apps] YuuichiNakamura commented on a change in pull request #421: Add task trace support

2020-10-09 Thread GitBox
YuuichiNakamura commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r501507319 ## File path: nshlib/nsh_command.c ## @@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] = { "time", cmd_time, 2,

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1922: sched: nxtask_start should call entry point directly for kernel thread

2020-10-09 Thread GitBox
jerpelea commented on pull request #1922: URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705379477 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx-apps] ttnie commented on pull request #410: Add LTP support

2020-10-09 Thread GitBox
ttnie commented on pull request #410: URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705908365 > @ttnie is it ready to merge? @acassis back from holiday. This is an automated message from t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1922: sched: nxtask_start should call entry point directly for kernel thread

2020-10-09 Thread GitBox
xiaoxiang781216 commented on pull request #1922: URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705357685 > @xiaoxiang781216 > > As long as I checked the latest upstream, I think the issue does not relate to SMP. Yes, it isn't SMP specific. SMP just expo

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #421: Add task trace support

2020-10-09 Thread GitBox
xiaoxiang781216 commented on a change in pull request #421: URL: https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r500839342 ## File path: nshlib/nsh_command.c ## @@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] = { "time", cmd_time, 2,

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1956: Update spresense configs

2020-10-09 Thread GitBox
masayuki2009 commented on pull request #1956: URL: https://github.com/apache/incubator-nuttx/pull/1956#issuecomment-706020961 @jerpelea This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] jerpelea merged pull request #1950: Fix spresense smp

2020-10-09 Thread GitBox
jerpelea merged pull request #1950: URL: https://github.com/apache/incubator-nuttx/pull/1950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

2020-10-09 Thread GitBox
Ouss4 commented on a change in pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502261719 ## File path: arch/xtensa/src/esp32/esp32_wlan.c ## @@ -0,0 +1,1589 @@ +/***

[GitHub] [incubator-nuttx] saramonteiro edited a comment on issue #1952: Documentation: sphinx-build not found

2020-10-09 Thread GitBox
saramonteiro edited a comment on issue #1952: URL: https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705756365 Output: ``` shell Installing dependencies from Pipfile.lock (f6636c)… 🐍 28/28 — 00:01:28 All dependencies are now

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1922: sched: nxtask_start should call entry point directly for kernel thread

2020-10-09 Thread GitBox
xiaoxiang781216 edited a comment on pull request #1922: URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705357685 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1951: sched: task: Fix nxtask_exit() for SMP

2020-10-09 Thread GitBox
masayuki2009 commented on pull request #1951: URL: https://github.com/apache/incubator-nuttx/pull/1951#issuecomment-705371524 @patacongo Could you please review this PR? This is an automated message from the Apache Gi

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1949: sim: Fix make export

2020-10-09 Thread GitBox
xiaoxiang781216 merged pull request #1949: URL: https://github.com/apache/incubator-nuttx/pull/1949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] YuuichiNakamura commented on pull request #1955: Add note filters documentation

2020-10-09 Thread GitBox
YuuichiNakamura commented on pull request #1955: URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-705978566 @v01d @xiaoxiang781216 I have added the document for note filters. This is an introduction of only filter device. The application command introduction will be

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #1959: Documentation for the Timer Driver

2020-10-09 Thread GitBox
saramonteiro opened a new pull request #1959: URL: https://github.com/apache/incubator-nuttx/pull/1959 ## Summary This PR adds detailed instructions on how to use the Timer Driver. ## Impact N/A ## Testing N/A -

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #1961: tiva: Fix nxstyle warnings

2020-10-09 Thread GitBox
hartmannathan opened a new pull request #1961: URL: https://github.com/apache/incubator-nuttx/pull/1961 ## Summary arch/arm/include/tiva/cc13x0_irq.h: arch/arm/include/tiva/cc13x2_cc26x2_irq.h: arch/arm/include/tiva/chip.h: arch/arm/include/tiva/irq.h: arch/arm/include/tiv

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1960: arch/xtensa/src/common/xtensa.h: Include sys/types.h needed if STACK_COLORATON is enabled

2020-10-09 Thread GitBox
Ouss4 opened a new pull request #1960: URL: https://github.com/apache/incubator-nuttx/pull/1960 ## Summary If STACK_COLORATION is enabled the build would fail as it can't find a definition for size_t. ## Impact Fix build if STACK_COLORATION is enabled. ## Testing esp32-co

[incubator-nuttx] branch master updated (c59fcd3 -> 18edab3)

2020-10-09 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c59fcd3 sched: nxtask_start should call entry point directly for kernel thread add 18edab3 tiva

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1961: tiva: Fix nxstyle warnings

2020-10-09 Thread GitBox
Ouss4 merged pull request #1961: URL: https://github.com/apache/incubator-nuttx/pull/1961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1960: arch/xtensa/src/common/xtensa.h: Include sys/types.h needed if STACK_COLORATON is enabled

2020-10-09 Thread GitBox
xiaoxiang781216 merged pull request #1960: URL: https://github.com/apache/incubator-nuttx/pull/1960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (18edab3 -> 20f701f)

2020-10-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 18edab3 tiva: Fix nxstyle warnings add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.

[incubator-nuttx] branch master updated (18edab3 -> 20f701f)

2020-10-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 18edab3 tiva: Fix nxstyle warnings add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.

[incubator-nuttx] branch master updated (18edab3 -> 20f701f)

2020-10-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 18edab3 tiva: Fix nxstyle warnings add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.

[incubator-nuttx] branch master updated (18edab3 -> 20f701f)

2020-10-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 18edab3 tiva: Fix nxstyle warnings add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.

[incubator-nuttx] branch master updated (18edab3 -> 20f701f)

2020-10-09 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 18edab3 tiva: Fix nxstyle warnings add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #1959: Documentation for the Timer Driver

2020-10-09 Thread GitBox
saramonteiro commented on pull request #1959: URL: https://github.com/apache/incubator-nuttx/pull/1959#issuecomment-706330796 @v01d Please, take a look. I followed your suggestions in our talking. This is an automated message

[GitHub] [incubator-nuttx] ghn-certi commented on a change in pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

2020-10-09 Thread GitBox
ghn-certi commented on a change in pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502610057 ## File path: arch/xtensa/src/esp32/esp32_wlan.c ## @@ -0,0 +1,1589 @@ +/***

[GitHub] [incubator-nuttx] ghn-certi commented on pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

2020-10-09 Thread GitBox
ghn-certi commented on pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#issuecomment-706351508 It is important that the documentation is clear, and not just a copy and paste from other implementation. Please, try not to leave misleading comments in the source

[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #1893: xtensa/esp32: Add ESP32 WiFi adapter and driver

2020-10-09 Thread GitBox
donghengqaz commented on a change in pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502732161 ## File path: arch/xtensa/src/esp32/esp32_wlan.c ## @@ -0,0 +1,1589 @@ +/*