masayuki2009 commented on pull request #1956:
URL: https://github.com/apache/incubator-nuttx/pull/1956#issuecomment-706020961
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the message,
xiaoxiang781216 commented on a change in pull request #421:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r502255318
##
File path: nshlib/nsh_command.c
##
@@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] =
{ "time", cmd_time, 2,
Ouss4 commented on a change in pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502261719
##
File path: arch/xtensa/src/esp32/esp32_wlan.c
##
@@ -0,0 +1,1589 @@
+/***
Ouss4 commented on a change in pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502262236
##
File path: arch/xtensa/src/esp32/esp32_wlan.c
##
@@ -0,0 +1,1589 @@
+/***
Ouss4 opened a new pull request #1957:
URL: https://github.com/apache/incubator-nuttx/pull/1957
## Summary
Trivial alignments and typos.
## Impact
N/A
## Testing
N/A
This is an automated message from th
Ouss4 opened a new pull request #1958:
URL: https://github.com/apache/incubator-nuttx/pull/1958
## Summary
When external RAM and external FLASH are used together we have to make sure
that:
- For drivers, in case of a DMA transfer, the buffer is DMA capable, i.e.
doesn't originate
v01d commented on pull request #1955:
URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-706174559
The docs look fine, albeit there should also be some explanation inside the
first section of *what* the note driver does. Keep in mind that not everyone
(as me) is aware of
v01d commented on issue #1952:
URL:
https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-706176105
Did you manage to solve this?
If not, maybe paste the exact sequence of commands and output here. I feel
that we're missing something or maybe there's something that is not f
btashton commented on issue #1952:
URL:
https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705759996
Did you do `pipenv shell` or use `pipenv run` to run the make command?
This is an automated message from th
v01d commented on issue #1952:
URL:
https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705589272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ghn-certi commented on a change in pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r501658341
##
File path: arch/xtensa/src/esp32/esp32_wlan.c
##
@@ -0,0 +1,1589 @@
+/***
v01d commented on pull request #1955:
URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-706174559
The docs look fine, albeit there should also be some explanation inside the
first section of *what* the note driver does. Keep in mind that not everyone
(as me) is aware of
masayuki2009 commented on pull request #1950:
URL: https://github.com/apache/incubator-nuttx/pull/1950#issuecomment-705340388
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the message,
YuuichiNakamura commented on pull request #421:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/421#issuecomment-705383757
This is an automated message from the Apache Git Service.
To respond to the message, please l
masayuki2009 commented on pull request #1922:
URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705377635
@xiaoxiang781216
Thaks for your detailed explanation.
@jerpelea
I think it looks good to me but do you have any other comments.
-
masayuki2009 commented on pull request #422:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/422#issuecomment-705929872
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the mess
ttnie closed pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
saramonteiro commented on issue #1952:
URL:
https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705703354
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
jerpelea merged pull request #422:
URL: https://github.com/apache/incubator-nuttx-apps/pull/422
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jerpelea merged pull request #1922:
URL: https://github.com/apache/incubator-nuttx/pull/1922
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
YuuichiNakamura commented on a change in pull request #421:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r501507319
##
File path: nshlib/nsh_command.c
##
@@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] =
{ "time", cmd_time, 2,
jerpelea commented on pull request #1922:
URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705379477
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ttnie commented on pull request #410:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705908365
> @ttnie is it ready to merge?
@acassis back from holiday.
This is an automated message from t
xiaoxiang781216 commented on pull request #1922:
URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705357685
> @xiaoxiang781216
>
> As long as I checked the latest upstream, I think the issue does not
relate to SMP.
Yes, it isn't SMP specific. SMP just expo
xiaoxiang781216 commented on a change in pull request #421:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r500839342
##
File path: nshlib/nsh_command.c
##
@@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] =
{ "time", cmd_time, 2,
masayuki2009 commented on pull request #1956:
URL: https://github.com/apache/incubator-nuttx/pull/1956#issuecomment-706020961
@jerpelea
This is an automated message from the Apache Git Service.
To respond to the message,
jerpelea merged pull request #1950:
URL: https://github.com/apache/incubator-nuttx/pull/1950
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Ouss4 commented on a change in pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502261719
##
File path: arch/xtensa/src/esp32/esp32_wlan.c
##
@@ -0,0 +1,1589 @@
+/***
saramonteiro edited a comment on issue #1952:
URL:
https://github.com/apache/incubator-nuttx/issues/1952#issuecomment-705756365
Output:
``` shell
Installing dependencies from Pipfile.lock (f6636c)…
🐍 28/28 — 00:01:28
All dependencies are now
xiaoxiang781216 edited a comment on pull request #1922:
URL: https://github.com/apache/incubator-nuttx/pull/1922#issuecomment-705357685
This is an automated message from the Apache Git Service.
To respond to the message, pleas
masayuki2009 commented on pull request #1951:
URL: https://github.com/apache/incubator-nuttx/pull/1951#issuecomment-705371524
@patacongo
Could you please review this PR?
This is an automated message from the Apache Gi
xiaoxiang781216 merged pull request #1949:
URL: https://github.com/apache/incubator-nuttx/pull/1949
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
YuuichiNakamura commented on pull request #1955:
URL: https://github.com/apache/incubator-nuttx/pull/1955#issuecomment-705978566
@v01d @xiaoxiang781216 I have added the document for note filters.
This is an introduction of only filter device. The application command
introduction will be
saramonteiro opened a new pull request #1959:
URL: https://github.com/apache/incubator-nuttx/pull/1959
## Summary
This PR adds detailed instructions on how to use the Timer Driver.
## Impact
N/A
## Testing
N/A
-
hartmannathan opened a new pull request #1961:
URL: https://github.com/apache/incubator-nuttx/pull/1961
## Summary
arch/arm/include/tiva/cc13x0_irq.h:
arch/arm/include/tiva/cc13x2_cc26x2_irq.h:
arch/arm/include/tiva/chip.h:
arch/arm/include/tiva/irq.h:
arch/arm/include/tiv
Ouss4 opened a new pull request #1960:
URL: https://github.com/apache/incubator-nuttx/pull/1960
## Summary
If STACK_COLORATION is enabled the build would fail as it can't find a
definition for size_t.
## Impact
Fix build if STACK_COLORATION is enabled.
## Testing
esp32-co
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from c59fcd3 sched: nxtask_start should call entry point directly for
kernel thread
add 18edab3 tiva
Ouss4 merged pull request #1961:
URL: https://github.com/apache/incubator-nuttx/pull/1961
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoxiang781216 merged pull request #1960:
URL: https://github.com/apache/incubator-nuttx/pull/1960
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 18edab3 tiva: Fix nxstyle warnings
add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 18edab3 tiva: Fix nxstyle warnings
add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 18edab3 tiva: Fix nxstyle warnings
add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 18edab3 tiva: Fix nxstyle warnings
add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 18edab3 tiva: Fix nxstyle warnings
add 20f701f arch/xtensa/src/common/xtensa.h: Include sys/types.
saramonteiro commented on pull request #1959:
URL: https://github.com/apache/incubator-nuttx/pull/1959#issuecomment-706330796
@v01d Please, take a look. I followed your suggestions in our talking.
This is an automated message
ghn-certi commented on a change in pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502610057
##
File path: arch/xtensa/src/esp32/esp32_wlan.c
##
@@ -0,0 +1,1589 @@
+/***
ghn-certi commented on pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#issuecomment-706351508
It is important that the documentation is clear, and not just a copy and
paste from other implementation.
Please, try not to leave misleading comments in the source
donghengqaz commented on a change in pull request #1893:
URL: https://github.com/apache/incubator-nuttx/pull/1893#discussion_r502732161
##
File path: arch/xtensa/src/esp32/esp32_wlan.c
##
@@ -0,0 +1,1589 @@
+/*
48 matches
Mail list logo