lukegluke closed issue #1354:
URL: https://github.com/apache/incubator-nuttx/issues/1354
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658296884
@Ouss4 Ok, I changed the headers on the new files to Apache License 2.0, and
removed the obsolete config value. Anything else to do here?
xiaoxiang781216 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454507297
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,221 @@
#
#
xiaoxiang781216 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454506981
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,221 @@
#
#
xiaoxiang781216 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454509316
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
xiaoxiang781216 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454509968
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658300580
@Ouss4 BTW the two main files,
[sam_sdmmc.h](https://github.com/starcat-io/incubator-nuttx/blob/feature/sama5d27-sdmmc-support/arch/arm/src/sama5/hardware/sam_sdmmc.h)
xiaoxiang781216 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454511044
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454512376
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454512974
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454518789
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,221 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454519482
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,221 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454520646
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,221 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454523667
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454525440
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454526720
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454532491
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,225 @@
#
#
adamfeuer commented on pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#issuecomment-658319283
@xiaoxiang781216 Ok, I think I implemented all your suggestions. Anything
else left to do?
This is an
xiaoxiang781216 commented on pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#issuecomment-658345919
It's almost done, I squanch your change and make some clean:
https://github.com/xiaoxiang781216/incubator-nuttx/commit/b2fd53ae0bdae78ad73b4ae722756789d05a4ab7
xiaoxiang781216 edited a comment on pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#issuecomment-658345919
It's almost done, I squanch your change and make some clean:
https://github.com/xiaoxiang781216/incubator-nuttx/commit/b2fd53ae0bdae78ad73b4ae722756789d
adamfeuer commented on pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#issuecomment-658421775
@xiaoxiang781216 Your changes look good and I cherry-picked them, but they
break the `--dir` option for me. I also pushed a small change to fix that
`--dir` option pro
acassis opened a new pull request #1402:
URL: https://github.com/apache/incubator-nuttx/pull/1402
## Summary
Add buttons support to iMXRT1060
## Impact
None
## Testing
iMXRT1060-EVK
This is an automated mes
Ouss4 commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r454675791
##
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##
@@ -0,0 +1,149 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
adamfeuer edited a comment on pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#issuecomment-658421775
@xiaoxiang781216 Your changes look good and I cherry-picked them, but they
break the `--dir` option for me. I pushed a small change to fix that `--dir`
option p
Ouss4 merged pull request #1402:
URL: https://github.com/apache/incubator-nuttx/pull/1402
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new bc95500 Add buttons support to iM
adamfeuer commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r454685432
##
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##
@@ -0,0 +1,149 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT
adamfeuer commented on a change in pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#discussion_r454685483
##
File path: boards/arm/sama5/sama5d2-xult/configs/sdmmcnsh/defconfig
##
@@ -0,0 +1,149 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658462338
@Ouss4 Thanks, I pushed changes to remove the obsolete config values, I'll
watch the CI and try to resolve any other problems.
---
masayuki2009 opened a new pull request #1403:
URL: https://github.com/apache/incubator-nuttx/pull/1403
## Summary
- This PR contains two commits for configs/elf and configs/posix_spawn
- Each commit contains the following changes
- Remove Make.defs (i.e. Use scripts/Make.defs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d214cff7d79bd9d4e85076fc66f753c9aeafcd80
Author: Masayuki Ishikawa
AuthorDate: Wed Jul 15 10:25:29 2020 +090
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from bc95500 Add buttons support to iMXRT1060
new df72e45 boards: stm32f4discovery: Update configs/elf
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit df72e4566fb10b6a529b6238bc7d83cddf06b095
Author: Masayuki Ishikawa
AuthorDate: Wed Jul 15 10:14:46 2020 +090
xiaoxiang781216 merged pull request #1403:
URL: https://github.com/apache/incubator-nuttx/pull/1403
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
adamfeuer commented on pull request #1393:
URL: https://github.com/apache/incubator-nuttx/pull/1393#issuecomment-658553303
@Ouss4 Ok, looks like all the non-nxstyle checks are passing. I ran nxstyle
locally and fixed all the problems I could before submitting this PR; the
remaining nxstyle
xiaoxiang781216 commented on a change in pull request #1382:
URL: https://github.com/apache/incubator-nuttx/pull/1382#discussion_r454804482
##
File path: tools/checkrelease.sh
##
@@ -19,114 +19,208 @@
#
#
36 matches
Mail list logo
