[GitHub] [incubator-nuttx] jerpelea opened a new pull request #1232: boards: arm: cxd56: initilize the video stream driver from the board

2020-06-14 Thread GitBox
jerpelea opened a new pull request #1232: URL: https://github.com/apache/incubator-nuttx/pull/1232 ## Summary The video stream driver must be initialized from the board to comply with NuttX ## Impact Spresense board NOTE: Please remove the initalization from any came

[GitHub] [incubator-nuttx] acassis opened a new pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis opened a new pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233 This driver was created by Adam Porter and posted on NuttX mailing list at Google Group on Nov 14 2019 ## Summary ## Impact ## Testing -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830029 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830029 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830029 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830530 ## File path: net/netdev/netdev_register.c ## @@ -55,6 +55,7 @@ #define NETDEV_PAN_FORMAT "pan%d" #define NETDEV_WLAN_FORMAT "wlan%d" #def

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830792 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830721 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2578 @@ +/

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830977 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2578 @@ +/**

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830923 ## File path: net/netdev/netdev_register.c ## @@ -55,6 +55,7 @@ #define NETDEV_PAN_FORMAT "pan%d" #define NETDEV_WLAN_FORMAT "wlan%d" #defin

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439831100 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] btashton commented on pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
btashton commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643770298 You cannot just slap the Apache license on this without getting his approval... This is an automated m

[GitHub] [incubator-nuttx] acassis commented on pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643770782 > You cannot just slap the Apache license on this without getting his approval... Since the original code is BSD I think it is possible, but I should have kept th

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830530 ## File path: net/netdev/netdev_register.c ## @@ -55,6 +55,7 @@ #define NETDEV_PAN_FORMAT "pan%d" #define NETDEV_WLAN_FORMAT "wlan%d" #def

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830530 ## File path: net/netdev/netdev_register.c ## @@ -55,6 +55,7 @@ #define NETDEV_PAN_FORMAT "pan%d" #define NETDEV_WLAN_FORMAT "wlan%d" #def

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439833437 ## File path: net/netdev/netdev_register.c ## @@ -55,6 +55,7 @@ #define NETDEV_PAN_FORMAT "pan%d" #define NETDEV_WLAN_FORMAT "wlan%d" #def

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439831100 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] patacongo commented on pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643771519 > > > > You cannot just slap the Apache license on this without getting his approval... > > Since the original code is BSD I think it is possible, but I

[GitHub] [incubator-nuttx] acassis commented on pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643771988 > > > You cannot just slap the Apache license on this without getting his approval... > > > > > > Since the original code is BSD I think it is possible, but I

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439834008 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439834486 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439836065 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439836240 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439836065 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439836240 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439837333 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439837464 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1232: boards: arm: cxd56: initilize the video stream driver from the board

2020-06-14 Thread GitBox
jerpelea commented on pull request #1232: URL: https://github.com/apache/incubator-nuttx/pull/1232#issuecomment-643777507 @patacongo thanks for your patience. I am working on porting also the camera example app to mainline if this is ok ---

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439839343 ## File path: include/nuttx/usb/cdc.h ## @@ -890,15 +930,15 @@ struct cdc_linecoding_s struct cdc_linestatus_s { uint8_t size[2]; /* wLen

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439839612 ## File path: include/nuttx/net/net.h ## @@ -155,7 +155,8 @@ enum net_lltype_e NET_LL_BLUETOOTH,/* Bluetooth */ NET_LL_IEEE80211,/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439839940 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439840045 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439833437 ## File path: net/netdev/netdev_register.c ## @@ -55,6 +55,7 @@ #define NETDEV_PAN_FORMAT "pan%d" #define NETDEV_WLAN_FORMAT "wlan%d" #def

[GitHub] [incubator-nuttx] aport commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
aport commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643806087 Hi Alan, Greg, and team. I'm okay with the license change. A few things about this code: 1) It's old 2) It's incomplete 3) It's probably quite bug

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439857380 ## File path: net/netdev/netdev_register.c ## @@ -55,6 +55,7 @@ #define NETDEV_PAN_FORMAT "pan%d" #define NETDEV_WLAN_FORMAT "wlan%d" #defin

[GitHub] [incubator-nuttx] patacongo commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643806641 > > > Hi Alan, Greg, and team. > > I'm okay with the license change. > > A few things about this code: > > 1. It's old > > 2.

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439857620 ## File path: drivers/usbhost/Kconfig ## @@ -262,6 +262,15 @@ config USBHOST_CDCACM_TXBUFSIZE endif # USBHOST_CDCACM +config USBHOST_CDCMBI

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439859969 ## File path: net/netdev/netdev_register.c ## @@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum net_lltype_e lltype)

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439871941 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439871891 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439872027 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439872290 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439872316 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439872482 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439872546 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439872577 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439872607 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439875344 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/**

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439875385 ## File path: drivers/usbhost/usbhost_cdcmbim.c ## @@ -0,0 +1,2562 @@ +/**

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #1232: boards: arm: cxd56: initilize the video stream driver from the board

2020-06-14 Thread GitBox
masayuki2009 merged pull request #1232: URL: https://github.com/apache/incubator-nuttx/pull/1232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-nuttx] branch master updated (02ad0e9 -> c6c0214)

2020-06-14 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 02ad0e9 drivers/leds/ncp5623c&pca9635pw: Fix nxstyle issues. new 8fdfb74 drivers: video: fix uninit

[incubator-nuttx] 01/02: drivers: video: fix uninitialized variables

2020-06-14 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8fdfb745d62957a4f3f1a53a19cf299798f3201e Author: Alin Jerpelea AuthorDate: Sun Jun 14 15:41:57 2020 +0200

[incubator-nuttx] 02/02: boards: arm: cxd56: initilize the video stream driver from the board

2020-06-14 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit c6c0214f9a0e29fe563060069979d0cebf474d95 Author: Alin Jerpelea AuthorDate: Thu Jun 11 16:03:33 2020 +0200

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo edited a comment on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643839824 > The driver itself is mostly useless without a corresponding user app to send the MBIM commands. However writing this type of program is very simple and the MB

[GitHub] [incubator-nuttx] patacongo commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643839824 > The driver itself is mostly useless without a corresponding user app to send the MBIM commands. However writing this type of program is very simple and the MBIM

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439881884 ## File path: net/Kconfig ## @@ -150,6 +150,11 @@ config NET_LOOPBACK_PKTSIZE CONFIG_NET_LOOPBACK_PKTSIZE is zero, meaning that

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on a change in pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439882128 ## File path: net/Kconfig ## @@ -150,6 +150,11 @@ config NET_LOOPBACK_PKTSIZE CONFIG_NET_LOOPBACK_PKTSIZE is zero, meaning that th

[GitHub] [incubator-nuttx] aport commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
aport commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643849359 > @aport Do you have a sample program for testing purposes? Unfortunately I don't have anything suitable for contribution at the moment. The software I was using to

[GitHub] [incubator-nuttx] acassis commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
acassis commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643850912 > > @aport Do you have a sample program for testing purposes? > > Unfortunately I don't have anything suitable for contribution at the moment. The software I was u

[GitHub] [incubator-nuttx] patacongo commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
patacongo commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643853093 > Do you have a sample program for testing purposes? @aport No problem. I am think of buying some hardware. It there a low-cost CDC-MBIM USB device in a pr

[GitHub] [incubator-nuttx] aport commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
aport commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643856540 The easiest thing to do is probably pick up a mini-pcie to USB board similar to this one https://www.amazon.com/Adapter-Express-Converter-Support-Wireless/dp/B07FJXNLLT/re

[GitHub] [incubator-nuttx] btashton commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
btashton commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643860506 @patacongo as @aport said most 4G modems are a safe bet, the exception would be Ublox which I know the Toby line does not support it. I have some Sierra Wireless

[GitHub] [incubator-nuttx] btashton commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

2020-06-14 Thread GitBox
btashton commented on pull request #1233: URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643861785 Also that STM32 NAK issue is terrible, I never found a good way around it with the USB IP they use. I think I just ended up doing some ugly polling hack and moved to a

[GitHub] [incubator-nuttx] anchao opened a new pull request #1234: arch/stackframe: fix heap buffer overflow

2020-06-14 Thread GitBox
anchao opened a new pull request #1234: URL: https://github.com/apache/incubator-nuttx/pull/1234 ## Summary arch/stackframe: fix heap buffer overflow ASAN trace: ... ==32087==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xf4502120 at pc 0x56673ca3 bp 0xff9b6a08 s

[GitHub] [incubator-nuttx] yamt opened a new issue #1235: nxstyle should not complain on _Exit

2020-06-14 Thread GitBox
yamt opened a new issue #1235: URL: https://github.com/apache/incubator-nuttx/issues/1235 e.g. % nxstyle stdlib.h stdlib.h:152:19: error: Mixed case identifier found This is an automated message from the

[GitHub] [incubator-nuttx] yamt opened a new pull request #1236: Move mallinfo from stdlib.h to malloc.h

2020-06-14 Thread GitBox
yamt opened a new pull request #1236: URL: https://github.com/apache/incubator-nuttx/pull/1236 mallinfo is meant to be API compatible with Linux, where it's provided by malloc.h. Make stdlib.h include malloc.h for now, until all users are updated. (I think the API actually or

[GitHub] [incubator-nuttx] yamt commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

2020-06-14 Thread GitBox
yamt commented on pull request #1236: URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643875012 See https://github.com/apache/incubator-nuttx/issues/1235 for the nxstyle complaint This is an automated m

[GitHub] [incubator-nuttx] patacongo commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

2020-06-14 Thread GitBox
patacongo commented on pull request #1236: URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643892648 If this is the right thing to do, the I would prefer that we do it right the first time. Let's please not put the kludge in stdlib.h. How would we ever know when to

[GitHub] [incubator-nuttx] yamt commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

2020-06-14 Thread GitBox
yamt commented on pull request #1236: URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643898159 @patacongo i did this way because nuttx and apps patches can't be merged atomically. This is an automa

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #293: Include malloc.h instead of stdlib.h for mallinfo()

2020-06-14 Thread GitBox
yamt opened a new pull request #293: URL: https://github.com/apache/incubator-nuttx-apps/pull/293 Adapt to the change in the main repo. mallinfo is meant to be API compatible with Linux, where it's provided by malloc.h. (I think the API actually originated with System V. I d

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #293: Include malloc.h instead of stdlib.h for mallinfo()

2020-06-14 Thread GitBox
yamt commented on pull request #293: URL: https://github.com/apache/incubator-nuttx-apps/pull/293#issuecomment-643922377 the associated PR in the main repo is https://github.com/apache/incubator-nuttx/pull/1236 This is an a

[GitHub] [incubator-nuttx] yamt commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

2020-06-14 Thread GitBox
yamt commented on pull request #1236: URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643923773 @patacongo i pushed a change to break the build as you suggested. This is an automated message from the Apa