Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2025-01-12 Thread via GitHub
xiaoxiang781216 merged PR #15126: URL: https://github.com/apache/nuttx/pull/15126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2025-01-11 Thread via GitHub
hujun260 commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1912348776 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/***

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2025-01-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1911881004 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2025-01-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1911881004 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2024-12-12 Thread via GitHub
anchao commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1883140265 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/*

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2024-12-12 Thread via GitHub
hujun260 commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1883121835 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/***

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2024-12-12 Thread via GitHub
xiaoxiang781216 commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1882609849 ## sched/pthread/pthread_mutex.c: ## @@ -92,7 +98,7 @@ static void pthread_mutex_remove(FAR struct pthread_mutex_s *mutex) FAR struct pthread_mutex_s *prev;

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2024-12-10 Thread via GitHub
hujun260 commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1879350773 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/***

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2024-12-10 Thread via GitHub
anchao commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1879215710 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/*

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2024-12-10 Thread via GitHub
anchao commented on code in PR #15126: URL: https://github.com/apache/nuttx/pull/15126#discussion_r1879216487 ## sched/pthread/pthread_mutex.c: ## @@ -38,6 +38,12 @@ #include "sched/sched.h" #include "pthread/pthread.h" +/*

Re: [PR] pthread: remove enter_critical_section in pthread_mutex [nuttx]

2024-12-10 Thread via GitHub
nuttxpr commented on PR #15126: URL: https://github.com/apache/nuttx/pull/15126#issuecomment-2533450387 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.