xiaoxiang781216 merged PR #10926:
URL: https://github.com/apache/nuttx/pull/10926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
acassis commented on PR #10926:
URL: https://github.com/apache/nuttx/pull/10926#issuecomment-1765007526
> > @xuxin930 do you have any idea?
>
> how about simply checking in CI whether both files have been modified?
whether the content matches or not, I think it still requires human
i
xuxin930 commented on PR #10926:
URL: https://github.com/apache/nuttx/pull/10926#issuecomment-1764710548
> @xuxin930 do you have any idea?
how about simply checking in CI whether both files have been modified?
whether the content matches or not, I think it still requires human
int
xiaoxiang781216 commented on PR #10926:
URL: https://github.com/apache/nuttx/pull/10926#issuecomment-1764516095
> @xiaoxiang781216 is it possible to include an automatic check to verify if
a PR modified a Makefile and didn't modify the CMakefile at same level? I think
we will need it avoid
acassis commented on PR #10926:
URL: https://github.com/apache/nuttx/pull/10926#issuecomment-1764502939
@xiaoxiang781216 is it possible to include an automatic check to verify if a
PR modified a Makefile and didn't modify the CMakefile at same level? I think
we will need it avoid mistakes.
acassis commented on code in PR #10926:
URL: https://github.com/apache/nuttx/pull/10926#discussion_r1360675808
##
drivers/math/Make.defs:
##
@@ -20,7 +20,7 @@
# Include math acceleration support
-ifneq ($(CONFIG_MATH_CORDIC)$(CONFIG_MATH_FFT),)
+ifneq ($(CONFIG_MATH_CORDIC)
