Re: [PR] fix some build error [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14925: URL: https://github.com/apache/nuttx/pull/14925#discussion_r1856190777 ## arch/arm/src/qemu/qemu_boot.c: ## @@ -36,6 +36,11 @@ # include #endif +#ifdef CONFIG_SCHED_INSTRUMENTATION +# include +# include Review Comment: ok -

Re: [PR] fix some build error [nuttx]

2024-11-25 Thread via GitHub
anchao merged PR #14925: URL: https://github.com/apache/nuttx/pull/14925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] fix some build error [nuttx]

2024-11-25 Thread via GitHub
hujun260 commented on code in PR #14925: URL: https://github.com/apache/nuttx/pull/14925#discussion_r1856182508 ## arch/arm/src/qemu/qemu_boot.c: ## @@ -36,6 +36,11 @@ # include #endif +#ifdef CONFIG_SCHED_INSTRUMENTATION +# include +# include Review Comment: The d

Re: [PR] fix some build error [nuttx]

2024-11-25 Thread via GitHub
anchao commented on code in PR #14925: URL: https://github.com/apache/nuttx/pull/14925#discussion_r1856143461 ## arch/arm/src/qemu/qemu_boot.c: ## @@ -36,6 +36,11 @@ # include #endif +#ifdef CONFIG_SCHED_INSTRUMENTATION +# include +# include Review Comment: ```sugg

Re: [PR] Fix some build error [nuttx]

2024-10-23 Thread via GitHub
lupyuen commented on PR #14458: URL: https://github.com/apache/nuttx/pull/14458#issuecomment-2433970008 Sorry @GUIDINGLI is sim-02 failing because of this PR? ```text Cmake in present: sim/matter Error: /github/workspace/sources/nuttx/build/include/libcxx/cmath:337:9: error: 'signbi

Re: [PR] Fix some build error [nuttx]

2024-10-23 Thread via GitHub
xiaoxiang781216 merged PR #14458: URL: https://github.com/apache/nuttx/pull/14458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Fix some build error [nuttx]

2024-10-22 Thread via GitHub
nuttxpr commented on PR #14458: URL: https://github.com/apache/nuttx/pull/14458#issuecomment-2429457545 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does not meet the NuttX requirements fully. Her