Re: [PR] endian: Make all endian related functions use the expicit type [nuttx]

xiaoxiang781216 closed pull request #10974: endian: Make all endian related functions use the expicit type URL: https://github.com/apache/nuttx/pull/10974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] endian: Make all endian related functions use the expicit type [nuttx]

acassis commented on PR #10974: URL: https://github.com/apache/nuttx/pull/10974#issuecomment-1771571456 @xiaoxiang781216 I marked it as draft because this commit is already integrated on my PR and as you said "let's keep it in my PR to make things simple". BTW I confirmed everything worked,

Re: [PR] endian: Make all endian related functions use the expicit type [nuttx]

xiaoxiang781216 commented on code in PR #10974: URL: https://github.com/apache/nuttx/pull/10974#discussion_r1364438276 ## include/sys/endian.h: ## @@ -52,15 +52,15 @@ /* Common byte swapping macros */ #ifdef CONFIG_HAVE_BUILTIN_BSWAP16 -# define __swap_uint16 __builtin_bswa

Re: [PR] endian: Make all endian related functions use the expicit type [nuttx]

pkarashchenko commented on code in PR #10974: URL: https://github.com/apache/nuttx/pull/10974#discussion_r1364343018 ## include/sys/endian.h: ## @@ -52,15 +52,15 @@ /* Common byte swapping macros */ #ifdef CONFIG_HAVE_BUILTIN_BSWAP16 -# define __swap_uint16 __builtin_bswap1