acassis merged PR #16466:
URL: https://github.com/apache/nuttx/pull/16466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
jerpelea commented on PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#issuecomment-2986823530
> > @acassis @cederom any remaining concerns?
>
> not fix my comment yet.
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, p
xiaoxiang781216 commented on PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#issuecomment-2980368396
> @acassis @cederom any remaining concerns?
not fix my comment yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
jlaitine commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2152247517
##
drivers/serial/serial.c:
##
@@ -901,12 +901,21 @@ static ssize_t uart_readv(FAR struct file *filep, FAR
struct uio *uio)
#ifdef CONFIG_SERIAL_IFLOWCONTROL_WATERMA
jerpelea commented on PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#issuecomment-2980021727
@acassis @cederom any remaining concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2140510794
##
drivers/serial/Kconfig-usart:
##
@@ -705,13 +723,15 @@ menu "USART9 Configuration"
config USART9_RXBUFSIZE
int "Receive buffer size"
+ defau
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2140510794
##
drivers/serial/Kconfig-usart:
##
@@ -705,13 +723,15 @@ menu "USART9 Configuration"
config USART9_RXBUFSIZE
int "Receive buffer size"
+ defau
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2140495844
##
include/nuttx/serial/serial.h:
##
@@ -123,14 +123,25 @@
/* This structure defines one serial I/O buffer.
* The serial infrastructure will initialize the '
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2140489324
##
drivers/serial/Kconfig-usart:
##
@@ -130,13 +132,15 @@ menu "USART1 Configuration"
config USART1_RXBUFSIZE
int "Receive buffer size"
+ defau
jerpelea commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2139921657
##
include/nuttx/serial/serial.h:
##
@@ -123,14 +123,25 @@
/* This structure defines one serial I/O buffer.
* The serial infrastructure will initialize the 'sem' fi
jerpelea commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2139921332
##
drivers/serial/serial.c:
##
@@ -901,6 +901,11 @@ static ssize_t uart_readv(FAR struct file *filep, FAR
struct uio *uio)
#ifdef CONFIG_SERIAL_IFLOWCONTROL_WATERMAR
jerpelea commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2139918418
##
drivers/serial/Kconfig-usart:
##
@@ -705,13 +723,15 @@ menu "USART9 Configuration"
config USART9_RXBUFSIZE
int "Receive buffer size"
+ default 128
jerpelea commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2139917822
##
include/nuttx/serial/serial.h:
##
@@ -123,14 +123,25 @@
/* This structure defines one serial I/O buffer.
* The serial infrastructure will initialize the 'sem' fi
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2136262355
##
drivers/serial/serial.c:
##
@@ -901,6 +901,11 @@ static ssize_t uart_readv(FAR struct file *filep, FAR
struct uio *uio)
#ifdef CONFIG_SERIAL_IFLOWCONTROL_W
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2135965309
##
include/nuttx/serial/serial.h:
##
@@ -123,14 +123,25 @@
/* This structure defines one serial I/O buffer.
* The serial infrastructure will initialize the '
jlaitine commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2131598395
##
drivers/serial/serial.c:
##
@@ -248,9 +249,26 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
nexthead = 0;
}
-
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2124313387
##
drivers/serial/serial.c:
##
@@ -248,9 +249,26 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
nexthead = 0;
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2124313387
##
drivers/serial/serial.c:
##
@@ -248,9 +249,26 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
nexthead = 0;
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2124309089
##
drivers/serial/serial.c:
##
@@ -248,9 +249,26 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
nexthead = 0;
acassis commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2124055054
##
drivers/serial/serial.c:
##
@@ -248,9 +249,26 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
nexthead = 0;
}
-
xiaoxiang781216 commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2121473225
##
drivers/serial/serial.c:
##
@@ -248,9 +249,26 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
nexthead = 0;
acassis commented on code in PR #16466:
URL: https://github.com/apache/nuttx/pull/16466#discussion_r2121299247
##
drivers/serial/serial.c:
##
@@ -1875,7 +1933,18 @@ static int uart_poll(FAR struct file *filep,
ndx = 0;
}
- if (ndx != dev->xmit.tail)
+
22 matches
Mail list logo
