Re: [PR] binfmt/loadable: move binary_s to stack to avoid access allocator [nuttx]

2024-12-12 Thread via GitHub
anchao commented on PR #15124: URL: https://github.com/apache/nuttx/pull/15124#issuecomment-2538752834 @fdcavalcanti please help to verify this PR: https://github.com/apache/nuttx/pull/15160 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] binfmt/loadable: move binary_s to stack to avoid access allocator [nuttx]

2024-12-12 Thread via GitHub
anchao commented on PR #15124: URL: https://github.com/apache/nuttx/pull/15124#issuecomment-2538640304 > We are having some CI failure on `esp32s3-devkit:adb` and `esp32s3-devkit:txtable` after this PR. It builds ok but Nuttx crashes during startup. > > @anchao any ideas? I'll take a

Re: [PR] binfmt/loadable: move binary_s to stack to avoid access allocator [nuttx]

2024-12-12 Thread via GitHub
fdcavalcanti commented on PR #15124: URL: https://github.com/apache/nuttx/pull/15124#issuecomment-2538612610 We are having some CI failure on `esp32s3-devkit:adb` and `esp32s3-devkit:txtable` after this PR. It builds ok but Nuttx crashes during startup. @anchao any ideas? -- This

Re: [PR] binfmt/loadable: move binary_s to stack to avoid access allocator [nuttx]

2024-12-11 Thread via GitHub
xiaoxiang781216 merged PR #15124: URL: https://github.com/apache/nuttx/pull/15124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] binfmt/loadable: move binary_s to stack to avoid access allocator [nuttx]

2024-12-11 Thread via GitHub
anchao commented on code in PR #15124: URL: https://github.com/apache/nuttx/pull/15124#discussion_r1881200619 ## binfmt/binfmt_exec.c: ## @@ -80,24 +80,30 @@ static int exec_internal(FAR const char *filename, FAR const posix_spawn_file_actions_t *action

Re: [PR] binfmt/loadable: move binary_s to stack to avoid access allocator [nuttx]

2024-12-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #15124: URL: https://github.com/apache/nuttx/pull/15124#discussion_r1879718924 ## binfmt/binfmt_exec.c: ## @@ -80,24 +80,30 @@ static int exec_internal(FAR const char *filename, FAR const posix_spawn_file_actions_

Re: [PR] binfmt/loadable: move binary_s to stack to avoid access allocator [nuttx]

2024-12-10 Thread via GitHub
nuttxpr commented on PR #15124: URL: https://github.com/apache/nuttx/pull/15124#issuecomment-2533381478 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.