rcsim commented on PR #15861:
URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2691629750
Hi @hartmannathan ,
Could you please review this PR so I can fix any issues, or can we proceed
to merge it?
Thanks
--
This is an automated message from the Apache Git Servi
LuchianMihai commented on PR #15861:
URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2670600498
Sure, won't argue, but #define BOARD_NGPIOINT 0 and no define at all is the
same thing. Preprocessor assigns 0 to the defines not given.
--
This is an automated message from the Ap
rcsim commented on PR #15861:
URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2670070887
> Hi! Regarding the use of
>
> ```c
> #if BOARD_NGPIOINT > 0
> #endif
> ```
>
> It's a personal preference, but, I suggest the to use something like
>
> ```c
rcsim commented on PR #15861:
URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2670061761
> Please remember to fill in the Commit Description. (Just copy from PR
Summary) Thanks :-)
>
> *
[6dcfae8](https://github.com/apache/nuttx/commit/6dcfae8b8606c88577c90409224a7d6e07e
LuchianMihai commented on PR #15861:
URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2667954267
Hi!
Regarding the use of
```c
#if BOARD_NGPIOINT > 0
#endif
```
It's a personal preference, but,
I suggest the to use something like
```c
#ifdef BOARD_NGPIOI
lupyuen commented on PR #15861:
URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2667241042
Please remember to fill in the Commit Description. (Just copy from PR
Summary) Thanks :-)
-
https://github.com/apache/nuttx/pull/15861/commits/6dcfae8b8606c88577c90409224a7d6e07e8af19
nuttxpr commented on PR #15861:
URL: https://github.com/apache/nuttx/pull/15861#issuecomment-2667227193
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The provided information is a good start but is missing
