Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10885: URL: https://github.com/apache/nuttx/pull/10885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1355420863 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1355036583 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1355026545 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354888374 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354880734 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354854525 ## boards/xtensa/esp32s3/esp32s3-eye/include/board.h: ## @@ -43,4 +43,10 @@ #define BOARD_NLEDS 1 +/* GPIO pins used by the GPIO Subsystem */ + +#defi

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on PR #10885: URL: https://github.com/apache/nuttx/pull/10885#issuecomment-1757538494 > please add commit message done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354851897 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,390 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354847635 ## boards/xtensa/esp32s3/esp32s3-eye/include/board.h: ## @@ -43,4 +43,10 @@ #define BOARD_NLEDS 1 +/* GPIO pins used by the GPIO Subsystem */ + +#defi

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354823843 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,390 @@ +/ + * boards

Re: [PR] ESP32S3-EYE GPIO: and button support [nuttx]

2023-10-10 Thread via GitHub
acassis commented on PR #10885: URL: https://github.com/apache/nuttx/pull/10885#issuecomment-1755708269 Hi @casaroli nice work! It is good see ESP32xx users contributing with NuttX mainline! Kudos! -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] ESP32S3-EYE GPIO: and button support [nuttx]

2023-10-10 Thread via GitHub
acassis commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1352804839 ## boards/xtensa/esp32s3/esp32s3-eye/include/board.h: ## @@ -43,4 +43,10 @@ #define BOARD_NLEDS 1 +/* GPIO pins used by the GPIO Subsystem */ + +#defin