Re: [PR] Change the memory of struct filelist to be malloced [nuttx]

2024-12-10 Thread via GitHub
guohao15 closed pull request #15028: Change the memory of struct filelist to be malloced URL: https://github.com/apache/nuttx/pull/15028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Change the memory of struct filelist to be malloced [nuttx]

2024-12-03 Thread via GitHub
anchao commented on PR #15028: URL: https://github.com/apache/nuttx/pull/15028#issuecomment-2516186387 @guohao15 Thanks for your verification. could we make the alloc version to a configurable feature? Individual developers can decide whether to use static or dynamic files, which would be

Re: [PR] Change the memory of struct filelist to be malloced [nuttx]

2024-12-03 Thread via GitHub
guohao15 commented on PR #15028: URL: https://github.com/apache/nuttx/pull/15028#issuecomment-2516101632 > @guohao15 could you please help to verify PR #1 ? which should resolve the fsync issue you mentioned @anchao this patch will also work, i have tested a similer patch, bu

Re: [PR] Change the memory of struct filelist to be malloced [nuttx]

2024-12-03 Thread via GitHub
anchao commented on PR #15028: URL: https://github.com/apache/nuttx/pull/15028#issuecomment-2513800784 @guohao15 could you please help to verify PR #1 ? which should resolve the fsync issue you mentioned -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Change the memory of struct filelist to be malloced [nuttx]

2024-12-02 Thread via GitHub
guohao15 commented on PR #15028: URL: https://github.com/apache/nuttx/pull/15028#issuecomment-2513783406 @anchao help review this patch :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe