Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 closed pull request #16283: wqueue: improve the robustness of the work URL: https://github.com/apache/nuttx/pull/16283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-05-02 Thread via GitHub
xiaoxiang781216 commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2848417920 But, this problem is fixed by https://github.com/apache/nuttx/pull/16231 too, so let's review and merge that patch instead. -- This is an automated message from the Apache Git S

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-04-30 Thread via GitHub
cederom commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2842450854 This is interesting change, but we need to make sure it won't break anything. Hardware tests are welcome and required as stated by @acassis. We have short break right now in PL, I w

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-04-30 Thread via GitHub
simbit18 commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2841154599 Hi @cederom at the moment this is a known bug of msys2 on GitHub #16010 (Nuttx issue). Workaround is to restart the msys2 CI Job, and it will succeed. If it doesn't, try again.

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-04-29 Thread via GitHub
cederom commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2840184543 Hmm this msys2 worked fine in previous PRs o_O -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-04-29 Thread via GitHub
acassis commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2839938147 Added tag requiring more tests. Core functions not well tested on real hardware are prone to break the system! -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-04-29 Thread via GitHub
simbit18 commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2838230150 @lupyuen @xiaoxiang781216 I think it is necessary to stop the msys2 job that went into error ``` 1806443548 [sig] make 39741 sig_send: error sending signal 11, pid 39741, pipe

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-04-28 Thread via GitHub
nuttxpr commented on PR #16283: URL: https://github.com/apache/nuttx/pull/16283#issuecomment-2837424604 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] wqueue: improve the robustness of the work [nuttx]

2025-04-28 Thread via GitHub
GUIDINGLI opened a new pull request, #16283: URL: https://github.com/apache/nuttx/pull/16283 ## Summary struct work_s { union { struct { struct dq_entry_s dq; /* Implements a double linked list */ clock_t qtime; /* Time work