Re: [PR] toywasm: ignore compile warnings [nuttx-apps]

2024-05-16 Thread via GitHub
yamt merged PR #2396: URL: https://github.com/apache/nuttx-apps/pull/2396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] toywasm: ignore compile warnings [nuttx-apps]

2024-05-16 Thread via GitHub
yamt commented on PR #2396: URL: https://github.com/apache/nuttx-apps/pull/2396#issuecomment-2116611334 > let's ignore the unrelated sim ltp test failure, @ttnie is working on it. the ci still built relevant configs (sim:toywasm and esp32s3-devkit:toywasm) successfully. let's merge th

Re: [PR] toywasm: ignore compile warnings [nuttx-apps]

2024-05-16 Thread via GitHub
xiaoxiang781216 commented on PR #2396: URL: https://github.com/apache/nuttx-apps/pull/2396#issuecomment-2116600704 let's ignore the unrelated sim ltp test failure, @ttnie is working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] toywasm: ignore compile warnings [nuttx-apps]

2024-05-16 Thread via GitHub
yamt commented on PR #2396: URL: https://github.com/apache/nuttx-apps/pull/2396#issuecomment-2115258535 i guess you can mirror this https://github.com/yamt/toywasm/blob/master/cmake/ToywasmConfig.cmake#L298-L302 and leave a reference in a comment so that it can be updated when/if it was

[PR] toywasm: ignore compile warnings [nuttx-apps]

2024-05-16 Thread via GitHub
Gary-Hobson opened a new pull request, #2396: URL: https://github.com/apache/nuttx-apps/pull/2396 ## Summary Will cause compilation warning if NDEBUG is defined We can't modify the code of the external library, so let's ignore it ## Impact ## Testing -- This is an