Re: [PR] tools: Add cmux command line tool [nuttx]

2025-02-20 Thread via GitHub
xiaoxiang781216 closed pull request #14823: tools: Add cmux command line tool URL: https://github.com/apache/nuttx/pull/14823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] tools: Add cmux command line tool [nuttx]

2025-02-12 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2654560156 @Gary-Hobson any news about the CMUX driver? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-25 Thread via GitHub
acassis commented on code in PR #14823: URL: https://github.com/apache/nuttx/pull/14823#discussion_r1856457862 ## tools/cmux.c: ## @@ -0,0 +1,434 @@ +/ + * tools/cmux.c + * + * Licensed to the Apache Sof

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-24 Thread via GitHub
Gary-Hobson commented on code in PR #14823: URL: https://github.com/apache/nuttx/pull/14823#discussion_r1855826557 ## tools/cmux.c: ## @@ -0,0 +1,434 @@ +/ + * tools/cmux.c + * + * Licensed to the Apache

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-22 Thread via GitHub
acassis commented on code in PR #14823: URL: https://github.com/apache/nuttx/pull/14823#discussion_r1854456540 ## tools/cmux.c: ## @@ -0,0 +1,434 @@ +/ + * tools/cmux.c + * + * Licensed to the Apache Sof

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-21 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2491406840 @xiaoxiang781216 please include an explanation in the source code or a Documentation/ about this script, to avoid having another script that nobody knows why it is inside nuttx -- This

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
Gary-Hobson commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483504257 The nuttx kernel cmux driver support has been completed, but the internal review has not been completed (need to support sending and receiving data in interrupts). Maybe I can

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483356264 > > Because you need this tool to change host serial port into mux mode. > > Why? Are you using the modem with SIM? We use cmux for debugging purpose to have the multi

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483276779 > > > Please could you add a brief explanation what is cmux and what it is for in the PR description and commit log? Thanks. > > > > > > Update, you can learn the concep

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483312492 @xiaoxiang781216 maybe you can include a verbose explanation inside this C file (just before "Included Files") explaining the purpose of this file inside nuttx/tools. This way it could he

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483303781 > > > > Please could you add a brief explanation what is cmux and what it is for in the PR description and commit log? Thanks. > > > > > > > > > Update, you can learn the concep

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483177339 > > @xiaoxiang781216 I think this application depends on CMUX support in the NuttX kernel, is there a CMUX driver coming to NuttX kernel? > > Yes, it will come in the next patch.

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483126761 @xiaoxiang781216 there is an issue already opened question it: https://github.com/apache/nuttx/issues/7153 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483124946 @xiaoxiang781216 I think /me and @hartmannathan are asking some question: why to include a program that is supported only for Linux into NuttX? The documentation you provided is for Linux

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-18 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2483113657 > > Please could you add a brief explanation what is cmux and what it is for in the PR description and commit log? Thanks. > > Update, you can learn the concept and spec from: http

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2482037422 > @xiaoxiang781216 I was thinking this was CMUX support for NuttX, but seems like it has other purpose, probably to run on Linux side. Could you please explain the idea of this to

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2482038344 > Please could you add a brief explanation what is cmux and what it is for in the PR description and commit log? Thanks. Update, you can learn the concept and spec from:

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
xiaoxiang781216 commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2481261198 > @xiaoxiang781216 I think this application depends on CMUX support in the NuttX kernel, is there a CMUX driver coming to NuttX kernel? Yes, it will come in the

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-17 Thread via GitHub
acassis commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2481192725 @xiaoxiang781216 I think this application depends on CMUX support in the NuttX kernel, is there a CMUX driver coming to NuttX kernel? -- This is an automated message from the Apache Gi

Re: [PR] tools: Add cmux command line tool [nuttx]

2024-11-16 Thread via GitHub
nuttxpr commented on PR #14823: URL: https://github.com/apache/nuttx/pull/14823#issuecomment-2480636602 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] tools: Add cmux command line tool [nuttx]

2024-11-16 Thread via GitHub
xiaoxiang781216 opened a new pull request, #14823: URL: https://github.com/apache/nuttx/pull/14823 ## Summary Usage: ./nuttx/tools/cmux -d -n -b ## Impact new host tool ## Testing ci -- This is an automated message from the Apache Git Service.