xiaoxiang781216 merged PR #15854:
URL: https://github.com/apache/nuttx/pull/15854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
no1wudi commented on PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2667260026
> Does it solve an issue? Are you having problems with pipx?
Yes, each app installed by pipx like tools is in a isolated venv,
pkg_resources can't fetch the info if not switch to it
fdcavalcanti commented on PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2666305395
Please provide test with `esptool < 4.8.0`.
If possible, also test with older Python i.e.` < 3.8`
--
This is an automated message from the Apache Git Service.
To respond to the m
fdcavalcanti commented on code in PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#discussion_r1960134390
##
tools/espressif/check_esptool.py:
##
@@ -92,4 +78,4 @@ def check_version(min_esptool_version: str) -> int:
if __name__ == "__main__":
parser = parser.pa
fdcavalcanti commented on PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2666277174
Does it solve an issue? Are you having problems with pipx?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
LuchianMihai commented on code in PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#discussion_r1959996001
##
tools/espressif/check_esptool.py:
##
@@ -56,28 +46,24 @@ def parse_version(version_string) -> list:
def check_version(min_esptool_version: str) -> int:
Re
LuchianMihai commented on code in PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#discussion_r1959996001
##
tools/espressif/check_esptool.py:
##
@@ -56,28 +46,24 @@ def parse_version(version_string) -> list:
def check_version(min_esptool_version: str) -> int:
Re
tmedicci commented on PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2665647703
@eren-terzioglu and @fdcavalcanti , can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
nuttxpr commented on PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#issuecomment-2664752693
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This PR appears to meet the NuttX requirements, althoug
no1wudi opened a new pull request, #15854:
URL: https://github.com/apache/nuttx/pull/15854
## Summary
- Replace version checking logic using pkg_resources and importlib with a
subprocess call to `esptool.py version`
- This change enhances compatibility with esptool installed via pipx a
10 matches
Mail list logo
