Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-08 Thread via GitHub
xiaoxiang781216 merged PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
jlaitine commented on PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#issuecomment-2858861608 I just realized that this may cause unwanted side effects since there was an existing bug in the test; it doesn't unregister the signal action handlers after the test is done.

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
jlaitine commented on PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#issuecomment-2858460518 This fails on ostest, which is expected due to the bug that this change is supposed to expose. Need to re-trigger this after https://github.com/apache/nuttx/pull/16334 is prop

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
xiaoxiang781216 commented on code in PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#discussion_r2077487365 ## testing/ostest/signest.c: ## @@ -52,6 +52,8 @@ * Private Data / +static

Re: [PR] testing/ostest: add checking of signal deliver thread [nuttx-apps]

2025-05-07 Thread via GitHub
jlaitine commented on PR #3070: URL: https://github.com/apache/nuttx-apps/pull/3070#issuecomment-2858122594 > please add a commit message Oops, thanks for reminding, done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub