Re: [PR] system/nxplayer/nxrecorder: move apb buffer instance to stack [nuttx-apps]

2025-03-25 Thread via GitHub
xiaoxiang781216 merged PR #3023: URL: https://github.com/apache/nuttx-apps/pull/3023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] system/nxplayer/nxrecorder: move apb buffer instance to stack [nuttx-apps]

2025-03-25 Thread via GitHub
anchao commented on code in PR #3023: URL: https://github.com/apache/nuttx-apps/pull/3023#discussion_r2012122191 ## system/nxplayer/nxplayer.c: ## @@ -819,23 +818,11 @@ static FAR void *nxplayer_playthread(pthread_addr_t pvarg) /* Create array of pointers to buffers */ -

Re: [PR] system/nxplayer/nxrecorder: move apb buffer instance to stack [nuttx-apps]

2025-03-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #3023: URL: https://github.com/apache/nuttx-apps/pull/3023#discussion_r1986710953 ## system/nxrecorder/nxrecorder.c: ## @@ -551,23 +550,11 @@ static FAR void *nxrecorder_recordthread(pthread_addr_t pvarg) /* Create array of pointers

Re: [PR] system/nxplayer/nxrecorder: move apb buffer instance to stack [nuttx-apps]

2025-03-09 Thread via GitHub
nuttxpr commented on PR #3023: URL: https://github.com/apache/nuttx-apps/pull/3023#issuecomment-2709267869 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requiremen

[PR] system/nxplayer/nxrecorder: move apb buffer instance to stack [nuttx-apps]

2025-03-09 Thread via GitHub
anchao opened a new pull request, #3023: URL: https://github.com/apache/nuttx-apps/pull/3023 ## Summary system/nxplayer/nxrecorder: move apb buffer instance to stack move apb buffer instance to stack to avoid alloc buffer from heap Signed-off-by: chao an ## Im