xiaoxiang781216 commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2765004093
> Syslog configuration is an choice option, it's impossible to set
`CONFIG_ARCH_SYSLOG=n` and `CONFIG_SYSLOG=n`. Empty functions are needed
because the alternative approach (which
raiden00pl commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2764492192
Syslog configuration is an chose option, it's impossible to set
`CONFIG_ARCH_SYSLOG=n` and `CONFIG_SYSLOG=n`. Empty functions are needed
because the alternative approach (which are emp
xiaoxiang781216 commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2764478984
> `lib_syslog_none.c` can't be compiled when `CONFIG_ARCH_SYSLOG=y`.
you can check `CONFIG_ARCH_SYSLOG=y` too, bu why need add
CONFIG_SYSLOG_NONE? it's strange that we have
raiden00pl commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2764418857
`lib_syslog_none.c` can't be compiled when `CONFIG_ARCH_SYSLOG=y".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiaoxiang781216 commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2764412852
@raiden00pl why make an empty syslog/vsyslog when CONFIG_SYSLOG=n, but
instead add a new CONFIG_SYSLOG_NONE, like this:
```
if(CONFIG_SYSLOG)
target_sources(c PRIVATE li
lupyuen merged PR #16090:
URL: https://github.com/apache/nuttx/pull/16090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
acassis commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2761735373
@TimJTi please take a look, could be useful for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
raiden00pl commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2760862734
@lupyuen good idea :) done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lupyuen commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2760849095
Sorry @raiden00pl: Maybe you can rebase with master to fix sim:citest? So I
can stop clicking "Restart Job". Thanks :-)
--
This is an automated message from the Apache Git Service.
To r
lupyuen commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2760814499
Sorry I had to restart the CI Jobs a few times, because sim:citest kept
failing:
- https://github.com/apache/nuttx/issues/16088
--
This is an automated message from the Apache Git Se
nuttxpr commented on PR #16090:
URL: https://github.com/apache/nuttx/pull/16090#issuecomment-2760691855
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to meet the NuttX requirements, al
raiden00pl opened a new pull request, #16090:
URL: https://github.com/apache/nuttx/pull/16090
## Summary
Add an option to completely disable syslog() and replace it with an empty
functions. This option can be useful for small systems when we don't have any
logging support, but compil
12 matches
Mail list logo
