Re: [PR] support sorting symbol tables by name [nuttx]

2024-01-04 Thread via GitHub
xiaoxiang781216 merged PR #11448: URL: https://github.com/apache/nuttx/pull/11448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] support sorting symbol tables by name [nuttx]

2024-01-03 Thread via GitHub
Gary-Hobson commented on code in PR #11448: URL: https://github.com/apache/nuttx/pull/11448#discussion_r1440600860 ## libs/libc/symtab/symtab_findbyvalue.c: ## @@ -92,7 +92,7 @@ symtab_findbyvalue(FAR const struct symtab_s *symtab, } else if (symtab[mid].sym_valu

Re: [PR] support sorting symbol tables by name [nuttx]

2024-01-03 Thread via GitHub
Gary-Hobson commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1875577028 > Include more info in the git commit message done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] support sorting symbol tables by name [nuttx]

2024-01-03 Thread via GitHub
Gary-Hobson commented on code in PR #11448: URL: https://github.com/apache/nuttx/pull/11448#discussion_r1440600860 ## libs/libc/symtab/symtab_findbyvalue.c: ## @@ -92,7 +92,7 @@ symtab_findbyvalue(FAR const struct symtab_s *symtab, } else if (symtab[mid].sym_valu

Re: [PR] support sorting symbol tables by name [nuttx]

2024-01-02 Thread via GitHub
Gary-Hobson commented on code in PR #11448: URL: https://github.com/apache/nuttx/pull/11448#discussion_r1439601652 ## libs/libc/symtab/symtab_findbyvalue.c: ## @@ -92,7 +92,7 @@ symtab_findbyvalue(FAR const struct symtab_s *symtab, } else if (symtab[mid].sym_valu

Re: [PR] support sorting symbol tables by name [nuttx]

2024-01-02 Thread via GitHub
hartmannathan commented on code in PR #11448: URL: https://github.com/apache/nuttx/pull/11448#discussion_r1439479722 ## libs/libc/symtab/symtab_findbyvalue.c: ## @@ -92,7 +92,7 @@ symtab_findbyvalue(FAR const struct symtab_s *symtab, } else if (symtab[mid].sym_va

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-31 Thread via GitHub
xiaoxiang781216 commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1872974399 > > > > > why do you want to sort it? why do you want to make it optional? > > > > > > > > > > > > There are two types of sorts: sorted by symbol name or sorted by symbo

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-30 Thread via GitHub
yamt commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1872680677 > > > > why do you want to sort it? why do you want to make it optional? > > > > > > > > > There are two types of sorts: sorted by symbol name or sorted by symbol value(address). B

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1872656913 > > > why do you want to sort it? why do you want to make it optional? > > > > > > There are two types of sorts: sorted by symbol name or sorted by symbol value(address)

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-30 Thread via GitHub
yamt commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1872503676 > > why do you want to sort it? why do you want to make it optional? > > There are two types of sorts: sorted by symbol name or sorted by symbol value(address). Before the change, the

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-28 Thread via GitHub
pkarashchenko commented on code in PR #11448: URL: https://github.com/apache/nuttx/pull/11448#discussion_r1437915629 ## libs/libc/symtab/symtab_findbyvalue.c: ## @@ -92,7 +92,7 @@ symtab_findbyvalue(FAR const struct symtab_s *symtab, } else if (symtab[mid].sym_va

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-28 Thread via GitHub
acassis commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1871293949 @Gary-Hobson please include the summary information in the git commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-26 Thread via GitHub
xiaoxiang781216 commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1869913445 > why do you want to sort it? why do you want to make it optional? There are two types of sorts: sorted by symbol name or sorted by symbol value(address). Before the chan

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-25 Thread via GitHub
yamt commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1869294836 why do you want to sort it? why do you want to make it optional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #11448: URL: https://github.com/apache/nuttx/pull/11448#discussion_r1436247261 ## libs/libc/symtab/symtab_findbyvalue.c: ## @@ -92,7 +92,7 @@ symtab_findbyvalue(FAR const struct symtab_s *symtab, } else if (symtab[mid].sym_

[PR] support sorting symbol tables by name [nuttx]

2023-12-25 Thread via GitHub
Gary-Hobson opened a new pull request, #11448: URL: https://github.com/apache/nuttx/pull/11448 ## Summary 1. support sorting symbol tables by name 2. libs: fix the problem that the address obtained in thumb mode cannot be executed. ## Impact ## Testing -- This is a