Re: [PR] stream_getc: use lib_stream_eof instead of EOF [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14924: URL: https://github.com/apache/nuttx/pull/14924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] stream_getc: use lib_stream_eof instead of EOF [nuttx]

2024-11-24 Thread via GitHub
nuttxpr commented on PR #14924: URL: https://github.com/apache/nuttx/pull/14924#issuecomment-2496951307 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does *not* fully meet the NuttX requirements, t

[PR] stream_getc: use lib_stream_eof instead of EOF [nuttx]

2024-11-24 Thread via GitHub
jasonbu opened a new pull request, #14924: URL: https://github.com/apache/nuttx/pull/14924 ## Summary EOF is libc definition, not the stream definition, we should use errno to handle the stream getc EOF case. As we have lots of backend to support stream, which necessary to get errno.