xiaoxiang781216 merged PR #11458:
URL: https://github.com/apache/nuttx/pull/11458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438664717
##
arch/sim/src/sim/sim_checkhostfstypes.c:
##
@@ -0,0 +1,113 @@
+/
+ * arch/sim/src/sim/sim_ch
yamt commented on PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1872570889
> @yamt please sqaush your patch into one.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438664060
##
arch/sim/src/sim/sim_checkhostfstypes.c:
##
@@ -0,0 +1,113 @@
+/
+ * arch/sim/src/sim/sim_ch
xiaoxiang781216 commented on PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1872563665
@yamt please sqaush your patch into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoxiang781216 commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438652938
##
arch/sim/src/sim/sim_checkhostfstypes.c:
##
@@ -0,0 +1,113 @@
+/
+ * arch/sim/src
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438553341
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_che
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438553059
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_che
xiaoxiang781216 commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438542972
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/
xiaoxiang781216 commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438542649
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438538394
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_che
xiaoxiang781216 commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438531464
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438495825
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_che
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438495411
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_che
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438494893
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_che
xiaoxiang781216 commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438470065
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/
yamt commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1437794652
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_che
yamt commented on PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1871359913
> > > @yamt please include a git log message explaining more about it.
> >
> >
> > what kind of extra info do you want to see?
>
> Just why you decided to include the asserti
acassis commented on code in PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#discussion_r1437747057
##
arch/sim/src/sim/sim_checknuttxtypes.c:
##
@@ -0,0 +1,100 @@
+/
+ * arch/sim/src/sim/sim_
acassis commented on PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1871289545
> > @yamt please include a git log message explaining more about it.
>
> what kind of extra info do you want to see?
Just why you decided to include the assertions. Was it fai
yamt commented on PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1870800883
> @yamt please include a git log message explaining more about it.
what kind of extra info do you want to see?
--
This is an automated message from the Apache Git Service.
To
acassis commented on PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1870563788
@yamt please include a git log message explaining more about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
yamt commented on PR #11458:
URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1870297510
for some reasons it doesn't find config.h in case of cmake.
where is the cmake equivalent of
https://github.com/apache/nuttx/blob/e1a1f7b5f4fc90f0d4708a9caab9e3bc00b5b7a9/arch/sim/src/
yamt opened a new pull request, #11458:
URL: https://github.com/apache/nuttx/pull/11458
## Summary
sim: add assertions on hostfs copy of structures
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
24 matches
Mail list logo
