Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-13 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2876447320 > how can I add my milkv_duos to the CI? It should be nice if we could run this test automatically without calling the nuttxpr bot manually @acassis Hmmm are we thinking of triggeri

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-12 Thread via GitHub
xiaoxiang781216 merged PR #16343: URL: https://github.com/apache/nuttx/pull/16343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-11 Thread via GitHub
Fix-Point commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2870721999 > @Fix-Point please fix: > > ``` > /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/clock.h:601: leapyear ==> leap year > ``` Done. -- This is an automated messa

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-11 Thread via GitHub
xiaoxiang781216 commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2870687790 @Fix-Point please fix: ``` /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/clock.h:601: leapyear ==> leap year ``` -- This is an automated message from the Apache Gi

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-11 Thread via GitHub
acassis commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2870205560 @lupyuen how can I add my milkv_duos to the CI? It should be nice if we could run this test automatically without calling the nuttxpr bot manually -- This is an automated message from t

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-10 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2869529483 @Fix-Point: Please fix the Merge Conflict. Thanks! - sched/wqueue/kwork_queue.c -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-10 Thread via GitHub
nuttxpr commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2868679890 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (milkv_duos:nsh) https://gitlab.co

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-10 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2868677522 @nuttxpr test milkv_duos:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-10 Thread via GitHub
nuttxpr commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2868677444 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (avaota-a1:nsh) https://gitlab.com

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-10 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2868674761 @nuttxpr test avaota-a1:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
xiaoxiang781216 commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2868350490 please fix the spell error: https://github.com/apache/nuttx/actions/runs/14928688518/job/41939333096?pr=16343 -- This is an automated message from the Apache Git Service. To

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
Fix-Point commented on code in PR #16343: URL: https://github.com/apache/nuttx/pull/16343#discussion_r2081541549 ## sched/timer/timer_settime.c: ## @@ -331,6 +331,16 @@ int timer_settime(timer_t timerid, int flags, timer->pt_expected = clock_systime_ticks() + delay;

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865848559 @nuttxpr test milkv_duos:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
anchao commented on code in PR #16343: URL: https://github.com/apache/nuttx/pull/16343#discussion_r2081507422 ## sched/timer/timer_settime.c: ## @@ -331,6 +331,16 @@ int timer_settime(timer_t timerid, int flags, timer->pt_expected = clock_systime_ticks() + delay; }

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865830924 @nuttxpr test avaota-a1:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
nuttxpr commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865859449 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (milkv_duos:nsh) https://gitlab.co

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
nuttxpr commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865848159 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (avaota-a1:nsh) https://gitlab.com

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865606012 @nuttxpr test milkv_duos:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865646471 Sorry @Fix-Point could you check why this PR is crashing OSTest on Arm64 Avaota-A1 T527 and RISC-V SG2000? Thanks! ### Arm64 Avaota-A1 SBC (Allwinner T527) https://gitlab.com

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
nuttxpr commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865639370 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test **FAILED** (milkv_duos:nsh) https://gitlab.co

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
nuttxpr commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865596292 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test **FAILED** (avaota-a1:nsh) https://gitlab.com

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865564983 @nuttxpr test avaota-a1:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-09 Thread via GitHub
lupyuen commented on PR #16343: URL: https://github.com/apache/nuttx/pull/16343#issuecomment-2865562692 Hmmm why is `codespell` failing? - https://github.com/apache/nuttx/actions/runs/14923870688/job/41925150697#step:3:80 ``` include/nuttx/clock.h:579: leapyear ==> leap year ```

[PR] sched/wdog: watchdog timer improvements. [nuttx]

2025-05-08 Thread via GitHub
Fix-Point opened a new pull request, #16343: URL: https://github.com/apache/nuttx/pull/16343 ## Summary - 1. Simplified the `nxsched_timer_process` function to enhance readability and maintainability. - 2. Improved absolute timer accuracy by moving the `tick++` operation to the re