Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346261062 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = heapsize + M

Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346259547 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = hea

Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
pussuw commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346185129 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = heapsize + M

Re: [PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
xiaoxiang781216 commented on code in PR #10856: URL: https://github.com/apache/nuttx/pull/10856#discussion_r1346150803 ## arch/risc-v/src/common/riscv_addrenv.c: ## @@ -421,6 +422,12 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, heapsize = hea

[PR] risc-v/addrenv: Two minor fixes for addrenv handling [nuttx]

2023-10-04 Thread via GitHub
pussuw opened a new pull request, #10856: URL: https://github.com/apache/nuttx/pull/10856 ## Summary Fixes two bugs in risc-v address environment handling. - Not enough heap to allocate properly aligned TLS stack - Mapping kernel page tables with user page table flags is not a good i