Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-05 Thread via GitHub
yamt commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2771500740 > > > On AVR architecture, the compiler apparently sometimes truncates NSEC_PER_TICK to 16bit value > > > > > > can you please explain why? if it's a compiler bug, please consider

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-04 Thread via GitHub
acassis merged PR #16103: URL: https://github.com/apache/nuttx/pull/16103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-04 Thread via GitHub
lupyuen commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2771612253 @nuttxpr test avaota-a1:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-03 Thread via GitHub
raiden00pl commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2774730585 @yamt please ask on the mailing list, I'm not the author of this commit :) but from what I see, using `long` is the simplest solution and consistent with the rest of the definitions in

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-02 Thread via GitHub
yamt commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2774146901 @raiden00pl i'm still curious why you prefer long over eg. int32_t. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-02 Thread via GitHub
nuttxpr commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2771634942 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (milkv_duos:nsh) https://gitlab.co

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-02 Thread via GitHub
nuttxpr commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2771624084 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+15779&type=issues) Build and Test Successful (avaota-a1:nsh) https://gitlab.com

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-02 Thread via GitHub
lupyuen commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2771624481 @nuttxpr test milkv_duos:nsh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-01 Thread via GitHub
xiaoxiang781216 commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2771449707 > > On AVR architecture, the compiler apparently sometimes truncates NSEC_PER_TICK to 16bit value > > can you please explain why? if it's a compiler bug, please consider to

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-01 Thread via GitHub
yamt commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2771315650 > On AVR architecture, the compiler apparently sometimes truncates NSEC_PER_TICK to 16bit value can you please explain why? if it's a compiler bug, please consider to put a workarou

Re: [PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-01 Thread via GitHub
nuttxpr commented on PR #16103: URL: https://github.com/apache/nuttx/pull/16103#issuecomment-2769824652 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR likely meets the basic NuttX requirements,

[PR] nuttx/clock: make NSEC_PER_USEC and others long [nuttx]

2025-04-01 Thread via GitHub
raiden00pl opened a new pull request, #16103: URL: https://github.com/apache/nuttx/pull/16103 ## Summary Patch from mailing list https://lists.apache.org/thread/xzor3tjy9jozlmox82frd27v969b37l4 On AVR architecture, the compiler apparently sometimes truncates NSEC_PER_TICK to 1