Re: [PR] note: Remove enter_critical_section from the sched_note module [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 merged PR #14926: URL: https://github.com/apache/nuttx/pull/14926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] note: Remove enter_critical_section from the sched_note module [nuttx]

2024-11-25 Thread via GitHub
xiaoxiang781216 commented on code in PR #14926: URL: https://github.com/apache/nuttx/pull/14926#discussion_r1856876186 ## drivers/note/noterpmsg_driver.c: ## @@ -49,6 +50,7 @@ struct noterpmsg_driver_s uint8_t buffer[CONFIG_DRIVERS_NOTERPMSG_BUFSIZE]; struct

Re: [PR] note: Remove enter_critical_section from the sched_note module [nuttx]

2024-11-25 Thread via GitHub
nuttxpr commented on PR #14926: URL: https://github.com/apache/nuttx/pull/14926#issuecomment-2497216797 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] note: Remove enter_critical_section from the sched_note module [nuttx]

2024-11-25 Thread via GitHub
hujun260 opened a new pull request, #14926: URL: https://github.com/apache/nuttx/pull/14926 ## Summary note: Remove enter_critical_section from the sched_note module to avoid recursive calls. ## Impact note ## Testing ci ostest -- This is an automate