cederom merged PR #15820:
URL: https://github.com/apache/nuttx/pull/15820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
pussuw commented on PR #15820:
URL: https://github.com/apache/nuttx/pull/15820#issuecomment-2657927666
> Sorry, we need just the `git commit -s`, please update :-)
Ah, my bad. I never sign my commits so I will keep forgetting to do so.
Maybe a git commit hook is in order :P
--
This
cederom commented on PR #15820:
URL: https://github.com/apache/nuttx/pull/15820#issuecomment-2657213758
Thanks for all information @pussuw :-) Please remember to use `git commit
-s` we will require that soon as mandatory :-)
--
This is an automated message from the Apache Git Service.
To
cederom commented on code in PR #15820:
URL: https://github.com/apache/nuttx/pull/15820#discussion_r1953538035
##
arch/risc-v/src/mpfs/mpfs_irq.c:
##
@@ -125,9 +125,7 @@ void up_disable_irq(int irq)
PANIC();
}
- /* Disable the irq on all harts, we don'
pussuw commented on PR #15820:
URL: https://github.com/apache/nuttx/pull/15820#issuecomment-2655874391
> Thank you @pussuw, some questions below :-)
>
> * Is it safe to enable this irq on all harts? Can you provide a
reference to specification or advise that this is common practic
cederom commented on PR #15820:
URL: https://github.com/apache/nuttx/pull/15820#issuecomment-2655084050
Thank you @pussuw, some questions below :-)
* Is it safe to enable this irq on all harts? Can you provide a reference to
specification or advise that this is common practice?
* Would
pussuw opened a new pull request, #15820:
URL: https://github.com/apache/nuttx/pull/15820
## Summary
Enable interrupts on all cores, when enabling an external interrupt source.
Instead of enabling an interrupt on the calling hart, enable it on every
hart. This should balance th
nuttxpr commented on PR #15820:
URL: https://github.com/apache/nuttx/pull/15820#issuecomment-2653009509
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR summary does not fully meet the NuttX requi
