xiaoxiang781216 commented on code in PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#discussion_r1845720916
##
mm/iob/iob_alloc.c:
##
@@ -97,10 +97,82 @@ static FAR struct iob_s *iob_alloc_committed(void)
iob->io_pktlen = 0;/* Total length of the packet */
acassis merged PR #14764:
URL: https://github.com/apache/nuttx/pull/14764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
hujun260 commented on PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#issuecomment-2476173063
> > reason: We decouple semcount from business logic by using an independent
counting variable, which allows us to remove critical sections in many cases.
>
> if it's so common, i
yamt commented on PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#issuecomment-2475875902
> reason: We decouple semcount from business logic by using an independent
counting variable, which allows us to remove critical sections in many cases.
if it's so common, i feel it's
pussuw commented on code in PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#discussion_r1840778805
##
include/nuttx/mm/iob.h:
##
@@ -31,6 +31,7 @@
#include
#include
+#include
Review Comment:
The header needs nothing from nuttx/spinlock, please move the incl
pussuw commented on code in PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#discussion_r1840788819
##
mm/iob/iob_alloc_qentry.c:
##
@@ -101,21 +137,22 @@ static FAR struct iob_qentry_s *iob_allocwait_qentry(void)
* re-enabled while we are waiting for I/O buffers t
pussuw commented on code in PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#discussion_r1840783512
##
mm/iob/iob_alloc.c:
##
@@ -132,28 +207,31 @@ static FAR struct iob_s *iob_allocwait(bool throttled,
unsigned int timeout)
* we are waiting for I/O buffers to bec
pussuw commented on code in PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#discussion_r1840778805
##
include/nuttx/mm/iob.h:
##
@@ -31,6 +31,7 @@
#include
#include
+#include
Review Comment:
The header needs nothing from nuttx/spinlock, please move the incl
hujun260 opened a new pull request, #14764:
URL: https://github.com/apache/nuttx/pull/14764
## Summary
reason:
We decouple semcount from business logic
by using an independent counting variable,
which allows us to remove critical sections in many cases.
## Impact
mm/iob
nuttxpr commented on PR #14764:
URL: https://github.com/apache/nuttx/pull/14764#issuecomment-2473593056
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This PR appears to **partially** meet the NuttX require
10 matches
Mail list logo
