Re: [PR] improve libc/stream subsystem [nuttx]

Donny9 merged PR #16496: URL: https://github.com/apache/nuttx/pull/16496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on PR #16496: URL: https://github.com/apache/nuttx/pull/16496#issuecomment-2977719083 > @xiaoxiang781216 is it possible to add some testing to new fileinstream and fileoutstream ? fileinstream is used in coredump, which will upstream later. -- This is an a

Re: [PR] improve libc/stream subsystem [nuttx]

acassis commented on PR #16496: URL: https://github.com/apache/nuttx/pull/16496#issuecomment-2977700237 @xiaoxiang781216 is it possible to add some testing to new fileinstream and fileoutstream ? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] improve libc/stream subsystem [nuttx]

linguini1 commented on PR #16496: URL: https://github.com/apache/nuttx/pull/16496#issuecomment-2977386024 I feel like this should have testing beyond just that it's able to compile in CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2149904728 ## drivers/note/notestream_driver.c: ## @@ -131,15 +130,15 @@ int notefile_register(FAR const char *filename) #endif notefile->driver.stream = ¬efile->fil

Re: [PR] improve libc/stream subsystem [nuttx]

Donny9 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2148924155 ## drivers/note/notestream_driver.c: ## @@ -131,15 +130,15 @@ int notefile_register(FAR const char *filename) #endif notefile->driver.stream = ¬efile->filestream.c

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2147492707 ## drivers/note/notestream_driver.c: ## @@ -131,15 +130,15 @@ int notefile_register(FAR const char *filename) #endif notefile->driver.stream = ¬efile->fil

Re: [PR] improve libc/stream subsystem [nuttx]

Donny9 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2147004348 ## drivers/note/notestream_driver.c: ## @@ -131,15 +130,15 @@ int notefile_register(FAR const char *filename) #endif notefile->driver.stream = ¬efile->filestream.c

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2146796769 ## drivers/note/notestream_driver.c: ## @@ -131,15 +130,15 @@ int notefile_register(FAR const char *filename) #endif notefile->driver.stream = ¬efile->fil

Re: [PR] improve libc/stream subsystem [nuttx]

Donny9 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2145016688 ## drivers/note/notestream_driver.c: ## @@ -131,15 +130,15 @@ int notefile_register(FAR const char *filename) #endif notefile->driver.stream = ¬efile->filestream.c

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on PR #16496: URL: https://github.com/apache/nuttx/pull/16496#issuecomment-2963342969 @acassis all comments are fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2140527511 ## libs/libc/stream/lib_mtdoutstream.c: ## @@ -342,18 +330,22 @@ int lib_mtdoutstream_open(FAR struct lib_mtdoutstream_s *stream, return -EINVAL; }

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2140527058 ## libs/libc/stream/lib_mtdsostream.c: ## @@ -0,0 +1,359 @@ +/ + * libs/libc/stream/

Re: [PR] improve libc/stream subsystem [nuttx]

acassis commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2138422072 ## libs/libc/stream/lib_mtdoutstream.c: ## @@ -342,18 +330,22 @@ int lib_mtdoutstream_open(FAR struct lib_mtdoutstream_s *stream, return -EINVAL; } - st

Re: [PR] improve libc/stream subsystem [nuttx]

acassis commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2138404580 ## libs/libc/stream/lib_mtdsostream.c: ## @@ -0,0 +1,359 @@ +/ + * libs/libc/stream/lib_mtds

Re: [PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2136771345 ## libs/libc/stream/lib_blkoutstream.c: ## @@ -239,18 +239,18 @@ void lib_blkoutstream_close(FAR struct lib_blkoutstream_s *stream) { if (stream != NULL)

Re: [PR] improve libc/stream subsystem [nuttx]

acassis commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2135543602 ## libs/libc/stream/lib_blkoutstream.c: ## @@ -239,18 +239,18 @@ void lib_blkoutstream_close(FAR struct lib_blkoutstream_s *stream) { if (stream != NULL) { -

[PR] improve libc/stream subsystem [nuttx]

xiaoxiang781216 opened a new pull request, #16496: URL: https://github.com/apache/nuttx/pull/16496 ## Summary - mtdstream: use mtdsostream to support seek - blk/mtdoutstream: should flush before free - mtdoutstream: fix missing Make & cmake file - stream: Add fileinstream su