Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2858252790 Another problem I can see is "Commits must have verified signatures.". Looks like we need to update `required_signatures: false` too as signature in github nomenclature means cryptograph

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2858241271 You are right @raiden00pl with this `strict: true` all PR needs to be rebased each time master is updated that is a waste of focus and CI resources, sorry, the nomenclature is a bit misle

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-07 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2858163302 > @raiden00pl: dependency on `Build` seems bad to me. With this change it becomes impossible to merge changes where `nuttx` and `nuttx-apps` need to be changed at the same time. >

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-07 Thread via GitHub
raiden00pl commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2857455486 dependency on `Build` seems bad to me. With this change it becomes impossible to merge changes where `nuttx` and `nuttx-apps` need to be changed at the same time. Also `strict:

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
xiaoxiang781216 merged PR #16324: URL: https://github.com/apache/nuttx/pull/16324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2855940539 Okay I have asked #asfinfa on Slack, @Humbedooh said this looks okay, in case we break anything it should be possible to unbreak :D Switching to "ready for review" and turning on c

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
pussuw commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854725871 So linear history means fast forward only. Yes, enforce that please. I reading hate a git history that has a million divergent branches. Impossible to follow. -- This is an automated me

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
cederom commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854665017 > @pussuw: What does linear history mean, no merge commits allowed ? Good question :-) Admins help would be nice here :-P I think we DO WANT the linear history as we do rebase PRs n

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
pussuw commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854632952 What does linear history mean, no merge commits allowed ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
nuttxpr commented on PR #16324: URL: https://github.com/apache/nuttx/pull/16324#issuecomment-2854570505 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR likely meets the NuttX requirements, but n

[PR] github: Setup protection for master branch. [nuttx]

2025-05-06 Thread via GitHub
cederom opened a new pull request, #16324: URL: https://github.com/apache/nuttx/pull/16324 ## Summary * We do not have "Settings" tab in the Apache's owned repository, thus we need to update `.asf.yaml` file with repository settings. * No direct push to master branch is possible.